[chromium-dev] Re: Formatting substrings in a views::Label

2009-08-27 Thread Tim Steele
fwiw, another way to write a dialog like this platform independently without an extra abstraction for Label would be to use our html UI; that's what I did for the sync setup dialog/wizard flow, and so far so good! On Wed, Aug 26, 2009 at 2:15 PM, Aaron Boodman a...@chromium.org wrote: I'm

[chromium-dev] The webkit canary bots, now with performance tests!

2009-08-27 Thread Darin Fisher
Thanks to bevc and nsylvain, we now have performance bots testing chromium with the very latest webkit code: http://build.chromium.org/buildbot/waterfall.fyi/waterfall?branch=builder=XP+Perf+(webkit.org)builder=Linux+Perf+(webkit.org)reload=none (no mac bot yet) The dashboard is here:

[chromium-dev] Re: Git woes

2009-08-27 Thread Nico Weber
Not knowingly, at least. `git --version` says 1.6.0.2, which I believe is what it always said. On Wed, Aug 26, 2009 at 10:50 PM, Jeremy Moskovichjer...@chromium.org wrote: Git is comprised of billions of tiny orthogonal binaries. When this happened to me the cause was some old git binaries in

[chromium-dev] Re: The webkit canary bots, now with performance tests!

2009-08-27 Thread Adam Barth
Yay! This is fantastic! Adam On Wed, Aug 26, 2009 at 11:47 PM, Darin Fisherda...@chromium.org wrote: Thanks to bevc and nsylvain, we now have performance bots testing chromium with the very latest webkit code:

[chromium-dev] Re: Formatting substrings in a views::Label

2009-08-27 Thread Ben Goodger (Google)
I actually don't like having a mix of HTML/native UIs in the product. When we switched to the NTP from the old Destinations page we made the decision to have the content of tabs feel webby and the content of dialogs feel dialoggy. As a result the NTP now feels pleasantly webby, but many of the

[chromium-dev] Re: Formatting substrings in a views::Label

2009-08-27 Thread Aaron Boodman
On Thu, Aug 27, 2009 at 12:06 AM, Ben Goodger (Google)b...@chromium.org wrote: I actually don't like having a mix of HTML/native UIs in the product. When we switched to the NTP from the old Destinations page we made the decision to have the content of tabs feel webby and the content of

[chromium-dev] FreeBSD port, take 2

2009-08-27 Thread Ben Laurie
As brettw requested, I ported chrome/browser/renderer_host/ and base/. This is now done and can be reviewed here: http://codereview.chromium.org/172032 The description summarises the changes I made, what do people think? (I haven't forgot that I said I'd document defines - I'll do that once

[chromium-dev] Re: FreeBSD port, take 2

2009-08-27 Thread Ben Laurie
I forgot to mention - there's a single file that may not be complete, base/crypto/signature_verifier_nss.cc - this is because the FreeBSD port of NSS is too old and doesn't have a function it needs. I'll get to that at some point soon, but I don't anticipate it being a problem. On Thu, Aug 27,

[chromium-dev] Problem with try servers?

2009-08-27 Thread Ben Laurie
If I do a gcl try, I get prompted for a password for 'ben', which is my login name on my FreeBSD machine. Whatever I enter, the script then hangs - investigation shows that this is because it is prompting for a username, but gcl is swallowing the output. If I then enter b...@chromium.org, I get

[chromium-dev] Re: Problem with try servers?

2009-08-27 Thread Marc-Antoine Ruel
It's asking you for your svn password because you have no http access. I realize the faq at http://dev.chromium.org/developers/try-server-usage has no connection troubleshooting guide. feel free to add. M-A On Thu, Aug 27, 2009 at 6:17 AM, Ben Laurieb...@chromium.org wrote: If I do a gcl

[chromium-dev] Re: Formatting substrings in a views::Label

2009-08-27 Thread Finnur Thorarinsson
It is only incredibly painful if you mix in the link in with other words in the middle of a sentence, like I had to do with the About box. If you, instead, have a link below the main text (like the mock shows) it is dead simple and easy. I don't see why you should avoid using Link in that case.

[chromium-dev] Re: FreeBSD port, take 2

2009-08-27 Thread Evan Martin
On Thu, Aug 27, 2009 at 2:57 AM, Ben Laurieb...@google.com wrote: Added USE_GDK, set when either TOOLKIT_GTK or TOOLKIT_VIEWS is set but not OS_WIN. I believe VIEWS still uses GTK (for bits like the omnibox). All of the above cause slightly odd formulations like: #if defined(OS_WIN) ...

[chromium-dev] Re: FreeBSD port, take 2

2009-08-27 Thread Evan Martin
On Thu, Aug 27, 2009 at 8:13 AM, Ben Laurieb...@google.com wrote: On Thu, Aug 27, 2009 at 3:56 PM, Evan Martine...@chromium.org wrote: On Thu, Aug 27, 2009 at 2:57 AM, Ben Laurieb...@google.com wrote: Added USE_GDK, set when either TOOLKIT_GTK or TOOLKIT_VIEWS is set but not OS_WIN. I

[chromium-dev] Re: Formatting substrings in a views::Label

2009-08-27 Thread Scott Violet
On Thu, Aug 27, 2009 at 12:14 AM, Aaron Boodmana...@chromium.org wrote: On Thu, Aug 27, 2009 at 12:06 AM, Ben Goodger (Google)b...@chromium.org wrote: I actually don't like having a mix of HTML/native UIs in the product. When we switched to the NTP from the old Destinations page we made the

[chromium-dev] Re: Git woes

2009-08-27 Thread Evan Martin
Aside from basic stuff like running out of disk space, I have no idea what would cause this problem. (It's weird that pread would fail with no such file when its API is to take an open file descriptor.) One workaround might be to try setting this defined, mentioned in the Makefile: # Define

[chromium-dev] Re: Git woes

2009-08-27 Thread Evan Martin
https://kerneltrap.org/mailarchive/git/2007/7/23/252538 old and maybe obsolete, but has some exposition from Linus On Thu, Aug 27, 2009 at 7:51 AM, Evan Martine...@chromium.org wrote: Aside from basic stuff like running out of disk space, I have no idea what would cause this problem.  (It's

[chromium-dev] Re: FreeBSD port, take 2

2009-08-27 Thread Ben Laurie
On Thu, Aug 27, 2009 at 3:56 PM, Evan Martine...@chromium.org wrote: On Thu, Aug 27, 2009 at 2:57 AM, Ben Laurieb...@google.com wrote: Added USE_GDK, set when either TOOLKIT_GTK or TOOLKIT_VIEWS is set but not OS_WIN. I believe VIEWS still uses GTK (for bits like the omnibox). So this

[chromium-dev] Re: [gyp-developer] GYP buildbots

2009-08-27 Thread Evan Martin
Awesome, thanks! On Thu, Aug 27, 2009 at 8:50 AM, Steven Knights...@chromium.org wrote: Of interest to GYP developers (or anyone else who may need to roll the GYP revision in DEPS): The FYI (experimental) buildbot master now has a set of of canary slaves that build Chromium with the latest

[chromium-dev] Re: Git woes

2009-08-27 Thread Evan Martin
Try git gc On Thu, Aug 27, 2009 at 8:27 AM, Nico Webertha...@chromium.org wrote: The pack file truncated theory sounds most likely. Is there any way I could tell git to regenerate the newest N packfiles? On Thu, Aug 27, 2009 at 8:00 AM, Evan Martine...@chromium.org wrote:

[chromium-dev] Re: Formatting substrings in a views::Label

2009-08-27 Thread Finnur Thorarinsson
Oh, I see. I thought you meant the link since Brett said I had done this for the About box (Now Aaron's code snippet makes more sense) :). I didn't have to do any bolding of text in the About box, but I can see you running into exactly the same problems I did with the link. There be dragons. I

[chromium-dev] Re: Problem with try servers?

2009-08-27 Thread Nicolas Sylvain
On Thu, Aug 27, 2009 at 3:17 AM, Ben Laurie b...@chromium.org wrote: If I do a gcl try, I get prompted for a password for 'ben', which is my login name on my FreeBSD machine. Whatever I enter, the script then hangs - investigation shows that this is because it is prompting for a username,

[chromium-dev] Re: Git woes

2009-08-27 Thread Nico Weber
The pack file truncated theory sounds most likely. Is there any way I could tell git to regenerate the newest N packfiles? On Thu, Aug 27, 2009 at 8:00 AM, Evan Martine...@chromium.org wrote: https://kerneltrap.org/mailarchive/git/2007/7/23/252538 old and maybe obsolete, but has some

[chromium-dev] Re: Formatting substrings in a views::Label

2009-08-27 Thread Evan Martin
To be clear, Aaron's asking how to get the bold text in his paragraph, not the More information... link. :) On Thu, Aug 27, 2009 at 7:42 AM, Finnur Thorarinssonfin...@chromium.org wrote: It is only incredibly painful if you mix in the link in with other words in the middle of a sentence,

[chromium-dev] GYP buildbots

2009-08-27 Thread Steven Knight
Of interest to GYP developers (or anyone else who may need to roll the GYP revision in DEPS): The FYI (experimental) buildbot master now has a set of of canary slaves that build Chromium with the latest tip-of-tree GYP on Linux/Mac/Win (and run unit_tests and a few others, just for a sanity

[chromium-dev] Re: Git woes

2009-08-27 Thread Nico Weber
Didn't help. Oh well, back to my fallback svn client for now. Will create a new git checkout in the new feature. On Thu, Aug 27, 2009 at 9:12 AM, Evan Martine...@chromium.org wrote: Try git gc On Thu, Aug 27, 2009 at 8:27 AM, Nico Webertha...@chromium.org wrote: The pack file truncated

[chromium-dev] Re: Git woes

2009-08-27 Thread Dimitri Glazkov
I've had this issue before and found that if I used svn rebase it would sometimes fix it. So I am thinking perhaps instead of git pull, you could attempt doing git fetch first and then git merge? This would do the same thing, except not in atomic op. :DG On Thu, Aug 27, 2009 at 10:49 AM, Nico

[chromium-dev] Re: Formatting substrings in a views::Label

2009-08-27 Thread Tim Steele
On Thu, Aug 27, 2009 at 12:06 AM, Ben Goodger (Google) b...@chromium.orgwrote: I actually don't like having a mix of HTML/native UIs in the product. When we switched to the NTP from the old Destinations page we made the decision to have the content of tabs feel webby and the content of

[chromium-dev] git-try now lives in depot_tools

2009-08-27 Thread Evan Martin
git-try is a Chrome-specific tool for running changes managed with git against the trybots. It probably always belonged in depot_tools, but I wrote it as a quick hack and didn't do it the proper way. It now is part of the depot_tools checkout and future patches should go against that version.

[chromium-dev] Re: Copying of profiles across systems

2009-08-27 Thread Peter Kasting
On Wed, Aug 26, 2009 at 7:48 PM, PhistucK phist...@gmail.com wrote: Bearing the upcoming Chrome OS in mind, this should be taken into account quite strongly. I don't think it's appropriate to speculate on what will and will not be useful for Chrome OS until more details about it are made

[chromium-dev] Re: Question about resource_dispatcher_host.h

2009-08-27 Thread John Abd-El-Malek
On Thu, Aug 27, 2009 at 11:57 AM, hap 497 hap...@gmail.com wrote: On Mon, Aug 24, 2009 at 1:26 PM, John Abd-El-Malek j...@chromium.orgwrote: On Mon, Aug 24, 2009 at 1:06 PM, Brett Wilson bre...@chromium.orgwrote: On Mon, Aug 24, 2009 at 12:49 PM, hap 497hap...@gmail.com wrote: Thanks.

[chromium-dev] Tales from the test_expectations ...

2009-08-27 Thread Dimitri Glazkov
It's like Tales from the crypt, but less fun and actually scary. I just found out that we wall-papered over about 80-100 tests in fast/repaint dir. I will be removing bad baselines shortly. The bad news is that this bumped our failures to 875 (from 778 this morning). The good news is that they

[chromium-dev] Re: Question about resource_dispatcher_host.h

2009-08-27 Thread hap 497
On Mon, Aug 24, 2009 at 1:26 PM, John Abd-El-Malek j...@chromium.org wrote: On Mon, Aug 24, 2009 at 1:06 PM, Brett Wilson bre...@chromium.org wrote: On Mon, Aug 24, 2009 at 12:49 PM, hap 497hap...@gmail.com wrote: Thanks. But the picture in the document shows there is only 1

[chromium-dev] Re: [chromium-reviews] Re: WebKit deps roll 47797:47804

2009-08-27 Thread Dimitri Glazkov
Tests only pass if they are actually not loading any media. Which is a number of tests, yes. As an alternative maybe we could just agree among all WebKit gardeners to dump the new failures to bug 16779 and not add them to the end of test_expectations? :DG On Thu, Aug 27, 2009 at 1:25 PM, Ojan

[chromium-dev] Re: FreeBSD port, take 2

2009-08-27 Thread Wan-Teh Chang
On Thu, Aug 27, 2009 at 3:02 AM, Ben Laurieb...@google.com wrote: I forgot to mention - there's a single file that may not be complete, base/crypto/signature_verifier_nss.cc - this is because the FreeBSD port of NSS is too old and doesn't have a function it needs. I'll get to that at some

[chromium-dev] Re: Git woes

2009-08-27 Thread Nico Weber
I accidentally fixed the problem by running something like rm -rf .git/svn/ git svn fetch; git merge trunk git merge refs/remotes/origin/trunk git checkout -f HEAD git pull . Not sure what fixed it, but pulling works again. Yay, I guess, but of course I fixed it about 2 minutes before

[chromium-dev] OS X debugging tip - turn off the sandbox.

2009-08-27 Thread Jeremy Moskovich
When the sandbox gets in the way of the kernel or other parts of the system, very strange things can happen. If you're running into unexplained behavior on OS X try disabling the sandbox by running with --no-sandbox. This was the key to a crash we where looking at today which is why I'm sending

[chromium-dev] Re: The webkit canary bots, now with performance tests!

2009-08-27 Thread Nicolas Sylvain
And now it is also running test_shell_tests in purify and valgrind: http://build.chromium.org/buildbot/waterfall.fyi/waterfall?branch=builder=Webkit+(purify+webkit.org)builder=Webkit+Linux+(valgrind+webkit.org)

[chromium-dev] Re: [chromium-reviews] Re: WebKit deps roll 47797:47804

2009-08-27 Thread Andrew Scherkus
The media tests are highly platform specific at the moment due to differences in codec support. Keeping them lumped together under one bug works for me. Andrew On Thu, Aug 27, 2009 at 1:55 PM, Dimitri Glazkov dglaz...@chromium.orgwrote: Tests only pass if they are actually not loading any

[chromium-dev] Re: Question about resource_dispatcher_host.h

2009-08-27 Thread Michael Nordman
On Thu, Aug 27, 2009 at 11:57 AM, hap 497 hap...@gmail.com wrote: On Mon, Aug 24, 2009 at 1:26 PM, John Abd-El-Malek j...@chromium.orgwrote: On Mon, Aug 24, 2009 at 1:06 PM, Brett Wilson bre...@chromium.orgwrote: On Mon, Aug 24, 2009 at 12:49 PM, hap 497hap...@gmail.com wrote: Thanks.

[chromium-dev] Re: The webkit canary bots, now with performance tests!

2009-08-27 Thread Darin Fisher
Thank you!!! On Thu, Aug 27, 2009 at 4:03 PM, Nicolas Sylvain nsylv...@chromium.orgwrote: And now it is also running test_shell_tests in purify and valgrind:

[chromium-dev] Re: Copying of profiles across systems

2009-08-27 Thread Evan Stade
On Wed, Aug 26, 2009 at 7:48 PM, PhistucKphist...@gmail.com wrote: Bearing the upcoming Chrome OS in mind, this should be taken into account quite strongly. Regular programs will probably not move cleanly and nicely from Windows to Chrome OS, but, at least, Google products should migrate