[chromium-dev] Re: Survey results and followup actions

2009-10-29 Thread PhistucK
I have seen some change lists regarding stuff that were previously implemented only on Chrome OS, such as the compact navigation\location bar. A few days ago, a change list was committed to make it cross platform, or something like that. And now there is more development in this area. I am talking

[chromium-dev] Re: Working on privacy blacklists, collision warning

2009-10-29 Thread Paweł Hajdan Jr .
I landed the patch, and now the code in browser/privacy_blacklist should be quite stable (at least the interfaces). There's still a lot of work to do, but here's my plan for now: - make ExtensionsService a BlacklistPathProvider and write a test which loads an extension and verifies that

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread Peter Kasting
On Thu, Oct 29, 2009 at 2:27 PM, Ben Goodger (Google) b...@chromium.orgwrote: VS2008 builds with /MP by default, and it's well supported, so when present there's no reason for us to not use it by default. Note that you can still force VS2005 by setting GYP_MSVS_VERSION=2005 in your

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread Ben Goodger (Google)
It'd be nice if the defaults could be set on a per-sln level I guess. -Ben On Thu, Oct 29, 2009 at 2:30 PM, Peter Kasting pkast...@google.com wrote: On Thu, Oct 29, 2009 at 2:27 PM, Ben Goodger (Google) b...@chromium.orgwrote: VS2008 builds with /MP by default, and it's well supported, so

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread Mike Belshe
I've been using VS2008 on Win7 for the last month or so. I hate it. Problems: 1) Stepping in the debugger is SOOO slow. I am thinking about going back to VS2005. 2) If you turn on Intellisense, it crashes like crazy very regularly. I've turned off intellisense, but it is a big loss in

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread Peter Kasting
On Thu, Oct 29, 2009 at 2:38 PM, Mike Belshe mbel...@google.com wrote: I strongly recommend against VS2008; do others have these problems? For awhile I was having serious crashiness problems with it. Those stopped, I don't remember if it was because I installed enough service packs and

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread Ben Goodger (Google)
It does seem slower, however never having to remember to patch the appropriate vsprops/gypi with /MP is a big win. When I was ordering the new machines I found most people on the team I asked were not doing this, and as a result their builds were 2-3x slower. -Ben On Thu, Oct 29, 2009 at 2:38

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread John Abd-El-Malek
On Thu, Oct 29, 2009 at 2:38 PM, Mike Belshe mbel...@google.com wrote: I've been using VS2008 on Win7 for the last month or so. I hate it. Problems: 1) Stepping in the debugger is SOOO slow. I am thinking about going back to VS2005. I was just about to reply and say the same thing

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread Eric Roman
On Thu, Oct 29, 2009 at 2:38 PM, Mike Belshe mbel...@google.com wrote: I've been using VS2008 on Win7 for the last month or so. I hate it. Problems: 1) Stepping in the debugger is SOOO slow.  I am thinking about going back to VS2005. 2) If you turn on Intellisense, it crashes like crazy

[chromium-dev] Inheritance in gyp configurations

2009-10-29 Thread Bradley Nelson
Hi All, I've just rolled out an enhancement to gyp to support inheritance in configurations. This shouldn't have any noticeable effect other than reducing the repetition needed for things like Purify/notcmalloc. I've tested it as best I can, but please let me know if you experience anything

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread Finnur Thorarinsson
I was just about to reply and say the same thing (on Win 7). It would take me 2-3 seconds each time I step over a line. I couldn't use it anymore and switched back to VS 2005. Isn't the stepping speed affected by things like what you have in your Watch window and what conditional breakpoints

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread John Abd-El-Malek
On Thu, Oct 29, 2009 at 3:23 PM, Finnur Thorarinsson fin...@chromium.orgwrote: I was just about to reply and say the same thing (on Win 7). It would take me 2-3 seconds each time I step over a line. I couldn't use it anymore and switched back to VS 2005. Isn't the stepping speed affected

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread Jeremy Orlow
From http://dev.chromium.org/developers/how-tos/build-instructions-windows Ensure that /MP is enabled. You can do this by creating a file called inc lude.gypi which contains the following lines: { 'variables': { 'msvs_multi_core_compile': 1 } } Put this file in a folder

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread Ben Goodger (Google)
Yes, this was widely publicized when discovered, yet most people won't make the change if it's not the default. -Ben On Thu, Oct 29, 2009 at 3:42 PM, Jeremy Orlow jor...@chromium.org wrote: From http://dev.chromium.org/developers/how-tos/build-instructions-windows Ensure that /MP is enabled.

[chromium-dev] git users and svn:eol-style

2009-10-29 Thread John Abd-El-Malek
Per the Chromium style guide ( http://dev.chromium.org/developers/coding-style), we require all new files to have the svn:eol-style property set. We even have a presubmit check for it in case you don't configure Subversion to automatically add them per the above previous link. git users seem to

[chromium-dev] Re: git users and svn:eol-style

2009-10-29 Thread Andrew Scherkus
I believe git-svn is incapable of handling svn properties. I usually do a follow-up TBR CL using svn to set properties, which is annoying. git-cl relies on git-svn to do the actual committing, so I think we'd be patching up git-svn to support properties. On Thu, Oct 29, 2009 at 5:13 PM, John

[chromium-dev] Re: git users and svn:eol-style

2009-10-29 Thread Evan Martin
On Thu, Oct 29, 2009 at 5:13 PM, John Abd-El-Malek j...@chromium.org wrote: Per the Chromium style guide (http://dev.chromium.org/developers/coding-style), we require all new files to have the svn:eol-style property set. We even have a presubmit check for it in case you don't configure

[chromium-dev] Re: git users and svn:eol-style

2009-10-29 Thread Evan Martin
On Thu, Oct 29, 2009 at 5:28 PM, Evan Martin e...@chromium.org wrote: If you add the junk to your ~/.subversion/config that's specified on this page  http://dev.chromium.org/developers/coding-style then git will do the right thing as well.  (I just tested it on a local svn repo to be sure.)

[chromium-dev] Re: Inheritance in gyp configurations

2009-10-29 Thread Nick Carter
What does the syntax look like? - nick On Thu, Oct 29, 2009 at 3:22 PM, Bradley Nelson bradnel...@google.comwrote: Hi All, I've just rolled out an enhancement to gyp to support inheritance in configurations. This shouldn't have any noticeable effect other than reducing the repetition

[chromium-dev] Re: git users and svn:eol-style

2009-10-29 Thread Andrew Scherkus
On Thu, Oct 29, 2009 at 5:31 PM, Evan Martin e...@chromium.org wrote: On Thu, Oct 29, 2009 at 5:28 PM, Evan Martin e...@chromium.org wrote: If you add the junk to your ~/.subversion/config that's specified on this page http://dev.chromium.org/developers/coding-style then git will do the

[chromium-dev] Re: git users and svn:eol-style

2009-10-29 Thread John Abd-El-Malek
On Thu, Oct 29, 2009 at 5:31 PM, Evan Martin e...@chromium.org wrote: On Thu, Oct 29, 2009 at 5:28 PM, Evan Martin e...@chromium.org wrote: If you add the junk to your ~/.subversion/config that's specified on this page http://dev.chromium.org/developers/coding-style then git will do the

[chromium-dev] Chrome + git + svn:eol-style properties

2009-10-29 Thread Drew Wilson
Hi all, John pointed out to me in a recent review that my new files didn't have svn:eol-style LF set on them. When setting up my git enlistment, turns out I didn't setup the various svn properties described in the git setup docs (the documentation may have been added after I setup git, or maybe I

[chromium-dev] Re: Inheritance in gyp configurations

2009-10-29 Thread Bradley Nelson
configurations can now inherit from one or more other configurations, and configurations which are not fully expressed should be marked 'abstract': 1, So something like this: 'configurations': { 'Common: { 'abstract': 1, # common settings }, 'Debug': { 'inherit_from':

[chromium-dev] Re: Chrome + git + svn:eol-style properties

2009-10-29 Thread Drew Wilson
Gah. Need to read my mail first. On Thu, Oct 29, 2009 at 5:42 PM, Drew Wilson atwil...@chromium.org wrote: Hi all, John pointed out to me in a recent review that my new files didn't have svn:eol-style LF set on them. When setting up my git enlistment, turns out I didn't setup the various

[chromium-dev] Re: Working on privacy blacklists, collision warning

2009-10-29 Thread Nick Baum
Sounds good. Thanks for the continued progress on this! -Nick On Thu, Oct 29, 2009 at 1:50 PM, Paweł Hajdan Jr. phajdan...@chromium.orgwrote: I landed the patch, and now the code in browser/privacy_blacklist should be quite stable (at least the interfaces). There's still a lot of work to

[chromium-dev] cygwin's setup.exe started crashing on me during an upgrade, this is how I fixed it...

2009-10-29 Thread Chase Phillips
If you ever find yourself using Cygwin's setup.exe to install/upgrade packages, and it hangs or starts crashing during that process, follow the instructions at http://rubenlaguna.com/wp/2007/11/05/cygwin-setupexe-crashes-when-upgrading-packages/ to fix: 1. Look in /etc/setup/ for a file

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread Marc-Antoine Ruel
Here are the fixes for your debugger sluggishness problems: Bind this macro to F7 http://code.google.com/p/chromium/wiki/WindowsVisualStudioMacros?ts=1256870705updated=WindowsVisualStudioMacros#Only_build_startup_project and bind this macro to F5

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread Marc-Antoine Ruel
After thinking about it, just setting in Debugging properties: Command = c:\program files\Debugging Tools for Windows (x86)\windbg.exe Command Arguments = -o $(TargetPath) is way simpler, then you just use Ctrl-F5 to start debugging your app! M-A On Thu, Oct 29, 2009 at 10:50 PM, Marc-Antoine

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread Mike Belshe
On Thu, Oct 29, 2009 at 3:34 PM, John Abd-El-Malek j...@chromium.org wrote: On Thu, Oct 29, 2009 at 3:23 PM, Finnur Thorarinsson fin...@chromium.orgwrote: I was just about to reply and say the same thing (on Win 7). It would take me 2-3 seconds each time I step over a line. I couldn't

[chromium-dev] Re: Layout tests can now be run on both XP and Vista

2009-10-29 Thread TAMURA, Kent
Hi Dirk, I found a problem of the generic theme. Some of controls in the generic theme are drawn in sizes larger than specified sizes. For example, if you command to draw kDownArrow_Type at (0, 0) in 10x10 size, the generic theme updates (0,0) - (10,10), of which size is 11x11.

[chromium-dev] [Help]how can i get the chrome project files

2009-10-29 Thread zhangdw
hello everyone: I want to compile chrome in WinXP,so I download the source form http://build.chromium.org/buildbot/archives/chromium.r30027.tg http://build.chromium.org/buildbot/archives/chromium.r30027.tgz But it doesn't contain the project files. I searched in the net,and they telled me that i

[chromium-dev] Re: [Help]how can i get the chrome project files

2009-10-29 Thread Eric Roman
I recommend following the Bootstrap using the tarball instructions at: http://dev.chromium.org/developers/how-tos/get-the-code It sounds like you have already completed steps 1 - 4, so next you must do steps 5 and 6: (5) install the depot_tools (6) gclient sync --force Step 6 is what