On Wed, Nov 4, 2009 at 08:56, Aaron Boodman a...@chromium.org wrote:
Why don't you pass an Extension instance?
It's in a test. Mocking an Extension is not trivial as well. :( Or maybe...
I didn't read all of the extensions unit tests, maybe it's not that hard.
It seems like you are
On Wed, Nov 4, 2009 at 12:12 AM, Paweł Hajdan Jr.
phajdan...@chromium.org wrote:
On Wed, Nov 4, 2009 at 08:56, Aaron Boodman a...@chromium.org wrote:
Why don't you pass an Extension instance?
It's in a test. Mocking an Extension is not trivial as well. :( Or maybe...
I didn't read all of
Thanks Yuta-san.
That's a good-idea-I-should-have-had-myself. It works! I missed the
memory usage during the first pass, but rebuilding just the
src/sconsbuild/Release/chrome executable was a mere 200Mb.
When I get the extra memory I'll confirm Marc-Antoine's observation.
Cheers,
So, the problem with Extensions has been solved (thanks to Aaron), but
there's stil the original issue that may bite at any time (please see the
first message for context):
Is there a big difference between a Singleton and LazyInstance? I was
thinking about making NPAPI::PluginList a Singleton
On Tue, Nov 3, 2009 at 10:10 PM, Ben Goodger (Google) b...@chromium.org wrote:
Can there be a way to apply this to a local tree only so that you can revert
then revert the revert quickly locally so you can figure out why your change
broke?
I know this doesn't answer the question you are
Thanks for all answers! I think I'll use CarbonEmacs for editing (it's great,
my entire .emacs finally works) and Xcode for compiling. Aquamacs just landed
in the trash.
It's nice that Xcode supports some Emacs keybindings - I didn't know that.
That's a feature of OS X, these keybindings
On Wed, Nov 4, 2009 at 8:17 AM, Paweł Hajdan Jr.
phajdan...@chromium.org wrote:
Oh, indeed. Thanks, after looking at other tests it was easy. It was a bit
annoying that I had to use #ifdefs for FilePath though.
You may be able to just specify an empty FilePath() ? I'm not sure.
Give it a try.
On Tue, Nov 3, 2009 at 10:38 PM, Drew Wilson atwil...@chromium.org wrote:
Do the trybots build the release version? Because I had a build break last
week that passed the 3 basic trybots, but failed to compile on the release
buildbots because of a missing include which was apparently pulled in
On Tue, Nov 3, 2009 at 11:49 PM, Paweł Hajdan Jr.
phajdan...@chromium.orgwrote:
I encountered another problem related to Singletons in unit tests.
PluginService is a Singleton, and it listens to extensions notifications. In
one of my tests when I was using the extensions notifications the
On Thu, Oct 29, 2009 at 21:50, Paweł Hajdan Jr. phajdan...@chromium.orgwrote:
- make ExtensionsService a BlacklistPathProvider and write a test which
loads an extension and verifies that BlacklistManager notices that (I'm
working on it now)
This is done. To clarify: you can't yet load an
Hi Folks,
In r30948, I fixed several bugs related to the Linux suid sandbox. If
you're running ToT with sandboxing turned on, you will need to rebuild
chrome_sandbox. Without the new version of sandbox, Chromium will hang
on start up.
- Lei
--~--~-~--~~~---~--~~
On Wed, Nov 4, 2009 at 11:40 AM, Peter Kasting pkast...@google.com wrote:
On Tue, Nov 3, 2009 at 6:05 PM, John Abd-El-Malek j...@chromium.orgwrote:
But this means that the person didn't use the trybot.
I think we need to be harsher on people who commit with changes that
didn't complete or
On Wed, Nov 4, 2009 at 11:56 AM, Nicolas Sylvain nsylv...@chromium.orgwrote:
I don't think anyone suggested immediate auto revert.
Ben Goodger: I am supportive of auto-revert as long as we apply it
universally
Kenneth Russell: I completely support immediate backouts of changes that
break the
Meant to hit reply-all
I want to caveat this on having less flakiness. ;-) See my comments on IRC
about some tests randomly making a mess of themselves then going green
again.
-Ben
I'll also add this could be done automatically based on the set of tests we
define as not flaky.
I always feel
On Wed, Nov 4, 2009 at 12:02 PM, Peter Kasting pkast...@google.com wrote:
On Wed, Nov 4, 2009 at 11:56 AM, Nicolas Sylvain nsylv...@chromium.orgwrote:
I don't think anyone suggested immediate auto revert.
Ben Goodger: I am supportive of auto-revert as long as we apply it
universally
On Wed, Nov 4, 2009 at 12:08 PM, James Robinson jam...@google.com wrote:
I don't see who this benefits - assuming that a given patch is broken and
needs a small delta to be correct, it's just as easy to submit a patch with
a small delta as it is to submit the small delta. Leaving the broken
On Wed, Nov 4, 2009 at 12:16 PM, Peter Kasting pkast...@google.com wrote:
On Wed, Nov 4, 2009 at 12:08 PM, James Robinson jam...@google.com wrote:
I don't see who this benefits - assuming that a given patch is broken and
needs a small delta to be correct, it's just as easy to submit a patch
On Tue, Oct 27, 2009 at 8:26 AM, Antony Sargent asarg...@google.com wrote:
Page Cycler Tests
Since the page cycler tests take a long time to run, we've only added one
extensions case to 2 of the individual data sets: Moz (relatively simple
pages, less javascript) and MoreJS (more complicated
it seems that the time limit should depend on the type of bustage
break winxp compile --- you get 2 minutes
break linux views compile --- you get 30 minutes
-- Evan Stade
On Wed, Nov 4, 2009 at 1:10 PM, Nicolas Sylvain nsylv...@chromium.org wrote:
On Wed, Nov 4, 2009 at 12:16 PM, Peter
I am trying to use some binary in continuous build.
In the linux continuous build folder, for example,
http://build.chromium.org/buildbot/continuous/linux/2009-11-04/31013/
When I download chrome-linux.zip, how can I unzip this file?
--~--~-~--~~~---~--~~
duh, my bad. using unzip. Please ignore this message.
On Nov 4, 4:08 pm, webinfinite webinfin...@gmail.com wrote:
I am trying to use some binary in continuous build.
In the linux continuous build folder, for
example,http://build.chromium.org/buildbot/continuous/linux/2009-11-04/31013/
Great, thanks for the update.
-Nick
On Wed, Nov 4, 2009 at 10:58 AM, Paweł Hajdan Jr.
phajdan...@chromium.orgwrote:
On Thu, Oct 29, 2009 at 21:50, Paweł Hajdan Jr.
phajdan...@chromium.orgwrote:
- make ExtensionsService a BlacklistPathProvider and write a test which
loads an extension and
On Nov 3, 2009, at 9:56 AM, Paweł Hajdan Jr. wrote:
I also tried Xcode, but it seems that the editor isn't powerful
enough. I don't know how to quickly remove an entire line (2
keystrokes in Vim)
With the normal Mac key bindings it's Cmd-leftarrow, Shift-downarrow,
delete. If you want
Earlier today at Mozilla the UX team along with Mike Beltzner and
Johnathan Nightingale spent a good deal of time discussing how we want
to evolve the security UI in Firefox. We are planning on making a few
changes to our current approach based on what worked (and didn't work)
in Firefox
Please do. :)
Adam
On Wed, Nov 4, 2009 at 6:27 PM, Alex Faaborg faab...@mozilla.com wrote:
Earlier today at Mozilla the UX team along with Mike Beltzner and Johnathan
Nightingale spent a good deal of time discussing how we want to evolve the
security UI in Firefox. We are planning on
Hi,
Recently, I'm studying the source code under chrome/browser and trying to
understand the overall architecture, especially the relationship among those
important classes, such as Browser, BrowserWindow, TabContents,
TabContentsDelegate, TabContentsView, TabStripModel, RenderWidgetHost,
Hi James, when I first started, I read the design documents here:
http://dev.chromium.org/developers/design-documents
http://dev.chromium.org/developers/design-documentsThey helped me give me
the initial push in the architecture, they are pretty well done. Maybe the
one your looking for is:
27 matches
Mail list logo
