On Mon, Dec 14, 2009 at 21:23, Andrew Scherkus scher...@chromium.org wrote:
I wrote up this section under our Tree Sheriff page:
http://dev.chromium.org/developers/tree-sheriffs#TOC-Disabling-tests
Thanks! I expanded the section to also mention the FLAKY_ prefix
(which is very helpful in
(this topic has been on my mind a lot, so here's my vent :) )
I think we shouldn't allow any test to be disabled without a bug to track it
that includes an initially assigned owner. This shouldn't
I've seen it happen too often that a test gets disabled to quickly turn the
tree green, and it
On Mon, Dec 14, 2009 at 10:42 AM, Drew Wilson atwil...@chromium.org wrote:
They'll sometimes get disabled due to webkit updates, other times they'll
get disabled due to other things (for example, we changed the valgrind bots
to fail noisily if individual tests fail, regardless of whether they
OK, thanks for the clarification. I'll starting whinging at people who
disable tests without a comment pointing at an associated bug.
-atw
On Mon, Dec 14, 2009 at 10:52 AM, Darin Fisher da...@chromium.org wrote:
On Mon, Dec 14, 2009 at 10:42 AM, Drew Wilson atwil...@chromium.orgwrote:
Since I just excluded a lot of tests in valgrind last week, I'd like to give
a background here.
About a week ago, we noticed that we're ignoring failing tests in our
valgrind tests, which means
that the test results are not accurate. Even worse, unit test of
valgrind/test was crashing in the
On Mon, Dec 14, 2009 at 10:55 AM, Ojan Vafai o...@google.com wrote:
On Mon, Dec 14, 2009 at 10:36 AM, David Levin le...@chromium.org wrote:
On Mon, Dec 14, 2009 at 10:24 AM, Scott Hess sh...@chromium.org wrote:
Also, last time I was looking through some valgrind suppressions, I
found that
On Mon, Dec 14, 2009 at 8:54 AM, Drew Wilson atwil...@chromium.org wrote:
Anyhow, what's our best practices for disabling tests? I think ideally we'd
always log a tracking bug and add a comment, akin to what we do in the
test_expectations file for layout tests.
Another point to keep in mind -
Anyhow, what's our best practices for disabling tests? I think ideally we'd
always log a tracking bug and add a comment, akin to what we do in the
test_expectations file for layout tests. This might be too much of a burden
on sheriffs, so an alternative is for people who are working on
