Re: [chromium-dev] Core Text

2009-12-15 Thread Jeremy Moskovich
Here are some numbers: 10.5 75270ms 10.6 Core Text 77191ms 10.6 ATSUI 73293ms These were calculated by running PageCyclerTest.Intl2File 3 times on each platform, summing the times reported for the individual tests and then averaging over the 3 runs. I'm not sure these actually

Re: [chromium-dev] Core Text

2009-12-14 Thread Mark Mentovai
We will. It's on my plate and TVL's. We did have some hardware slated to use for this, but we've slowly chipped away at that, so it'll come out of the next batch. Bringing up the 10.6 bots had to take a back seat to the other things that we needed to do in the beta run-up, but 10.6 bots are a

Re: [chromium-dev] Core Text

2009-12-14 Thread Darin Fisher
Sounds great. Thanks, -Darin On Mon, Dec 14, 2009 at 10:38 AM, Mark Mentovai m...@chromium.org wrote: We will. It's on my plate and TVL's. We did have some hardware slated to use for this, but we've slowly chipped away at that, so it'll come out of the next batch. Bringing up the 10.6

Re: [chromium-dev] Core Text

2009-12-04 Thread Jeremy Moskovich
Thanks Drew, I'll look into toggling ATSUI/Core Text at runtime based on OS version then. Best regards, Jeremy On Fri, Dec 4, 2009 at 5:25 AM, Drew Wilson atwil...@chromium.org wrote: It looks like this had some negative perf issues:

Re: [chromium-dev] Core Text

2009-12-03 Thread Jeremy Moskovich
Hi Drew Albert, I picked your names off the WebKit sheriff calendar. I've landed a change to switch the Mac port over from ATSUI-Core Text APIs on the WebKit tree at http://trac.webkit.org/changeset/51633 . If you see stability or performance issues on the next WebKit roll then feel free to

Re: [chromium-dev] Core Text

2009-12-03 Thread Drew Wilson
Hi Jeremy, My next roll will be to 51642 (in progress). I'll ping you when it lands so you can keep an eye on it too. -atw 2009/12/3 Jeremy Moskovich jer...@chromium.org Hi Drew Albert, I picked your names off the WebKit sheriff calendar. I've landed a change to switch the Mac port over

Re: [chromium-dev] Core Text

2009-12-03 Thread Drew Wilson
It looks like this had some negative perf issues: http://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Perf%281%29/builds/6289/steps/page_cycler_intl2/logs/stdio http://build.chromium.org/buildbot/perf/mac-release-10.5/intl2/report.html?history=150 (my DEPS roll was 33776) I'm going

[chromium-dev] Core Text

2009-11-23 Thread Jeremy Moskovich
Re http://crbug.com/27195 https://bugs.webkit.org/show_bug.cgi?id=31802 : Dan Bernstein says that Core Text on Leopard has performance issues vs ATSUI so I'm going to look into switching APIs at runtime rather than compile time. So we'd use ATSUI 10.6 Core Text = 10.6 . Best regards,

Re: [chromium-dev] Core Text

2009-11-23 Thread Jeremy Moskovich
Thanks Nico, I'll run some numbers. Best regards, Jeremy On Mon, Nov 23, 2009 at 11:15 PM, Nico Weber tha...@chromium.org wrote: Did you do measuring if it's actually slower on 10.5? The CoreText backend for MacVim is much faster than the ATSUI backend from what I've heard (then again,

Re: [chromium-dev] Core Text

2009-11-23 Thread Dirk Pranke
As an aside, have we looked at using DirectWrite() on Windows? -- Dirk On Mon, Nov 23, 2009 at 12:58 PM, Jeremy Moskovich jer...@chromium.org wrote: Re http://crbug.com/27195  https://bugs.webkit.org/show_bug.cgi?id=31802 : Dan Bernstein says that Core Text on Leopard has performance issues

Re: [chromium-dev] Core Text

2009-11-23 Thread Peter Kasting
On Mon, Nov 23, 2009 at 2:51 PM, Dirk Pranke dpra...@chromium.org wrote: As an aside, have we looked at using DirectWrite() on Windows? crbug.com/25541 (No) PK -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe:

Re: [chromium-dev] Core Text

2009-11-23 Thread 坊野 博典
Greetings Jeremy, This is just for your information. It seems WebCore/platform/graphics/mac/ComplexTextControllerCoreText.cpp uses CTRunGetAdvancesPtr() and CTRunGetAdvances(), which are available only on 10.6 or later. (This might be a reason why WebKit doesn't use Core Text for Leopard?) (*1)

Re: [chromium-dev] Core Text

2009-11-23 Thread Jeremy Moskovich
Thanks Hironori, I thought so too at the beginning but it turns out that they are available, just not declared in public headers. The WebKit bug I linked to has a patch that switches us to Core Text on 10.5 10.6. I'll do some perf tests and then we can make a decision based on that. Best