I just verified that this patch completely broke everything. You
committed late at night when no sheriff or anyone was around, and then
you went to bed.
Thanks for not testing your code, and not watching the tree go red after it.
Appreciation from another time zone,
-- dean
On Thu, Mar 5,
I didn't mean that to be such a personal flame, we need to have some
better guards to prevent this from happening. It's just frustrating
when the tree is broken for hours at a time. It's happened a lot
lately, the tree has been closed and/or hosed for the majority of my
workday week. The
There is one thing though, I don't think hclam checkin turned any Linux
tests red. The linux build was unusable, but the unit tests and layout tests
were passing. It seems like there is a lack of tests here.
When I woke up I reverted his change because it broke Purify on windows and
another unit
On Thu, Mar 5, 2009 at 6:01 PM, Nicolas Sylvain nsylv...@chromium.org wrote:
There is one thing though, I don't think hclam checkin turned any Linux
tests red. The linux build was unusable, but the unit tests and layout tests
were passing. It seems like there is a lack of tests here.
Yeah, we
On Thu, Mar 5, 2009 at 12:38 PM, Alpha (Hin-Chung) Lam hc...@google.com wrote:
everytime I do a checkin I do a sync and send it
to the try server, which really takes me a lot of time, but still try server
is showing me green light to check in, am I suppose to not trust the try
server and rely
On Thu, Mar 5, 2009 at 7:03 PM, Alpha (Hin-Chung) Lam hc...@google.com wrote:
2009/3/5 Amanda Walker ama...@chromium.org
On Thu, Mar 5, 2009 at 12:38 PM, Alpha (Hin-Chung) Lam hc...@google.com
wrote:
everytime I do a checkin I do a sync and send it
to the try server, which really takes
I looked at yesterday Alpha's try run on linux, the try server runs ui
tests and it was green. The mac try slave were dead last evening. I
would only blame poor testing on linux side.
I'm adding ui testprinting tests on modules mac linux on next master restart.
And oh, please read the 3 lines
