[chromium-dev] Re: Don't include render_messages.h in a header

2009-02-06 Thread John Abd-El-Malek
On Fri, Feb 6, 2009 at 10:54 AM, Nicolas Sylvain nsylv...@chromium.orgwrote: On Thu, Feb 5, 2009 at 10:56 AM, John Abd-El-Malek j...@chromium.orgwrote: One idea I've been thinking about is timing how long a clean build takes, and tracking that just as we do with other performance tests.

[chromium-dev] Re: Don't include render_messages.h in a header

2009-02-05 Thread Erik Kay
(arg. reposting again) One thing that scons is very good at is dependency analysis. Is it possible to get it to spit out a dependency report (which files depend on each file in the project)? I wonder if we might find that files like npapi.h don't actually need to touch everything, etc. Erik

[chromium-dev] Re: Don't include render_messages.h in a header

2009-02-05 Thread Steven Knight
Hi Erik-- It depends on what you really want. SCons does have all of the dependencies, but it doesn't keep the #include tree. Tangible example: if foo.c #includes inc.h, and inc.h also #includes both a.h and b.h, the resulting dependency list actually looks like: foo.o: foo.c inc.h a.h b.h

[chromium-dev] Re: Don't include render_messages.h in a header

2009-02-05 Thread Erik Kay
(sorry for repost, gmail sucks and I have a short memory) On Thu, Feb 5, 2009 at 2:51 PM, Steven Knight s...@chromium.org wrote: Hi Erik-- It depends on what you really want. SCons does have all of the dependencies, but it doesn't keep the #include tree. Tangible example: if foo.c

[chromium-dev] Re: Don't include render_messages.h in a header

2009-02-05 Thread James Vega
On Thu, Feb 05, 2009 at 04:04:58PM -0800, Peter Kasting wrote: On Thu, Feb 5, 2009 at 4:02 PM, Erik Kay erik...@chromium.org wrote: $ scons_deps -v target foo.c:inc.h:a.h foo.c:inc.h:b.h bar.c:bar.h etc. Does such a script (or something similar) exist? From what you're saying,

[chromium-dev] Re: Don't include render_messages.h in a header

2009-02-05 Thread Lei Zhang
On Thu, Feb 5, 2009 at 4:21 PM, James Vega vega.ja...@gmail.com wrote: On Thu, Feb 05, 2009 at 04:04:58PM -0800, Peter Kasting wrote: On Thu, Feb 5, 2009 at 4:02 PM, Erik Kay erik...@chromium.org wrote: $ scons_deps -v target foo.c:inc.h:a.h foo.c:inc.h:b.h bar.c:bar.h etc. Does

[chromium-dev] Re: Don't include render_messages.h in a header

2009-02-05 Thread Evan Martin
On Thu, Feb 5, 2009 at 4:35 PM, Lei Zhang thes...@chromium.org wrote: I did the same with -MM and parsed the results. Assuming I did it right, the average .cc file in src/chrome/ includes about 135 header files. The files with the most number of includes: 440 about_chrome_view.o 470