[chromium-dev] Re: Proposal: Accessibility extension api

2009-12-18 Thread Erik Kay
I some comments to the code review, but I'll summarize the API pieces for those following here. The main issue is that I think there's a little too much overloading going on: * ControlInfo feels like it should be split into more concrete subtypes with separate parameters. * onOpen/Close should be

[chromium-dev] Re: Proposal: Accessibility extension api

2009-12-18 Thread Dominic Mazzoni
Thanks! Your suggestions sound great, and I'll let you know when I've finished changing the code. I didn't even realize an enum was possible in an extension api. That sounds great. I also thought it would be nice if the names matched equivalent names already used in the html dom where

[chromium-dev] Re: Proposal: Accessibility extension api

2009-12-16 Thread Erik Kay
+chromium-dev On Wed, Dec 16, 2009 at 1:15 PM, Dominic Mazzoni dmazz...@google.comwrote: Hi, Here's an experimental proposal I'd like to throw out there. All types of suggestions, criticism, and questions are welcome. - Dominic * * *Overview* This experimental API exposes information

Re: [chromium-dev] Re: Proposal: Accessibility extension api

2009-12-16 Thread Evan Martin
(Disclaimer: I know very little about a11y.) On Wed, Dec 16, 2009 at 10:20 PM, Erik Kay erik...@chromium.org wrote: On Wed, Dec 16, 2009 at 1:15 PM, Dominic Mazzoni dmazz...@google.com This experimental API exposes information about focused controls in the native ui, like dialog boxes and the