[chromium-dev] Re: What's missing in my view?

2008-12-15 Thread Darin Fisher
Don't you still need to engage some of webkit's code to ensure that space is made for the resizer (when there is only a vertical scrollbar)? -Darin On Sun, Dec 14, 2008 at 10:27 PM, Marc-Andre Decoste m...@google.com wrote: Salut Darin, I know, I have investigated that route, but the

[chromium-dev] Re: What's missing in my view?

2008-12-15 Thread Peter Kasting
On Mon, Dec 15, 2008 at 8:06 AM, Darin Fisher da...@chromium.org wrote: Don't you still need to engage some of webkit's code to ensure that space is made for the resizer (when there is only a vertical scrollbar)? He's doing that. (I was confused on this point too.) This requires providing a

[chromium-dev] Re: What's missing in my view?

2008-12-15 Thread Peter Kasting
On Mon, Dec 15, 2008 at 10:12 AM, Peter Kasting pkast...@google.com wrote: The status bubble is overkill for this; it was a separate window mainly so it could move outside the main browser bounds as needed. Bah, I was wrong. Another issue is that the content area has its own HWND. If you

[chromium-dev] Re: What's missing in my view?

2008-12-15 Thread Ben Goodger (Google)
A few thoughts on implementing the resizer: - Windows supports a resizer hit test code return value from WM_NCHITTEST. I think it's something like HTBOTTOMRIGHT (it's actually not HTGROWBOX, that doesn't work). When you return this value for coordinates in the resizer area, Windows will do the

[chromium-dev] Re: What's missing in my view?

2008-12-15 Thread Darin Fisher
does the webkit resizer disappear when the download shelf appears? -darin On Mon, Dec 15, 2008 at 11:27 AM, Ben Goodger (Google) b...@chromium.orgwrote: A few thoughts on implementing the resizer: - Windows supports a resizer hit test code return value from WM_NCHITTEST. I think it's

[chromium-dev] Re: What's missing in my view?

2008-12-15 Thread Darin Fisher
sorry, s/does/should/ On Mon, Dec 15, 2008 at 11:44 AM, Darin Fisher da...@chromium.org wrote: does the webkit resizer disappear when the download shelf appears? -darin On Mon, Dec 15, 2008 at 11:27 AM, Ben Goodger (Google) b...@chromium.orgwrote: A few thoughts on implementing the

[chromium-dev] Re: What's missing in my view?

2008-12-15 Thread Ben Goodger (Google)
Yes that would be what would have to be done. The renderer would have to support showing/hiding it on demand. -Ben On Mon, Dec 15, 2008 at 11:44 AM, Darin Fisher da...@chromium.org wrote: does the webkit resizer disappear when the download shelf appears? -darin On Mon, Dec 15, 2008 at

[chromium-dev] Re: What's missing in my view?

2008-12-14 Thread Marc-Andre Decoste
Salut Darin, I know, I have investigated that route, but the webkit code for the resizer is very tied to HTML tag rendering, so I had a hard time finding how to reuse it. Also, since I realized that I couldn't reuse it in the same way when I get to draw over bottom shelves like the download

[chromium-dev] Re: What's missing in my view?

2008-12-13 Thread Marc-Andre Decoste
ok, cool... Thanks Peter... I thought the resizer needed to be a leaf in the view hierarchy to be drawn on top of all the other views and receive the mouse events... So now I guess there is a way for the browser view to specify that this child has to be laid on top of the other child, right? Is

[chromium-dev] Re: What's missing in my view?

2008-12-13 Thread Jo
I wanted to reply earlier, but i got some problem with my build :( Anyway, your problem is that your label is rendered behind the tab content. To test that behavior, try to reduce the height of the tabcontent and put your label right under it, it should now display your text. There is no way to

[chromium-dev] Re: What's missing in my view?

2008-12-13 Thread Darin Fisher
By the way, WebKit has support for drawing the resizer. So, if you are trying to add a resizer to windows that display web content, you might want to just enable the feature in WebKit (or at least the rendering portion of it). -Darin On Fri, Dec 12, 2008 at 1:32 PM, Marc-Andre Decoste

[chromium-dev] Re: What's missing in my view?

2008-12-12 Thread Marc-Andre Decoste
Salut again, a little update. I got the drawing of my view to work within the download shelf, and I think I found why I couldn't get it to work as a child of the content_container_. This latter parent view seem to only be able to draw TabContents objects... So I'll try to make the resizer