+1
Google style encourages including everything you need in the source. There
should be no magic -include lines required to build the source.
This is why pre-compiled headers are disabled in release builds. If they
were not, then over time people would only be able to build the source if
they
I agree with this in principle, but we're long past that, I think?
From one of the Mac build files:
FEATURE_DEFINES = ENABLE_DATABASE=1
ENABLE_DASHBOARD_SUPPORT=0
ENABLE_JAVASCRIPT_DEBUGGER=0 ENABLE_JSC_MULTIPLE_THREADS=0
ENABLE_ICONDATABASE=0 ENABLE_XSLT=1
I didn't mean to pick on the Mac, it was just the easiest one to grab
all the defines out of. :)
On Tue, Feb 17, 2009 at 10:45 AM, Mike Pinkerton pinker...@chromium.org wrote:
Note these are only for building WebKit, not any of the Chromium
files. I think Win does something similar, no?
On
On Mon, Feb 16, 2009 at 1:45 PM, Evan Martin e...@chromium.org wrote:
http://codereview.chromium.org/21401 does this. It seems to work on
Windows (I'd like an expert to doublecheck I did it the right way) but
my wild guess at making Mac work is apparently wrong. If any Mac
expert could help
On Mon, Feb 16, 2009 at 4:00 PM, Adam Langley a...@chromium.org wrote:
On Mon, Feb 16, 2009 at 1:45 PM, Evan Martin e...@chromium.org wrote:
http://codereview.chromium.org/21401 does this. It seems to work on
Windows (I'd like an expert to doublecheck I did it the right way) but
my wild
I don't agree with this approach. I think that we should include what
we use, and that should extend to headers that provide nonstandard
macro definitions. I think that we should be expressing as much as
possible in code rather than in build environments. Most importantly,
I don't like the
