[chromium-dev] Re: porting chrome_process_filter

2009-03-25 Thread Paweł Hajdan Jr .
Thanks for all your comments. Actually chrome_process_filter is only used by tests to enumerate chrome processes. So I plan to add a chrome_process_enumerator in chrome/test and remove chrome/common/chrome_process_filter. --~--~-~--~~~---~--~~ Chromium Developers

[chromium-dev] Re: porting chrome_process_filter

2009-03-24 Thread Thomas Van Lenten
A bunch of process handle code is something we're gonna need to look very carefully at. The filtering via names may be valid on Windows, but on Linux, a user could have Chromium running twice (with different profiles/user data dirs) pointing at different displays, so we'll have to be very careful

[chromium-dev] Re: porting chrome_process_filter

2009-03-24 Thread John Abd-El-Malek
2009/3/24 Thomas Van Lenten thoma...@chromium.org A bunch of process handle code is something we're gonna need to look very carefully at. The filtering via names may be valid on Windows, but on Linux, a user could have Chromium running twice (with different profiles/user data dirs) pointing

[chromium-dev] Re: porting chrome_process_filter

2009-03-24 Thread Adam Langley
2009/3/24 John Abd-El-Malek j...@chromium.org: Right, this is used so that if the user starts Chrome a second time, it tells the currently running exe to open a new tab.  This is the standard way of doing it on Windows, but I don't know how Mac/Linux apps enforce single-instance semantics.  

[chromium-dev] Re: porting chrome_process_filter

2009-03-24 Thread Amanda Walker
2009/3/24 John Abd-El-Malek j...@chromium.org: Right, this is used so that if the user starts Chrome a second time, it tells the currently running exe to open a new tab.  This is the standard way of doing it on Windows, but I don't know how Mac/Linux apps enforce single-instance semantics.  

[chromium-dev] Re: porting chrome_process_filter

2009-03-24 Thread Thomas Van Lenten
On Tue, Mar 24, 2009 at 1:00 PM, Amanda Walker ama...@chromium.org wrote: 2009/3/24 John Abd-El-Malek j...@chromium.org: Right, this is used so that if the user starts Chrome a second time, it tells the currently running exe to open a new tab. This is the standard way of doing it on

[chromium-dev] Re: porting chrome_process_filter

2009-03-24 Thread Dan Kegel
2009/3/24 John Abd-El-Malek j...@chromium.org: If I remember right when I looked at some of this, the Windows code uses the process filter as a hook to scan the windows to find a running Chromium and send it a message. So that whole functionality should be re-abstracted, if needed, instead

[chromium-dev] Re: porting chrome_process_filter

2009-03-24 Thread Amanda Walker
On Tue, Mar 24, 2009 at 1:06 PM, John Abd-El-Malek j...@chromium.org wrote: A lot of the code that touches databases/files in the user-data-dir assume they're the only ones accessing them.  If multiple instances use the data, there could be corruption. Makes sense. But multiple instances

[chromium-dev] Re: porting chrome_process_filter

2009-03-24 Thread Amanda Walker
Agreed. The current code base has many abstractions that implicitly embody windows assumptions--just porting them is not always the right approach. Sometimes sticking a layer *above* them and putting different mechanisms into play per-platform is a better solution. --Amanda On Tue, Mar 24,

[chromium-dev] Re: porting chrome_process_filter

2009-03-24 Thread Evan Martin
On Tue, Mar 24, 2009 at 10:14 AM, Dan Kegel daniel.r.ke...@gmail.com wrote: 2009/3/24 John Abd-El-Malek j...@chromium.org: If I remember right when I looked at some of this, the Windows code uses the process filter as a hook to scan the windows to find a running Chromium and send it a