[chromium-dev] Re: using string16

2009-02-04 Thread Dean McNamee
Hey Evan, I apologize for missing this discussion, I'm sure that I'm not seeing the entire picture and the pros of this argument. I mentioned before that I'm in support of utf-8 everywhere we can get it. We are obviously going to have platform specific code for the UI (win32 /

[chromium-dev] Re: using string16

2009-02-04 Thread Evan Martin
On Wed, Feb 4, 2009 at 6:53 AM, Dean McNamee de...@chromium.org wrote: I apologize for missing this discussion, I'm sure that I'm not seeing the entire picture and the pros of this argument. I mentioned before that I'm in support of utf-8 everywhere we can get it. I lost this argument, so I

[chromium-dev] Re: using string16

2009-02-04 Thread Darin Fisher
The proposal was to search-n-replace std::wstring to string16. We would have to invent a macro to replace L usage. Most usages of string literals are in unit tests, so it doesn't seem to matter if there is cost associated with the macro. My belief is that there isn't much fruit to be had by

[chromium-dev] Re: using string16

2009-02-04 Thread Dean McNamee
On Wed, Feb 4, 2009 at 6:11 PM, Darin Fisher da...@chromium.org wrote: The proposal was to search-n-replace std::wstring to string16. We would have to invent a macro to replace L usage. Most usages of string literals are in unit tests, so it doesn't seem to matter if there is cost associated

[chromium-dev] Re: using string16

2009-02-04 Thread Thomas Van Lenten
Trying to remember what came up along the discussion. UTF16 is what Mac/win use, so there we can avoid a batch of conversions on those two platforms. (Mac can take UTF8, but the system would still be doing conversions to get things into a form it prefers) Didn't someone say ICU needs things in

[chromium-dev] Re: using string16

2009-02-04 Thread Darin Fisher
On Wed, Feb 4, 2009 at 9:35 AM, Dean McNamee de...@chromium.org wrote: On Wed, Feb 4, 2009 at 6:11 PM, Darin Fisher da...@chromium.org wrote: The proposal was to search-n-replace std::wstring to string16. We would have to invent a macro to replace L usage. Most usages of string literals

[chromium-dev] Re: using string16

2009-02-04 Thread Mike Belshe
The big string area is webkit, of course. If webkit were 100% UTF-8 already, we might take a different stance on this issue as well. If it is our goal to get to UTF-8 everywhere, then laying the plumbing for utf8 strings rather than string16 strings seems like the right thing to do. Mike On

[chromium-dev] Re: using string16

2009-02-04 Thread cpu
+1 to string16 I can't make performance or memory saving claims with a straight face for any. We just don't process enough strings for us to matter. On Feb 4, 9:57 am, Mike Belshe mbel...@google.com wrote: The big string area is webkit, of course.  If webkit were 100% UTF-8 already, we might

[chromium-dev] Re: using string16

2009-02-03 Thread Linus Upson
An angel loses its wings for each 00 byte in UTF-16. Is 'host' measured in base-2 or base-10? Linus On Tue, Feb 3, 2009 at 6:11 PM, Evan Martin e...@chromium.org wrote: [A bunch of the team met up today to hammer out some decisions.] In brief: for strings that are known to be Unicode (that