[chromium-dev] Re: What's the real reason of giving up Windows 2000 support?

2009-06-27 Thread Jim Roskind
re: Your comment the cost is big. FWIW: One item that I recall was very complex was the message loop implementation, which handles both native Windows events and coordinates inter-thread Task processing.. It was quite difficult to create a task processing system that integrated with the Windows

[chromium-dev] Re: Should GYP files be UTF8 Encoded?

2009-06-27 Thread Daniel Cowx
No use case. I was just creating a new GYP file and wanted to know what encoding to save the file as...that's all :-) On Jun 26, 10:52 pm, Bradley Nelson bradnel...@google.com wrote: The intention was ascii AFAIK. Unless someone has a use case? -BradN On Fri, Jun 26, 2009 at 3:05 PM,

[chromium-dev] How do I *undefine* a define in GYP?

2009-06-27 Thread Daniel Cowx
I have a third_party project that assumes that WIN32_LEAN_AND_MEAN is *not* defined. Unfortunately, common.gypi defines it, so I'm getting lots of compiler errors that I dont particularly want to track down. What's teh best way to either a) undefine WIN32_LEAN_AND_MEAN from common.gypi, or b)

[chromium-dev] Re: How do I *undefine* a define in GYP?

2009-06-27 Thread Daniel Cowx
Okay, I've figured out that I can do: snip 'msvs_settings': { 'VCCLCompilerTool': { 'UndefinePreprocessorDefinitions': 'WIN32_LEAN_AND_MEAN', }, }, /snip Though this works, it will cause a command line warning D9025 to be issued b/c you're undefining a previous define. I'd prefer if

[chromium-dev] Re: How do I *undefine* a define in GYP?

2009-06-27 Thread Bradley Nelson
You can undefine items with: 'defines!: [ 'WIN32_LEAN_AND_MEAN', ], -BradN On Sat, Jun 27, 2009 at 1:47 PM, Daniel Cowx daniel.c...@gmail.com wrote: Okay, I've figured out that I can do: snip 'msvs_settings': { 'VCCLCompilerTool': { 'UndefinePreprocessorDefinitions':

[chromium-dev] Re: How do I *undefine* a define in GYP?

2009-06-27 Thread Daniel Cowx
Awesome. Thanks Brad! On Jun 27, 1:52 pm, Bradley Nelson bradnel...@google.com wrote: You can undefine items with: 'defines!: [     'WIN32_LEAN_AND_MEAN', ], -BradN On Sat, Jun 27, 2009 at 1:47 PM, Daniel Cowx daniel.c...@gmail.com wrote: Okay, I've figured out that I can do:

[chromium-dev] Re: Memory usage in chrome

2009-06-27 Thread Linus Upson
If I recall correctly, the best way we found to measure the total memory usage of a multi-process system like chrome was to measure the total commit charge of windows as you run the test. This will correctly account for shared memory, mapped pages that have been touched, kernel memory, etc. I

[chromium-dev] Re: middle click on home

2009-06-27 Thread krtulmay
This is fine except for the other 50% of users who do want the browser to change tabs for them. And before you reply with there are more than 50% of users who want new tabs queued in the background or say that it's your preference, I would like to see explicitly a statement from Google's testing

[chromium-dev] Re: Memory usage in chrome

2009-06-27 Thread Dan Kegel
On Sat, Jun 27, 2009 at 2:50 PM, Linus Upsonli...@google.com wrote: If I recall correctly, the best way we found to measure the total memory usage of a multi-process system like chrome was to measure the total commit charge of windows as you run the test. My favorite test is to plot the

[chromium-dev] Re: Memory usage in chrome

2009-06-27 Thread Mike Belshe
This one is the hardest to test, you need to run a pristinely clean system to execute. Also - don't forget to make the browser window sizes the same (and with the same amount of visible window) for all browsers under test, because if the kernel can't offload to the graphics card, the display

[chromium-dev] Re: changing chrome_exe to chrome, converting chrome.exe to gyp

2009-06-27 Thread Bradley Nelson
Hi Dean, So I've dropped in a change that switches directories to have name like: (base) (test_shell) This will allow you to run things at the command line again. I don't find this choice particularly ascetic myself. But the options where limited, because the following characters cannot appear

[chromium-dev] Re: middle click on home

2009-06-27 Thread Peter Kasting
I argued from the point of consistency and mentioned my personal preference only as an afternote to point out that the consistent behavior would not be universally despised. PK On Jun 27, 2009 4:08 PM, krtulmay krtul...@gmail.com wrote: This is fine except for the other 50% of users who do