[chromium-dev] Re: Flakiness. Please help.

2009-08-06 Thread Jeremy Orlow
Oops...I failedit's actually src/webkit/tools/layout_tests Also the file uses an underscore, not a dash...it's test_expectations.txt J On Wed, Aug 5, 2009 at 11:28 PM, Jeremy Orlow jor...@chromium.org wrote: src/webkit/tools/data/layout_tests btw, run_layout_tests.* can be used to run

[chromium-dev] Re: Urgent, a very evil site i think which does evil things (no joke)

2009-08-06 Thread Jeremy Orlow
On Wed, Aug 5, 2009 at 11:52 PM, yoav zilberberg yoav.zilberb...@gmail.comwrote: Jeremy, i can't see how it will make things any worse to punch these holes I never said it's worse...just that you couldn't make it airtight. Patches welcome. :-) you still fork flash in its own process like

[chromium-dev] Re: gcl change that you should be aware of

2009-08-06 Thread Jeremy Orlow
Another vote against this change for similar reasons... On Thu, Aug 6, 2009 at 12:37 AM, Dirk Pranke dpra...@google.com wrote: I also fear that I may have unwanted files sneaking in. This was less of an issue with Perforce since you have to manually 'p4 edit' files first anyway. I'll be

[chromium-dev] Re: Urgent, a very evil site i think which does evil things (no joke)

2009-08-06 Thread Jeremy Orlow
Yoav everyone on this thread is a Chromium developer and almost everyone posting in this thread (not me) are some of the top developers working on Chrome and many of them have spent a good deal of time working on sandbox related issues. All of us have a healthy disrespect for the impossible and

[chromium-dev] Re: Urgent, a very evil site i think which does evil things (no joke)

2009-08-06 Thread Jeremy Orlow
On Thu, Aug 6, 2009 at 10:16 AM, Miguel F Mascarenhas Sousa Filipe miguel.fil...@gmail.com wrote: Hi, On Thu, Aug 6, 2009 at 6:08 PM, Jeremy Orlow jor...@chromium.org wrote: Yoav everyone on this thread is a Chromium developer and almost everyone posting in this thread (not me) are some

[chromium-dev] Re: Dev Chrome crashes on subsequent starts after installing a theme

2009-08-06 Thread Jeremy Orlow
Does http://groups.google.com/group/chromium-dev/browse_thread/thread/df20c1f0e4576131 help? If not, please go to new.crbug.com On Thu, Aug 6, 2009 at 6:04 AM, Gobbledegook aftabkha...@gmail.com wrote: Hi, I've been unable to get into chrome dev (latest) ever since I installed the Baseball

[chromium-dev] Re: gyp failing while triggering gclient sync in linux with git

2009-08-06 Thread Jeremy Orlow
Can you check out another client and see if that fixes it for you? On Thu, Aug 6, 2009 at 8:58 PM, Mohamed Mansour m0.interact...@gmail.comwrote: Tonight I was trying to sync my project so I did git pull and it worked fine, then I did gclient sync as well as --force. But gyp is failing:

[chromium-dev] Re: Chrome and OLE Excel Table Question

2009-08-07 Thread Jeremy Orlow
This is not the place to ask such questions. try chromium-discuss On Fri, Aug 7, 2009 at 3:45 AM, Fraser MacKenzie fmack...@gmail.com wrote: Folks, Whenever I need to paste an OLE Excel table in the message it appears as text only in the body of the e-mail. Also I have to attach images

[chromium-dev] Re: Missing config.h?

2009-08-07 Thread Jeremy Orlow
What file(s) are we talking about specifically? On Fri, Aug 7, 2009 at 11:31 AM, Ben Laurie b...@chromium.org wrote: On Fri, Aug 7, 2009 at 6:17 PM, Darin Fisherda...@chromium.org wrote: This will become a non-issue once we finish upstreaming all code that uses WebCore. This means

[chromium-dev] Re: Missing config.h?

2009-08-07 Thread Jeremy Orlow
On Fri, Aug 7, 2009 at 12:01 PM, Darin Fisher da...@chromium.org wrote: On Fri, Aug 7, 2009 at 11:31 AM, Ben Laurie b...@chromium.org wrote: On Fri, Aug 7, 2009 at 6:17 PM, Darin Fisherda...@chromium.org wrote: This will become a non-issue once we finish upstreaming all code that uses

[chromium-dev] Re: Missing config.h?

2009-08-07 Thread Jeremy Orlow
On Fri, Aug 7, 2009 at 2:15 PM, Ben Laurie b...@chromium.org wrote: On Fri, Aug 7, 2009 at 8:11 PM, Jeremy Orlowjor...@chromium.org wrote: On Fri, Aug 7, 2009 at 12:01 PM, Darin Fisher da...@chromium.org wrote: On Fri, Aug 7, 2009 at 11:31 AM, Ben Laurie b...@chromium.org wrote: On

[chromium-dev] Re: Stack traces on layout test crashes

2009-08-08 Thread Jeremy Orlow
run with this! :) :DG On Fri, Aug 7, 2009 at 8:45 PM, Darin Fisherda...@chromium.org wrote: On Fri, Aug 7, 2009 at 8:39 PM, Ojan Vafai o...@chromium.org wrote: On Fri, Aug 7, 2009 at 8:45 PM, Jeremy Orlow jor...@chromium.org wrote: Has anyone ever looked into printing out stack traces

[chromium-dev] Re: Stack traces on layout test crashes

2009-08-10 Thread Jeremy Orlow
On Sun, Aug 9, 2009 at 9:07 AM, Nicolas Sylvain nsylv...@chromium.orgwrote: Some things to consider: 1. On windows, breakpad used to be wired in test_shell. And I'm pretty sure we used to archive crash dumps for the layout tests too. It should not be hard to do that again. Huan also write a

[chromium-dev] Re: Stack traces on layout test crashes

2009-08-10 Thread Jeremy Orlow
On Mon, Aug 10, 2009 at 9:59 AM, Ojan Vafai o...@chromium.org wrote: On Mon, Aug 10, 2009 at 3:12 AM, Jeremy Orlow jor...@chromium.org wrote: On Sun, Aug 9, 2009 at 9:07 AM, Nicolas Sylvain nsylv...@chromium.orgwrote: 2. The show stopper for any implementation of this feature

[chromium-dev] Clobbering

2009-08-10 Thread Jeremy Orlow
We really need a better way to submit patches that we know require a clobber. Today alone, there were 2 WebKit deps rolls that we _knew_ would need a clobber. Both ended up closing the tree for a bit. What if we added an optional flag to the CL descriptions that tells the bots that a clobber is

[chromium-dev] Re: Clobbering

2009-08-11 Thread Jeremy Orlow
On Mon, Aug 10, 2009 at 10:45 PM, Aaron Boodman a...@chromium.org wrote: Such a system does not help when people sync your change. We should invest the effort we would expend building this system fixing the dependency issues. gclient could be made to obey it as well. But I agree, it's a

[chromium-dev] Re: Clobbering

2009-08-11 Thread Jeremy Orlow
in the chain) that are just due to mistakes in the gyp files. I would be curious which kind of dependency issue these latest ones were (can someone point me at the CLs?, been on nacl/o3d buildbot stuff of late). -BradN On Mon, Aug 10, 2009 at 11:00 PM, Jeremy Orlow jor...@chromium.orgwrote

[chromium-dev] Re: lan manager in cloud

2009-08-11 Thread Jeremy Orlow
Even with the translation, it's difficult to understand what you're saying and asking. Chromium has a full screen feature and is open source so you could tweak it to meet your needs. Does that help? On Tue, Aug 11, 2009 at 3:16 PM, Wallace Araujo wallace@gmail.comwrote: Someone could help

[chromium-dev] Re: Clobbering

2009-08-11 Thread Jeremy Orlow
Nice!!! On Tue, Aug 11, 2009 at 3:57 PM, Bradley Nelson bradnel...@google.comwrote: Ok I think I've found it.It looks like a bug in the rule - makefile emitter which is only used for webcore. (Most gyp rules turn into custom build rules, but we added a makefile emitter option for this one

[chromium-dev] Re: lan manager in cloud

2009-08-11 Thread Jeremy Orlow
, Aug 12, 2009 at 07:01, Wallace Araujo wallace@gmail.com wrote: Jeremy Orlow So, how can I do this? ^^ Dan Kegel No, but if I can get help I would be thankful. I can't find the material of the documentation about this. Ricardo Vargas Exactly, I need a screen without

[chromium-dev] Re: problem of flashplayer

2009-08-12 Thread Jeremy Orlow
On Tue, Aug 11, 2009 at 8:24 PM, peter peterxiemin.x...@gmail.com wrote: today I downloaded a chromium ,by the way , my os is linux of ubuntu 9.04 , it work ok but can't play flash .who can help me Flash support is VERY experimental if working at all, last time I checked. Also, Chromium-dev

[chromium-dev] Re: tryserver flakiness

2009-08-12 Thread Jeremy Orlow
Clobber needed? I know Michael just enabled this within the last 24 hours. On Wed, Aug 12, 2009 at 1:49 PM, Paweł Hajdan Jr. phajdan...@chromium.orgwrote: Just got this on the Windows tryserver: C:\b\slave\win\build\src\chrome\renderer\renderer_webkitclient_impl.cc : error C2220: warning

[chromium-dev] Re: tryserver flakiness

2009-08-12 Thread Jeremy Orlow
Brad, looks like we might have another dependency bug in GYP? J On Wed, Aug 12, 2009 at 1:57 PM, Michael Nordman micha...@google.comwrote: I just submitted the change that ENABLE's that flag a moment ago... we're clobbering things now On Wed, Aug 12, 2009 at 1:55 PM, Jeremy Orlow jor

[chromium-dev] Re: tryserver flakiness

2009-08-12 Thread Jeremy Orlow
mentioned sounds like a fine one. TVL -BradN On Wed, Aug 12, 2009 at 1:59 PM, Jeremy Orlow jor...@google.com wrote: Brad, looks like we might have another dependency bug in GYP? J On Wed, Aug 12, 2009 at 1:57 PM, Michael Nordman micha...@google.comwrote: I just submitted the change

[chromium-dev] Re: Halting JS execution in V8?

2009-08-12 Thread Jeremy Orlow
An infinite running script in a worker should be a valid use case. Computing Pi to the infiniteth digit is actually the first example in the worker spec, IIRC. So this would just kill/timeout shared workers that no longer are connected to any active pages, right? J On Wed, Aug 12, 2009 at 3:25

[chromium-dev] Re: Rogers SMS login page does not save password

2009-08-13 Thread Jeremy Orlow
This is not the right place to bring this up. http://new.crbug.com On Thu, Aug 13, 2009 at 3:51 AM, Gobbledegook aftabkha...@gmail.com wrote: The option to save the password does not appear on the following login page: http://websms.rogers.page.ca/2way/ Chrome (3.0.197.11) only saves the

[chromium-dev] Re: Trybot HUNK failed on patch

2009-08-15 Thread Jeremy Orlow
The LKGR (http://chromium-status.appspot.com/lkgr) is really stale. You could supply your own '--revision number' when you do 'gcl try' or upload. On Sat, Aug 15, 2009 at 12:59 PM, Mike Belshe mbel...@google.com wrote: I'm trying to test a simple patch which does nothing more than roll the

[chromium-dev] Re: Is it possible to link Chromium to shared CRT on Windows (i.e. /MD instead of /MT)

2009-08-18 Thread Jeremy Orlow
On Tue, Aug 18, 2009 at 2:40 PM, Daniel Cowx daniel.c...@gmail.com wrote: I'm incorporating Chromium into an existing that uses the shared CRT. To minimize footprint, I'd like to experiment with linking Chromium to the shared CRT as well. I've tried changing RuntimeLibrary in common.gypi,

[chromium-dev] Re: PSA: do not include X_messages.h in other headers

2009-08-20 Thread Jeremy Orlow
Are you positive it's the per-file presubmit checks slowing things down? If so, maybe the presubmit stuff needs to be re-factored? Right now, it does each presubmit check one by one (and each check might read in the files). If it were changed to go file by file (reading fully into memory,

[chromium-dev] Re: WebKit API guidance?

2009-08-20 Thread Jeremy Orlow
On Thu, Aug 20, 2009 at 6:17 PM, Drew Wilson atwil...@chromium.org wrote: I have to admit I'm somewhat fuzzy on the motivation behind our webkit API, although I gather the plan is to eventually upstream it to WebKit, and use it as our abstraction layer instead of using the (more mutable)

[chromium-dev] Re: Question about Browser IO thread

2009-08-21 Thread Jeremy Orlow
What exactly are you trying to do? On Thu, Aug 20, 2009 at 11:27 PM, n179911 n179...@gmail.com wrote: Hi, From this chromium document, http://sites.google.com/a/chromium.org/dev/developers/design-documents/multi-process-architecture Browser has an IO thread which receives messages from

[chromium-dev] Re: Handling layout test expectations for failing tests

2009-08-21 Thread Jeremy Orlow
On Fri, Aug 21, 2009 at 1:00 PM, Dirk Pranke dpra...@chromium.org wrote: Hi all, As Glenn noted, we made great progress last week in rebaselining the tests. Unfortunately, we don't have a mechanism to preserve the knowledge we gained last week as to whether or not tests need to be

[chromium-dev] Re: Handling layout test expectations for failing tests

2009-08-21 Thread Jeremy Orlow
On Fri, Aug 21, 2009 at 2:33 PM, Pam Greene p...@chromium.org wrote: At least in the batch of tests I examined, the ones that needed re-baselining weren't tests we'd originally failed and suddenly started passing. They were new tests that nobody had ever taken a good look at. If that matches

[chromium-dev] Re: Handling layout test expectations for failing tests

2009-08-22 Thread Jeremy Orlow
On Sat, Aug 22, 2009 at 4:00 PM, Peter Kasting pkast...@chromium.orgwrote: On Fri, Aug 21, 2009 at 8:07 PM, Jeremy Orlow jor...@chromium.org wrote: 1) We don't have notes on why tests are failing. = Why not annotate the tests in test_lists? That's what I've always done. Once again, we

[chromium-dev] Re: Handling layout test expectations for failing tests

2009-08-22 Thread Jeremy Orlow
On Sat, Aug 22, 2009 at 5:54 PM, Peter Kasting pkast...@chromium.orgwrote: On Sat, Aug 22, 2009 at 4:29 PM, Jeremy Orlow jor...@chromium.org wrote: On Sat, Aug 22, 2009 at 4:00 PM, Peter Kasting pkast...@chromium.orgwrote: If you somehow managed to not see any comments in this file, I think

[chromium-dev] Re: Question about resource_dispatcher_host.h

2009-08-24 Thread Jeremy Orlow
There's one host per renderer, so there's no need for any list. On Mon, Aug 24, 2009 at 11:22 AM, hap 497 hap...@gmail.com wrote: From http://dev.chromium.org/developers/design-documents/multi-process-architecture, Resoruce dispatcher Host should have the list of all the channel opened with

[chromium-dev] Re: Question about resource_dispatcher_host.h

2009-08-24 Thread Jeremy Orlow
Oops...sorry for the misinformation...should have double checked before I said anything. :-) On Mon, Aug 24, 2009 at 1:26 PM, John Abd-El-Malek j...@chromium.org wrote: On Mon, Aug 24, 2009 at 1:06 PM, Brett Wilson bre...@chromium.org wrote: On Mon, Aug 24, 2009 at 12:49 PM, hap

[chromium-dev] Re: How to generate file under webkit.build/DerivedSources/Debug/bindings

2009-08-25 Thread Jeremy Orlow
I don't know the answer specifically, but this might help: If your question is how to do it by hand, src/webkit/webkit.gyp should have the answer. If you just want to compile all of chromium, you shouldn't need to worry about it: just compile Chromium however you normally would and it should

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread Jeremy Orlow
On Wed, Aug 26, 2009 at 12:48 PM, Dan Kegel d...@kegel.com wrote: On Wed, Aug 26, 2009 at 12:28 PM, Darin Fisherda...@chromium.org wrote: I've heard people proclaim the principle of being able to copy a profile across systems as being a deciding factor for certain changes (e.g. the

[chromium-dev] Re: Layout try slaves

2009-09-01 Thread Jeremy Orlow
, Jeremy Orlow jor...@chromium.org wrote: I'd suggest putting the webkit layout test slaves under release. This would allow us to catch debug/release build errors (since the normal bots are on debug) and layout tests run MUCH faster under release. On Tue, Sep 1, 2009 at 8:47 AM, Marc-Antoine

[chromium-dev] Re: WebKit Chromium Port

2009-09-09 Thread Jeremy Orlow
On Wed, Sep 9, 2009 at 2:47 PM, Eric Seidel esei...@chromium.org wrote: On Tue, Sep 8, 2009 at 10:39 PM, Jeremy Orlow jor...@chromium.org wrote: If it does work, we could definitely let them know it's an option for those who might want to. We'd have to phrase it delicately though. They're

[chromium-dev] Re: Windows trybot issue.

2009-09-09 Thread Jeremy Orlow
Please follow the instructions on the email you get from the try bot On Wed, Sep 9, 2009 at 8:55 PM, James Su su...@chromium.org wrote: Hi, I tried a CL on trybot. Linux and Mac trybots finished without any problem very soon. But windows trybot spent more than 40 minutes to compile and

[chromium-dev] Re: Windows trybot issue.

2009-09-09 Thread Jeremy Orlow
I'm just following instructions: TRY FAILED *If you think the try slave is broken (it happens!), please REPLY to this email, don't ask on irc, mailing list or IM.* Thanks! I doubt emailing the list here asking what's up is going to help things much. Marc-Antoine is quite responsive about

[chromium-dev] Re: WebKit Chromium Port

2009-09-09 Thread Jeremy Orlow
On Thu, Sep 10, 2009 at 2:10 AM, Dimitri Glazkov dglaz...@chromium.orgwrote: Marc-Antoine, you will forever have a special place in every WebKit committer's heart if you can pull of setting up these trybots. +100 Given that this thread quickly discombobulated into a general WebKit

[chromium-dev] Re: autolinking BUG= lines in Rietveld

2009-09-09 Thread Jeremy Orlow
, Jeremy Orlow jor...@chromium.org wrote: I don't have a rietveld dev environment set up, so I wrote a quick script to test the general algorithm. It's not as pythony as I'd like, but it seems to be fairly robust: #!/usr/bin/python import re description = \ Blah blah blah. Blaaa TEST

[chromium-dev] Re: Where does -Werror get disabled for WebCore?

2009-09-13 Thread Jeremy Orlow
Unless we can get people upstream to compile with -Wall -Werror, that'll be an uphill battle (every time we want to roll to a new version). It'd be nice if we could, though. On Sun, Sep 13, 2009 at 11:35 AM, Ben Laurie b...@chromium.org wrote: On Sun, Sep 13, 2009 at 7:13 PM, Darin

[chromium-dev] Re: [linux] computing cpu usage

2009-09-17 Thread Jeremy Orlow
Is the last version released under the LGPL version good enough for our needs? If so, we can just use that. And not feel too bad. :-) As a side note, if we use ps or /proc we're just scraping information that was printed out by a GPL program. :-) J On Thu, Sep 17, 2009 at 4:22 PM, Peter

[chromium-dev] Re: [Green Tree] Week 1

2009-09-21 Thread Jeremy Orlow
On Mon, Sep 21, 2009 at 8:25 AM, Nicolas Sylvain nsylv...@chromium.orgwrote: Hi chromium-dev, A small group of us joined forces to create a Green Tree task force. The goal of this task force is to make sure the tree stays green most of the time. The 2 main pain points that we are

[chromium-dev] Shipping features behind a run-time flag can sometimes still be dangerous

2009-09-21 Thread Jeremy Orlow
I think we need to re-consider our practice of shipping beta/stable browsers with experimental features hidden behind flags--at least when they have any side-effects in JavaScript. An example of where this has bitten us is http://code.google.com/p/chromium/issues/detail?id=22181 Although part of

[chromium-dev] Re: Shipping features behind a run-time flag can sometimes still be dangerous

2009-09-21 Thread Jeremy Orlow
, 2009 at 2:31 PM, Jeremy Orlow jor...@chromium.org wrote: I think we need to re-consider our practice of shipping beta/stable browsers with experimental features hidden behind flags--at least when they have any side-effects in JavaScript. An example of where this has bitten us is http

[chromium-dev] Re: Shipping features behind a run-time flag can sometimes still be dangerous

2009-09-21 Thread Jeremy Orlow
On Mon, Sep 21, 2009 at 2:55 PM, Jeremy Orlow jor...@chromium.org wrote: On Mon, Sep 21, 2009 at 2:47 PM, Aaron Boodman a...@chromium.org wrote: It is really useful to have early code compiling and running as much as possible on all platforms right from the beginning. This catches a lot

[chromium-dev] Re: Shipping features behind a run-time flag can sometimes still be dangerous

2009-09-21 Thread Jeremy Orlow
On Mon, Sep 21, 2009 at 3:29 PM, John Abd-El-Malek j...@chromium.org wrote: On Mon, Sep 21, 2009 at 2:31 PM, Jeremy Orlow jor...@chromium.org wrote: I think we need to re-consider our practice of shipping beta/stable browsers with experimental features hidden behind flags--at least when

[chromium-dev] Re: Shipping features behind a run-time flag can sometimes still be dangerous

2009-09-21 Thread Jeremy Orlow
On Mon, Sep 21, 2009 at 3:51 PM, John Abd-El-Malek j...@chromium.org wrote: On Mon, Sep 21, 2009 at 3:43 PM, Jeremy Orlow jor...@chromium.org wrote: On Mon, Sep 21, 2009 at 3:29 PM, John Abd-El-Malek j...@chromium.orgwrote: On Mon, Sep 21, 2009 at 2:31 PM, Jeremy Orlow jor

[chromium-dev] Re: Shipping features behind a run-time flag can sometimes still be dangerous

2009-09-21 Thread Jeremy Orlow
:23 PM, John Abd-El-Malek j...@chromium.org wrote: On Mon, Sep 21, 2009 at 3:59 PM, Jeremy Orlow jor...@chromium.org wrote: On Mon, Sep 21, 2009 at 3:51 PM, John Abd-El-Malek j...@chromium.org wrote: On Mon, Sep 21, 2009 at 3:43 PM, Jeremy Orlow jor...@chromium.org wrote: Please reply

[chromium-dev] Re: Webkit merges and tree closures

2009-09-22 Thread Jeremy Orlow
There are 2 major issues here (besides leaving things for the Sheriff to clean up): 1) a lot of the gardeners are inexperienced and drop the ball. This has bitten us many times. The last time we had a big string of problems related to this, I meant to send out an email giving people advice on

[chromium-dev] Re: WebKit Hygiene: Please be kind. Test your patches. Warn about two-sided patches.

2009-09-22 Thread Jeremy Orlow
On Tue, Sep 22, 2009 at 6:06 PM, Dimitri Glazkov dglaz...@google.comwrote: Today wasn't a happy day for p...@. He did a seemingly innocuous roll that broke the world: selenium, ui tests, layout tests. I am sure it was stressful and probably added unnecessary gray to his hair. Stuff like

[chromium-dev] Re: Webkit merges and tree closures

2009-09-22 Thread Jeremy Orlow
On Tue, Sep 22, 2009 at 6:16 PM, Nicolas Sylvain nsylv...@chromium.orgwrote: On Tue, Sep 22, 2009 at 6:10 PM, Jeremy Orlow jor...@chromium.org wrote: There are 2 major issues here (besides leaving things for the Sheriff to clean up): 1) a lot of the gardeners are inexperienced and drop

[chromium-dev] Re: Chromium Without SSe2

2009-09-23 Thread Jeremy Orlow
On Wed, Sep 23, 2009 at 11:30 AM, Evan Martin e...@chromium.org wrote: On Wed, Sep 23, 2009 at 11:26 AM, Mark Mentovai m...@chromium.org wrote: If a test exposes a case where something requires 53/64-bit IEEE double precision as opposed to 64/80-bit double extended, and we're changing our

[chromium-dev] Re: Problem with gyp every time v8 updates their branch

2009-09-23 Thread Jeremy Orlow
Same here. I see it both on windows and mac. On Wed, Sep 23, 2009 at 1:35 PM, Elliot Glaysher (Chromium) e...@chromium.org wrote: On Wed, Sep 23, 2009 at 1:25 PM, John Abd-El-Malek j...@chromium.org wrote: I have to delete the v8 directory and run gclient sync again (or remove the

[chromium-dev] Re: Problem with gyp every time v8 updates their branch

2009-09-23 Thread Jeremy Orlow
On Wed, Sep 23, 2009 at 1:43 PM, John Abd-El-Malek j...@chromium.org wrote: I've seen this before last week as well. I have too. Can this really be added to v8's svn:ignore? These VS generated files have the username in them. On Wed, Sep 23, 2009 at 1:39 PM, Mark Mentovai

[chromium-dev] Re: WebKit Hygiene: Please be kind. Test your patches. Warn about two-sided patches.

2009-09-24 Thread Jeremy Orlow
On Tue, Sep 22, 2009 at 6:35 PM, Adam Barth aba...@chromium.org wrote: On Tue, Sep 22, 2009 at 6:25 PM, John Abd-El-Malek j...@chromium.org wrote: Is this even possible? i.e. I had uploaded a WebKit patch on codereview but none of the patchsets got run on the try server

[chromium-dev] Re: WebKit Hygiene: Please be kind. Test your patches. Warn about two-sided patches.

2009-09-24 Thread Jeremy Orlow
--dst-prefix=src/third_party/WebKit on your diff command. On Thu, Sep 24, 2009 at 1:43 PM, Jeremy Orlow jor...@chromium.org wrote: On Tue, Sep 22, 2009 at 6:35 PM, Adam Barth aba...@chromium.org wrote: On Tue, Sep 22, 2009 at 6:25 PM, John Abd-El-Malek j...@chromium.org wrote

[chromium-dev] Re: Kiosk Mode for Chrome

2009-09-24 Thread Jeremy Orlow
IIRC, someone asked this a couple months ago. I believe the answer was that http://code.google.com/p/chromiumembedded/ might be of interest. I could see patches being welcome as long as they were fairly clean. I know that's not an official answer, but you're probably not going to get a yes from

[chromium-dev] Re: Build time doubled since May - what gives?

2009-09-24 Thread Jeremy Orlow
Not sure, but it's possible shutting off precompiled headers is part of it. In addition, I'm sure the code base has grown. It'd be interesting to know how many lines of code there are now vs. then. Even if those are major contributors, I'd find it surprising if they were enough to double the

[chromium-dev] Re: Kiosk Mode for Chrome

2009-09-25 Thread Jeremy Orlow
On Fri, Sep 25, 2009 at 5:30 AM, Mohamed Mansour m...@chromium.org wrote: I tried ChromeFrame it is very good, but it doesn't work if the Kiosk Mode flag is set. If the Kiosk mode is set ( iexplorer.exe -k http://www.google.com ) it renders it as IE Renderer. It renders it fine in a Chrome

[chromium-dev] Re: WebKit Hygiene: Please be kind. Test your patches. Warn about two-sided patches.

2009-09-25 Thread Jeremy Orlow
On Fri, Sep 25, 2009 at 10:01 AM, Amanda Walker ama...@chromium.org wrote: On Tue, Sep 22, 2009 at 9:06 PM, Dimitri Glazkov dglaz...@google.comwrote: This all means that we have to be a bit more diligent. We shouldn't be paying these unnecessary costs. So, from now on, I propose a fairly

[chromium-dev] Re: Kiosk Mode for Chrome

2009-09-25 Thread Jeremy Orlow
No objections. I think it's a good idea, you're not the only one who wants this, and it seems like it can be done very cleanly. On Fri, Sep 25, 2009 at 10:47 AM, Adam Barth aba...@chromium.org wrote: On Fri, Sep 25, 2009 at 10:43 AM, Mohamed Mansour m...@chromium.org wrote: I could submit a

[chromium-dev] Re: [DESIGN DOC] registerProtocolHandler HTML5 API

2009-09-25 Thread Jeremy Orlow
If you click no on an info bar, then how would you later change your mind? I really liked the proposal because it'd just always be there. Much like the RSS feed UI. It seems like we can either just keep adding infobars or make an investment in training users what these icons mean. On Fri, Sep

[chromium-dev] Re: gclient hang

2009-09-25 Thread Jeremy Orlow
I updated http://sites.google.com/a/chromium.org/dev/developers/contributing-to-webkit On Fri, Sep 25, 2009 at 12:14 PM, Andrew Scherkus scher...@chromium.orgwrote: For those that use third_party/WebKit as a full WebKit checkout, you'll need to add the following line to your .gclient:

[chromium-dev] Re: [DESIGN DOC] registerProtocolHandler HTML5 API

2009-09-25 Thread Jeremy Orlow
:08 PM, Jeremy Orlow jor...@chromium.orgwrote: If you click no on an info bar, then how would you later change your mind? I don't know. Maybe at that point the icon appears in the address bar. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list

[chromium-dev] Re: Skipping reference_build ?

2009-09-25 Thread Jeremy Orlow
Sounds like we need a presubmit check. On Fri, Sep 25, 2009 at 6:38 AM, Marc-Antoine Ruel mar...@chromium.orgwrote: It's too late for git but not for svn and tarballs. Please move them to DEPS. M-A On Thu, Sep 24, 2009 at 6:26 PM, Evan Martin e...@chromium.org wrote: We have already

[chromium-dev] Re: [DESIGN DOC] registerProtocolHandler HTML5 API

2009-09-25 Thread Jeremy Orlow
On Fri, Sep 25, 2009 at 5:30 PM, Nick Baum nickb...@chromium.org wrote: First of all, thanks for putting together this proposal, great to see progress on this! A few comments: - UI: I prefer the infobar, as per the arguments above. I don't think this will happen frequently enough to

[chromium-dev] Re: Skipping reference_build ?

2009-09-28 Thread Jeremy Orlow
Good point. Done: http://code.google.com/p/chromium/issues/detail?id=23277 On Mon, Sep 28, 2009 at 10:43 AM, Marc-Antoine Ruel mar...@chromium.orgwrote: As usual, please file a feature request unless you plan on doing it, otherwise I'll forget. On Fri, Sep 25, 2009 at 3:59 PM, Jeremy Orlow

[chromium-dev] Re: browser_tests hang on Win7

2009-09-29 Thread Jeremy Orlow
Yeah, the loader lock is held the entire time while in the DLL main. The lock allows re-entrance, but if you do anything that starts another thread and then tries to dynamically load a DLL you'll get a deadlock. Unfortunately, it's very hard to predict what will cause a dynamic load (or one of

[chromium-dev] Re: Try-ing WebKit patches (was WebKit Chromium Port Update Sep 29th)

2009-09-29 Thread Jeremy Orlow
On Tue, Sep 29, 2009 at 12:05 PM, Eric Seidel esei...@chromium.org wrote: On Tue, Sep 29, 2009 at 11:53 AM, Yaar Schnitman y...@chromium.org wrote: 1. An internal webkit chromium port try bot: Will help test webkit-only patches. At first stage, it will test build failures (saving many of

[chromium-dev] Re: Try-ing WebKit patches (was WebKit Chromium Port Update Sep 29th)

2009-09-29 Thread Jeremy Orlow
On Tue, Sep 29, 2009 at 12:52 PM, Jeremy Orlow jor...@chromium.org wrote: On Tue, Sep 29, 2009 at 12:05 PM, Eric Seidel esei...@chromium.orgwrote: On Tue, Sep 29, 2009 at 11:53 AM, Yaar Schnitman y...@chromium.org wrote: 1. An internal webkit chromium port try bot: Will help test webkit

[chromium-dev] Re: WebKit Chromium Port Update Sep 29th

2009-09-29 Thread Jeremy Orlow
That is one of the goals of creating and upstreaming the WebKit API. On Tue, Sep 29, 2009 at 1:01 PM, Evan Martin e...@chromium.org wrote: Q. Does this mean you can build a libwebkit.so independently of Chrome? On Tue, Sep 29, 2009 at 11:53 AM, Yaar Schnitman y...@chromium.org wrote: Hi,

[chromium-dev] Re: Green tree task force: How to try upstream Windows layout tests?

2009-09-29 Thread Jeremy Orlow
This would be a VERY VERY VERY useful feature. Especially if we wanted to open try server access up to other WebKit committers. Many Apple engineers also have difficult testing their patches against Windows and simply commit, watch the WebKit build bots, and iterate. For that matter, having mac

[chromium-dev] Re: Kiosk Mode for Chrome

2009-09-29 Thread Jeremy Orlow
On Tue, Sep 29, 2009 at 4:20 PM, Brett Wilson bre...@chromium.org wrote: On Tue, Sep 29, 2009 at 4:15 PM, Jeremy Orlow jor...@chromium.org wrote: I'm guessing different people/companies will have different needs for a kiosk mode. Maybe all of these should be separate flags rather than one

[chromium-dev] Re: MSVC2005 vs Win7 PlatformSDK

2009-09-30 Thread Jeremy Orlow
I saw this on Vista 64 as well. On Wed, Sep 30, 2009 at 10:39 AM, Stephen White senorbla...@chromium.orgwrote: Just in case someone else runs into this: I recently installed MSVC2005 and the Win7 Platform SDK on my win7/64 machine and it gave me this error at link time:

[chromium-dev] Re: WebKit has a buildbot console view too!

2009-09-30 Thread Jeremy Orlow
S much better than grid view. :-) On Wed, Sep 30, 2009 at 3:49 PM, Adam Barth aba...@chromium.org wrote: Nice! On Wed, Sep 30, 2009 at 3:47 PM, Eric Seidel esei...@chromium.org wrote: Who knew? Looks like Mark (Rowe) recently updated their buildbot:

[chromium-dev] Re: XP Perf page load regression on morejs and moz page cyclers

2009-10-01 Thread Jeremy Orlow
On Thu, Oct 1, 2009 at 12:38 PM, Scott Hess sh...@chromium.org wrote: On Thu, Oct 1, 2009 at 11:32 AM, Mike Belshe mbel...@google.com wrote: On Thu, Oct 1, 2009 at 11:27 AM, Scott Hess sh...@chromium.org wrote: Could we set jemalloc on selected renderer processes? I realize that wouldn't

[chromium-dev] Re: [DESIGN DOC] registerProtocolHandler HTML5 API

2009-10-02 Thread Jeremy Orlow
I totally agree. I envision it being something much more like RSS feeds. In my mind, it should always advertise itself to the browser and then the browser should decide how to advertise it to the user. Requiring scripts to initiate things seems silly to me. Is this API even part of any

[chromium-dev] Re: [DESIGN DOC] registerProtocolHandler HTML5 API

2009-10-02 Thread Jeremy Orlow
On Fri, Oct 2, 2009 at 2:48 PM, Peter Kasting pkast...@google.com wrote: On Fri, Oct 2, 2009 at 2:47 PM, Jeremy Orlow jor...@chromium.org wrote: Is this API even part of any standard? Maybe we should bring this up on WhatWG? The thread title is a clue that these are specced in HTML5

[chromium-dev] Re: [DESIGN DOC] registerProtocolHandler HTML5 API

2009-10-02 Thread Jeremy Orlow
all of this functionality for a site in one shot... e.g. if the site published the data via some kind of link tag then a menu item in the browser might activate that the user could use to activate it. -Ben On Fri, Oct 2, 2009 at 2:55 PM, Jeremy Orlow jor...@chromium.org wrote: On Fri, Oct 2

[chromium-dev] Re: build time speed improvement with solid state drive?

2009-10-05 Thread Jeremy Orlow
On Mon, Oct 5, 2009 at 11:14 AM, Amanda Walker ama...@chromium.org wrote: On Mon, Oct 5, 2009 at 2:08 PM, Marshall Greenblatt magreenbl...@gmail.com wrote: I'm putting together a new computer and I'd like to optimize my chromium build times :-) Is anyone currently building chromium using a

[chromium-dev] Re: Drive Chrome Automation from Outside Browser Process

2009-10-05 Thread Jeremy Orlow
How is this different from ChromeBot? How you control things depends on what level of realism you want. If you're just verifying the sites work correctly, you might just use the code the UI tests use. If you want to actually simulate button clicks and such, then you'll need something more like

[chromium-dev] Re: networking code in src/third_party/WebKit/WebCore/platform/network/mac

2009-10-06 Thread Jeremy Orlow
I'm 99% sure we use what's in third_party On Mon, Oct 5, 2009 at 11:06 PM, hap 497 hap...@gmail.com wrote: Hi, Can you please tell me if chromium on Mac OS X uses the networking code in src/third_party/WebKit/WebCore/platform/network/mac? Or the code there is for Webkit? I asked because

[chromium-dev] Re: Paper about DRAM error rates

2009-10-06 Thread Jeremy Orlow
On Tue, Oct 6, 2009 at 4:59 PM, John Abd-El-Malek j...@chromium.org wrote: On Tue, Oct 6, 2009 at 4:30 PM, Carlos Pizano c...@google.com wrote: On Tue, Oct 6, 2009 at 4:14 PM, John Abd-El-Malek j...@chromium.org wrote: I'm not sure how Carlos is doing it? Will we know if something is

[chromium-dev] Re: detecting tabs using a lot of CPU?

2009-10-07 Thread Jeremy Orlow
Pawel, I was responding to the idea of suspending a tab. I agree that exposing this information to extensions wouldn't be too hard and could be quite useful. On Wed, Oct 7, 2009 at 12:37 PM, Charles Reis cr...@chromium.org wrote: On Wed, Oct 7, 2009 at 12:25 PM, Jeremy Orlow jor

[chromium-dev] Re: Friendly reminder: don't let changes rot

2009-10-08 Thread Jeremy Orlow
Part of this has to do with your level of experience and how big the review is. Doing code reviews for people not yet up to speed is _painful_. And large reviews also can be. I think part of the reason things seem better to you is a reflection on your level of experience. That said, some of us

[chromium-dev] Re: Buildbot upgrade

2009-10-11 Thread Jeremy Orlow
Is there documentation anywhere for all the parameters you can feed into the buildbot webpage? If not, a cheat sheet would be really helpful. On Sat, Oct 10, 2009 at 6:25 PM, Nicolas Sylvain nsylv...@chromium.orgwrote: Hello, Today I upgraded buildbot to the latest version. If you have a

[chromium-dev] Re: Please confirm the bug (some bitmaps aren/t displayed)

2009-10-12 Thread Jeremy Orlow
I think the bigger issue is how/when Area-Misc bugs get triaged. Do they ever? If not, we should probably change that. On Mon, Oct 12, 2009 at 11:50 AM, Guria guria...@gmail.com wrote: Please confirm the bug http://code.google.com/p/chromium/issues/detail?id=12900 It really annoys me. I

[chromium-dev] Is it time to create a SecurityOrigin class in Chromium?

2009-10-14 Thread Jeremy Orlow
Right now, we don't have a good story for what to do with WebCore::SecurityOrigins in Chromium. We now have a WebSecurityOrigin in WebKit, but if you want to move the data between processes, you need to convert it to a string and then send that. In some cases we then convert the string to a

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-14 Thread Jeremy Orlow
::WebSecurityOrigin). We can then deal with these details only if/when we need to. On Wed, Oct 14, 2009 at 1:36 PM, Jeremy Orlow jor...@chromium.org wrote: Right now, we don't have a good story for what to do with WebCore::SecurityOrigins in Chromium. We now have a WebSecurityOrigin in WebKit

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-14 Thread Jeremy Orlow
On Wed, Oct 14, 2009 at 2:23 PM, Darin Fisher da...@chromium.org wrote: On Wed, Oct 14, 2009 at 2:08 PM, Jeremy Orlow jor...@chromium.org wrote: On Wed, Oct 14, 2009 at 2:00 PM, Michael Nordman micha...@google.comwrote: +1 SecurityOrigin class Sounds like a reasonable plan. I suspect

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-14 Thread Jeremy Orlow
On Wed, Oct 14, 2009 at 3:50 PM, Adam Barth aba...@chromium.org wrote: On Wed, Oct 14, 2009 at 2:48 PM, Michael Nordman micha...@google.com wrote: As mentioned f2f, this falls apart as soon as Chrome tries to manufacture a security origin. I'm not sure, may already have instances of that

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-14 Thread Jeremy Orlow
On Wed, Oct 14, 2009 at 2:48 PM, Darin Fisher da...@chromium.org wrote: On Wed, Oct 14, 2009 at 2:47 PM, Darin Fisher da...@chromium.org wrote: On Wed, Oct 14, 2009 at 2:30 PM, Jeremy Orlow jor...@chromium.orgwrote: On Wed, Oct 14, 2009 at 2:23 PM, Darin Fisher da...@chromium.orgwrote

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-14 Thread Jeremy Orlow
On Wed, Oct 14, 2009 at 3:58 PM, Dumitru Daniliuc d...@chromium.org wrote: On Wed, Oct 14, 2009 at 2:47 PM, Darin Fisher da...@chromium.org wrote: On Wed, Oct 14, 2009 at 2:30 PM, Jeremy Orlow jor...@chromium.orgwrote: On Wed, Oct 14, 2009 at 2:23 PM, Darin Fisher da...@chromium.orgwrote

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-14 Thread Jeremy Orlow
On Wed, Oct 14, 2009 at 2:48 PM, Michael Nordman micha...@google.comwrote: On Wed, Oct 14, 2009 at 2:08 PM, Jeremy Orlow jor...@chromium.org wrote: On Wed, Oct 14, 2009 at 2:00 PM, Michael Nordman micha...@google.comwrote: +1 SecurityOrigin class Sounds like a reasonable plan. I suspect

<    1   2   3   >