I'm in the process of updating chromium to use tip-of-tree skia, and in the
same CL, moving skia to a third_party directory, retrieved via DEPS. What
this means for you:
1) Any outstanding CL's in which you've added #include
skia/include/... will have to be changed to the corresponding
path in
On Tue, May 12, 2009 at 5:48 PM, Nicolas Sylvain nsylv...@chromium.orgwrote:
On Tue, May 12, 2009 at 2:22 PM, Stephen White
senorbla...@chromium.orgwrote:
I'm in the process of updating chromium to use tip-of-tree skia, and in
the same CL, moving skia to a third_party directory, retrieved
, Stephen White senorbla...@chromium.orgwrote:
I'm in the process of updating chromium to use tip-of-tree skia, and in the
same CL, moving skia to a third_party directory, retrieved via DEPS. What
this means for you:
1) Any outstanding CL's in which you've added #include
skia/include/... will have
Hi John,
This is likely because skia's dependencies did not get correctly invalidated
after the sync, and you're linking against the old version while compiling
against the new (SkBitmap changed in size). While a clobber build is
safest, you might be able to get away with just
cleaning and
Could we make them TEXTFAIL and IMAGEFAIL, just to be clear?
Stephen
(And then post them to failblog if they're really embarassing.. J/K ;)
On Wed, Sep 23, 2009 at 3:33 PM, Ojan Vafai o...@chromium.org wrote:
+pam, tc, darin in case they disagree with what I'm saying here.
Also a bunch of
tomorrow, unless someone else
would rather do it.
I might actually prefer FAIL-TEXT and FAIL-IMAGE, but that's just me.
I agree that TEXTFAIL is better than TEXT. Anyone else care to express
a preference?
-- Dirk
On Wed, Sep 23, 2009 at 1:50 PM, Stephen White senorbla...@chromium.org
Just in case someone else runs into this: I recently installed MSVC2005 and
the Win7 Platform SDK on my win7/64 machine and it gave me this error at
link time:
shell32.lib(shguid.obj) : fatal error LNK1103: debugging information
corrupt; recompile module
Installing hotfix 949009 (
I see it's now listed as required for MSVC2005 (thanks to whoever updated
the build instructions).
On Wed, Sep 30, 2009 at 1:39 PM, Stephen White senorbla...@chromium.orgwrote:
Just in case someone else runs into this: I recently installed MSVC2005
and the Win7 Platform SDK on my win7/64
I think that's a Release builder, and the tests are marked DEBUG, no?
Stephen
On Fri, Oct 2, 2009 at 12:34 PM, Avi Drissman a...@google.com wrote:
Latest Mac pixel test result is here:
I agree with Dimitri that we're fighting a losing battle here.
In my last stint as gardener, I did informally what I proposed formally last
time: I spent basically 1 full day just triaging failures from my 2 days
gardening. Not fixing, but just running tests locally, analyzing, grouping,
with.
On Tue, Oct 13, 2009 at 11:53 AM, Stephen White
senorbla...@chromium.org
wrote:
I agree with Dimitri that we're fighting a losing battle here.
In my last stint as gardener, I did informally what I proposed
formally
last time: I spent basically 1 full day just triaging failures from
On Tue, Oct 20, 2009 at 1:25 PM, Jeremy Orlow jor...@chromium.org wrote:
On Tue, Oct 20, 2009 at 10:19 AM, David Levin le...@google.com wrote:
That sounds like a reasonable policy.
Hmm...I thought this was the policy. I guess not? :-)
There is the current idea of figuring out something
For the curious, as of WebKit 51800, SVG Filters are enabled by default. In
theory (since this code is cross-platform), this should just require us
turning them on in Chrome, and rebaselining the affected tests (about 24 on
Windows). In practice, however, some of the code behind #if
I put a drive-by comment on the bug, but here's my understanding:
gcc 4.4 now has -fstrict-aliasing on by default, whereas it was off by
default in 4.2.
gcc's behaviour, while annoying, is actually correct in this case: the C++
spec says that pointers to different types may not alias, and gcc
On Wed, Jan 13, 2010 at 12:19 PM, Dan Kegel d...@kegel.com wrote:
On Wed, Jan 13, 2010 at 9:12 AM, Stephen White senorbla...@chromium.org
wrote:
2) Most of the supposed performance advantage of strict aliasing rules
is
probably taken care of by memory disambiguation in modern (ie., Core2
Fix is in as of r36382; reopening.
Stephen
On Fri, Jan 15, 2010 at 1:57 PM, build...@chromium.org wrote:
http://build.chromium.org/buildbot/waterfall/
Automatically closing tree for compile on Chromium Builder
XP Tests clobbered due to .grd changes; should cycle green. Tree reopened
as of r36407.
Stephen
On Fri, Jan 15, 2010 at 4:21 PM, build...@chromium.org wrote:
http://build.chromium.org/buildbot/waterfall/
Automatically closing tree for unit_tests on XP Tests
17 matches
Mail list logo
