Re: [PATCH] Field position attribute handling

Hi Mark, Mark Wielaard wrote: Hi, On Sat, 2003-11-15 at 19:43, Dalibor Topic wrote: 2003-11-15 Guilhem Lavaux [EMAIL PROTECTED] * java/text/FieldPosition.java (field_attribute): New field. (FieldPosition (Format.Field), FieldPosition(Format.Field, int),

Re: [PATCH] Field position attribute handling

On Tue, Nov 18, 2003 at 08:30:44PM +0100, Dalibor Topic wrote: 2003-11-18 Guilhem Lavaux [EMAIL PROTECTED] * java/text/FieldPosition.java (field_attribute): New field. (FieldPosition (Format.Field), FieldPosition(Format.Field, int), getFieldAttribute) New methods. 2003-11-18

Re: [PATCH] Field position attribute handling

Michael Koch wrote: On Tue, Nov 18, 2003 at 08:30:44PM +0100, Dalibor Topic wrote: 2003-11-18 Guilhem Lavaux [EMAIL PROTECTED] * java/text/FieldPosition.java (field_attribute): New field. (FieldPosition (Format.Field), FieldPosition(Format.Field, int), getFieldAttribute) New methods.

Re: [PATCH] Field position attribute handling

Hi, On Tue, 2003-11-18 at 20:30, Dalibor Topic wrote: * liThe specified object is an instance of codeFieldPosition/code. - * liThe specified object has the same field identifier and beginning - * and ending index as this object. + * liThe specified object has the same field

[PATCH] text layout implementation

hi, this patch implements simple awt text layouts using attributed strings and j2d glyph vectors. it will probably need further work, but it is enough to get the swing text system limping along. -graydon 2003-11-18 Graydon Hoare [EMAIL PROTECTED] * java/awt/font/TextLayout.java:

[PATCH] swing frame fixes

hi, this patch implements JLayeredPane and makes some minor adjustments to JFrame and JRootPane. -graydon 2003-11-18 Graydon Hoare [EMAIL PROTECTED] * javax/swing/JLayeredPane.java: Implement. * javax/swing/JFrame.java (getContentPane): Make public *

Re: [PATCH] attributed string fixes

graydon == graydon hoare [EMAIL PROTECTED] writes: graydon 2003-11-18 Graydon Hoare [EMAIL PROTECTED] graydon* java/text/AttributedString.java: Fix arithmetic. graydon* java/text/AttributedStringIterator.java: Likewise. Looks good, please commit. Actually, could you update the

Re: [PATCH] Field position attribute handling

Dalibor == Dalibor Topic [EMAIL PROTECTED] writes: Dalibor -if (! (obj instanceof FieldPosition)) Dalibor +if (this == obj) Dalibor + return true; Dalibor + Dalibor +if (obj != null (obj.getClass() != this.getClass())) Daliborreturn false; I think this should read:

Re: [PATCH] text layout implementation

graydon == graydon hoare [EMAIL PROTECTED] writes: graydon this patch implements simple awt text layouts using attributed strings graydon and j2d glyph vectors. it will probably need further work, but it is graydon enough to get the swing text system limping along. If you know of specific

Re: [PATCH] various graphics2d fixes

graydon == graydon hoare [EMAIL PROTECTED] writes: graydon these are just miscellaneous fixes which have accumulated to the graydon graphics2d implementation I did atop cairo. nothing revolutionary, graydon just a lot of minor fixups, so I bundled them up here in one graydon patch. changes to

Re: [PATCH] swing frame fixes

graydon == graydon hoare [EMAIL PROTECTED] writes: graydon 2003-11-18 Graydon Hoare [EMAIL PROTECTED] graydon* javax/swing/JLayeredPane.java: Implement. graydon* javax/swing/JFrame.java (getContentPane): Make public graydon* javax/swing/javax/swing/JRootPane.java

Re: [PATCH] Field position attribute handling

Hi Mark, Mark Wielaard wrote: The documentation and code don't match up now. My Class Library book seems to indicate that it actually is instanceof, thought in most cases your code comparing the actual Class seems more correct. It's the recommended way of doing equals() if you want to avoid

Re: [PATCH] Field position attribute handling

Hi Tom, Tom Tromey wrote: Dalibor == Dalibor Topic [EMAIL PROTECTED] writes: Dalibor -if (! (obj instanceof FieldPosition)) Dalibor +if (this == obj) Dalibor + return true; Dalibor + Dalibor +if (obj != null (obj.getClass() != this.getClass())) Daliborreturn false; I