Re: [PATCH] Compliance of DecimalFormatSymbols

Hi, On Sat, 2003-11-22 at 00:39, Dalibor Topic wrote: Here is an adaptation of the former patch concerning java/text. This one is small and concerns only java/text/DecimalFormatSymbols. According to the official specification, if the serial version is greater than 2, you have to read the

Re: [PATCH] Two methods for NumberFormat

Hi Guilhem, On Fri, 2003-11-21 at 21:34, Guilhem Lavaux wrote: I am continuing the series of patches with that one, it adds two methods to NumberFormat: getIntegerInstance() and getIntegerInstance(Locale). They have to be implemented according to Java 1.4. Thanks for splitting this up in

Re: new jalopy available

Hi, On Fri, 2003-11-21 at 23:06, Raif S. Naffah wrote: jalopy is able to handle grouping, and sorting, of class elements (e.g.static field and initialisers, instance fields, constructors, etc...) and separating them with a 1-line separator (2 with a blank line followup). how (strongly)

RE: [PATCH] Fix for Hashtable contains blowing up the stack

Hi, On Sat, 2003-11-22 at 13:06, Jeroen Frijters wrote: The fix is actually incorrect. containsValue() should call contains() because containsValue() is a new method (since 1.2) and contains() exists since 1.0. Older code may have overridden contains() and this should work with newer code

Re: new jalopy available

I've noticed two general styles of 'sorting' in Classpath sources. Both styles separate the metadata types (all fields are listed, followed by member classes, constructors, methods). Within those groupings, one style sorts all methods alphabetically, and the other sorts methods according to

Re: [PATCH] Two methods for NumberFormat

Mark Wielaard wrote: Hi Guilhem, On Fri, 2003-11-21 at 21:34, Guilhem Lavaux wrote: I am continuing the series of patches with that one, it adds two methods to NumberFormat: getIntegerInstance() and getIntegerInstance(Locale). They have to be implemented according to Java 1.4. Thanks

Re: [PATCH] Compliance of DecimalFormatSymbols

Mark Wielaard wrote: At your service! - ChangeLog entries should start with: date two spaces Name two spaces email. - Just one space between filename and (field/method) - Entries are full sentences with starting capital and ending dot. 2003-11-21 Guilhem Lavaux [EMAIL PROTECTED] *

Re: new jalopy available

Michael Koch wrote: Serializable classes have to have their fields in the same order as in in SUNs classes because of serialization issues. I thought we already had the style rule that all serialized classes provide an explicit serialVersionUID - because we cannot depend on the compiler to

Re: [PATCH] Two methods for NumberFormat

Hi, On Sat, 2003-11-22 at 15:38, Guilhem Lavaux wrote: (I would like to see us not use a space between the method and the bracket beginning the argument list. But this class already had that and jalopy will hopefully catch all this in the future for us.) I've just made a probabilistic

Re: new jalopy available

On Sat, Nov 22, 2003 at 07:57:55AM -0700, Eric Blake wrote: Michael Koch wrote: Serializable classes have to have their fields in the same order as in in SUNs classes because of serialization issues. I thought we already had the style rule that all serialized classes provide an explicit

Re: new jalopy available

Hi, On Sat, 2003-11-22 at 15:45, Michael Koch wrote: Serializable classes have to have their fields in the same order as in in SUNs classes because of serialization issues. I didn't know that. What are the problems precisely? For calculation of the stream unique identifiers (serialVersionUIDs)