Re: Support for installation of glibj.zip and separate class files

2004-04-09 Thread Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Perhaps a better interface (more intuitive) would be something like this: - --enable-install=[both|classes|zip] On Thursday 08 April 2004 22:36, Michael Koch wrote: Hi all, With my big NIO commit I accidently commited the first part (the parts

RE: Classpath build process and VM-specific issues

2004-04-09 Thread Jeroen Frijters
Etienne Gagnon wrote: Jeroen Frijters wrote: Indeed. The goal is to find the optimal solution that would be spec compliant, portable and efficient. and later: I'm not the one nitpicking about pure ISO C portability (I don't use JNI, so I couldn't care less), ... and later: and is of

RE: Classpath build process and VM-specific issues

2004-04-09 Thread Jeroen Frijters
Archie Cobbs wrote: Note: by this logic byte[] is the most portable/generic way to hold VM private data. It places no portability restrictions, only (possibly) performance ones. However, I have yet to hear a convincing argument that proves byte[] is slower than RawData (or whatever) on ALL

RE: Classpath build process and VM-specific issues

2004-04-09 Thread Jeroen Frijters
Steven Augart wrote: If we were to do this in the GNU Classpath Java code, then the only solution I see is to use a preprocessor, and expand gpointer to an int or long as appropriate, based upon the standard pointer representation in that platform's usual ABI. That wouldn't work for me.

RE: Classpath build process and VM-specific issues

2004-04-09 Thread Jeroen Frijters
Stuart Ballard wrote: 2) Unusual VMs: Things where JNI-centric assumptions don't hold true. For example, IKVM and Jaos(?) don't use JNI at all within Classpath, and their natural pointer type is just a normal object reference. gcj with CNI also falls into this category. I'd like to

Re: Classpath build process and VM-specific issues

2004-04-09 Thread Steven Augart
If the RawData type were to be used, would you be able to share a Classpath installation with other Classpath-based virtual machines? --Steve Augart Jeroen Frijters wrote: Steven Augart wrote: If we were to do this in the GNU Classpath Java code, then the only solution I see is to use a

RE: Classpath build process and VM-specific issues

2004-04-09 Thread Jeroen Frijters
Steven Augart wrote: If the RawData type were to be used, would you be able to share a Classpath installation with other Classpath-based virtual machines? For some purposes yes. For performance (and some bootstrapping) reasons I compile Classpath code ahead of time to a CLI assembly, so at

RE: The big NIO

2004-04-09 Thread Jeroen Frijters
Michael Koch wrote: I just commited my big NIO patch. I doesnt contain yet anything from the big pointer discussion. It is just a merge from libgcj. It reworks java.io file operations to use java.nio.channels internally for performance. I have done a full mauve run and found no new strange

Re: The Mauve unicode testcase and VM performance

2004-04-09 Thread Stephen Crawley
Hi Guilhelm, Thanks for the info. Your numbers tend to confirm my suspicion that the factor of 200 is a Kissme-specific problem. In the meantime, I think I have come across a problem in Kissme's implementation of the CONSTANT_STRING instruction that does some way towards explaining this. --

Re: Patch: remove C++ keywords

2004-04-09 Thread Eric Blake
Tom Tromey wrote: My only comment or criticism is that, in the absence of regular checking for this, we'll just see more code like it checked in. That's been the experience with non-C89 constructs, I don't see why this would be any different. It's just too hard to remember to write in some

RE: FileDescriptor patch

2004-04-09 Thread Jeroen Frijters
Michael Koch wrote: Am Freitag, 9. April 2004 15:38 schrieb Jeroen Frijters: Hi, If there aren't any objections, I'll commit the attached fix. Why do you need this ? Is this for network related stuff ? No, FileDescriptor is documented to have a public constructor. I don't see the point

Re: FileDescriptor patch

2004-04-09 Thread Michael Koch
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am Freitag, 9. April 2004 15:38 schrieb Jeroen Frijters: Hi, If there aren't any objections, I'll commit the attached fix. Why do you need this ? Is this for network related stuff ? Michael - -- Homepage: http://www.worldforge.org/ -BEGIN

Re: FileDescriptor patch

2004-04-09 Thread Michael Koch
Am Freitag, 9. April 2004 16:27 schrieb Jeroen Frijters: Michael Koch wrote: Am Freitag, 9. April 2004 15:38 schrieb Jeroen Frijters: Hi, If there aren't any objections, I'll commit the attached fix. Why do you need this ? Is this for network related stuff ? No, FileDescriptor is

Re: The big NIO

2004-04-09 Thread Michael Koch
Am Freitag, 9. April 2004 15:24 schrieb Jeroen Frijters: Michael Koch wrote: I just commited my big NIO patch. I doesnt contain yet anything from the big pointer discussion. It is just a merge from libgcj. It reworks java.io file operations to use java.nio.channels internally for

FYI: Patch: URLConnection

2004-04-09 Thread Jeroen Frijters
Hi, Committed. Regards, Jeroen 2004-04-09 Jeroen Frijters [EMAIL PROTECTED] * java/net/URLConnection.java: (setContentHandlerFactory): Fixed to check static field instead of argument. Index: java/net/URLConnection.java

Re: FYI: Patch: URLConnection

2004-04-09 Thread Michael Koch
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am Freitag, 9. April 2004 16:47 schrieb Jeroen Frijters: @@ -872,7 +872,7 @@ */ public static synchronized void setContentHandlerFactory(ContentHandlerFactory factory) { -if (factory != null) +if (URLConnection.factory !=

RE: FYI: Patch: URLConnection

2004-04-09 Thread Jeroen Frijters
Michael Koch wrote: Am Freitag, 9. April 2004 16:47 schrieb Jeroen Frijters: @@ -872,7 +872,7 @@ */ public static synchronized void setContentHandlerFactory(ContentHandlerFactory factory) { -if (factory != null) +if (URLConnection.factory != null) throw

Re: Patch: remove C++ keywords

2004-04-09 Thread Thomas Zander
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thats a hack; its dirty and its non-intuitive. I'd advice against that. What about having a source formatter that checks this? A make check seems like a good candidate to report warnings like these. On Friday 09 April 2004 15:49, Eric Blake wrote:

Re: Patch: remove C++ keywords

2004-04-09 Thread Steven Augart
Tom Tromey wrote: [...] A third option would be for you to periodically try it out and check in patches like the one you sent :-). Assuming the other developers are ok with this, it wouldn't be unreasonable, just a bit messy. This seems like the best way to handle the situation. I have a minor

Re: Support for installation of glibj.zip and separate class files

2004-04-09 Thread C. Brian Jones
On Thu, 2004-04-08 at 16:36, Michael Koch wrote: Hi all, With my big NIO commit I accidently commited the first part (the parts in configure.ac) for this patch and so I decided to commit it fully. We now have two options for installing our classes --enable-glibj installs glibj.zip

Re: Classpath build process and VM-specific issues

2004-04-09 Thread Per Bothner
Etienne Gagnon wrote: I am starting to have difficulty understanding Classpath's goals and motivations. When I proposed to add to Classpath some mechanism to allow it to be customized to each VM, I was told that it would be a heresy to encode any VM-specific thing into Classpath, as the

Re: Support for installation of glibj.zip and separate class files

2004-04-09 Thread Robert Lougher
Brian, I think you're thinking of --without-zip? This option still exists, but it hasn't seemed to work since classpath 0.05... Rob. Original Message Follows From: C. Brian Jones [EMAIL PROTECTED] Reply-To: [EMAIL PROTECTED] To: Michael Koch [EMAIL PROTECTED] CC: [EMAIL PROTECTED]