[cp-patches] FYI: JTable fixes

2005-11-21 Thread Roman Kennke
Hi, I fixed a bug in the JTable and its UI implementation. The UI should actually call JTable.prepareRenderer() to prepare the cell renderer, instead of preparing the renderer in the UI. Also I removed some unused code that was pointed out by Eclipse. 2005-11-21 Roman Kennke [EMAIL PROTECTED]

Re: [cp-patches] FYI: JViewport system property

2005-11-21 Thread Roman Kennke
Hi Mark, Am Samstag, den 19.11.2005, 20:04 +0100 schrieb Mark Wielaard: On Tue, 2005-11-15 at 21:23 +0100, Mark Wielaard wrote: On Tue, 2005-11-15 at 14:16 +, Roman Kennke wrote: 2005-11-15 Roman Kennke [EMAIL PROTECTED] * javax/swing/JViewport.java

Re: [cp-patches] FYI: RepaintManager fix

2005-11-21 Thread Roman Kennke
Am Samstag, den 19.11.2005, 19:09 +0100 schrieb Mark Wielaard: Hi Roman, On Mon, 2005-11-14 at 12:52 +, Roman Kennke wrote: + /** + * The current repaint managers, indexed by their ThreadGroups. + */ + static HashMap currentRepaintManagers; Isn't this a potential memory

[cp-patches] FYI: patch for DefaultEditorKit fixes PR 24925

2005-11-21 Thread Anthony Balkissoon
This patch fixes bug 24925 by not inserting text into a text component that is either disabled or uneditable. Also, when a key is typed, instead of calling insertString, we should be calling replaceSelection. Fixed. 2005-11-21 Anthony Balkissoon [EMAIL PROTECTED] Fixes bug #24925

Re: [cp-patches] FYI: JViewport system property

2005-11-21 Thread Roman Kennke
I forgot the actual patch. Here it comes now. /Roman Am Montag, den 21.11.2005, 14:34 +0100 schrieb Roman Kennke: Hi Mark, Am Samstag, den 19.11.2005, 20:04 +0100 schrieb Mark Wielaard: On Tue, 2005-11-15 at 21:23 +0100, Mark Wielaard wrote: On Tue, 2005-11-15 at 14:16 +, Roman

Re: [cp-patches] FYI: RepaintManager fix

2005-11-21 Thread Roman Kennke
I forgot the patch. Here it comes now. /Roman Am Montag, den 21.11.2005, 15:02 +0100 schrieb Roman Kennke: Am Samstag, den 19.11.2005, 19:09 +0100 schrieb Mark Wielaard: Hi Roman, On Mon, 2005-11-14 at 12:52 +, Roman Kennke wrote: + /** + * The current repaint managers,

[cp-patches] An imageio/ImageDecoder hack

2005-11-21 Thread Mark Wielaard
Hi list, Hi Tom, While playing a bit with Caliph Emir I found that our imageio and ImageDecoder/GdkPixBufDecoder don't play well. The attached patch is a quick hack to make the Emir splash-screen show up. Should I make a real/full DataInputStreamWrapper to make a bridge between the two or will

[cp-patches] Re: An imageio/ImageDecoder hack

2005-11-21 Thread Thomas Fitzsimmons
On Mon, 2005-11-21 at 21:30 +0100, Mark Wielaard wrote: Hi list, Hi Tom, While playing a bit with Caliph Emir I found that our imageio and ImageDecoder/GdkPixBufDecoder don't play well. The attached patch is a quick hack to make the Emir splash-screen show up. Should I make a real/full

[cp-patches] RFC: BasicComboBoxUI minimum size caching

2005-11-21 Thread Mark Wielaard
Hi, Some more hacking on Free Swing (this stuff really seems to work for a lot of things now!). Emir uses something called the plastic theme. It seems to use the BasicComboBoxUI protected fields that cache the minimum size. So I implemented them and wrote some documentation on how I think they

Re: [cp-patches] RFC: GdkGraphics fix

2005-11-21 Thread Lillian Angel
On Mon, 2005-11-21 at 15:46 -0500, Thomas Fitzsimmons wrote: On Mon, 2005-11-21 at 14:33 -0500, Lillian Angel wrote: This fixes bug # 24937 I spoke in detail to Roman about this. drawString(String...) was changed to call drawString(AttributedCharacterIterator...) because they both need

[cp-patches] Patch: Text Component key bindings

2005-11-21 Thread Lillian Angel
Cut, Copy, Paste, selection forward, selection backward actions now work for text components. 2005-11-21 Lillian Angel [EMAIL PROTECTED] PR classpath/PR24872 * javax/swing/text/DefaultEditorKit.java (actionPerformed): Implemented. (actionPerformed): Implemented.

Re: [cp-patches] RFC: BasicComboBoxUI minimum size caching

2005-11-21 Thread Roman Kennke
Hi Mark, hi list, Some more hacking on Free Swing (this stuff really seems to work for a lot of things now!). Emir uses something called the plastic theme. It seems to use the BasicComboBoxUI protected fields that cache the minimum size. So I implemented them and wrote some documentation on

Re: [cp-patches] RFC: BasicComboBoxUI minimum size caching

2005-11-21 Thread Mark Wielaard
Hi Roman, On Mon, 2005-11-21 at 22:23 +0100, Roman Kennke wrote: Looks ok. Except that the cache is possibly invalidated a little too often. I would think that the focus state doesn't change the minimumSize. Also, the general propertyChange() invalidation is maybe not good. But still ok to

[cp-patches] FYI: JTable propertyChange for non-null header

2005-11-21 Thread Mark Wielaard
Hi, We were trying the resize the JTable header even when there was none. This fixes that. 2005-11-21 Mark Wielaard [EMAIL PROTECTED] * javax/swing/JTable.java (propertyChange): Only resize header when not null. This get Caliph Emir again a bit further. I will commit this. Cheers,

Re: [cp-patches] FYI: GdkGraphics fix

2005-11-21 Thread Lillian Angel
This has been approved by Tom and Roman. I re-implemented this to just use replaceAll. I know it is sometimes inefficent, so I added a FIXME. 2005-11-21 Lillian Angel [EMAIL PROTECTED] PR classpath/PR24937 * gnu/java/awt/peer/gtk/GdkGraphics.java (drawString): Removed

[cp-patches] Re: An imageio/ImageDecoder hack

2005-11-21 Thread Mark Wielaard
Hi, On Mon, 2005-11-21 at 15:37 -0500, Thomas Fitzsimmons wrote: I expect that GdkPixbufDecoder will go away with the GTK2.8/Cairo/Graphics2D migration, so I wouldn't bother. I just checked in this little workaround then as is. It is a bit lame and slow, but at least it works and it shouldn't

Re: [cp-patches] FYI: GdkGraphics fix

2005-11-21 Thread Mark Wielaard
Hi Lilian, On Mon, 2005-11-21 at 17:11 -0500, Lillian Angel wrote: I re-implemented this to just use replaceAll. I know it is sometimes inefficent, so I added a FIXME. This is really, really inefficient. +// FIXME: Possibly more characters we need to ignore/ +// Also,

[cp-patches] RFC: some missing DeleteLocalRef patches

2005-11-21 Thread Christian Thalinger
Hi! These are some patches for missing DeleteLocalRef calls i've found with CACAO. Are they ok? It seems so to me. Should i search for more stuff like that? TWISTI Index: native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphicsEnvironment.c

[cp-patches] RFC: BasicTabbedPaneUI paint null Icon?

2005-11-21 Thread Mark Wielaard
Hi, This one is a little strange. Apparently the plastic laf overrides getIconForTab(int) and returns null in certain cases. But then it still calls paintIcon on it. I cannot find too much documentation on this, but this seems the correct thing to do: 2005-11-21 Mark Wielaard [EMAIL PROTECTED]

[cp-patches] Comparable in java.util.Calendar

2005-11-21 Thread Kendall Bell
2005-11-21 Kendall Bell [EMAIL PROTECTED] * java/util/Calendar.java: Implemented Comparable. /* Calendar.java -- Copyright (C) 1998, 1999, 2000, 2001, 2002, 2004, 2005 Free Software Foundation, Inc. This file is part of GNU Classpath. GNU Classpath is free software; you can

Comparable in java.util.Calendar

2005-11-21 Thread Kendall Bell
I would like to implement Comparable in java.util.Calendar.java. I fell that this is necessary for compatibility with other JRE's. Kendall Bell begin:vcard fn:Kendall Bell n:Bell;Kendall email;internet:[EMAIL PROTECTED] x-mozilla-html:FALSE version:2.1 end:vcard

Re: Comparable in java.util.Calendar

2005-11-21 Thread Stephen Crawley
Kendall Bell wrote: I would like to implement Comparable in java.util.Calendar.java. I fell that this is necessary for compatibility with other JRE's. Kendall Bell Which other JRE's are you talking about? For the record, java.util.Calendar does NOT implement Comparable in the JDK 1.4.2.

Re: Comparable in java.util.Calendar

2005-11-21 Thread Mark Wielaard
Hi Kendall, On Mon, 2005-11-21 at 17:15 -0600, Kendall Bell wrote: I would like to implement Comparable in java.util.Calendar. That seems like a nice start for a 1.5 addition. Please follow the Hacking Guide for some general instructions and post a patch to classpath-patches plus ChangeLog

[commit-cp] classpath ./ChangeLog javax/swing/JViewport.java

2005-11-21 Thread Roman Kennke
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Roman Kennke [EMAIL PROTECTED]05/11/21 13:33:06 Modified files: . : ChangeLog javax/swing: JViewport.java Log message: 2005-11-21 Roman Kennke [EMAIL

[commit-cp] classpath javax/swing/JTable.java javax/swing/p...

2005-11-21 Thread Roman Kennke
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Roman Kennke [EMAIL PROTECTED]05/11/21 13:18:30 Modified files: javax/swing: JTable.java javax/swing/plaf/basic: BasicTableUI.java . : ChangeLog Log

[commit-cp] classpath ./ChangeLog javax/swing/RepaintManage...

2005-11-21 Thread Roman Kennke
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Roman Kennke [EMAIL PROTECTED]05/11/21 14:01:43 Modified files: . : ChangeLog javax/swing: RepaintManager.java Log message: 2005-11-21 Roman Kennke

[commit-cp] classpath ./ChangeLog javax/swing/JTable.java

2005-11-21 Thread Mark Wielaard
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Mark Wielaard [EMAIL PROTECTED] 05/11/21 22:03:17 Modified files: . : ChangeLog javax/swing: JTable.java Log message: * javax/swing/JTable.java

[commit-cp] classpath ./ChangeLog java/awt/datatransfer/Dat...

2005-11-21 Thread Jan Roehrich
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Jan Roehrich [EMAIL PROTECTED]05/11/21 22:17:42 Modified files: . : ChangeLog java/awt/datatransfer: DataFlavor.java Log message: 2005-11-21 Jan Roehrich