Re: [cp-patches] Patch: Opening RandomAccessFiles requires excessive permission

2005-12-06 Thread Christian Thalinger
On Mon, 2005-12-05 at 14:42 +, Gary Benson wrote: public void write (int oneByte) throws IOException { +if (out == null) + throw new IOException(Bad file descriptor); + out.write(oneByte); I don't know if this is performance critical code or is used very often, but

[cp-patches] Patch: fix Float/DoubleBuffer.compareTo in the presence of NaN

2005-12-06 Thread Anthony Green
This patch makes sure FloatBuffer and DoubleBuffer objects compare properly when they contain NaN values. I've already checked in Mauve tests cases. Ok to commit? AG 2005-12-06 Anthony Green [EMAIL PROTECTED] * java/nio/DoubleBuffer.java (compareTo): Handle NaN values within

[cp-patches] FYI: ViewportLayout fix

2005-12-06 Thread Roman Kennke
Hi, This is a small fix for the ViewportLayout. As it was before, the layout manager sets the size for the view to it's minimum when the port is smaller thant the view. This can't be correct. To be honest, I think it still isn't correct now, I don't have time to investigate more atm and it seems

Re: [cp-patches] [generics] RFC: fix generics branch compilation on Darwin

2005-12-06 Thread Archie Cobbs
Casey Marshall wrote: This puts the 'environ' declaration/define in jcl.h; I hope this is OK, it looks like the best place for a global thing like this. What you have now results in a duplicate declaration of environ on systems that already declare environ in unistd.h (or wherever), but don't

Re: [cp-patches] Patch: Opening RandomAccessFiles requires excessive permission

2005-12-06 Thread Archie Cobbs
Christian Thalinger wrote: I don't know if this is performance critical code or is used very often, but this seems to be a special case and i'd suggest something like: public void write (int oneByte) throws IOException { try { out.write(oneByte); return; } catch

[cp-patches] FYI: Container fixlet

2005-12-06 Thread Roman Kennke
Mark pointed out that my fix from 2005-11-17 Roman Kennke [EMAIL PROTECTED] * java/awt/Container.java (Container): Added comment. (remove): Only call removeNotify if removed component is still showing. (paintComponents): Call paint() instead of

[cp-patches] FYI: JComponent fixlet

2005-12-06 Thread Roman Kennke
I removed an unneeded warning in JComponent. We used to print out this warning when a component has no UI installed. This probably was useful in the early days when some components didn't have a UI class yet or something like that. Today such a warning is completely superfluous and confuses some

Re: [cp-patches] Patch: fix Float/DoubleBuffer.compareTo in the presence of NaN

2005-12-06 Thread Tom Tromey
Anthony == Anthony Green [EMAIL PROTECTED] writes: Anthony This patch makes sure FloatBuffer and DoubleBuffer objects compare Anthony properly when they contain NaN values. I've already checked in Mauve Anthony tests cases. Ok to commit? Does it do the right thing if a is NaN and b is not?

Re: [cp-patches] Patch: Add security check to Class.getClasses()

2005-12-06 Thread Tom Tromey
Gary == Gary Benson [EMAIL PROTECTED] writes: Gary Class.getClasses() was not performing the member access checks like it Gary ought. The attached patch fixes. I'm working on mauve tests for all Gary of Class's security calls so there will be a check for this issue Gary soonish.

Re: [cp-patches] Patch: Opening RandomAccessFiles requires excessive permission

2005-12-06 Thread Christian Thalinger
On Tue, 2005-12-06 at 10:00 -0600, Archie Cobbs wrote: That's getting into the micro-optimzation realm, which is fraught with danger and mistaken assumptions :-) E.g., on some machines the time overhead of setting up a try/catch in a method that wouldn't otherwise have one is higher than the

RE: [cp-patches] RFC: StringIndexOutOfBoundsException fixes inString contructors

2005-12-06 Thread Christian Thalinger
On Wed, 2005-11-02 at 12:50 +0100, Jeroen Frijters wrote: Christian Thalinger wrote: +if (offset + count 0 || offset + count ascii.length) You can write this more efficiently as: if (ascii.length - offset count) (This assumes that offset and count have previously been

Re: [cp-patches] FYI: Container fixlet

2005-12-06 Thread Roman Kennke
Hi Mark, Am Dienstag, den 06.12.2005, 18:49 +0100 schrieb Mark Wielaard: Hi Roman, On Tue, 2005-12-06 at 16:25 +, Roman Kennke wrote: 2005-12-06 Roman Kennke [EMAIL PROTECTED] PR classpath/25256 * java/awt/Container.java

Re: [cp-patches] Patch: Opening RandomAccessFiles requires excessive permission

2005-12-06 Thread Archie Cobbs
Christian Thalinger wrote: That's getting into the micro-optimzation realm, which is fraught with danger and mistaken assumptions :-) E.g., on some machines the time overhead of setting up a try/catch in a method that wouldn't otherwise have one is higher than the single comparison required to

Re: [cp-patches] Patch: Opening RandomAccessFiles requires excessive permission

2005-12-06 Thread David Daney
Christian Thalinger wrote: On Tue, 2005-12-06 at 10:00 -0600, Archie Cobbs wrote: That's getting into the micro-optimzation realm, which is fraught with danger and mistaken assumptions :-) E.g., on some machines the time overhead of setting up a try/catch in a method that wouldn't otherwise

Re: [cp-patches] Patch: Opening RandomAccessFiles requires excessive permission

2005-12-06 Thread Christian Thalinger
On Tue, 2005-12-06 at 13:32 -0600, Archie Cobbs wrote: You say the generated code is smaller but that depends on who generates the code (if you mean the generated Java bytecode, I'd guess you're wrong there too because of the extra exception table required). And that depends on which VM you're

[cp-patches] Patch: BoxLayout fix

2005-12-06 Thread Anthony Balkissoon
2005-12-06 Anthony Balkissoon [EMAIL PROTECTED] Fixes bug #25233 * javax/swing/BoxLayout.java: (maximumLayoutSize): Don't add the Insets to the Dimension calculated in checkTotalRequirements(). ___ Classpath-patches

[cp-patches] Patch: BoxLayout fix

2005-12-06 Thread Anthony Balkissoon
This patch fixes PR 25233. 2005-12-06 Anthony Balkissoon [EMAIL PROTECTED] Fixes bug #25233 * javax/swing/BoxLayout.java: (maximumLayoutSize): Don't add the Insets to the Dimension calculated in checkTotalRequirements(). --Tony Index:

Re: [cp-patches] Patch: Opening RandomAccessFiles requires excessive permission

2005-12-06 Thread Archie Cobbs
Christian Thalinger wrote: what i'm trying to say is, if we ever want to catch up (or even be better) than sun or other proprietary JVMs, we should think about optimizing some core functions in classpath... I definitely agree there. -Archie

Re: [cp-patches] Patch: Opening RandomAccessFiles requires excessive permission

2005-12-06 Thread Tom Tromey
Twisti == Christian Thalinger [EMAIL PROTECTED] writes: Twisti Yeah, i didn't take it personally :-) Of course i see your point, but Twisti what i'm trying to say is, if we ever want to catch up (or even be Twisti better) than sun or other proprietary JVMs, we should think about Twisti

Re: [cp-patches] Patch: BoxLayout fix

2005-12-06 Thread Anthony Balkissoon
I reverted this patch because it caused a Mauve regression. I'll have to write more tests and figure out what was wrong. regression: gnu.testlet.javax.swing.BoxLayout.maximumLayoutSize On Tue, 2005-12-06 at 14:52 -0500, Anthony Balkissoon wrote: This patch fixes PR 25233. 2005-12-06

[cp-patches] FYI: GridBagLayout.ArrangeGrid fix

2005-12-06 Thread Thomas Fitzsimmons
Hi, An application I was running exposed a crash in GridBagLayout.ArrangeGrid. I committed this fix. Tom 2005-12-06 Thomas Fitzsimmons [EMAIL PROTECTED] * java/awt/GridBagLayout.java (ArrangeGrid): Use info rather than layoutInfo in the component for loop. Cache layout

Re: [cp-patches] Patch: BoxLayout fix

2005-12-06 Thread Anthony Balkissoon
On Tue, 2005-12-06 at 15:58 -0500, Anthony Balkissoon wrote: I reverted this patch because it caused a Mauve regression. I'll have to write more tests and figure out what was wrong. regression: gnu.testlet.javax.swing.BoxLayout.maximumLayoutSize Okay, here's the new patch. It doesn't

Re: [cp-patches] FYI: Container fixlet

2005-12-06 Thread Mark Wielaard
[Sorry for the duplicate message, trouble with my primary email account] Hi Roman, On Tue, 2005-12-06 at 16:25 +, Roman Kennke wrote: 2005-12-06 Roman Kennke [EMAIL PROTECTED] PR classpath/25256 * java/awt/Container.java

[cp-patches] FYI: LookAndFeel.toString() fixlet

2005-12-06 Thread Mark Wielaard
Hi, Riccardo reported a bug off list about code that tried to parse the LookAndFeel.toString() result to find the actual Class name of the LookAndFeel subclass. Although this is highly questionable the big Swing book does indeed that toString() returns a string based on the description and class

[cp-patches] [generics] Patch: FYI: more genericization

2005-12-06 Thread Tom Tromey
I'm checking this in on the generics branch. Even more genericization that I somehow missed earlier. I really suspect japi is just feeding me methods and classes piecemeal somehow :-) This one includes some real bug fixes in javax.imageio. An earlier patch I made to ImageIO was in error, so I

[cp-patches] [generics] Patch: FYI: more genericization

2005-12-06 Thread Tom Tromey
I'm checking this in on the generics branch. This adds generics in to javax.security.auth.Subject. I think this covers everything in the japi report as of today (with a minor exception java.util; and it is a bit hard to be 100% sure as some of the things in the report have been fixed for a few

Re: [cp-patches] FYI: LookAndFeel.toString() fixlet

2005-12-06 Thread Tom Tromey
Mark == Mark Wielaard [EMAIL PROTECTED] writes: Mark Riccardo reported a bug off list about code that tried to parse the Mark LookAndFeel.toString() result to find the actual Class name of the Mark LookAndFeel subclass. Although this is highly questionable It would be nice if we had a

Re: [cp-patches] Patch: fix Float/DoubleBuffer.compareTo in the presence of NaN

2005-12-06 Thread Anthony Green
On Tue, 2005-12-06 at 11:12 -0700, Tom Tromey wrote: Anthony == Anthony Green [EMAIL PROTECTED] writes: Anthony This patch makes sure FloatBuffer and DoubleBuffer objects compare Anthony properly when they contain NaN values. I've already checked in Mauve Anthony tests cases. Ok to

RFC: merging GNU Crypto and Jessie

2005-12-06 Thread Casey Marshall
A few of us have been throwing around the idea of merging GNU Crypto and Jessie into GNU Classpath, so Classpath will have full support for crypto and SSL out of the box. We've proposed this before, and I think this idea was mostly approved by the group, but no-one ever got around to doing

Re: Free Swing runs with JGoodies Forms

2005-12-06 Thread Dalibor Topic
Robert Schuster wrote: Thanks to all Swing hackers!!! JGoodies Forms, which contains a layout manager and some glue classes to make it harder to write bad GUIs, works with free Swing! Great! But ... where is the obligatory screenshot? :) cheers, dalibor topic

Re: RFC: merging GNU Crypto and Jessie

2005-12-06 Thread Dalibor Topic
Casey Marshall wrote: A few of us have been throwing around the idea of merging GNU Crypto and Jessie into GNU Classpath, so Classpath will have full support for crypto and SSL out of the box. We've proposed this before, and I think this idea was mostly approved by the group, but no-one

Re: RFC: merging GNU Crypto and Jessie

2005-12-06 Thread Christian Thalinger
On Mon, 2005-12-05 at 23:42 -0800, Casey Marshall wrote: A few of us have been throwing around the idea of merging GNU Crypto and Jessie into GNU Classpath, so Classpath will have full support for crypto and SSL out of the box. We've proposed this before, and I think this idea was mostly

Re: Security manager problem

2005-12-06 Thread Anthony Green
On Tue, 2005-12-06 at 16:14 +, Gary Benson wrote: I'm having security manager problems, with JamVM at least. Various initialisations happen the first time a permission is checked, including java.security.Security's clinit method which reads the provider files $vendor.security and

Re: Security manager problem

2005-12-06 Thread Gary Benson
Anthony Green wrote: On Tue, 2005-12-06 at 16:14 +, Gary Benson wrote: I'm having security manager problems, with JamVM at least. Various initialisations happen the first time a permission is checked, including java.security.Security's clinit method which reads the provider files

Re: Free Swing runs with JGoodies Forms

2005-12-06 Thread Robert Schuster
Great! But ... where is the obligatory screenshot? :) Yes. yes. Here it is: http://page.mi.fu-berlin.de/~rschuste/ffmki-classpath.png (running on JamVM Classpath 0.19+CVS) For reference. The same dialogs on JDK 1.5: http://bitecode.de/wiki/images/2/24/09-2004-launcher2.jpg

Re: [GNU Crypto] RFC: merging GNU Crypto and Jessie

2005-12-06 Thread Casey Marshall
On Dec 6, 2005, at 1:14 AM, Raif S. Naffah wrote: On Tuesday 06 December 2005 18:42, Casey Marshall wrote: A few of us have been throwing around the idea of merging GNU Crypto and Jessie into GNU Classpath, so Classpath will have full support for crypto and SSL out of the box. We've proposed

Re: Security manager problem

2005-12-06 Thread Tom Tromey
Anthony == Anthony Green [EMAIL PROTECTED] writes: Anthony Perhaps. Implementing proper sandbox behaviour is easy to defer. I Anthony think it will take the kind of work you are doing to drive VMs to take Anthony care of details like this. Do we even do it properly in libgcj (being Anthony

Re: Security manager problem

2005-12-06 Thread Tom Tromey
Anthony == Anthony Green [EMAIL PROTECTED] writes: Anthony It's been a long time since I've read anything about this Anthony kind of stuff, but my understanding is that you simply wrap Anthony things like this up in a AccessController.doPrivileged(), Anthony since the access control context of

Re: Security manager problem

2005-12-06 Thread Robert Lougher
Hi, On 12/6/05, Gary Benson [EMAIL PROTECTED] wrote: Anthony Green wrote: It's been a long time since I've read anything about this kind of stuff, but my understanding is that you simply wrap things like this up in a AccessController.doPrivileged(), since the access control context of

Re: memory behavior to expect with gjdoc-0.7.6

2005-12-06 Thread Mark Wielaard
[Sorry for the duplicate message, trouble with my primary email account] Hi, On Mon, 2005-12-05 at 18:52 +0100, Mark Wielaard wrote: Thanks. This seems to point out two things: 1) There is a huge allocation (2MB+): GC: Alloc attempt for 2209016 bytes failed. at this point in the

[commit-cp] classpath ./ChangeLog javax/swing/ViewportLayou...

2005-12-06 Thread Roman Kennke
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Roman Kennke [EMAIL PROTECTED]05/12/06 14:31:09 Modified files: . : ChangeLog javax/swing: ViewportLayout.java Log message: 2005-12-06 Roman Kennke

[commit-cp] classpath ./ChangeLog java/awt/Container.java

2005-12-06 Thread Roman Kennke
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Roman Kennke [EMAIL PROTECTED]05/12/06 16:22:25 Modified files: . : ChangeLog java/awt : Container.java Log message: 2005-12-06 Roman Kennke [EMAIL

[commit-cp] classpath ./ChangeLog javax/swing/JComponent.java

2005-12-06 Thread Roman Kennke
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Roman Kennke [EMAIL PROTECTED]05/12/06 16:27:15 Modified files: . : ChangeLog javax/swing: JComponent.java Log message: 2005-12-06 Roman Kennke

[commit-cp] classpath ./ChangeLog java/awt/BorderLayout.java

2005-12-06 Thread Anthony Balkissoon
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Anthony Balkissoon [EMAIL PROTECTED] 05/12/06 16:30:03 Modified files: . : ChangeLog java/awt : BorderLayout.java Log message: 2005-12-06 Anthony

[commit-cp] classpath ./ChangeLog java/lang/String.java

2005-12-06 Thread Christian Thalinger
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Christian Thalinger [EMAIL PROTECTED] 05/12/06 18:52:27 Modified files: . : ChangeLog java/lang : String.java Log message: 2005-12-06 Christian Thalinger

[commit-cp] classpath ./ChangeLog java/awt/Container.java

2005-12-06 Thread Roman Kennke
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Roman Kennke [EMAIL PROTECTED]05/12/06 19:27:53 Modified files: . : ChangeLog java/awt : Container.java Log message: 2005-12-06 Roman Kennke [EMAIL

[commit-cp] classpath ./ChangeLog javax/swing/BoxLayout.java

2005-12-06 Thread Anthony Balkissoon
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Anthony Balkissoon [EMAIL PROTECTED] 05/12/06 19:50:24 Modified files: . : ChangeLog javax/swing: BoxLayout.java Log message: 2005-12-06 Anthony Balkissoon

[commit-cp] classpath ./ChangeLog java/awt/GridBagLayout.java

2005-12-06 Thread Thomas Fitzsimmons
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Thomas Fitzsimmons [EMAIL PROTECTED] 05/12/06 21:20:18 Modified files: . : ChangeLog java/awt : GridBagLayout.java Log message: 2005-12-06 Thomas

[commit-cp] classpath ./ChangeLog javax/swing/BoxLayout.java

2005-12-06 Thread Anthony Balkissoon
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Anthony Balkissoon [EMAIL PROTECTED] 05/12/06 21:26:38 Modified files: . : ChangeLog javax/swing: BoxLayout.java Log message: 2005-12-06 Anthony Balkissoon

[commit-cp] classpath javax/imageio/ImageIO.java javax/prin... [generics-branch]

2005-12-06 Thread Tom Tromey
CVSROOT:/cvsroot/classpath Module name:classpath Branch: generics-branch Changes by: Tom Tromey [EMAIL PROTECTED] 05/12/07 00:53:56 Modified files: javax/imageio : ImageIO.java javax/print/attribute: Attribute.java HashAttributeSet.java

[commit-cp] classpath javax/security/auth/Subject.java ./Ch... [generics-branch]

2005-12-06 Thread Tom Tromey
CVSROOT:/cvsroot/classpath Module name:classpath Branch: generics-branch Changes by: Tom Tromey [EMAIL PROTECTED] 05/12/07 01:15:18 Modified files: javax/security/auth: Subject.java . : ChangeLog Log message: *