[cp-patches] PR 48131. Handle empty Huffman tree

Committed. Fix for PR 48131. Handle empty tree. Index: InflaterHuffmanTree.java === RCS file: /cvsroot/classpath/classpath/java/util/zip/InflaterHuffmanTree.java,v retrieving revision 1.8 diff -u -r1.8 InflaterHuffmanTree.java ---

[commit-cp] classpath ChangeLog java/util/zip/InflaterHuffm...

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 11/03/15 06:19:39 Modified files: . : ChangeLog java/util/zip : InflaterHuffmanTree.java Log message: Fix for PR 48131. Handle empty tree

RE: Free Java @ FOSDEM 2011 DevRoom Proposal

Mark Wielaard wrote: The FOSDEM organization has granted us a developer room! Nice! Just booked my hotel. Looking forward to seeing everyone again. Regards, Jeroen

Re: [cp-patches] What's about bug 36560 (Error parsing zip file...)?

Hello Ivan, The JDK also fails to open zip files that contain encrypted entries. Regards, Jeroen -Original Message- From: Ivan Maidanski [mailto:iv...@mail.ru] Sent: Wednesday, July 14, 2010 7:56 AM To: Andrew John Hughes Cc: classpath-patches; Daniel Noll; Jeroen Frijters Subject

Re: [cp-patches] What's about bug 36560 (Error parsing zip file...)?

Hello, I've committed the patch below and closed the bug. Regards, Jeroen Index: InflaterHuffmanTree.java === RCS file: /cvsroot/classpath/classpath/java/util/zip/InflaterHuffmanTree.java,v retrieving revision 1.7 diff -u -r1.7

[cp-patches] ZipFile handling of encrypted entries

Hello, I've committed the patch below. When a zip file contains an encrypted entry, we should throw a ZipException (as the JDK does) while reading the zip file directory. This has been in IKVM.NET's ZipFile implementation (which is a fork of GNU Classpath's) for a while. Regards, Jeroen

[commit-cp] classpath ChangeLog

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 10/07/13 13:10:39 Modified files: . : ChangeLog Log message: Added description of previous commit. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath

[commit-cp] classpath ChangeLog java/util/zip/ZipFile.java

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 10/07/13 13:27:41 Modified files: . : ChangeLog java/util/zip : ZipFile.java Log message: When a zip file contains an encrypted entry, we should

[commit-cp] classpath ChangeLog java/util/zip/Inflater.java

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 10/01/12 16:49:02 Modified files: . : ChangeLog java/util/zip : Inflater.java Log message: 2010-01-12 Jeroen Frijters jer...@frijters.net

Re: [cp-patches] FYI: ThreadLocal optimisation

Andrew Haley wrote: It's not just static compilation: if you look at VMThread.currentThread() you'll probably see something like extern DWORD _Jv_ThreadKey; return (java::lang::Thread *) TlsGetValue(_Jv_ThreadKey); or extern pthread_key_t _Jv_ThreadKey; return

Re: [cp-patches] FYI: ThreadLocal optimisation

Andrew Haley wrote: Why? If you're going to call pthread_getspecific() to get the current thread, you might as well call it to get the thread-local variable. That remains true regardless of GC, TL inheritance, or anything else. PTHREAD_KEYS_MAX is very low on some OSes compared with the needs

RE: [cp-patches] RFC: tweaks to java.util.zip.ZipEntry

Ian Rogers wrote: the attached patch stops the lazy initialization of a Calendar object in ZipEntry and instead uses a static final one. It also modifies the clone method to instead of using Object.clone to use the ZipEntry's own copy constructor. ZipEntry isn't final, so you must use

[cp-patches] FYI: java.awt.image.Raster.createInterleavedRaster() fix

Hi, I committed the rather obvious fix below. Regards, Jeroen 2008-01-07 Jeroen Frijters [EMAIL PROTECTED] * java/awt/image/Raster.java (createInterleavedRaster): Fixed ComponentSampleModel constructor argument order. Index: Raster.java

[commit-cp] classpath ChangeLog java/awt/image/Raster.java

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 08/01/07 09:16:30 Modified files: . : ChangeLog java/awt/image : Raster.java Log message: 2008-01-07 Jeroen Frijters [EMAIL PROTECTED

RE: [cp-patches] FYI: java.util.Locale default locale strings aren't interned

Hi, Committed. Regards, Jeroen 2007-11-08 Jeroen Frijters [EMAIL PROTECTED] * java/util/Locale.java (Locale): Always intern strings. Index: Locale.java === RCS file: /cvsroot/classpath/classpath/java/util

RE: [cp-patches] Setting default assertion status

Christian Thalinger wrote: On Tue, 2007-09-18 at 06:47 +0200, Jeroen Frijters wrote: I believe you are correct that Classpath doesn't currently support the system assertions boolean. I believe you are also correct in assuming that noone cares ;-) Does the Classpath code even have any

RE: [cp-patches] Setting default assertion status

Christian Thalinger wrote: On Tue, 2007-09-04 at 10:25 +0200, Christian Thalinger wrote: OK, this email was a bit short without much explanation. We're currently implementing assertion support in CACAO (means the -ea/-da command line switches) and Gregor, our student doing this, noticed

RE: [cp-patches] Changes to ThreadLocal

Ian Rogers wrote: Thanks Jeroen, it's clear now. The problem with a phantom reference is that when we collect the thread local we should also really make collectable all of the values set to thread locals. A phantom reference won't do this and so introduces a memory leak until something can

RE: [cp-patches] Changes to ThreadLocal

Ian Rogers wrote: the attached patch modifies ThreadLocal to use an array of Objects hung off Thread rather than a weak hash map hung off Thread. On DaCapo's Jython benchmark this can improve the performance of the Jikes RVM by more than 10%. It also improves other DaCapo benchmark

RE: [cp-patches] Changes to ThreadLocal

Ian Rogers wrote: One bug in the current implementation is that if the thread local overrides hashcode and/or equal it can be made to collide with other thread locals. No, it uses an Weak*Identity*HashMap. Regards, Jeroen

RE: [cp-patches] Changes to ThreadLocal

Ian Rogers wrote: here is the revised patch. + int arraySize = group.activeCount(); + Thread[] threadList = new Thread[arraySize]; + int filled = group.enumerate(threadList); + while (filled == arraySize) + { +arraySize *= 2; +threadList = new

RE: [cp-patches] Changes to ThreadLocal

Ian Rogers wrote: How can then the thread local be resurrected after the finalizer is run? All the references in ThreadLocal and InheritableThreadLocal are weak and will be atomically cleared prior to the finalizer being run. All other references must be dead for the finalizer to have been

RE: [cp-patches] Changes to ThreadLocal

Ian Rogers wrote: Anyway, this design decision seems to hang off how weak references are finalized. If they are finalized on their own finalizer thread then the final local index design is fine and preferable imo to the volatile design or a weak identity hash map (however cached or stream

[cp-patches] FYI: Fix serialVersionUID computation for enums and proxies

Hi, Committed. Regards, Jeroen 2007-06-21 Jeroen Frijters [EMAIL PROTECTED] * java/io/ObjectStreamClass.java (getClassUID): Return 0L for enums and proxies. Index: ObjectStreamClass.java === RCS file: /cvsroot

[commit-cp] classpath ChangeLog java/io/ObjectStreamClass.java

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 07/06/21 06:19:28 Modified files: . : ChangeLog java/io: ObjectStreamClass.java Log message: 2007-06-21 Jeroen Frijters [EMAIL PROTECTED

[cp-patches] FYI: Fix to gnu/java/security/Engine.java

Hi, I committed the patch below. It fixes a bug when the passed in service or algorithm aren't in the correct case (the initial lookup is case insenstive, but later on provider.getProperty() was called with the incorrectly cased key). Regards, Jeroen 2007-06-21 Jeroen Frijters [EMAIL

[cp-patches] FYI: Fix for 32356

Hi, Committed. Regards, Jeroen 2007-06-21 Jeroen Frijters [EMAIL PROTECTED] Fixes #32356 * java/lang/reflect/Array.java (newInstance(Class,int[])): Call createMultiArray correctly. (createMultiArray): Fixed dimensions processing order. Index: java/lang

[commit-cp] classpath ChangeLog gnu/java/security/Engine.java

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 07/06/21 05:29:38 Modified files: . : ChangeLog gnu/java/security: Engine.java Log message: 2007-06-21 Jeroen Frijters [EMAIL PROTECTED

[commit-cp] classpath ChangeLog java/lang/reflect/Array.java

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 07/06/21 05:39:50 Modified files: . : ChangeLog java/lang/reflect: Array.java Log message: 2007-06-21 Jeroen Frijters [EMAIL PROTECTED

[commit-cp] classpath ChangeLog java/net/URLClassLoader.java

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 07/06/21 05:43:38 Modified files: . : ChangeLog java/net : URLClassLoader.java Log message: 2007-06-21 Jeroen Frijters [EMAIL PROTECTED

[cp-patches] FYI: java/util/Arrays.java patch

Hi, Committed. Regards, Jeroen 2007-05-23 Jeroen Frijters [EMAIL PROTECTED] * java/util/Arrays.java (copyOfRange(T,int,int)): Fixed to instantiate right array type. Index: Arrays.java === RCS file: /cvsroot

[commit-cp] classpath ChangeLog java/util/Arrays.java

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 07/05/23 12:22:26 Modified files: . : ChangeLog java/util : Arrays.java Log message: 2007-05-23 Jeroen Frijters [EMAIL PROTECTED

[cp-patches] FYI: Float/VMFloat changes

Hi, While merging in the Sun double/float toString/parsing in IKVM, I found that the Float/VMFloat interface wasn't properly factored to support this. This patch (already committed) fixes that. Regards, Jeroen 2007-05-11 Jeroen Frijters [EMAIL PROTECTED] * java/lang/Float.java

[commit-cp] classpath ChangeLog NEWS java/lang/Float.java v...

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 07/05/11 08:07:46 Modified files: . : ChangeLog NEWS java/lang : Float.java vm/reference/java/lang: VMFloat.java Log message: 2007-05-11

[cp-patches] FYI: Arrays.sort() fix for 31646

Hi, Committed. Mark, please consider applying to 0.95 as well. Regards, Jeroen 2007-04-23 Jeroen Frijters [EMAIL PROTECTED] PR classpath/31646: * java/util/Arrays.java (qsort): Corrected initial median calculation. Index: Arrays.java

RE: 0.95 branch created

Mark Wielaard wrote: A release branch has been created 'classpath-0_95-branch' Shouldn't that have been 0.94? I'll try to pick up any fixes made on the trunk, but if you feel some patch is release critical please do CC me. I'd really like to see the removal of the META-INF/services/*xml* go

RE: RE: 0.95 branch created

Jeroen Frijters wrote: Mark Wielaard wrote: I'll try to pick up any fixes made on the trunk, but if you feel some patch is release critical please do CC me. I'd really like to see the removal of the META-INF/services/*xml* go in. The inclusion of these resources breaks a lot of code (e.g

RE: 0.95 branch created

Mark Wielaard wrote: On Sat, 2007-04-07 at 08:03 +0200, Jeroen Frijters wrote: I'd really like to see the removal of the META-INF/services/*xml* go in. Yes, that seems like a good idea. libgcj also did I believe that and the fallbacks are in place. Besides the four service files you mention

RE: [cp-patches] Patch: FYI: hard-code SAX fallback

Tom Tromey wrote: I think for proper operation we have to remove the various XML service files from META-INF; see the earlier thread. But in order for this to work we also have to fix SAX to properly fall back to the Classpath SAX parser. Any update on this? I'm convinced that we must remove

[cp-patches] FYI: Fix for CopyOnWriteArrayList (PR 31402)

Hi, Committed. Regards, Jeroen 2007-03-31 Jeroen Frijters [EMAIL PROTECTED] PR classpath/31402: * java/util/concurrent/CopyOnWriteArrayList.java (remove): Fixed ArrayIndexOutOfBoundsException when index == 0. Index: CopyOnWriteArrayList.java

[commit-cp] classpath ChangeLog java/util/concurrent/CopyOn...

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 07/03/31 10:01:39 Modified files: . : ChangeLog java/util/concurrent: CopyOnWriteArrayList.java Log message: 2007-03-31 Jeroen Frijters [EMAIL

RE: un dos-ify ChangeLog

Tom Tromey wrote: Today I found out that ^M characters were added to the end of all the lines of ChangeLog. I undid this and added a local variable section for the benefit of those using Emacs. I'd just like to point out (as the only evil CR/LF using OS user) that it wasn't me... ;-)

[cp-patches] FYI: Fix for ServerSocket regression

Hi, My previous Socket patch broke ServerSocket. This fixes it again. Sorry for the inconvenience. Regards, Jeroen 2007-03-23 Jeroen Frijters [EMAIL PROTECTED] * java/net/ServerSocket.java (implAccept): set implCreated flag on socket. * java/net/Socket.java

RE: jetty-5.1.11 regression

Mark Wielaard wrote: On Fri, 2007-03-23 at 12:26 +0100, Christian Thalinger wrote: I've found another regression with current head. jetty-5.1.11 does not serve pages anymore (while it does for 6.1.1): $ telnet localhost 8080 Trying 127.0.0.1... Connected to localhost.localdomain.

RE: jetty-5.1.11 regression

Christian Thalinger wrote: On Fri, 2007-03-23 at 13:38 +0100, Jeroen Frijters wrote: I think my Socket patch from the 19th introduced this. I'm looking into it... Yes, I just verified. The attached patch fixes things. Sorry for the trouble. Regards, Jeroen Index: ServerSocket.java

[commit-cp] classpath ChangeLog java/net/ServerSocket.java ...

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 07/03/23 13:19:46 Modified files: . : ChangeLog java/net : ServerSocket.java Socket.java Log message: 2007-03-23 Jeroen Frijters [EMAIL

[cp-patches] FYI: Socket.getImpl() fix checked in

Hi, I committed the attached patch. Regards, Jeroen 2007-03-19 Jeroen Frijters [EMAIL PROTECTED] * java/net/Socket.java (implCreated): New field. (getImpl): Call impl.create() if it hasn't been called yet. (bind): Removed explicit impl.create() call. Index

[commit-cp] classpath ChangeLog java/net/Socket.java

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 07/03/19 08:51:16 Modified files: . : ChangeLog java/net : Socket.java Log message: 2007-03-19 Jeroen Frijters [EMAIL PROTECTED

New release?

Hoi Mark, When is the next release due? The current release (0.93) has the incorrect daylight savings rules for the US and I've already had one IKVM user run into this. I'm probably going to release an IKVM update that is based on GNU Classpath 0.93 + the cvs version of TimeZone, but it would

[cp-patches] RFC: Socket fix

Hi, I think we need the patch below to fix the following case: Socket sock = new Socket(); sock.setKeepAlive(false); Currently this throws a NullPointerException (on IKVM at least), because the impl.create() hasn't been called yet. Any comments? Regards, Jeroen Index: java/net/Socket.java

RE: [cp-patches] RFC: Socket fix

David Daney wrote: Jeroen Frijters wrote: Hi, I think we need the patch below to fix the following case: Socket sock = new Socket(); sock.setKeepAlive(false); Currently this throws a NullPointerException (on IKVM at least), because the impl.create() hasn't been called yet

RE: [kaffe] make check fails...

Jeroen Frijters [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] * java/io/ObjectInputStream.java (readClassDescriptor): Use class's class loader to resolve field types. * java/io/ObjectStreamField.java (ObjectStreamField(String,String,ClassLoader)): Removed

[cp-patches] FYI: ByteCharset.Decoder patch

Hi, I committed the attached patch. Regards, Jeroen 2007-02-04 Jeroen Frijters [EMAIL PROTECTED] Fix for #30693 * gnu/java/nio/charset/ByteCharset.java (ByteCharset.Decoder.decodeLoop): Reset input buffer position if the byte read was unmappable. Index: gnu

[cp-patches] FYI: Enum reflection fixes

Hi, I committed the attached patch. Regards, Jeroen 2007-02-04 Jeroen Frijters [EMAIL PROTECTED] * java/lang/Class.java (newInstance): Moved setAccessible call to helper method. (getEnumConstants): Call new helper method to allow values method to be called

[commit-cp] classpath ChangeLog gnu/java/nio/charset/ByteCh...

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 07/02/04 09:52:56 Modified files: . : ChangeLog gnu/java/nio/charset: ByteCharset.java Log message: 2007-02-04 Jeroen Frijters [EMAIL PROTECTED

[commit-cp] classpath ChangeLog java/lang/Class.java java/l...

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 07/02/04 09:58:00 Modified files: . : ChangeLog java/lang : Class.java Enum.java Log message: 2007-02-04 Jeroen Frijters [EMAIL PROTECTED

RE: VMChannel read/write native interface

Roman Kennke wrote: I don't know if the FileInputStream should attempt to use a direct buffer. I guess it could be better in the case when a VM supports efficient access to it (see above). In other cases it should not be slower, so we should probably try to use direct buffers there (and in

Can javax/swing/text/html/default.css be moved to resources/javax/swing/text/html/default.css?

Hi, Subject says it all. Can someone who understands the Classpath build infrastructure please have a look at this? Thanks, Jeroen

[commit-cp] classpath ChangeLog javax/net/ssl/SSLServerSock...

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 06/12/28 07:38:32 Modified files: . : ChangeLog javax/net/ssl : SSLServerSocketFactory.java SSLSocketFactory.java Log message

RE: [cp-patches] FYI: Add Enum.finalize()

Mark Wielaard wrote: Interesting. Even though Enums should never be initialized by hand this is something a garbage collector should be aware of. Do garbage collectors already handle empty finalize() methods as if there was no finalizer? Good ones do :-) (I know that HotSpot does and IKVM

RE: [cp-patches] FYI: Use exception chaining in javax.net.ssl.SSLSocketFactory.getDefault()

David Daney wrote: Jeroen Frijters wrote: throw new RuntimeException(error instantiating default socket factory: - + ex.toString()); That sounds more like an InternalError than the super-generic RuntimeException. Possibly. I don't

RE: [cp-patches] FYI: Use exception chaining in javax.net.ssl.SSLSocketFactory.getDefault()

David Daney wrote: Jeroen Frijters wrote: David Daney wrote: Jeroen Frijters wrote: throw new RuntimeException(error instantiating default socket factory: - + ex.toString()); That sounds more like

RE: [cp-patches] FYI: Use exception chaining in javax.net.ssl.SSLSocketFactory.getDefault()

Casey Marshall wrote: Really? That seems like worse behavior than just giving up when trying to create the factory. Just delaying exceptions like that seems like it will just hide bugs, instead of forcing you to deal with them up front. Well, given that this method is currently used

[commit-cp] classpath ChangeLog javax/net/ssl/SSLSocketFact...

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 06/12/11 13:45:55 Modified files: . : ChangeLog javax/net/ssl : SSLSocketFactory.java Log message: 2006-12-11 Jeroen Frijters [EMAIL PROTECTED

RE: Migration to generics opens up exciting optimization opportunities from annotations

Ian Rogers wrote: I'm interested in adding these optimization to the Jikes RVM, but clearly the annotations need adding to Classpath. I was wondering what kind of response this would get? I've been thinking about using annotations for similar things and one of the things that I think makes

RE: SystemProperties secure?

Andrew Haley wrote: Jeroen Frijters writes: Tom Tromey wrote: Roman == Roman Kennke [EMAIL PROTECTED] writes: Roman We are using the SystemProperties class throughout the Classpath code to Roman access system properties and avoid the security checks in Roman

RE: SystemProperties secure?

Tom Tromey wrote: Roman == Roman Kennke [EMAIL PROTECTED] writes: Roman We are using the SystemProperties class throughout the Classpath code to Roman access system properties and avoid the security checks in Roman java.lang.System. However, I come to think that this is no good the way

RE: The Generics Branch: A Proposal

Andrew John Hughes wrote: Hi everyone, Now that: a) gcj has branched for 4.2 and the gcj-eclipse branch is moving to trunk b) there is another Free 1.5 compiler in the form of Sun's javac c) most VMs have support for at least some of the 1.5 native stuff I'd like to suggest that we

RE: [cp-patches] QName

Chris Burdess wrote: Besides, I don't see how you can validate an anyURI, since it can be absolute or relative. According to the XML namespaces spec http://www.w3.org/TR/xml-names/#iri-use http://www.w3.org/2000/09/xppa you cannot use relative URIs in XML namespace references.

RE: [cp-patches] QName

Chris Burdess wrote: I'd like some feedback on a change I'd like to make to a small part of the JAXP implementation. [...] Note that this is contentious, because Sun's QName *doesn't do any validation* of its input. However, I still think it's the right thing to do, and I'm not alone:

RE: Generic Signatures

Andrew Haley wrote: I can't get even simple tests with generic signatures to work. Like this: public class test2 { static class A extends ArrayListString {}; public static void main(String[] args) { A a = new A(); Object x = a; ((Collection)x).add(new Byte((byte)

[cp-patches] FYI: jcl.c fix

Hi, I committed the attached patch to make it compile (and work) on platforms where JNIEXPORT and JNICALL actually mean something. Regards, Jeroen 2006-10-17 Jeroen Frijters [EMAIL PROTECTED] * native/jni/classpath/jcl.c (JNI_OnLoad): Corrected calling convention. Index

[commit-cp] classpath ChangeLog native/jni/classpath/jcl.c

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 06/10/17 14:14:16 Modified files: . : ChangeLog native/jni/classpath: jcl.c Log message: 2006-10-17 Jeroen Frijters [EMAIL PROTECTED

RE: [cp-patches] RFC: PR Classpath/28664 - GNU MP based BigIntegertake2 (compressed)

To: classpath-patches@gnu.org Subject: [cp-patches] RFC: PR Classpath/28664 - GNU MP based BigIntegertake2 (compressed) hello all, the attached proposed patch addresses the above and incorporates Jeroen Frijters pattern for native implementation using native memory. the related ChangeLog

RE: gnu.classpath.VMStackWalker

Andrew Haley wrote: The current gnu.classpath.VMStackWalker interface is inefficient. Sun provide: sun.reflect.reflection.getCallerClass(int depth) and for the same function we would do VMStackWalker.getClassContext()[depth]; You see the difference: Classpath's VMStackWalker

RE: gnu.classpath.VMStackWalker

Andrew Haley wrote: How, exactly? I see horrors like [...] public static ClassLoader getCallingClassLoader() { Class[] ctx = getClassContext(); if (ctx.length 3) return null; return getClassLoader(ctx[2]); } in several places. Huh? The code you quoted is from

RE: gnu.classpath.VMStackWalker

Andrew Haley wrote: I don't think that's a reasonable excuse for a bad interface. It's not a bad interface, it's a bad implementation, that's a big difference. If we had a better one, people could actually _use_ some of these reference methods without having to rewrite them. That's complete

RE: [cp-patches] RFC: IdentityHashMap linear probing

Tom Tromey wrote: I'm not checking this in yet, I'd like some comments first. Thanks. I like this change a lot, but I have one small comment. In the documentation of Map.Entry.hashCode() it is sort of implied that a null reference returns a 0 hash code. Both the RI and our current implementation

[cp-patches] FYI: AbstractSelectableChannel fix

Hi, Committed. The spec says that implCloseChannel should cancel all keys associated with the channel. Regards, Jeroen 2006-09-24 Jeroen Frijters [EMAIL PROTECTED] * java/nio/channels/spi/AbstractSelectableChannel.java (implCloseChannel): Cancel all keys after closing

[cp-patches] FYI: A couple of ServerSocket.bind fixes

Hi, Committed. This fixes several bugs in ServerSocket.bind(). Regards, Jeroen 2006-09-24 Jeroen Frijters [EMAIL PROTECTED] * java/net/ServerSocket.java (bind(SocketAddress,int)): Added support for null address. Throw proper exception if already bound. Handle

[cp-patches] FYI: AbstractSelectableChannel register fix

Hi, Committed. This fixes the bug that when a key was already registered it would not get the new interest ops and the attachment wouldn't be cleared if the value value was null. Regards, Jeroen 2006-09-24 Jeroen Frijters [EMAIL PROTECTED] * java/nio/channels/spi

[commit-cp] classpath ChangeLog java/nio/channels/spi/Abstr...

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 06/09/24 11:37:21 Modified files: . : ChangeLog java/nio/channels/spi: AbstractSelectableChannel.java Log message: 2006-09-24 Jeroen Frijters [EMAIL

[commit-cp] classpath ChangeLog java/nio/channels/spi/Abstr...

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 06/09/24 18:39:58 Modified files: . : ChangeLog java/nio/channels/spi: AbstractSelectableChannel.java Log message: 2006-09-24 Jeroen Frijters [EMAIL

RE: native methods in inner classes (long)

Raif S. Naffah wrote: * the header file generated by the RI-1.5 emits a signature for the native method of an inner class that looks like so: JNIEXPORT void JNICALL Java_OC_IC_natInit This looks like a bug in javah. [1] claims they fixed it. my questions are: 1. do VMs handle

[cp-patches] RFC: small nio change

Hi Casey, I would like to remove the dependence on VMChannel from Socket and ServerSocket (as this breaks the layering). Do you agree with this patch? Thanks, Jeroen Index: gnu/java/nio/SocketChannelImpl.java === RCS file:

[cp-patches] RE: RFC: small nio change

Casey Marshall wrote: Jeroen Frijters wrote: Hi Casey, I would like to remove the dependence on VMChannel from Socket and ServerSocket (as this breaks the layering). Do you agree with this patch? I think this should be OK. Refresh my memory, though: in ServerSocket and Socket

[cp-patches] FYI: Remove VMChannel dependency from Socket / ServerSocket

Hi, I committed the previously discussed patch (minus the SocketChannelImpl import that I accidentally removed). Regards, Jeroen 2006-09-19 Jeroen Frijters [EMAIL PROTECTED] * gnu/java/nio/SocketChannelImpl.java: Removed unused import. * java/net/ServerSocket.java

[commit-cp] classpath ChangeLog java/net/ServerSocket.java ...

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 06/09/19 05:47:39 Modified files: . : ChangeLog java/net : ServerSocket.java Socket.java Log message: 2006-09-19 Jeroen Frijters [EMAIL

[cp-patches] FYI: InputStreamReader fix for 28984

Hi, Committed. Regards, Jeroen 2006-09-14 Jeroen Frijters [EMAIL PROTECTED] PR classpath/28984 * java/io/InputStreamReader.java (read(char[],int,int)): Fixed bug. Index: java/io/InputStreamReader.java

[cp-patches] FYI: Fix for gnu/java/rmi/server/ActivatableRef.java

Hi, Committed. This fix isn't perfect, but it's better than the current code. Regards, Jeroen 2006-09-14 Jeroen Frijters [EMAIL PROTECTED] * gnu/java/rmi/server/ActivatableRef.java (readExternal, writeExternal): Partial fix for serialization format. Index: gnu/java/rmi/server

[commit-cp] classpath ChangeLog java/io/InputStreamReader.java

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 06/09/14 08:03:57 Modified files: . : ChangeLog java/io: InputStreamReader.java Log message: 2006-09-14 Jeroen Frijters [EMAIL PROTECTED

[commit-cp] classpath ChangeLog gnu/java/rmi/server/Activat...

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 06/09/14 09:59:34 Modified files: . : ChangeLog gnu/java/rmi/server: ActivatableRef.java Log message: 2006-09-14 Jeroen Frijters [EMAIL PROTECTED

[cp-patches] RFC: gnu/java/rmi/server/ActivatableRef.java patch

Hi Audrius, Can you please take a look at this patch? The current ActivatableRef (de)serialization code is wrong (the format is documented here [1]) and I fixed the common case, but I don't understand what a null nested remote reference is. Thanks, Jeroen [1]

RE: [cp-patches] RFC: PR Classpath/28664 - GNU MP based BigInteger(compressed)

Raif S. Naffah wrote; i followed the advice given in [1] and synchronized the code in the BigInteger finalize() method which now looks like so: This is not yet sufficient. *All* native method calls that use the native_ptr need to be synchronized. It is also not very good practice to

RE: [cp-patches] RFC: PR Classpath/28664 - GNU MP based BigInteger(compressed)

Raif S. Naffah wrote: On Monday 04 September 2006 20:40, Jeroen Frijters wrote: ... ...*All* native method calls that use the native_ptr need to be synchronized. i'm sorry but it is still not obvious to me why this should be so. every instance of a BigInteger has its own value

RE: [cp-patches] RFC: PR Classpath/28664 - GNU MP based BigInteger(compressed)

Raif S. Naffah wrote: the attached patch adds support for GNU MP in BigInteger if/when configured. How/why is the native version better? Is it really worthwhile to complicate the code this way? Where are the benchmarks that prove the native code is faster? I assume it is already widely know

RE: [cp-patches] RFC: PR Classpath/28664 - GNU MP based BigInteger(compressed)

Raif S. Naffah wrote: the attractiveness of the native code is performance. to quickly see how the new methods improve for example RSA key generation, one can modify the code in TestOfRSAKeyGeneration (Mauve) to call the generate() method N times and print the duration --on my

[commit-cp] classpath ChangeLog java/lang/ref/Reference.jav...

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 06/08/24 06:40:08 Modified files: . : ChangeLog java/lang/ref : Reference.java ReferenceQueue.java Log message: 2006-08-24 Jeroen Frijters [EMAIL

[cp-patches] FYI: SecureClassLoader cleanup and update to 1.5

Hi, Committed. Regards, Jeroen 2006-08-24 Jeroen Frijters [EMAIL PROTECTED] * java/security/SecureClassLoader.java (protectionDomainCache): Changed to HashMap. (SecureClassLoader): Removed redundant security check. (defineClass(String,byte[],int,int,CodeSource

[commit-cp] classpath ChangeLog java/security/SecureClassLo...

CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Jeroen Frijters jfrijters 06/08/24 05:11:26 Modified files: . : ChangeLog java/security : SecureClassLoader.java Log message: 2006-08-24 Jeroen Frijters [EMAIL PROTECTED

  1   2   3   4   5   6   7   >