Re: [PATCH] Fix for Hashtable contains blowing up the stack

2003-11-28 Thread Dalibor Topic
Hi Mark, hallo Jeroen, Mark Wielaard wrote: Hi On Sat, 2003-11-22 at 13:06, Jeroen Frijters wrote: The fix is actually incorrect. containsValue() should call contains() because containsValue() is a new method (since 1.2) and contains() exists since 1.0. Older code may have overridden contains()

Re: [PATCH] Fix for Hashtable contains blowing up the stack

2003-11-28 Thread Mark Wielaard
Hi, On Fri, 2003-11-28 at 17:39, Dalibor Topic wrote: Thanks for pointing that mistake out. I've attached an updated version of the patch. 2003-11-28 Dalibor Topic [EMAIL PROTECTED] Reported by: Jim Pick [EMAIL PROTECTED] * libraries/javalib/java/util/Hashtable.java

Re: [PATCH] Fix for Hashtable contains blowing up the stack

2003-11-28 Thread Dalibor Topic
Hi Mark, Mark Wielaard wrote: Hi, On Fri, 2003-11-28 at 17:39, Dalibor Topic wrote: Thanks for pointing that mistake out. I've attached an updated version of the patch. 2003-11-28 Dalibor Topic [EMAIL PROTECTED] Reported by: Jim Pick [EMAIL PROTECTED] *

Re: [PATCH] Fix for Hashtable contains blowing up the stack

2003-11-28 Thread Chris Gray
On Friday 28 November 2003 17:39, Dalibor Topic wrote: Hi Mark, hallo Jeroen, Mark Wielaard wrote: Hi On Sat, 2003-11-22 at 13:06, Jeroen Frijters wrote: The fix is actually incorrect. containsValue() should call contains() because containsValue() is a new method (since 1.2) and

RE: [PATCH] Fix for Hashtable contains blowing up the stack

2003-11-22 Thread Mark Wielaard
Hi, On Sat, 2003-11-22 at 13:06, Jeroen Frijters wrote: The fix is actually incorrect. containsValue() should call contains() because containsValue() is a new method (since 1.2) and contains() exists since 1.0. Older code may have overridden contains() and this should work with newer code

[PATCH] Fix for Hashtable contains blowing up the stack

2003-11-21 Thread Dalibor Topic
Hi all, attached is my fix to make ant (I think) work again with Classpath, fixing the bug reported by Jim Pick here [1] Citing myself [2]: this is a typical java library bug, and I've both produced and fixed a couple of those myself ;) You get an infinite recursion through calling overridden

Re: [PATCH] Fix for Hashtable contains blowing up the stack

2003-11-21 Thread Dalibor Topic
Dalibor Topic wrote: Hi all, attached is my fix to make ant (I think) work again with Classpath, fixing the bug reported by Jim Pick here [1] Citing myself [2]: this is a typical java library bug, and I've both produced and fixed a couple of those myself ;) You get an infinite recursion

Re: [PATCH] Fix for Hashtable contains blowing up the stack

2003-11-21 Thread Dalibor Topic
Dalibor Topic wrote: Dalibor Topic wrote: Hi all, attached is my fix to make ant (I think) work again with Classpath, fixing the bug reported by Jim Pick here [1] Citing myself [2]: this is a typical java library bug, and I've both produced and fixed a couple of those myself ;) You get an

Re: [PATCH] Fix for Hashtable contains blowing up the stack

2003-11-21 Thread Mark Wielaard
Hi, On Fri, 2003-11-21 at 20:48, Dalibor Topic wrote: this is a typical java library bug, and I've both produced and fixed a couple of those myself ;) You get an infinite recursion through calling overridden methods. Class A in library implements public methods b and c, where b