Re: ResourceBundle optimisation

2005-07-08 Thread Thomas Zander
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thursday 7 July 2005 18:29, you wrote: Thomas Zander wrote: Won't that break things when new (more specialised) resource bundles are added to the classpath at a later time? Then again, we probably also don't store URL of already loaded RBs to

Re: ResourceBundle optimisation

2005-07-08 Thread Roman Kennke
Hi, Another idea: invent a System.property to control cache-behaviour. With a useful default, users can tune as they like: cache, no cache, cache forever, cache with expiration... Indeed, a good idea! Someone should set up a page in the Wiki about the system properties that the user can use

Re: ResourceBundle optimisation

2005-07-08 Thread Bryce McKinlay
Thomas Zander wrote: I'm pretty sure its not an API design to disallow this. So its implementation specific and your argument that Sun does not do it is indeed a pretty strong one. I'm not sure I agree with it, but its a good argument nontheless. ... My original point still stands;

Re: ResourceBundle optimisation

2005-07-08 Thread Bryce McKinlay
Thanks for the explanation, Nicolas. You are correct, the current caching strategy does not work when the same base resource is loaded repeatedly for many different locale arguments. I'm looking at a solution that will fix this but continue to avoid the string concatenations and allocations

Re: ResourceBundle optimisation

2005-07-08 Thread Bryce McKinlay
[EMAIL PROTECTED] wrote: While you are at it... I remember a discussion ( somewhere, somewhen long ago) about a probable bug with ResourceBundles, that they stay in memory (because of caching) and that they should be dropped from cache somehow. Maybe its a good idea to use one of the

Re: ResourceBundle optimisation

2005-07-07 Thread Nicolas Geoffray
Hi Bryce, Bryce McKinlay wrote: Nicolas Geoffray wrote: My mistake, i gave you a patch against classpath-0.13. Here's a patch against the latest cvs. Nicolas Geoffray wrote: Hi everyone, I've been doing benchmarks beween my vm and another one launching Tomcat and noticed that the

Re: ResourceBundle optimisation

2005-07-07 Thread Thomas Zander
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thursday 7 July 2005 10:33, Nicolas Geoffray wrote: Even better, in tryBundle when a result is found for a resource, we could cache all intermediary resources we were looking for. For example if we were looking for ApplicationProperties_AA_aa,

ResourceBundle optimisation

2005-07-06 Thread Nicolas Geoffray
Hi everyone, I've been doing benchmarks beween my vm and another one launching Tomcat and noticed that the startup spent a long time trying to find Resouces with getBundle. The thing is, ResourceBundle uses a cache for the resources it founds, but i think it's not perfectly used. When

Re: ResourceBundle optimisation

2005-07-06 Thread Nicolas Geoffray
My mistake, i gave you a patch against classpath-0.13. Here's a patch against the latest cvs. Nicolas Geoffray wrote: Hi everyone, I've been doing benchmarks beween my vm and another one launching Tomcat and noticed that the startup spent a long time trying to find Resouces with getBundle.