Re: file locking problem in Java_gnu_java_nio_VMChannel_lock

2006-10-12 Thread Edwin Steiner
On Thu, Oct 12, 2006 at 05:17:20PM -0700, Casey Marshall wrote: > Edwin Steiner wrote: > > On Wed, Oct 11, 2006 at 10:56:46AM -0600, Tom Tromey wrote: > >>> "Edwin" == Edwin Steiner <[EMAIL PROTECTED]> writes: > >> Edwin> The attached patch fixes this case. It is still > >> Edwin> not safe for

Re: file locking problem in Java_gnu_java_nio_VMChannel_lock

2006-10-12 Thread Casey Marshall
Edwin Steiner wrote: > On Wed, Oct 11, 2006 at 10:56:46AM -0600, Tom Tromey wrote: >>> "Edwin" == Edwin Steiner <[EMAIL PROTECTED]> writes: >> Edwin> The attached patch fixes this case. It is still >> Edwin> not safe for len > signed 32 bit. >> >> Looks ok to me, I'm going to check it in. >> >>

Re: file locking problem in Java_gnu_java_nio_VMChannel_lock

2006-10-12 Thread Edwin Steiner
On Wed, Oct 11, 2006 at 10:56:46AM -0600, Tom Tromey wrote: > > "Edwin" == Edwin Steiner <[EMAIL PROTECTED]> writes: > > Edwin> The attached patch fixes this case. It is still > Edwin> not safe for len > signed 32 bit. > > Looks ok to me, I'm going to check it in. > > I wrote a ChangeLog ent

Re: file locking problem in Java_gnu_java_nio_VMChannel_lock

2006-10-12 Thread Christian Thalinger
On Wed, 2006-10-11 at 10:56 -0600, Tom Tromey wrote: > > "Edwin" == Edwin Steiner <[EMAIL PROTECTED]> writes: > > Edwin> The attached patch fixes this case. It is still > Edwin> not safe for len > signed 32 bit. > > Looks ok to me, I'm going to check it in. Thanks. Could you also commit it

Re: file locking problem in Java_gnu_java_nio_VMChannel_lock

2006-10-11 Thread Tom Tromey
> "Edwin" == Edwin Steiner <[EMAIL PROTECTED]> writes: Edwin> The attached patch fixes this case. It is still Edwin> not safe for len > signed 32 bit. Looks ok to me, I'm going to check it in. I wrote a ChangeLog entry for you -- but please, next time, send one with a patch. Thanks! Tom

file locking problem in Java_gnu_java_nio_VMChannel_lock

2006-10-10 Thread Edwin Steiner
Hi! Beginning with this ChangeLog entry (snipped): 2006-09-16 Casey Marshall <[EMAIL PROTECTED]> * gnu/java/nio/FileChannelImpl.java: moved from gnu/java/nio/channels/FileChannelImpl.java. * gnu/java/nio/channels/FileChannelImpl.java: removed. * native/jni/java-