RFC: @Requires

2006-06-13 Thread Casey Marshall
Hi. I was thinking a little about how to properly document what permissions a method requires, and to help do static checking on Classpath when it comes to permissions. Usually the Javadoc for a method will declare what permissions it requires, and with what arguments, sometimes in a

[Bug awt/27960] CairoGraphics2D.setTransform() doesn't update clip

2006-06-13 Thread mark at gcc dot gnu dot org
--- Comment #1 from mark at gcc dot gnu dot org 2006-06-13 07:46 --- With Roman's latest patches jfreechart seems to look fine again. 2006-06-12 Roman Kennke [EMAIL PROTECTED] * gnu/java/awt/peer/gtk/CairoGraphics2D.java (copy): Use getClip() to copy the clip. Make

Re: Graphics2D security check

2006-06-13 Thread roman.kennke
Hi Gary, The setComposite method of anything that extends java.awt.Graphics2D is supposed to do a permisson check if ...this Graphics2D context is drawing to a Component on the display screen and the Composite is a custom object rather than an instance of the AlphaComposite class. The latter is

[Bug awt/27960] CairoGraphics2D.setTransform() doesn't update clip

2006-06-13 Thread david dot gilbert at object-refinery dot com
--- Comment #2 from david dot gilbert at object-refinery dot com 2006-06-13 08:23 --- (In reply to comment #1) Could you retest? It is working nicely again, thanks! the jfreechart superdemo is a really slow, but that seems to be caused by the text area on the bottom-right, not by

[Bug awt/27960] CairoGraphics2D.setTransform() doesn't update clip

2006-06-13 Thread mark at gcc dot gnu dot org
--- Comment #3 from mark at gcc dot gnu dot org 2006-06-13 08:29 --- Anyway, thanks to Roman for fixing the bug...please close it. Done as requested :) -- mark at gcc dot gnu dot org changed: What|Removed |Added

[Bug awt/27960] CairoGraphics2D.setTransform() doesn't update clip

2006-06-13 Thread mark at gcc dot gnu dot org
-- mark at gcc dot gnu dot org changed: What|Removed |Added Target Milestone|--- |0.92 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27960

Re: Graphics2D security check

2006-06-13 Thread Gary Benson
David Daney wrote: Roman Kennke wrote: Hi Gary, The setComposite method of anything that extends java.awt. Graphics2D is supposed to do a permisson check if ...this Graphics2D context is drawing to a Component on the display screen and the Composite is a custom object

[cp-patches] [generics] RFC: Add TimeUnit enum (without documentation)

2006-06-13 Thread Maciej Piechotka
2006-06-12 Maciej Piechotka [EMAIL PROTECTED] * java/util/concurrent/TimeUnit.java : Add TimeUnit enum. diff -ruN java.old/util/concurrent/#TimeUnit.java# java/util/concurrent/#TimeUnit.java# --- java.old/util/concurrent/#TimeUnit.java# 1970-01-01 01:00:00.0 +0100 +++

[cp-patches] RFQ: LockSupport utility class

2006-06-13 Thread Maciej Piechotka
2006-06-12 Maciej Piechotka [EMAIL PROTECTED] * java/util/concurrent/locks/LockSupport : Added diff -ruN java.old/util/concurrent/locks/LockSupport.java java/util/concurrent/locks/LockSupport.java --- java.old/util/concurrent/locks/LockSupport.java 1970-01-01 01:00:00.0 +0100

[cp-patches] FYI: Fixed Checkstyle warnings in javax.swing.plaf.basic.*

2006-06-13 Thread David Gilbert
This patch (committed) fixes some Checkstyle warnings regarding source code formattings in javax.swing.plaf.basic.*: 2006-06-13 David Gilbert [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicCheckBoxUI.java: Source code formatting changes only, *

[cp-patches] FYI: Popup fix

2006-06-13 Thread Roman Kennke
This fixes the global PopupHelper implementation so that it consumes the mouse event when popups have been closed. This also fixes the nasty ComboBox popup problem, where the popup helper closes the popup, and some listener (which receives the same event as the PopupHelper) toggles it open

[cp-patches] FYI: Fix Component/CairoGraphics deadlock and handle VolatileImages with identity transform

2006-06-13 Thread Mark Wielaard
Hi, We had another deadlock between ComponentGraphics and CairoGraphics if the image wasn't a BufferedImage already. Then CairoGraphics would try to convert the Image to an BuffereImage which in some cases would need the gdk lock. So this patch makes sure that ComponentGraphics always passes an

[cp-patches] Re: RFA JDWP ExceptionOnlyFilter

2006-06-13 Thread Kyle Galloway
The part that was removed upon commit actually introduced some logic changes to the constructor to allow it to filter on all exceptions. Here is another patch to correct the committed file. 2006-06-13 Kyle Galloway [EMAIL PROTECTED] *

[cp-patches] Patch: PixelGrabber fix

2006-06-13 Thread Lillian Angel
I found this problem when I tested this applet: http://www.btinternet.com/~se16/js/mapproj.htm The JDK doesnt care if the ImageProducer is null when passed to the constructor. 2006-06-13 Lillian Angel [EMAIL PROTECTED] * java/awt/image/PixelGrabber.java (PixelGrabber):

[cp-patches] Re: RFA JDWP ExceptionOnlyFilter

2006-06-13 Thread Keith Seitz
Kyle Galloway wrote: The part that was removed upon commit actually introduced some logic changes to the constructor to allow it to filter on all exceptions. Here is another patch to correct the committed file. 2006-06-13 Kyle Galloway [EMAIL PROTECTED] *

[cp-patches] FYI: BasicSliderUI fixes

2006-06-13 Thread David Gilbert
This patch (committed) is a partial fix for bug 27956. It modifies the slider geometry by a pixel here and a pixel there to match the reference implementation, and remove the visible clipping problem with the slider thumb: 2006-06-13 David Gilbert [EMAIL PROTECTED] *

[cp-patches] Re: RFA JDWP ClassUnloadEvent

2006-06-13 Thread Keith Seitz
Kyle Galloway wrote: Ok, fixed that, I think this is probably the better way to do it, I hadn't though about when the event would get passed from the VM and this will work both ways. I've committed this. Thanks. Keith

[cp-patches] Re: RFA JDWP ExceptionOnlyFilter

2006-06-13 Thread Kyle Galloway
2006-06-13 Kyle Galloway [EMAIL PROTECTED] * gnu/classpath/jdwp/event/filters/ExceptionOnlyFilter.java: Allow null refId. Keith Seitz wrote: Kyle Galloway wrote: The part that was removed upon commit actually introduced some logic changes to the constructor to allow it to filter on

[cp-patches] Re: RFA JDWP ExceptionOnlyFilter

2006-06-13 Thread Keith Seitz
Kyle Galloway wrote: 2006-06-13 Kyle Galloway [EMAIL PROTECTED] * gnu/classpath/jdwp/event/filters/ExceptionOnlyFilter.java: Allow null refId. Grr. I really hate to do this, but I just noticed... ExceptionOnlyFilter.matches doesn't handle the case where _refId is null. Since you're

[cp-patches] RFC: JCheckBoxMenuItem

2006-06-13 Thread Tania Bento
Hey, Before setting the value of the button's selected property to true, i added a check that ensures that state first be set to true. 2006-06-13 Tania Bento [EMAIL PROTECTED] * classpath/javax/swing/JCheckBoxMenuItem.java (JCheckBoxMenuItem): Added check to set the selected

[cp-patches] [cp-pathes] RFC: JMenuItem

2006-06-13 Thread Tania Bento
Hey, Changed the horizontal alignment from JButton.LEFT to JButton.LEADING. Could someone please approve this and commit it for me. Thanks. 2006-06-13 Tania Bento [EMAIL PROTECTED] * javax/swing/JMenuItem.java (init): Changed horizontalAlignment from JButton.LEFT to

[cp-patches] Re: [cp-pathes] RFC: JMenuItem

2006-06-13 Thread Tania Bento
Sorry... wrong patch. Here's the right one. On Tue, 2006-06-13 at 11:52 -0400, Tania Bento wrote: Hey, Changed the horizontal alignment from JButton.LEFT to JButton.LEADING. Could someone please approve this and commit it for me. Thanks. 2006-06-13 Tania Bento [EMAIL PROTECTED]

[cp-patches] FYI: CairoSurface fix

2006-06-13 Thread Sven de Marothy
Whoops! Two wrongs make a right, CairoSurface was allocating 4x too much memory due to an inconsistent row stride parameter. 2006-06-13 Sven de Marothy [EMAIL PROTECTED] * gnu/java/awt/peer/gtk/CairoSurface.java * native/jni/gtk-peer/gnu_java_awt_peer_gtk_CairoSurface.c

[cp-patches] RFC: AbstractButton

2006-06-13 Thread Tania Bento
Hey, In the constructor, focusable should be set to false and not true. Could someone please approve and commit this for me. Thanks a bunch. 2006-06-13 Tania Bento [EMAIL PROTECTED] * javax/swing/AbstractButton.java (AbstractButton): Set focusable to false, not true. Cheers,

Re: [cp-patches] RFC: JCheckBoxMenuItem

2006-06-13 Thread Thomas Fitzsimmons
Tania Bento wrote: Hey, Before setting the value of the button's selected property to true, i added a check that ensures that state first be set to true. 2006-06-13 Tania Bento [EMAIL PROTECTED] * classpath/javax/swing/JCheckBoxMenuItem.java (JCheckBoxMenuItem): Added check

Re: [cp-patches] RFC: AbstractButton

2006-06-13 Thread Thomas Fitzsimmons
Tania Bento wrote: Hey, In the constructor, focusable should be set to false and not true. Could someone please approve and commit this for me. Thanks a bunch. 2006-06-13 Tania Bento [EMAIL PROTECTED] * javax/swing/AbstractButton.java (AbstractButton): Set focusable to

Re: [cp-patches] Re: [cp-pathes] RFC: JMenuItem

2006-06-13 Thread Thomas Fitzsimmons
Tania Bento wrote: Sorry... wrong patch. Here's the right one. On Tue, 2006-06-13 at 11:52 -0400, Tania Bento wrote: Hey, Changed the horizontal alignment from JButton.LEFT to JButton.LEADING. Could someone please approve this and commit it for me. Thanks. 2006-06-13 Tania Bento [EMAIL

[cp-patches] Re: RFA JDWP ExceptionOnlyFilter

2006-06-13 Thread Kyle Galloway
Yeah, sorry, should have seen that before, I think when I changed the logic to compress it I may have destroyed that functionality. Anyways fixed now. 2006-06-13 Kyle Galloway [EMAIL PROTECTED] * gnu/classpath/jdwp/event/filters/ExceptionOnlyFilter.java: Allow null refId.

Re: [cp-patches] RFC: JCheckBoxMenuItem

2006-06-13 Thread David Gilbert
A couple of nits: - the ChangeLog entry doesn't need the 'classpath/' prefix; - I think the official coding style is to omit 'this.' for method calls. Regards, Dave Thomas Fitzsimmons wrote: Tania Bento wrote: Hey, Before setting the value of the button's selected property to true, i

[cp-patches] RFA: JDWP BreakpointEvent

2006-06-13 Thread Kyle Galloway
Small fix for BreakpointEvent for filter compatibility. Requesting approval and commit. - Kyle 2006-06-13 Kyle Galloway [EMAIL PROTECTED] * gnu/classpath/jdwp/event/BreakpointEvent.java : Added Object _instance for compatibility with filters. (getParameter): Modified to allow access

Re: [cp-patches] RFA: JDWP BreakpointEvent

2006-06-13 Thread Keith Seitz
Kyle Galloway wrote: Small fix for BreakpointEvent for filter compatibility. Requesting approval and commit. - Kyle 2006-06-13 Kyle Galloway [EMAIL PROTECTED] * gnu/classpath/jdwp/event/BreakpointEvent.java : Added Object _instance for compatibility with filters. (getParameter):

Re: [cp-patches] RFC: Combo box mouseclick

2006-06-13 Thread Francis Kung
After talking to rkennke, here is an alternate implementation to fix the same bug, which does not involve removing and re-adding listeners, nor consuming the mouseclick event (since this breaks other functionality). Regards, Francis 2006-06-13 Francis Kung [EMAIL PROTECTED] *

[cp-patches] Re: RFA JDWP ExceptionOnlyFilter

2006-06-13 Thread Keith Seitz
Kyle Galloway wrote: Yeah, sorry, should have seen that before, I think when I changed the logic to compress it I may have destroyed that functionality. Anyways fixed now. Committed. Keith

Re: [cp-patches] Patch: PixelGrabber fix

2006-06-13 Thread Tom Tromey
Lillian == Lillian Angel [EMAIL PROTECTED] writes: Lillian The JDK doesnt care if the ImageProducer is null when passed to the Lillian constructor. Lillian -if (ip == null) Lillian - throw new NullPointerException(The ImageProducer must not be null.); In cases like this it is nice to

Re: [cp-patches] Patch: PixelGrabber fix

2006-06-13 Thread Lillian Angel
On Tue, 2006-06-13 at 12:16 -0600, Tom Tromey wrote: Lillian == Lillian Angel [EMAIL PROTECTED] writes: Lillian The JDK doesnt care if the ImageProducer is null when passed to the Lillian constructor. Lillian -if (ip == null) Lillian - throw new NullPointerException(The

Re: [cp-patches] FYI: PixelGrabber fix

2006-06-13 Thread Lillian Angel
On Tue, 2006-06-13 at 15:01 -0400, Lillian Angel wrote: On Tue, 2006-06-13 at 12:16 -0600, Tom Tromey wrote: Lillian == Lillian Angel [EMAIL PROTECTED] writes: Lillian The JDK doesnt care if the ImageProducer is null when passed to the Lillian constructor. Lillian -if (ip ==

Re: [cp-patches] RFC: Combo box mouseclick

2006-06-13 Thread Roman Kennke
Hi Francis, After talking to rkennke, here is an alternate implementation to fix the same bug, which does not involve removing and re-adding listeners, nor consuming the mouseclick event (since this breaks other functionality). What I meant was something along the line of the attached patch.

Re: [cp-patches] Patch: PixelGrabber fix

2006-06-13 Thread David Gilbert
Lillian Angel wrote: On Tue, 2006-06-13 at 12:16 -0600, Tom Tromey wrote: In cases like this it is nice to have a comment, either in the javadoc or in the code, explaining what happens when ip==null. That way nobody will be tempted to add the check back in later. Good idea.

[cp-patches] FYI: MetalIconFactory fix

2006-06-13 Thread David Gilbert
This patch (committed) fixes the mask for the gradient paint on the slider thumb icons - one pixel was overwriting the thumb outline: 2006-06-13 David Gilbert [EMAIL PROTECTED] * javax/swing/plaf/metal/MetalIconFactory.java (HorizontalSliderThumbIcon.gradientMask): Modified

[cp-patches] Patch: gcjwebplugin fix

2006-06-13 Thread Lillian Angel
I moved the code to create the whitelist file from NP_Initialize to GCJ_New. The file should be opened for each applet instance created. This prevents any reading/writing/loading errors that were encountered. 2006-06-13 Lillian Angel [EMAIL PROTECTED] * native/plugin/gcjwebplugin.cc

Re: [cp-patches] [generics] RFC: Add TimeUnit enum (without documentation)

2006-06-13 Thread Tom Tromey
Maciej == Maciej Piechotka [EMAIL PROTECTED] writes: Maciej 2006-06-12 Maciej Piechotka [EMAIL PROTECTED] Maciej * java/util/concurrent/TimeUnit.java : Add TimeUnit enum. I hate to rain on your parade here... but we got approval from the FSF to check in the reference implementation of

[cp-testresults] FAIL: regressions for libgcj on Tue Jun 13 06:33:20 UTC 2006

2006-06-13 Thread cpdev
Baseline from: Sun Jun 11 19:03:20 UTC 2006 Regressions: FAIL: Thread_Sleep -O3 -findirect-dispatch output - bytecode-native test FAIL: Thread_Sleep -O3 output - bytecode-native test FAIL: Thread_Sleep output - bytecode-native test FAIL: Thread_Sleep output - gij test FAIL: Thread_Sleep output -

[cp-testresults] Japi diffs for classpath

2006-06-13 Thread Stuart Ballard
Japi diff jdk12 vs classpath: Full results: http://www.kaffe.org/~stuart/japi/htmlout/h-jdk12-classpath.html Changes since last run: -Comparison run at Mon Jun 12 09:56:00 2006 GMT -jdk12 API scanned at 2006/06/12 05:28:20 EDT -classpath API scanned at 2006/06/12 05:47:06 EDT +Comparison run at

[cp-testresults] FAIL: regressions for libgcj on Tue Jun 13 12:04:42 UTC 2006

2006-06-13 Thread cpdev
Baseline from: Sun Jun 11 19:03:20 UTC 2006 Regressions: FAIL: Thread_Sleep -findirect-dispatch output - bytecode-native test FAIL: Thread_Sleep output - bytecode-native test FAIL: Thread_Sleep output - source compiled test Totals: PASS: 4797 XPASS: 0 FAIL: 3 XFAIL: 12

[cp-testresults] FAIL: regressions for mauve-jamvm on Tue Jun 13 13:01:53 UTC 2006

2006-06-13 Thread cpdev
Baseline from: Tue Jun 13 07:35:08 UTC 2006 Regressions: FAIL: gnu.testlet.java.lang.Thread.sleep: Interrupted sleep (number 2) New fails: FAIL: gnu.testlet.gnu.javax.swing.text.html.parser.support.Parser.HTML_randomTable: Exception: java.lang.Exception: 'htmlhead/headbodytabletrtdC_0_0 td

[cp-testresults] FAIL: regressions for libgcj on Tue Jun 13 17:30:04 UTC 2006

2006-06-13 Thread cpdev
Baseline from: Sun Jun 11 19:03:20 UTC 2006 Regressions: FAIL: Thread_Sleep -O3 output - source compiled test FAIL: Thread_Sleep output - source compiled test Totals: PASS: 4798 XPASS: 0 FAIL: 2 XFAIL: 12 ___ Classpath-testresults mailing list

[cp-testresults] FAIL: regressions for mauve-jamvm on Tue Jun 13 18:28:40 UTC 2006

2006-06-13 Thread cpdev
Baseline from: Tue Jun 13 07:35:08 UTC 2006 Regressions: FAIL: gnu.testlet.java.lang.Thread.sleep: Interrupted sleep (number 2) New fails: FAIL: gnu.testlet.gnu.javax.crypto.jce.TestOfPR27849: (Encrypting) cipher.getIV() MUST NOT return null (number 1) FAIL:

[cp-testresults] FAIL: regressions for libgcj on Tue Jun 13 22:55:53 UTC 2006

2006-06-13 Thread cpdev
Baseline from: Sun Jun 11 19:03:20 UTC 2006 Regressions: FAIL: Thread_Sleep -O3 output - bytecode-native test FAIL: Thread_Sleep output - bytecode-native test Totals: PASS: 4798 XPASS: 0 FAIL: 2 XFAIL: 12 ___ Classpath-testresults mailing list

[cp-testresults] FAIL: regressions for mauve-jamvm on Tue Jun 13 23:54:49 UTC 2006

2006-06-13 Thread cpdev
Baseline from: Tue Jun 13 07:35:08 UTC 2006 Regressions: FAIL: gnu.testlet.java.lang.Thread.sleep: Interrupted sleep (number 2) New fails: FAIL: gnu.testlet.gnu.java.security.key.dss.TestOfDSSCodec abnormal termination 142 CRASH or TIMEOUT FAIL: gnu.testlet.gnu.javax.crypto.jce.TestOfPR27849:

[commit-cp] classpath ChangeLog javax/swing/plaf/basic/Basi...

2006-06-13 Thread David Gilbert
CVSROOT:/sources/classpath Module name:classpath Changes by: David Gilbert trebligd06/06/13 09:28:57 Modified files: . : ChangeLog javax/swing/plaf/basic: BasicCheckBoxUI.java BasicComboBoxUI.java

[commit-cp] classpath javax/swing/plaf/basicBasicLookAndFee...

2006-06-13 Thread Roman Kennke
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Roman Kennke rabbit78 06/06/13 12:37:56 Modified files: javax/swing/plaf/basic: BasicLookAndFeel.java java/awt : Component.java . : ChangeLog Log message: 2006-06-13

[commit-cp] classpath ChangeLog gnu/java/awt/peer/gtk/Cairo...

2006-06-13 Thread Mark Wielaard
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Mark Wielaard mark06/06/13 12:59:22 Modified files: . : ChangeLog gnu/java/awt/peer/gtk: CairoGraphics2D.java ComponentGraphics.java Log message:

[commit-cp] classpath ChangeLog java/awt/image/PixelGrabber...

2006-06-13 Thread Lillian Angel
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Lillian Angel langel 06/06/13 14:18:18 Modified files: . : ChangeLog java/awt/image : PixelGrabber.java Log message: 2006-06-13 Lillian Angel [EMAIL PROTECTED]

[commit-cp] classpath ChangeLog javax/swing/plaf/basic/Basi...

2006-06-13 Thread David Gilbert
CVSROOT:/sources/classpath Module name:classpath Changes by: David Gilbert trebligd06/06/13 15:10:39 Modified files: . : ChangeLog javax/swing/plaf/basic: BasicSliderUI.java Log message: 2006-06-13 David Gilbert [EMAIL PROTECTED]

[commit-cp] classpath ChangeLog gnu/classpath/jdwp/event/Cl...

2006-06-13 Thread Keith Seitz
CVSROOT:/sources/classpath Module name:classpath Changes by: Keith Seitz keiths06/06/13 15:17:08 Modified files: . : ChangeLog Added files: gnu/classpath/jdwp/event: ClassUnloadEvent.java Log message: From Kyle Galloway [EMAIL

[commit-cp] classpath ChangeLog gnu/java/awt/peer/gtk/Cairo...

2006-06-13 Thread Sven de Marothy
CVSROOT:/sources/classpath Module name:classpath Changes by: Sven de Marothy smarothy 06/06/13 15:59:36 Modified files: . : ChangeLog gnu/java/awt/peer/gtk: CairoSurface.java native/jni/gtk-peer: gnu_java_awt_peer_gtk_CairoSurface.c

[commit-cp] classpath ChangeLog gnu/classpath/jdwp/event/Br...

2006-06-13 Thread Keith Seitz
CVSROOT:/sources/classpath Module name:classpath Changes by: Keith Seitz keiths06/06/13 18:08:21 Modified files: . : ChangeLog gnu/classpath/jdwp/event: BreakpointEvent.java gnu/classpath/jdwp/event/filters: ExceptionOnlyFilter.java Log

[commit-cp] classpath ChangeLog java/awt/image/PixelGrabber...

2006-06-13 Thread Lillian Angel
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Lillian Angel langel 06/06/13 19:00:48 Modified files: . : ChangeLog java/awt/image : PixelGrabber.java Log message: 2006-06-13 Lillian Angel [EMAIL PROTECTED]

[commit-cp] classpath ChangeLog javax/management/AttributeN...

2006-06-13 Thread Andrew John Hughes
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Andrew John Hughes gnu_andrew 06/06/13 20:54:01 Modified files: . : ChangeLog Added files: javax/management: AttributeNotFoundException.java

[commit-cp] classpath ChangeLog javax/swing/plaf/metal/Meta...

2006-06-13 Thread David Gilbert
CVSROOT:/sources/classpath Module name:classpath Changes by: David Gilbert trebligd06/06/13 21:08:10 Modified files: . : ChangeLog javax/swing/plaf/metal: MetalIconFactory.java Log message: 2006-06-13 David Gilbert [EMAIL

[commit-cp] classpath ChangeLog native/plugin/gcjwebplugin.cc

2006-06-13 Thread Lillian Angel
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Lillian Angel langel 06/06/13 21:39:21 Modified files: . : ChangeLog native/plugin : gcjwebplugin.cc Log message: 2006-06-13 Lillian Angel [EMAIL PROTECTED]