[cp-patches] Patch for approval: JMenu setSelected behavior (bug 13683)

This patch is in reference to bug report 13683, JMenu setSelected behavior. Direct calls to setSelected no longer expand the popupMenu, although mouse events still do. This also allows direct calls to setSelected to select the menu even while it is disabled (as in the JDK), however it is not

[cp-patches] FYI: java-net native cleanup (and Socket timeouts)

Hi, This cleans up a lot of the java-net native code. In several places we were masking the actual exception by throwing a new exception. In other places we did cleanup before we used the result of perror() which meant that the error message was often bogus. We weren't checking whether system

[cp-patches] FYI: 2 JMenu related patches

I committed the patch I sent to the list earlier today which fixes bug 13683. Second patch fixes BasicMenuUI's handling of MouseEntered events. To comply with the JDK a top level menu shouldn't be selected upon a mouse entered event unless there was a previously selected menu in the same menubar

[cp-patches] FYI: Another small java.net exception hiding fixlet

Hi, Here is another fixlet to show the real cause of an exception in java.net: 2005-07-11 Mark Wielaard [EMAIL PROTECTED] * java/net/DatagramSocket.java (getImpl): Record cause of Exception. Committed, Mark diff -u -r1.44 DatagramSocket.java --- java/net/DatagramSocket.java2 Jul

[cp-patches] FYI: BasicMenuUI fixlet

This patch makes our JMenu usage more compatible with the reference implementation. Oddly enough, calls to JMenu.setSelected will allow more than one menu in a menubar to be selected, so I wrote popupVisible to make clear the criteria for selecting a menu due to a mouse entered event. Removing

[cp-patches] FYI: JFileChooser.getSelectedFiles() fixlet

Hi, While testing Jump a bit I noticed that you can call getSelectedFiles() even if in single file selection mode. So this patch makes sure getSelectedFiles() does return something in that case. 2005-07-11 Mark Wielaard [EMAIL PROTECTED] * javax/swing/JFileChooser.java

[cp-patches] Patch: Demo tree

2005-07-11 Lillian Angel [EMAIL PROTECTED] * examples/gnu/classpath/examples/swing/Demo.java (mkTree): fixed so the JTree appears properly. Index: examples/gnu/classpath/examples/swing/Demo.java === RCS file:

[cp-patches] FYI: GtkImage Error handling (2)

Previous patch is wrong. This one is right. 2005-07-11 Sven de Marothy [EMAIL PROTECTED] * gnu/java/awt/peer/gtk/GtkImage.java: (setImage): Set error flag on bad width, height or pixels. (checkImage): Return error flag. -- Sven de Marothy [EMAIL PROTECTED] Index:

[cp-patches] FYI GtkImage error handling

2005-07-11 Sven de Marothy [EMAIL PROTECTED] * gnu/java/awt/peer/gtk/GtkImage.java: (setImage): Set error flag on bad width, height or pixels. (checkImage): Return error flag. -- Sven de Marothy [EMAIL PROTECTED] Index: gnu/java/awt/peer/gtk/GtkImage.java

[cp-patches] FYI: new icons in MetalIconFactory

I committed this patch to add support for the JSlider thumb icons in MetalIconFactory: 2005-07-11 David Gilbert [EMAIL PROTECTED] * javax/swing/plaf/metal/MetalIconFactory.java (HorizontalSliderThumbIcon): new inner class, (VerticalSliderThumbIcon): new inner class,

[cp-patches] FYI: minor API doc fixes in java.io.*

I committed this patch: 2005-07-11 David Gilbert [EMAIL PROTECTED] * java/io/DataOutput.java: fixed minor API doc errors, * java/io/LineNumberInputStream.java: likewise. Regards, Dave Gilbert Index: java/io/DataOutput.java

[cp-patches] FYI: ParserDelegator compatibility fix.

Roman says this is required to compile the class with JDK1.3's javac (and only for that compiler). 2005-07-12 Audrius Meskauskas [EMAIL PROTECTED] * javax/swing/text/html/parser/ParserDelegator.java (gnuParser.getDTD): added super. to refer the inherited field more obvious. Index:

Re: [cp-patches] FYI: ParserDelegator compatibility fix.

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, could you please add a small comment that this is a workaround for 1.3's javac to make sure no one removes it when the next spring clean happens. :) cu Robert Meskauskas Audrius wrote: Roman says this is required to compile the class with

[cp-patches] [patch] indent gdk_threads calls in GTK peers

Hi, I committed this patch. It is mostly a formatting change that makes it clearer which native functions are run with the GDK lock held. This patch may cause some temporary regressions as I separated it out from other work I had in my tree, but I'll fix any problems in the next few days. Tom

Re: [cp-patches] FYI: file locks

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, should that patch allow me to run Eclipse without -Dosgi.locking=none? cu Robert Casey Marshall wrote: Hi, I'm checking in this little patch that implements file locks in gnu.java.nio.channels.FileChannelImpl. This just uses straight C in

Re: [cp-patches] [patch] malloc - g_malloc, free - g_free

Tom == Thomas Fitzsimmons [EMAIL PROTECTED] writes: Tom We should use the g_ variants of malloc and free in the GTK peers. I Tom committed this patch. We could try poisoning 'malloc' and 'free' (and realloc I suppose) in some gtk-peer-specific header. This would have to be conditional on gcc

Re: [cp-patches] FYI: file locks

On Jul 11, 2005, at 5:14 PM, Robert Schuster wrote: Hi, should that patch allow me to run Eclipse without - Dosgi.locking=none? It might. I don't know what Eclipse does internally, but if it uses FileChannel.lock and you are running on a platform that supports the 'fcntl' function,

Re: regression in logger?

David P Grove wrote: This started showing up in regression tests of Jikes RVM with classpath cvs head recently. I haven't dug deeply, so it could be a latent problem in Jikes RVM that was exposed by a classpath change, rather than a real classpath bug, but might still be worth mentioning.

Re: String.equals optimisation

On Tue, 2005-07-12 at 11:02 +1200, Simon Kitching wrote: It would certainly be nice to know that collection methods will automatically work more efficiently when the objects being manipulated are String objects that have been interned (of course String.intern has to be used appropriately).

String class: hack for ORP 1.0.9

Hi, In String.java there is this piece of code: public char[] toCharArray() { // XXX ORP 1.0.9 crashes on (char[]) clone() during bootstrap, so we // omit this optimization for now. // if (count == value.length) // return (char[]) value.clone(); char[] copy = new

Re: String.equals optimisation

Simon Kitching wrote:. * Class.getName returns strings that have been interned. I don't think this is explicitly required by the java specs but is certainly true for Sun's JVM and seems likely to be done by any sensible JVM. You definitely make some good arguments, but this one is not

Re: String class: hack for ORP 1.0.9

Simon Kitching wrote: public char[] toCharArray() { // XXX ORP 1.0.9 crashes on (char[]) clone() during bootstrap, so we // omit this optimization for now. // if (count == value.length) // return (char[]) value.clone(); char[] copy = new char[count];

Re: regression in logger?

On Jul 11, 2005, at 4:54 AM, David P Grove wrote: This started showing up in regression tests of Jikes RVM with classpath cvs head recently. I haven't dug deeply, so it could be a latent problem in Jikes RVM that was exposed by a classpath change, rather than a real classpath bug, but

Re: String.equals optimisation

Hi Archie, On Mon, 2005-07-11 at 20:27 -0500, Archie Cobbs wrote: Simon Kitching wrote:. * Class.getName returns strings that have been interned. I don't think this is explicitly required by the java specs but is certainly true for Sun's JVM and seems likely to be done by any

[commit-cp] classpath ./ChangeLog javax/swing/JInternalFram...

CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Roman Kennke [EMAIL PROTECTED]05/07/11 11:57:23 Modified files: . : ChangeLog javax/swing: JInternalFrame.java javax/swing/plaf/basic:

[commit-cp] classpath ./ChangeLog include/gnu_java_nio_chan...

CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Mark Wielaard [EMAIL PROTECTED] 05/07/11 17:27:55 Modified files: . : ChangeLog include: gnu_java_nio_channels_FileChannelImpl.h

[commit-cp] classpath ./ChangeLog javax/swing/plaf/basic/Ba...

CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Anthony Balkissoon [EMAIL PROTECTED] 05/07/11 18:07:15 Modified files: . : ChangeLog javax/swing/plaf/basic: BasicMenuUI.java Log message: 2005-07-11 Anthony

[commit-cp] classpath ./ChangeLog java/net/DatagramSocket.java

CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Mark Wielaard [EMAIL PROTECTED] 05/07/11 18:38:12 Modified files: . : ChangeLog java/net : DatagramSocket.java Log message: *

[commit-cp] classpath ChangeLog

CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Roman Kennke [EMAIL PROTECTED]05/07/11 19:51:05 Modified files: . : ChangeLog Log message: Cleaned up the ChangeLog a bit. CVSWeb URLs:

[commit-cp] classpath ./ChangeLog javax/swing/plaf/basic/Ba...

CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Lillian Angel [EMAIL PROTECTED] 05/07/11 20:13:56 Modified files: . : ChangeLog javax/swing/plaf/basic: BasicLookAndFeel.java Log message: 2005-07-11

[commit-cp] classpath ./ChangeLog javax/swing/JInternalFram...

CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Roman Kennke [EMAIL PROTECTED]05/07/11 20:55:44 Modified files: . : ChangeLog javax/swing: JInternalFrame.java Log message: 2005-07-11 Roman Kennke

[commit-cp] classpath gnu/java/awt/peer/gtk/GtkImage.java ....

CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Sven de Marothy [EMAIL PROTECTED] 05/07/11 21:11:20 Modified files: gnu/java/awt/peer/gtk: GtkImage.java . : ChangeLog Log message: 2005-07-11 Sven de Marothy

[commit-cp] classpath ./ChangeLog java/io/DataOutput.java j...

CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: David Gilbert [EMAIL PROTECTED] 05/07/11 22:02:29 Modified files: . : ChangeLog java/io: DataOutput.java LineNumberInputStream.java Log message:

[commit-cp] classpath ./ChangeLog gnu/java/awt/peer/gtk/Gtk...

CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Thomas Fitzsimmons [EMAIL PROTECTED] 05/07/11 23:27:43 Modified files: . : ChangeLog gnu/java/awt/peer/gtk: GtkChoicePeer.java include:

[commit-cp] classpath ./ChangeLog native/jni/gtk-peer/gnu_j...

CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Thomas Fitzsimmons [EMAIL PROTECTED] 05/07/11 23:55:27 Modified files: . : ChangeLog native/jni/gtk-peer: gnu_java_awt_peer_gtk_GdkGraphics2D.c Log message: