Re: [cp-patches] FYI: Implemented some methods javax.swing.text.AbstractDocument

2005-04-23 Thread Mark Wielaard
Hi Roman, On Sat, 2005-04-23 at 10:41 +0200, Roman Kennke wrote: 2005-04-23 Roman Kennke [EMAIL PROTECTED] * javax/swing/text/AbstractDocument.java (getDocumentProperties): Implemented. (setDocumentProperties): Implemented. (getProperty): Implemented.

[cp-patches] FYI: Better MalformedURLException

2005-04-23 Thread Mark Wielaard
Hi, The following helped me a lot with debugging some URL problem. It simply adds the spec to parse as URL to the MalformedURLException of the URL constructor when there is a null context. 2005-04-23 Mark Wielaard [EMAIL PROTECTED] * java/net/URL.java (URL(URL,String,URLStreamHandler

[cp-patches] RFC: Some iconv provider (build) fixes

2005-04-24 Thread Mark Wielaard
like darwin, freebsd or solaris. 2005-04-24 Mark Wielaard [EMAIL PROTECTED] * iconv.m4: New file. * configure.ac: Use AM_ICONV. * native/jni/java-nio/Makefile.am (libjavanio_la_LIBADD): Add LTLIBICONV. * native/jni/java-nio

[cp-patches] FYI: FileNotFoundException for opening dirs as files

2005-05-01 Thread Mark Wielaard
Hi, This is the patch that Jeroen and Dalibor discussed a while ago to fix the regression with respect to not throwing a FileNotFoundException when opening a dir as FileInputStream or RandomAccessFile. It has been in kaffe CVS for more then a month already. All my smoke tests pass. And it fixes a

Re: [cp-patches] [patch] document BufferCapabilities

2005-05-05 Thread Mark Wielaard
initialized. if (front == null || back == null) ^ ../java/awt/BufferCapabilities.java:151: error: variable 'flip' may not have been initialized. this.flip = flip; ^ 3 errors Obvious fix checked into GNU Classpath CVS: 2005-05-04 Mark Wielaard [EMAIL PROTECTED

[cp-patches] FYI: Update looking at proprietary source faq answer

2005-05-11 Thread Mark Wielaard
-05-11 Mark Wielaard [EMAIL PROTECTED] * doc/www.gnu.org/faq/faq.wml: Update looking at proprietary source code entry. Committed, Mark Index: doc/www.gnu.org/faq/faq.wml === RCS file: /cvsroot/classpath/classpath/doc

Re: [cp-patches] FYI/RFC: Implemented missing methods in javax.swing.JComponent

2005-05-17 Thread Mark Wielaard
about the ^ 1 error Fixed by just removing that character from the source file. 2005-05-15 Mark Wielaard [EMAIL PROTECTED] * javax/swing/JComponent.java: Removed invalid char from comment. BTW. For those that have commit access, please fix issues like these that are obviously some

Re: [cp-patches] FYI: SizeRequirements.java: fixed two non-utf8 chars

2005-05-23 Thread Mark Wielaard
Hi, On Fri, 2005-05-20 at 11:19 +0200, Roman Kennke wrote: Hmm, this is the second time that I introduce strange characters in the source code. I wonder how that comes, I am using Emacs under Linux like always. This is really strange. Anybody has a hint on this, how I could detect such

Re: [cp-patches] FYI: Second round of java.net.URI fixes

2005-05-23 Thread Mark Wielaard
Hi Andrew, On Thu, 2005-05-19 at 20:14 +0100, Andrew John Hughes wrote: I'm committing the attached patch, which implements the remaining unimplemented methods in java.net.URI (stubs up until now). I'll shortly be adding some Mauve tests to accompany them. It's solved a number of issues in my

Re: [cp-patches] Patch: RFC: add --with-vm-classes

2005-05-24 Thread Mark Wielaard
Hi, On Thu, 2005-05-05 at 11:14 -0600, Tom Tromey wrote: I'm not checking this in yet; I wanted commentary before doing so. I've been working on the Big Classpath Merge for libgcj. The idea here is to eliminate libgcj/classpath cross-merging by simply dropping a copy of the classpath tree

Re: [cp-patches] TimeZone strings

2005-05-24 Thread Mark Wielaard
Hi Sven, On Mon, 2005-05-16 at 19:15 +0200, Sven de Marothy wrote: This reimplements the getDefaultTimeZone method of java.util.TimeZone. It could probably be done in less code. I'm lame though. Now it can parse the syntax of the glibc/POSIX TZ string:

Re: [cp-patches] FYI: Implemented class InternationalFormatter

2005-06-14 Thread Mark Wielaard
I have disabled it for now to make building of CVS with gcj possible again. 2005-06-14 Mark Wielaard [EMAIL PROTECTED] * javax/swing/text/InternationalFormatter.java (clone): Disabled. I have filed this as: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22060 Cheers, Mark

Re: [cp-patches] Patch: FYI: new --with-vm-classes option

2005-06-14 Thread Mark Wielaard
Hi Tom, On Tue, 2005-06-14 at 15:13 -0600, Tom Tromey wrote: I'm checking this in on the trunk. This adds the new '--with-vm-classes' option to allow the libgcj big merge to proceed. This lets a VM override some Classpath sources with its own. It also adds a new --with-glibj setting, so

[cp-patches] FYI: make distcheck fixlet

2005-06-15 Thread Mark Wielaard
Hi, This fixes the make distcheck failure by removing the new temporary files created by gen-classlist.sh. 2005-06-15 Mark Wielaard [EMAIL PROTECTED] * lib/gen-classlist.sh.in: Remove vm.omit, vm.add and tmp.omit files after use. Committed, Mark diff -u -r1.25 gen

Re: [cp-patches] Patch for logging

2005-06-20 Thread Mark Wielaard
Hi Chris, On Sat, 2005-06-18 at 13:31 +0100, Chris Burdess wrote: This patch sets the root logger's level to INFO. The root logger's behaviour is inherited by all loggers by default, so this specifies the default level. This means that by default, loggers will actually log something.

Re: [cp-patches] FYI: Null check after dereference in javax.swing.DefaultDesktopManager

2005-06-21 Thread Mark Wielaard
().getPreferredSize(); -if (desktopPane == null) - return frame.getDesktopIcon().getBounds(); - Component[] frames = desktopPane.getComponents(); int count = 0; Seems your change and Roman's reformatting clashed. This patch fixes it again: 2005-06-20 Mark Wielaard [EMAIL

Re: [cp-patches] FYI: javax/swing/JScrollPane.java

2005-06-22 Thread Mark Wielaard
Hi, On Mon, 2005-06-20 at 17:20 +0200, Roman Kennke wrote: Lillian Angel wrote: JScrollPane was not initializing the view when the view is null. 2005-06-20 Lillian Angel [EMAIL PROTECTED] * javax/swing/JScrollPane.java (JScrollPane): Viewport was not being set when

Re: [cp-patches] FYI: javax/swing/JScrollPane.java

2005-06-22 Thread Mark Wielaard
Hi, On Wed, 2005-06-22 at 15:36 +0200, Mark Wielaard wrote: With my patch reapplied that issue goes away. And IDB starts up again. But according to bug #13439 swing: regression with omniscient debugger https://savannah.gnu.org/bugs/?func=detailitemitem_id=13439 this isn't a full solution

[cp-patches] GdkPixbufDecoder fix

2005-06-22 Thread Mark Wielaard
Hi, This fixes loading of small images with GdkPixbufDecoder. We need to explicitly tell gdk-pixbuf that we are done feeding it image bytes. I also took the opportunity to add extra error checking. 2005-06-22 Mark Wielaard [EMAIL PROTECTED] * gnu/java/awt/peer/gtk

[cp-patches] Re: GdkPixbufDecoder fix

2005-06-23 Thread Mark Wielaard
On Thu, 2005-06-23 at 01:31 +0200, Mark Wielaard wrote: 2005-06-22 Mark Wielaard [EMAIL PROTECTED] * gnu/java/awt/peer/gtk/GdkPixbufDecoder.java (pumpBytes): Throws IOException. (pumpDone): New native method. (produce): Call pumpDone(). * include

Re: [cp-patches]: Patch: JTree related class' implementations

2005-06-28 Thread Mark Wielaard
Hi, On Tue, 2005-06-28 at 12:35 +0200, Roman Kennke wrote: It looks like you introduced TABs all over the files. You should never use tabs, this may come out very ugly, depending on the user's setting of TAB widths. To keep consistency with other GNU styles and tools indentation uses tabs and

[cp-patches] FYI: Make JTextPane work

2005-06-30 Thread Mark Wielaard
Hi, This patch makes JTextPane work for programs (like JFreeChart) which use it. Unfortunately it was (and still is) a complete stub. I was tempted to just rip it out. But the JEditorPane.getEditorKit() fix is real. 2005-06-30 Mark Wielaard [EMAIL PROTECTED] * javax/swing

Re: [cp-patches] RFC: gnu.java.locale.LocaleHelper fix

2005-06-30 Thread Mark Wielaard
Hi Andrew, On Thu, 2005-06-30 at 17:59 +0100, Andrew John Hughes wrote: This patch fixes LocaleHelper to use the new property files (and hence fixes the Currency class). Appears to have been missed previously. 2005-06-30 Andrew John Hughes [EMAIL PROTECTED] *

[cp-patches] The tree is open for 0.16+!

2005-06-30 Thread Mark Wielaard
Hi all, Tagged, build release, tested and uploading as we speak. So here is the patch to reopen the tree for our work on 0.17. 2005-06-30 Mark Wielaard [EMAIL PROTECTED] * configure.ac: Set version to 0.16+cvs. Cheers, Mark diff -u -r1.90 configure.ac --- configure.ac30 Jun

[cp-patches] Re: [commit-cp] classpath ./ChangeLog gnu/xml/dom/DomDocument.j...

2005-07-01 Thread Mark Wielaard
Hi Chris, On Thu, 2005-06-30 at 18:09 -0400, Chris Burdess wrote: CVSROOT: /cvsroot/classpath Module name: classpath Branch: Changes by: Chris Burdess [EMAIL PROTECTED] 05/06/30 22:09:07 Reading the main mailinglist I see this wasn't a mistaken commit. But I didn't see a

Re: [cp-patches] Re: Serialization: readResolve and writeReplace in parent class

2005-07-03 Thread Mark Wielaard
Hi, On Mon, 2005-06-27 at 19:32 +0200, Daniel Bonniot wrote: I wonder if there is a strange case here where someone adds a private method to the class hierarchy later (after all the other classes are compiled). Should the private method hide the superclass methods of the same signature?

[cp-patches] FYI: Correctly close gdk_pixbuf_loader

2005-07-04 Thread Mark Wielaard
Hi, This adds the bookkeeping needed to correctly close the gdk_pixbuf_loader as pointed out by my glib_log patch last week. 2005-07-04 Mark Wielaard [EMAIL PROTECTED] * gnu/java/awt/peer/gtk/GdkPixbufDecoder.java (initialized): Remove unused field. (needsClose): New

Re: [cp-patches] [patch] refactor text peers to remove GtkTextComponentPeer

2005-07-05 Thread Mark Wielaard
. Please be a bit more careful. This broke the build since you forgot to change the include file generation. And --enable-Werror since classpath_gtk_component_connect_signals and the nonfocus variant are not actually implemented. Fixed as follows: 2005-07-05 Mark Wielaard [EMAIL PROTECTED

Re: [cp-patches] FYI: Jlabel revert

2005-07-05 Thread Mark Wielaard
Hi Sven, On Tue, 2005-07-05 at 14:16 +0200, Sven de Marothy wrote: 2005-07-05 Sven de Marothy [EMAIL PROTECTED] * javax/swing/JLabel.java: (JLabel): Revert previous change for JLabel(Icon) constructor. Could you next time please mention the actual change. Your previous change

Re: [cp-patches] [patch] refactor text peers to remove GtkTextComponentPeer

2005-07-05 Thread Mark Wielaard
On Tue, 2005-07-05 at 11:22 -0400, Thomas Fitzsimmons wrote: Should I be building with --enable-Werror? I plan to commit another patch today that will eliminate these warnings and I thought it was acceptable to introduce temporary warnings. If not, --enable-Werror should be the default.

Re: [cp-patches] Re: Serialization: readResolve and writeReplace in parent class

2005-07-05 Thread Mark Wielaard
On Tue, 2005-07-05 at 10:41 -0600, Tom Tromey wrote: Mark == Mark Wielaard [EMAIL PROTECTED] writes: Suppose you have a hierarchy like: class A { blah blah readResolve() } class B extends A { } class C extends B { } You compile all of these. Then you go back and add 'private

Re: [cp-patches] Re: Patch: dependency tracking with gcj

2005-07-08 Thread Mark Wielaard
Hi, On Thu, 2005-07-07 at 22:25 +0200, Mark Wielaard wrote: On Wed, 2005-07-06 at 15:59 -0600, Tom Tromey wrote: Tom == Tom Tromey [EMAIL PROTECTED] writes: Tom This patch adds real dependency tracking when compiling with gcj. I am checking this in. This seems to break builddir

Re: [cp-patches] [RFA] broken links in hacking.texinfo

2005-07-08 Thread Mark Wielaard
Hi Aaron, On Thu, 2005-07-07 at 17:05 -0400, Aaron Luchko wrote: 2005-07-07 Aaron Luchko [EMAIL PROTECTED] * doc/hacking.texinfo: Fixed broken links to GNU Coding Standards to point to http://www.gnu.org/prep/standards/ Please commit this. Thanks, Mark signature.asc

Re: [cp-patches] PATCH: logfile rotation, native methods

2005-07-08 Thread Mark Wielaard
Hi Casey, On Thu, 2005-07-07 at 23:17 -0700, Casey Marshall wrote: One feature this implementation requires, in order to function properly, are file locks, which to my dismay are still not implemented. On that point, I'd like to ask what the requirements on JNI code are for Classpath,

[cp-patches] FYI: java-net native cleanup (and Socket timeouts)

2005-07-11 Thread Mark Wielaard
the failure in the jni code. So socket timeouts didn't work at all. 2005-07-10 Mark Wielaard [EMAIL PROTECTED] * native/jni/java-net/gnu_java_net_PlainDatagramSocketImpl.c: Whenever an ExceptionOccurred just return to throw it, don't mask. * native/jni/java-net/javanet.c

[cp-patches] FYI: Another small java.net exception hiding fixlet

2005-07-11 Thread Mark Wielaard
Hi, Here is another fixlet to show the real cause of an exception in java.net: 2005-07-11 Mark Wielaard [EMAIL PROTECTED] * java/net/DatagramSocket.java (getImpl): Record cause of Exception. Committed, Mark diff -u -r1.44 DatagramSocket.java --- java/net/DatagramSocket.java2 Jul

[cp-patches] FYI: JFileChooser.getSelectedFiles() fixlet

2005-07-11 Thread Mark Wielaard
Hi, While testing Jump a bit I noticed that you can call getSelectedFiles() even if in single file selection mode. So this patch makes sure getSelectedFiles() does return something in that case. 2005-07-11 Mark Wielaard [EMAIL PROTECTED] * javax/swing/JFileChooser.java

[cp-patches] FYI: JTextComponent.CaretBlinkTimer fixlet

2005-07-12 Thread Mark Wielaard
Hi, From time to time the JTextComponent.CaretBlinkTimer would fire while the caret was null. Resulting in nasty exceptions. This patch guards all uses of caret in the Timer with a check to make sure the caret actually exists. 2005-07-12 Mark Wielaard [EMAIL PROTECTED] * javax/swing

[cp-patches] FYI: Make MediaTRacker handle Images that didn't properly load

2005-07-12 Thread Mark Wielaard
the status. And since checkImage() itself doesn't in itself try to load the image, we do still need the prepareImage() call to kick off the loading. 2005-07-12 Mark Wielaard [EMAIL PROTECTED] * java/awt/MediaTracker.java (checkAll): Set and check status of MediaEntry with checkImage

[cp-patches] Some accessor relaxing for inner classes

2005-07-13 Thread Mark Wielaard
which needs an extra synthetic access method), I fixed the most prominent issues it pointed out. That didn't help unfortunately. It still is a good practice. So I am checking in the following: 2005-07-14 Mark Wielaard [EMAIL PROTECTED] * examples/gnu/classpath/examples/awt/Demo.java

Re: [cp-patches] Logging fixes

2005-07-14 Thread Mark Wielaard
Hi, On Wed, 2005-07-13 at 21:54 +0200, Guilhem Lavaux wrote: 2005-07-13 Guilhem Lavaux [EMAIL PROTECTED] * java/util/logging/Logger.java (resetLogger): Remove all handlers from the handler list. * java/util/logging/LogManager.java (reset): Call

Re: [cp-patches] [patch] refactor GTK event handling

2005-07-14 Thread Mark Wielaard
Hi, On Thu, 2005-07-14 at 18:17 -0400, Thomas Fitzsimmons wrote: This large patch does several things. Just for the record we coordinated this on irc to make sure it would not break the build just before the release. I intend to go over our list of issues tomorrow morning and make a 0.17

[cp-patches] FYI: Make texi2html work for newer versions

2005-07-15 Thread Mark Wielaard
Hi, Newer texi2html versions are a bit more strict in what they expect. This makes our html generation for texinfo files work nicely again. 2005-07-15 Mark Wielaard [EMAIL PROTECTED] * hacking.texinfo: @setchapternewpage off. * vmintegration.texinfo: Likewise

Re: [cp-patches] RFC; VM Integration Documentation Update

2005-07-15 Thread Mark Wielaard
Hi, 2005-06-30 Andrew John Hughes [EMAIL PROTECTED] * doc/vmintegration.texinfo: Updated 'Classpath Hooks' section. Thanks! This looks really nice is a really good overview. There has been lots of questions about this part so I committed this now to make it part of the 0.17

Re: [cp-patches] FYI: actioncommand fixes

2005-07-15 Thread Mark Wielaard
Hi, On Fri, 2005-07-15 at 10:59 +0200, Roman Kennke wrote: I have applied all patches and still breaks my app. I get an actionCommand of null where is expected at the very least. If it still matters (I committed a fix in the meantime) I could try to boil this case down to a simple

[cp-patches] FYI: Another icons fixlet

2005-07-15 Thread Mark Wielaard
. (The BasicLookAndFeel doesn't support icons and the MetalLookAndFeel now uses the MetalIconFactory.) 2005-07-15 Mark Wielaard [EMAIL PROTECTED] * lib/standard.omit: Only list gnu/javax/swing/plaf/gtk/.*java and README explicitly, not the icons. * examples/gnu/classpath/examples/swing

[cp-patches] Last 0.17 patch

2005-07-15 Thread Mark Wielaard
2005-07-15 Mark Wielaard [EMAIL PROTECTED] * NEWS: Add 0.17 release date and new features. * configure.ac: Set version to 0.17. Tagging and uploading now. Index: NEWS === RCS file: /cvsroot/classpath/classpath/NEWS

[cp-patches] FYI: 0.17 announcement

2005-07-15 Thread Mark Wielaard
Hi, this update the version to 0.17+cvs and adds the announcement to the webpages. 2005-07-15 Mark Wielaard [EMAIL PROTECTED] * configure.ac: Set version to 0.17+cvs. * doc/www.gnu.org/announce/20050715.wml: New file. * doc/www.gnu.org/newsitems.txt: Add announcement

Re: [cp-patches] [RFA] update to eclipse formatter settings

2005-07-20 Thread Mark Wielaard
Hi, On Thu, 2005-07-07 at 16:13 -0400, Aaron Luchko wrote: I've found a couple issues with the style formatter included in .settings/org.eclipse.jdt.core.prefs The guidelines I'm going by are here, Implements and extends on separate lines, throws too. Indent extends, implements, throws.

Re: [cp-patches] FYI: file locks

2005-07-20 Thread Mark Wielaard
Hi, On Mon, 2005-07-11 at 21:37 -0700, Casey Marshall wrote: On Jul 11, 2005, at 5:14 PM, Robert Schuster wrote: Hi, should that patch allow me to run Eclipse without - Dosgi.locking=none? It might. I don't know what Eclipse does internally, but if it uses FileChannel.lock and you

[cp-patches] Re: String class: hack for ORP 1.0.9

2005-07-20 Thread Mark Wielaard
Hi David, On Tue, 2005-07-12 at 08:06 -0400, David P Grove wrote: So, I'm having a hard time seeing how this optimization actually makes the code faster under any reasonable assumptions of what an optimizing JIT is going to do. It seems mostly harmless to have it (although it makes the

Re: [cp-patches] Patch: BasicTreeUI, preferredsize and double clicking

2005-07-21 Thread Mark Wielaard
On Thu, 2005-07-21 at 10:33 -0400, Lillian Angel wrote: --- examples/gnu/classpath/examples/swing/Demo.java 21 Jul 2005 14:13:36 - 1.16 +++ examples/gnu/classpath/examples/swing/Demo.java 21 Jul 2005 14:30:33 - @@ -70,7 +70,7 @@

Re: [cp-patches] RFC: misc NIO fixes

2005-07-21 Thread Mark Wielaard
Hi, On Tue, 2005-07-19 at 09:12 -0500, Archie Cobbs wrote: Casey Marshall wrote: Attached is a patch I'd like to get some comments on, before I check it in, especially if anyone can spot holes in my C. This patch + /* FIXME: I'd bet dollars for donuts the compiler optimizes this +

[cp-patches] FYI: gtk-plaf cleanup

2005-07-24 Thread Mark Wielaard
these files (sorry Brian). 2005-07-23 Mark Wielaard [EMAIL PROTECTED] * lib/standard.omit: Don't omit gnu/javax/swing/plaf/gtk files. * lib/Makefile.am (dist-hook): Don't remove standard.omit dirs. * gnu/javax/swing/plaf/gtk/GtkBorders.java: Removed. * gnu/javax/swing/plaf/gtk

Re: [cp-patches] [generics] Enum#valueOf implementation

2005-07-25 Thread Mark Wielaard
On Mon, 2005-07-25 at 00:33 -0600, Tom Tromey wrote: Ewout == Ewout Prangsma [EMAIL PROTECTED] writes: Ewout Here's the unified diff. Again my question if someone can Ewout commit this, or give me CVS access rights. It still needs a ChangeLog entry. Also the code is not formatted

[cp-patches] FYI: Update assign faq entry

2005-07-25 Thread Mark Wielaard
can get a grant-back for any contribution you made for use in other projects (even proprietary) if you wish. Here it is. 2005-07-25 Mark Wielaard [EMAIL PROTECTED] * doc/www.gnu.org/faq.wml: Expand contribution assign answer. Committed, Mark ? doc/www.gnu.org/downloads.diff ? doc

Re: [cp-patches] RFC: RMI Class loader fix

2005-07-25 Thread Mark Wielaard
Hi, On Mon, 2005-07-25 at 14:52 +0200, Jeroen Frijters wrote: I'm not an RMI person, but an IKVM user ran into an RMI problem that I think is caused by a problem in the RMI class loader that the attached patch should fix. Please comment. I assume this is because the code tries to load an

RE: [cp-patches] FYI: ClassLoader caching Part 2

2005-07-25 Thread Mark Wielaard
Hi Jeroen, On Mon, 2005-07-25 at 18:17 +0200, Jeroen Frijters wrote: Is this an important scenario? I thought you long haired types didn't like binary distributions ;-) He he. Sure we don't. But if you follow the harmony effort of the cleanly shaved apache types you will have noticed that they

Re: [cp-patches] RFC: New JCL helper functions for RawData handling

2005-07-25 Thread Mark Wielaard
Hi, On Mon, 2005-07-25 at 19:21 +0200, Guilhem Lavaux wrote: Ok. Then I will make a set of patches to first use the new common JCL interface. And then I will rename RawData* to Pointer*. Is it ok ? Yes please. And for extra bonus points you could add a little thing to the Hacker Guide about

Re: [cp-patches] [patch] fix memory image source handling in GTK peers

2005-07-26 Thread Mark Wielaard
Hi, On Mon, 2005-07-25 at 21:56 -0400, Thomas Fitzsimmons wrote: @@ -372,8 +374,28 @@ if (x == 0 y == 0 width == 0 height == 0) return; -q().postEvent (new PaintEvent (awtComponent, PaintEvent.UPDATE, - new Rectangle (x, y, width,

Re: [cp-patches] FYI: Minor tweak to java.awt.List

2005-07-26 Thread Mark Wielaard
Hi, On Sat, 2005-07-23 at 18:00 +0200, Sven de Marothy wrote: This agrees with the JDK behaviour better. And my peers expect it too. (Whoops, accidentally commited a change to Component. Did that revert correctly?) No. You committed the attached. The first hunk seems to have been changed by

Re: [cp-patches] RFC: misc NIO fixes

2005-07-26 Thread Mark Wielaard
Hi, On Sat, 2005-07-23 at 20:37 -0700, Casey Marshall wrote: Committed. I changed a few minor things, such as using Mark's suggestion to use 'madvise' to load the file into core. I can't get this to work with Jamvm on Darwin; I get a bizarre segfault when trying to create the new

Re: [cp-patches] javanet.c compile fix for IRIX

2005-07-26 Thread Mark Wielaard
Hi Christian, On Tue, 2005-07-26 at 11:29 +0200, Christian Thalinger wrote: On Tue, 2005-07-26 at 11:12 +0200, Mark Wielaard wrote: That is what the autoconf manual recommends. Does that work for you? Yes. Thanks. Committed as follows: 2005-07-26 Christian Thalinger [EMAIL PROTECTED

[cp-patches] FYI: Better diagnostics for FileChannelImpl

2005-07-26 Thread Mark Wielaard
Hi, I had this patch on my disk for a long time. It helps with debugging file related errors/exceptions a lot. 2005-07-26 Mark Wielaard [EMAIL PROTECTED] * gnu/java/nio/channels/FileChannelImpl.java (description): New final field. (FileChannelImpl): Set description. (init

[cp-patches] FYI: FileChannelImpl lock() and tryLock() sanity checking

2005-07-26 Thread Mark Wielaard
Hi, This moves the sanity checking of lock() and tryLock() into a shared private method checkLock() so that all argument and channel property checking is done in the same way. 2005-07-26 Mark Wielaard [EMAIL PROTECTED] * gnu/java/nio/channels/FileChannelImpl.java (lockCheck): New

[cp-patches] FYI: Some more FileChannelImpl.c cleanups

2005-07-26 Thread Mark Wielaard
Hi, A close and select call (possibly used by available) can be interrupted. In that case we have to retry the system call. 2005-07-26 Mark Wielaard [EMAIL PROTECTED] * native/jni/java-nio/gnu_java_nio_channels_FileChannelImpl.c (Java_gnu_java_nio_channels_FileChannelImpl_init): Mark

[cp-patches] DataFormat.equals() reimplemented

2005-07-26 Thread Mark Wielaard
Hi, This is a reimplementation of DateFormat.equals() following the JCL book description. While testing this I found that David already created Mauve tests for this which closely follow this description already. 2005-07-26 Mark Wielaard [EMAIL PROTECTED] * java/text/DateFormat.java

[cp-patches] FYI: basic plaf getPreferredSize() cleanups

2005-07-26 Thread Mark Wielaard
found two more issues like these. 2005-07-26 Mark Wielaard [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicScrollPaneUI.java (getPreferredSize): Removed. * javax/swing/plaf/basic/BasicTabbedPaneUI.java (getPreferredSize): Removed. * javax/swing/plaf/basic

[cp-patches] Re: DataFormat.equals() reimplemented

2005-07-26 Thread Mark Wielaard
Hi David, On Tue, 2005-07-26 at 15:22 +, David Gilbert wrote: I wasn't sure from your description exactly which test fails. Only number 10 fails. Where you set the TimeZone of the Calendar to a new one with the same rules. I can't run the tests against Classpath myself right now because

Re: [cp-patches] RFC: Class Loader patch to record class with initiating class loader

2005-07-28 Thread Mark Wielaard
Hi, On Wed, 2005-07-27 at 13:18 +0200, Jeroen Frijters wrote: While digging around the class loading issues, I discovered that we didn't record a class with the initiating loader [1]. This is necessary to maintain type safety in the face of buggy or malicious class loaders (or even when the

Re: [cp-patches] cvs head 64-bit build breakage (java_nio_MappedByteBufferImpl.c)

2005-07-28 Thread Mark Wielaard
Hi, On Thu, 2005-07-28 at 09:55 +0200, Christian Thalinger wrote: Just a small typo. But it seems noone is testing with 64-bits ;-) 2005-7-28 Christian Thalinger [EMAIL PROTECTED] * native/jni/java-nio/java_nio_MappedByteBufferImpl.c (get_raw_values): Fixed typo for 64-bit

RE: [cp-patches] RFC: Class Loader patch to record class withinitiating class loader

2005-07-28 Thread Mark Wielaard
Hi Jeroen, On Thu, 2005-07-28 at 10:52 +0200, Jeroen Frijters wrote: I agree that the call to registerInitiatingLoader() in ClassLoader.defineClass() is a bit iffy. The reason I left it in there is to not break any VMs when I check in this patch. I was a bit surprised by the fact that two

[cp-patches] FYI: FileLock fixes

2005-07-31 Thread Mark Wielaard
Hi, I created some mauve tests and found some bugs with FileLock. The biggest issue was that when we use LONG.MAX_VALUE, which means everything from the given position, fcntl actually expects zero as size argument for the same semantics. 2005-07-31 Mark Wielaard [EMAIL PROTECTED] * gnu

[cp-patches] FYI: Document new bug database

2005-07-31 Thread Mark Wielaard
Hi, This documents the new location of our bug database. 2005-08-01 Mark Wielaard [EMAIL PROTECTED] * doc/www.gnu.org/bugs.wml: New file. * doc/www.gnu.org/newsitems.txt: Add bugzilla entry. * doc/www.gnu.org/events/events.wml: Correct Fosdem 2005 date. * doc

Re: [cp-patches] FYI: Method drawCentered add to BasicTreeUI

2005-07-31 Thread Mark Wielaard
Hi Jan, On Mon, 2005-08-01 at 00:31 +0200, Jan Röhrich wrote: 2005-08-01 Jan Roehrich [EMAIL PROTECTED] * javax.swing.plaf.basic.BasicTreeUI: Method drawCentered added / corrected javadoc issues in paintHorizonalLine and paintVerticalLine / fixed getRightChildIndent

Re: [cp-patches] [patch] make darwin 'work' with classpath

2005-08-01 Thread Mark Wielaard
Hi, On Sun, 2005-07-24 at 23:05 +0200, Andreas Tobler wrote: the attached patch changes link behavior of darwin ppc and makes it work in reality. For detailed explanation please search the apple developer pages. In short, when building against a .so we have a module which is like an

Re: [cp-patches] [patch] make darwin 'work' with classpath

2005-08-01 Thread Mark Wielaard
Hi Andreas, On Mon, 2005-08-01 at 23:29 +0200, Andreas Tobler wrote: Well, I will investigate a bit more. But my guess is here: with jamvm and other vm you run interpreted code, where the classpath lib is the last bit in the chain. On gcj/libgcj you can build/run native apps where you link

Re: [cp-patches] [patch] make darwin 'work' with classpath

2005-08-02 Thread Mark Wielaard
Hi Andreas, On Tue, 2005-08-02 at 06:41 +0200, Andreas Tobler wrote: Well, here I should have said 'once', with the actual cp I didn't. :( But I know jamvm will fail because it in src/dll.c:300 it checks against .so and new will .dylib on darwin. OK. Useful additional datapoint :) Maybe the

Re: [cp-patches] FYI: RawData rename to Pointer

2005-08-05 Thread Mark Wielaard
Hi Guilhem, On Wed, 2005-08-03 at 15:10 +0200, Guilhem Lavaux wrote: Here is the patch to rename 2005-08-03 Guilhem Lavaux [EMAIL PROTECTED] * gnu/classpath/Pointer.java, gnu/classpath/Pointer32.java, gnu/classpath/Pointer64.java, gnu/classpath/RawData.java,

[cp-patches] Make --enable-Werror work again

2005-08-05 Thread Mark Wielaard
Hi, This cleans up some things that prevented compilation with --enable-Werror. 2005-08-05 Mark Wielaard [EMAIL PROTECTED] * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkImage.c: Include jcl.h. (createRawData): Removed unused variable method. (getData): Removed

[cp-patches] FYI: Condense VMNetworkInterface.getInterfaces() result

2005-08-07 Thread Mark Wielaard
Hi, This fixes a bug that Ito fixed a long time ago for kaffe. (Found in bugzilla by Andrew) 2005-08-07 Ito Kazumitsu [EMAIL PROTECTED] Fixes bug #22929 * libraries/javalib/java/net/NetworkInterface.java (condense): New static private method. (getNetworkInterfaces):

Re: [cp-patches]: Patch: Formatting for DefaultTreeModel.

2005-08-09 Thread Mark Wielaard
. And you cannot remove any old copyright years, so I added 2002 and 2004 back. 2005-08-09 Mark Wielaard [EMAIL PROTECTED] * javax/swing/tree/DefaultTreeModel.java: Fix copyright boilerplate formatting. Committed, Mark Index: javax/swing/tree/DefaultTreeModel.java

[cp-patches] FYI: New datatransfer example

2005-08-11 Thread Mark Wielaard
-11 Mark Wielaard [EMAIL PROTECTED] * examples/gnu/classpath/examples/datatransfer/Demo.java: New example. I was hoping that it would at least help the awt hackers. Two things that I found was that I need to resize the window before anything is visible and that (multiple) selections

Re: [cp-patches] Re: Help needed to persuade apaches about the Classpath license: Maven does not deal with CORBA, just uses OpenEJB.

2005-08-12 Thread Mark Wielaard
Hi, On Fri, 2005-08-12 at 10:18 +0200, Meskauskas Audrius wrote: You may not believe, but there are packages were our CORBA passes much more cost.omg.org tests from Iona technologies and Nec corporation than Sun's implementation. The summary of the tested CORBA features is included in

[cp-patches] FYI: Some (jikes) warning fixes

2005-08-12 Thread Mark Wielaard
Hi, jikes was complaining about a couple of constructs used in our code. Were it was easy and obviously correct to fix this I did to make the compilation experience with jikes nicer. 2005-08-12 Mark Wielaard [EMAIL PROTECTED] * gnu/java/awt/peer/qt/QtButtonPeer.java: Replace uses

Re: [cp-patches] [RFA/JDWP] Frame.java

2005-08-12 Thread Mark Wielaard
On Fri, 2005-08-12 at 21:13 -0400, Aaron Luchko wrote: On Fri, 2005-08-12 at 13:28 -0600, Tom Tromey wrote: Typo in 'variable'. Oops I really need to get that eclipse spell checker working :) If you were using emacs you could turn on flyspell-prog-mode :) Cheers, Mark signature.asc

[cp-patches] FYI: check_jni_methods.sh fixlets

2005-08-13 Thread Mark Wielaard
Hi, Our check jni methods script would try to create temporary files in the source directory which can be write protected. It would silently fail, but not report any errors about this. The following patch fixes this. 2005-08-13 Mark Wielaard [EMAIL PROTECTED] * scripts

[cp-patches] Some cleanups for gjdoc

2005-08-13 Thread Mark Wielaard
Hi, I had the following little cleanups in my local tree for gjdoc: 2005-08-13 Mark Wielaard [EMAIL PROTECTED] * configure.ac: Add AC_CHECK_RQRD_CLASS check for java.util.regex.Pattern. * src/gnu/classpath/tools/gjdoc/AbstractTagImpl.java (toString): New method. * src/gnu

[cp-patches] FYI: Use just one repaintTimer for all GtkComponentPeers

2005-08-13 Thread Mark Wielaard
Hi, I was seeing lots of repaint Timers running while we only need one. Since Timers are thread safe we can just instantiate one and use that for all GtkComponentPeers instead of creating one for each peer. 2005-08-13 Mark Wielaard [EMAIL PROTECTED] * gnu/java/awt/peer/gtk

[cp-patches] FYI: Remove Java_gnu_java_awt_peer_gtk_GtkToolkit_nativeQueueEmpty

2005-08-16 Thread Mark Wielaard
Hi, As pointed out by the autobuilder check_jni_methods script GtkToolkit.nativeQueueEmpty() isn't used anymore. This patch removes it and makes the tree build again. 2005-08-16 Mark Wielaard [EMAIL PROTECTED] * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkToolkit.c

[cp-patches] FYI: Update and document datatransfer example Demo

2005-08-16 Thread Mark Wielaard
Hi, This adds an example of using FlavorListeners to the datatransfer example Demo and add documentation for all the features used. 2005-08-16 Mark Wielaard [EMAIL PROTECTED] * examples/gnu/classpath/examples/datatransfer/Demo.java: Document and implement ItemListener

Re: [cp-patches] RFC: qt4 peers build machinery

2005-08-17 Thread Mark Wielaard
get this warning. I changed my patch to use -U 0 now. 2005-08-17 Mark Wielaard [EMAIL PROTECTED] * scripts/check_jni_methods.sh: Find JNI method declarations in .cpp files. Check both GNU style functions (start of line) and one-line like declarations. Use diff -U 0

Re: [cp-patches] FYI: Made PixelGrabber more robust

2005-08-18 Thread Mark Wielaard
Hi, On Thu, 2005-08-18 at 15:41 +0200, Roman Kennke wrote: public void run () { - ip.startProduction (PixelGrabber.this); + try +{ + ip.startProduction (PixelGrabber.this); +} +

Re: [cp-patches] RFC: qt4 peers build machinery

2005-08-20 Thread Mark Wielaard
Hi Dalibor, On Wed, 2005-08-17 at 14:34 +0200, Dalibor Topic wrote: 2005-08-17 Mark Wielaard [EMAIL PROTECTED] * native/jni/qt-peer/Makefile.am (libqtpeer_la_SOURCES): Remove eventmethods.h. I believe that's a bug in the patch, as the file still exists in the source code

Re: [cp-patches] invalidate Label on setText

2005-08-21 Thread Mark Wielaard
Hi, On Sat, 2005-08-20 at 23:58 -0400, Thomas Fitzsimmons wrote: 2005-08-20 Thomas Fitzsimmons [EMAIL PROTECTED] * java/awt/Label.java (setText): Invalidate label. - this.text = text; - - if (peer != null) + if (this.text != text) { - LabelPeer lp = (LabelPeer)

Re: [cp-patches] invalidate Label on setText

2005-08-21 Thread Mark Wielaard
On Sun, 2005-08-21 at 13:19 +0200, Mark Wielaard wrote: This should probably should be if ((this.text == null text != null) || (! this.text.equals(text))) Although invalidating whenever this.text != text probably doesn't hurt. Ugh, I meant if ((this.text == null text

Re: [cp-patches] Reimplemented gtk-peers datatransfer support

2005-08-21 Thread Mark Wielaard
Hi, On Tue, 2005-08-16 at 19:03 -0400, Thomas Fitzsimmons wrote: Yes, please discuss this with Owen Taylor and file bugs against GTK if necessary. This is a relatively new API and we should provide feedback where it doesn't meet our needs. I filed the following bugs that would make our (and

Re: [cp-patches] make libjawt binary-compatible with Sun's implementation

2005-08-22 Thread Mark Wielaard
Hi, On Sat, 2005-08-20 at 19:19 -0400, Thomas Fitzsimmons wrote: I tested this with our JAWT demo; libDemoJAWT.so can be built and run interchangeably between JamVM and the JDK. How exactly do I compile and run the example? The .java file is in the package gnu.classpath.examples.jawt but the

Re: [cp-patches] ImageIcon fix

2005-08-22 Thread Mark Wielaard
documentation patch: 2005-08-22 Mark Wielaard [EMAIL PROTECTED] * javax/swing/ImageIcon.java: Add documentation. Cheers, Mark Index: javax/swing/ImageIcon.java === RCS file: /cvsroot/classpath/classpath/javax/swing/ImageIcon.java,v

[cp-patches] Make qt-peers build and run out of the box

2005-08-23 Thread Mark Wielaard
the CLASSPATH_MODULE flags depend on the architecture/os, or Darwin is weird). To make this all work out of the box a small include cleanup patch was also needed. 2005-08-23 Mark Wielaard [EMAIL PROTECTED] * configure.ac: Check for QtGui = 4.0.1. * native/jni/qt-peer/.cvsignore

<    9   10   11   12   13   14   15   16   17   18   >