Re: [cp-patches] FYI: Swing painting reworked

2005-10-16 Thread Roman Kennke
Hi, Hi Roman, Sorry I didn't get a chance to test this when you first submitted the patch. Yeah, I was quite quick with that. But given that I wouldn't have time to check it in for some days, and also given that I already tested this to a certain extent, and we have CVS and testers and

[cp-patches] FYI: JTable rendering fix

2005-10-17 Thread Roman Kennke
This fixes painting of selected cells/rows. 2005-10-17 Roman Kennke [EMAIL PROTECTED] * javax/swing/DefaultTableCellRenderer.java (getTableCellRendererComponent): Setup colors (more) correctly. * javax/swing/DefaultListSelectionModel.java (isSelectedIndex

[cp-patches] FYI: Another JComboBox fix

2005-10-17 Thread Roman Kennke
Hi, this fixes the size of the combobox popup and sets the selected item in the combobox before closing the popup. 2005-10-17 Roman Kennke [EMAIL PROTECTED] * javax/swing/JPopupMenu.java (setVisible): Set size according to the size property instead of the preferredSize

[cp-patches] FYI: ScrollPaneLayout fixes

2005-10-18 Thread Roman Kennke
Hi, The following patch solves a small but significant layout problem with JScrollPanes. The layout manager has to respect the insets of the JScrollPane properly. This is checked in. 2005-10-18 Roman Kennke [EMAIL PROTECTED] * javax/swing/ScrollPaneLayout.java

[cp-patches] FYI: Some JViewport fixes

2005-10-18 Thread Roman Kennke
Hi, This fixes some issues with JViewport. 2005-10-18 Roman Kennke [EMAIL PROTECTED] * javax/swing/JViewport.java (setView): Added repaint() call. (revalidate): Removed unnecessary and unspecified method. (reshape): Fire stateChanged if only the size changes

[cp-patches] FYI: AbstractButton fixlet

2005-10-18 Thread Roman Kennke
This prevents setEnabled() from getting active, if the actual value does not change. 2005-10-18 Roman Kennke [EMAIL PROTECTED] * javax/swing/AbstractButton.java Filled empty blocks with comments. (ButtonChangeListener.stateChanged): Moved implementation from

[cp-patches] FYI: filled empty blocks in javax.swing.colorchooser

2005-10-18 Thread Roman Kennke
I filled empty blocks (like method bodies) in javax.swing.colorchoosers with comments either stating that this does nothing or needs to be implemented. 2005-10-18 Roman Kennke [EMAIL PROTECTED] * javax/swing/colorchooser/AbstractColorChooserPanel.java: * javax/swing

[cp-patches] FYI: javax.swing.filechooser empty blocks

2005-10-18 Thread Roman Kennke
I filled two empty blocks in javax.swing.filechooser. 2005-10-18 Roman Kennke [EMAIL PROTECTED] * javax/swing/filechooser/FileFilter.java: * javax/swing/filechooser/FileView.java: Filled empty blocks with comments. /Roman Index: javax/swing/filechooser/FileFilter.java

[cp-patches] FYI: DebugGraphics logging implemented

2005-10-19 Thread Roman Kennke
commits, since I forgot a little piece in JComponent the first time. 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/JComponent.java (getDebugGraphicsOptions): Fixed to load system property if present. 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing

Re: [cp-patches] FYI: filled empty blocks in javax.swing.colorchooser

2005-10-19 Thread Roman Kennke
Am Dienstag, den 18.10.2005, 22:58 +0200 schrieb Robert Schuster: Hi Roman, Index: javax/swing/colorchooser/DefaultSwatchChooserPanel.java === RCS file:

[cp-patches] FYI: ComponentUI clipping reverted

2005-10-19 Thread Roman Kennke
in another area. 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/ComponentUI.java Filled empty blocks with comments. (update): Reverted my patch from 2005-10-12. This is wrong. If there are still clipping problems, then certainly in another area. /Roman

[cp-patches] FYI: TableColumnModel API fix

2005-10-19 Thread Roman Kennke
This fixes a minor API comment issue in TableColumnModel. 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/table/TableColumnModel.java: Fixed some minor API doc errors. /Roman Index: javax/swing/table/TableColumnModel.java

[cp-patches] javax.swing.text.html.parser cleanup

2005-10-19 Thread Roman Kennke
Adds comments to empty blocks in javax.swing.text.html.parser 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/text/html/parser/ContentModel.java * javax/swing/text/html/parser/DTD.java * javax/swing/text/html/parser/DocumentParser.java * javax/swing/text

[cp-patches] javax.swing.text.html cleanup

2005-10-19 Thread Roman Kennke
This adds comments to two empty blocks in javax.swing.text.html. 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/text/html/HTML.java * javax/swing/text/html/HTMLDocument.java Filled emtpy blocks with comments. /Roman Index: javax/swing/text/html/HTML.java

[cp-patches] FYI: javax.swing.text cleanup

2005-10-19 Thread Roman Kennke
Some cleanup for javax.swing.text. 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/text/AbstractDocument.java * javax/swing/text/AttributeSet.java * javax/swing/text/ComponentView.java * javax/swing/text/DefaultCaret.java * javax/swing/text

[cp-patches] FYI:javax.swing.tree cleanup

2005-10-19 Thread Roman Kennke
Some cleanup for javax.swing.tree. 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/tree/DefaultMutableTreeNode.java * javax/swing/tree/DefaultTreeCellEditor.java * javax/swing/tree/TreeCellRenderer.java * javax/swing/tree/TreeModel.java

[cp-patches] javax.swing.undo cleanup

2005-10-19 Thread Roman Kennke
This adds super() calls to 2 previously empty constructors. 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/undo/CannotRedoException.java * javax/swing/undo/CannotUndoException.java Put super() call in empty constructors. /Roman Index: javax/swing/undo

[cp-patches] FYI: implemented JButton method

2005-10-19 Thread Roman Kennke
I implemented the previously stubbed method JButton.removeNotify. 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/JButton.java (removeNotify): Implemented this previously stubbed method. /Roman Index: javax/swing/JButton.java

[cp-patches] FYI: implemented JEditorPane.read()

2005-10-19 Thread Roman Kennke
This implements the read() method in JEditorPane. 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/JEditorPane.java Added comments to empty blocks. (read): Implemented this previously stubbed method. /Roman Index: javax/swing/JEditorPane.java

[cp-patches] FYI: JLabel fixlet

2005-10-19 Thread Roman Kennke
This adds a repaint() and revalidate() call to JLabel.setText(). This is backed up by a Mauve testcase that I've written. 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/JLabel.java (setText): Call revalidate() and repaint(). /Roman Index: javax/swing/JLabel.java

[cp-patches] FYI: OverlayLayout fixlet

2005-10-19 Thread Roman Kennke
This fixes the OverlayLayout so that it respects the container's insets correctly. 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/OverlayLayout.java (checkLayout): Respect the container's insets correctly. /Roman

[cp-patches] FYI: Removed debug output in JComponent

2005-10-19 Thread Roman Kennke
I removed a debug statement in JComponent. 2005-10-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/JComponent.java (getDebugGraphicsOptions): Removed debug output. /Roman Index: javax/swing/JComponent.java === RCS

Re: [cp-patches] FYI: javax.swing cleanup

2005-10-19 Thread Roman Kennke
Hi, I saw you also added the start of the AccessibleJTable with this last patch (you forgot to mention that in the ChangeLog entry). Whoops, that one must have sneaked in. My plan was to finish this before committing it... /Roman signature.asc Description: Dies ist ein digital signierter

Re: [cp-patches] javax.swing.undo cleanup

2005-10-19 Thread Roman Kennke
Hi, -public class CannotRedoException - extends RuntimeException +public class CannotRedoException extends RuntimeException { The old version is according to our formatting rules. The new version is not. Well, last time I asked about that on IRC I was told (by

Re: [cp-patches] Patch: BasicMenuItemUI fix

2005-10-21 Thread Roman Kennke
Hi Lillian, It looks a little strange to handle CheckBoxMenuItem specific cases in the superclass. However, I understand that the API of BasicCheckBoxMenuItem does not leave much room for specific handling of this. What looks a bit strange to me is that the specs define a method

[cp-patches] FYI: BoxLayout thread-safe

2005-10-24 Thread Roman Kennke
Hi, I made the BoxLayout class thread-safe. I could find no better way to protect the BoxLayout inner state from getting inconsistent when multiple threads access this class like pointed out in Bug#24359. 2005-10-24 Roman Kennke [EMAIL PROTECTED] Fixes Bug #24359 * javax/swing

Re: [cp-patches] FYI: Providing workarounds for com.sun.CORBA.connection.ORBSocketFactoryClass property (or ORBConstants.SOCKET_FACTORY_CLASS_PROPERTY field).

2005-10-25 Thread Roman Kennke
Hi Audrius, The new property gnu.Corba.SocketFactory replaces the socket factory for the ORB being currently instantiated and should help with adaptation. The factory must implement gnu.CORBA.interfaces.gnuSocketFactory. One question that I asked myself for some time now: is there a

Re: [cp-patches] Patch: MenuItem fix

2005-10-25 Thread Roman Kennke
Hi Lillian, Made a couple minor fixes to BasicCheckBoxMenuItemUI to match the API and BasicRadioButtonMenuItemUI. 2005-10-21 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicCheckBoxMenuItemUI.java (BasicCheckBoxMenuItem): Implemented.

[cp-patches] FYI: GtkComponentPeer fix

2005-10-25 Thread Roman Kennke
instead of gdk_window_get_origin() so that the real screen coordinates of the window is returned and not the screen coordinate of the content area of the window. 2005-10-24 Roman Kennke [EMAIL PROTECTED] * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c

[cp-patches] FYI: Swing popup menu stuff reworked

2005-10-25 Thread Roman Kennke
on that? 2005-10-24 Roman Kennke [EMAIL PROTECTED] * javax/swing/JLayeredPane.java (addImpl): Removed unnecessary repaint() and revalidate() calls. * javax/swing/JPopupMenu.java (remove): Removed unnecessary revalidate() call. (insert): Removed code

[cp-patches] FYI: Swing Demo unified

2005-10-25 Thread Roman Kennke
should not be created in the createContent() methods, but instead somewhere outside in the standalone apps. David could you adjust this? 2005-10-24 Roman Kennke [EMAIL PROTECTED] * examples/gnu/classpath/examples/swing/Demo.java (mkMenuBar): Replaced some demos with new external demo

[cp-patches] FYI: Button fix

2005-10-25 Thread Roman Kennke
HI, I fixed a little issue in the button UIs. They used to fill the background for pressed buttons even if they are opaque. This is of course wrong. 2005-10-25 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicButtonUI.java (installDefaults): Removed initialization

[cp-patches] RFC: WeakHashMap improvement

2005-10-26 Thread Roman Kennke
Hi, Friedjof Siebert did some improvements on java.util.WeakHashMap that I'd like to check in. They are meant to improve reliability of this class by enabling the prove of a cast and the absence of a null-pointer. 2005-10-26 Roman Kennke [EMAIL PROTECTED] Reported by Friedjof Siebert

[cp-patches] RFC: WeakHashMap improvement

2005-10-26 Thread Roman Kennke
Hi, Friedjof Siebert did some improvements on java.util.WeakHashMap that I'd like to check in. They are meant to improve reliability of this class by enabling the prove of a cast and the absence of a null-pointer. 2005-10-26 Roman Kennke [EMAIL PROTECTED] Reported by Friedjof Siebert

[cp-patches] RFC: Remove lowercasing of Windows paths

2005-10-26 Thread Roman Kennke
-10-26 Roman Kennke [EMAIL PROTECTED] Reported by Ingo Proetel [EMAIL PROTECTED] * gnu/java/io/PlatformHelper.java (toCanonicalForm): Remove lowercasing of paths in Windows. This breaks working with URLs, like when accessing files withing JAR files. /Roman

[cp-patches] FYI: BasicScrollBarUI fix

2005-10-27 Thread Roman Kennke
Hi, I moved the code around a bit in BasicScrollBarUI. The initialization of some fields has been done in the wrong methods. I confirmed that my fixes are correct by some testcases that I committed to Mauve. 2005-10-27 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic

[cp-patches] FYI: FieldView fix

2005-10-27 Thread Roman Kennke
) on the textfield's document, then you can setText(Hello\nWorld) to display multilined text in a JTextField. 2005-10-27 Roman Kennke [EMAIL PROTECTED] * javax/swing/text/FieldView.java (getPreferredSpan): For the Y_AXIS call the superclass behaviour as described

[cp-patches] FYI: DefaultListSelectionModel fix

2005-10-28 Thread Roman Kennke
Here comes a small fix for DefaultListSelectionModel. Mauve test for this is also committed. 2005-10-28 Roman Kennke [EMAIL PROTECTED] * javax/swing/DefaultListSelectionModel.java (setLeadSelectionIndex): Forbit some changes to leadSelectionIndex when

[cp-patches] FYI: BasicTableUI fix

2005-10-28 Thread Roman Kennke
This fixes some rendering issues as well as some other stuff in JTable. 2005-10-28 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTableUI.java (MouseInputHandler.mouseDragged): Only react if table is enabled. (MouseInputHandler.mousePressed): Only react

[cp-patches] FYI: javax.swing.table fixlets

2005-10-28 Thread Roman Kennke
This fixes some little issues in javax.swing.table. 2005-10-28 Roman Kennke [EMAIL PROTECTED] * javax/swing/table/DefaulTableCellRenderer.java (getTableCellRenderer): Correctly configure the cell renderer for selected and / or focused cells. * javax/swing/table

Re: [cp-patches] Some example updates which LAF should be default?

2005-10-31 Thread Roman Kennke
Hi, I committed this. But should we keep the GNULookAndFeel as default? I was also thinking about this and my feeling is that we should use the MetalLookAndFeel. The OceanTheme is not ready yet. Once I set it as default for the MetalLookAndFeel (as in JDK1.5), but it turned out that the

[cp-patches] FYI: some AccessibleJTable methods

2005-10-31 Thread Roman Kennke
Hi, I implemented 3 methods in JTable.AccessibleJTable. 2005-10-31 Roman Kennke [EMAIL PROTECTED] * javax/swing/JTable.java (AccessibleJTable.tableChanged): Implemented. (AccessibleJTable.tableRowsInserted): Implemented. (AccessibleJTable.tableRowsDeleted

[cp-patches] FYI: New JTextField method

2005-10-31 Thread Roman Kennke
Hi, I added the missing method getHorizontalVisibility to JTextField. However, the real implementation of this thing is still missing, because this BoundedRangeModel must really be managed by javax.swing.text.FieldView. I have added a TODO note into the code for that. 2005-10-31 Roman Kennke

Re: [cp-patches] Patch: BasicMenuItemUI fixes

2005-11-01 Thread Roman Kennke
Hi Lillian, Am Dienstag, den 01.11.2005, 10:37 -0500 schrieb Lillian Angel: Played around with the defaults a bit so BasicMenuItemUI initializes checkIcon. I had to remove the checkIcon default from BasicLF, so the checkIcon is not drawn all the time. 2005-11-01 Lillian Angel [EMAIL

Re: [cp-patches] Patch: MenuItem fix

2005-11-01 Thread Roman Kennke
Hi Lillian, Am Dienstag, den 01.11.2005, 10:10 -0500 schrieb Lillian Angel: public class BasicCheckBoxMenuItemUI extends BasicMenuItemUI { + + /** + * Creates a new BasicCheckBoxMenuItemUI object. + */ + public BasicCheckBoxMenuItemUI() + { +super(); +

[cp-patches] FYI: JPopupMenu fixlet

2005-11-01 Thread Roman Kennke
the Popup is fetched from the PopupFactory, so the PopupFactory has the correct size. 2005-11-01 Roman Kennke [EMAIL PROTECTED] * javax/swing/JPopupMenu.java (setVisible): Pack the JPopupMenu before fetching the Popup instance. Otherwise the PopupFactory has the wrong

[cp-patches] FYI: MetalScrollPaneUI fixlet

2005-11-01 Thread Roman Kennke
The MetalScrollPaneUI returned shared instances of itself for all JScrollPanes. This is of course wrong. This has lead to disfunctional scrollpanes in the Metal LF. 2005-11-01 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/metal/MetalScrollPaneUI.java (instance): Removed

Re: [cp-patches] Patch: Window fix

2005-11-01 Thread Roman Kennke
Hi Lillian, Am Dienstag, den 01.11.2005, 17:18 -0500 schrieb Lillian Angel: 2005-11-01 Lillian Angel [EMAIL PROTECTED] * java/awt/Window.java (show): If pack is not called before show, the size of the window is often set to 0. This is now fixed. Isn't this the

Re: [cp-patches] Patch: Window fix

2005-11-01 Thread Roman Kennke
of your primary focus (== outside of Swing), please either back it up with a good mauve testcase and/or post it as RFC. I suppose you have seen a bug in some app that has lead you to this change, what was the real problem that you patch was supposed to solve? 2005-11-01 Roman Kennke [EMAIL PROTECTED

[cp-patches] FYI: AccessibleJTable improvement

2005-11-02 Thread Roman Kennke
I added the inner class AccessibleJTable.AccessibleJTableCell to javax.swing.JTable. This means we are nearly JAPI-complete vs JDK1.2 with javax.swing (not the subpackages). 2005-11-02 Roman Kennke [EMAIL PROTECTED] * javax/swing/JTable.java

[cp-patches] FYI: BoxLayout fixes

2005-11-02 Thread Roman Kennke
Here come some fixes for the BoxLayout that let the remaining Mauve tests for BoxLayout PASS. 2005-11-02 Roman Kennke [EMAIL PROTECTED] * javax/swing/BoxLayout.java (BoxLayout): Throw AWTError when the axis is invalid. (minimumLayoutSize): Respect the insets

[cp-patches] FYI: BasicLF defaults fixes

2005-11-02 Thread Roman Kennke
I fixed some defaults in the BasicLF as pointed out by the Mauve regressions that Mark sent. 2005-11-02 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicLookAndFeel.java (initComponentDefaults): Fixed the defaults for EditorPane.border, TextArea.font

Re: [cp-patches] Patch: Dialog fix

2005-11-02 Thread Roman Kennke
invalid. I reverted this patch just in time for the release. Sorry Lillian. 2005-11-02 Roman Kennke [EMAIL PROTECTED] * java/awt/Dialog.java (show): Do not call pack() here. /Roman Index: java/awt/Dialog.java

[cp-patches] FYI: Caret fixes

2005-11-03 Thread Roman Kennke
the conditions when the caret becomes visible by default (it should only become visible when the focus is gained AND the text component is editable and enabled). This fix makes the CornerCaret example from the OReilly Swing book work just fine. 2005-11-02 Roman Kennke [EMAIL PROTECTED] * javax

[cp-patches] FYI: Some Swing text additions

2005-11-03 Thread Roman Kennke
. Unfortunatly this introduces a couple of new stubs, since I didn't want to bother implementing them all at once (it's a difficult method). I have inserted a TODO tag and let them throw an AssertionError, so we get clear results when using these methods. 2005-11-02 Roman Kennke [EMAIL PROTECTED

[cp-patches] FYI: DefaultTextUI added

2005-11-03 Thread Roman Kennke
Hi, I added the deprecated DefaultTextUI class. 2005-11-02 Roman Kennke [EMAIL PROTECTED] * javax/swing/text/DefaultTextUI.java: New file. /Roman Index: javax/swing/text/DefaultTextUI.java === RCS file: javax/swing/text

[cp-patches] FYI: BasicTextUI fix

2005-11-03 Thread Roman Kennke
Obviously my previous addition of an abstract method broke the build because I forgot the RootView in BasicTextUI. I fixed this. 2005-11-02 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTextUI.java (RootView.getNextVisualPositionFrom): New method. /Roman Index

Re: [cp-patches] RFC: Suggested change in PlainView.

2005-11-03 Thread Roman Kennke
Hi Audrius, Am Donnerstag, den 03.11.2005, 15:50 +0100 schrieb Meskauskas Audrius: Our JTextField contains an imaginary end of line character (0xA), but the new text must be always inserted before it, not after. When clicking right from the last character in the field, the

Re: [cp-patches] Patch: BasicTreeUI and DefaultTableCellRenderer fix

2005-11-03 Thread Roman Kennke
is right (and thinking about ot, it is even more intuitive than the last one). 2005-11-03 Roman Kennke [EMAIL PROTECTED] * javax/swing/table/DefaultTableCellRenderer.java (background): New field. (foreground): New field. (setBackground): Store the color that is set

Re: [cp-patches] RFC: Suggested change in PlainView.

2005-11-03 Thread Roman Kennke
Hi there, Am 3.11.2005 schrieb Roman Kennke [EMAIL PROTECTED]: Hi Audrius, Am Donnerstag, den 03.11.2005, 15:50 +0100 schrieb Meskauskas Audrius: Our JTextField contains an imaginary end of line character (0xA), but the new text must be always inserted before it, not after. When clicking

[cp-patches] FYI: SizeRequirements fix

2005-11-04 Thread Roman Kennke
Hi, I discovered an overflow problem in SizeRequirements. I added a Mauve test for that problem (to BoxLayout testsuite) and this patch makes this test PASS. 2005-11-04 Roman Kennke [EMAIL PROTECTED] * javax/swing/SizeRequirements.java (getTiledSizeRequirements): Added check

[cp-patches] FYI: New TextField demo

2005-11-04 Thread Roman Kennke
Hi, I added a cool new JTextField demo that shows the JTextField in various states. The best thing is, most stuff is actually working now :-) A special highlight is the custom caret in the text field at the bottom left. 2005-11-04 Roman Kennke [EMAIL PROTECTED] * examples/gnu

[cp-patches] FYI: rootPaneChecking fixed in Swing top-level containers

2005-11-07 Thread Roman Kennke
and updateUI methods so that the UI initialization can work on the JInternalFrame directly and not on its contentPane. And yes, we need to do this in both methods, since subclasses commonly override one of these two, but not necessarily both. 2005-11-07 Roman Kennke [EMAIL PROTECTED] * javax

[cp-patches] FYI: Component invalidate() fix

2005-11-07 Thread Roman Kennke
valid. This also seems somewhat wrong because this might throw away the cached state more often than needed. 3. This patch. Elegant and short. :-D 2005-11-07 Roman Kennke [EMAIL PROTECTED] * java/awt/Component.java (invalidate): Invalidate up the whole tree, regardless if some

Re: [cp-patches] FYI: Component invalidate() fix

2005-11-08 Thread Roman Kennke
Hi again, Yesterday I checked in a change to java.awt.Component. Today I wrote a testcase for that (bad me, I should really do that before starting to code) that shows that this fix was wrong. I revert that. 2005-11-08 Roman Kennke [EMAIL PROTECTED] * java/awt/Component.java

[cp-patches] FYI: JLayeredPane fix

2005-11-08 Thread Roman Kennke
Hi, A testcase that I committed to Mauve showed a bug in JLayeredPane.getComponentsInLayer. This method should return an empty array for unknown layers instead of throwing an exception. This is fixed. 2005-11-08 Roman Kennke [EMAIL PROTECTED] * javax/swing/JLayeredPane.java

[cp-patches] FYI: BorderLayout fix

2005-11-08 Thread Roman Kennke
My previous fixes for all the alignment stuff showed up an error in the BorderLayout. This is fixed and backed by a mauve test. 2005-11-08 Roman Kennke [EMAIL PROTECTED] * java/awt/BorderLayout.java (getAlignmentX): Return 0.5F here. (getAlignmentY): Return 0.5F here

[cp-patches] FYI: BasicTextUI fix

2005-11-08 Thread Roman Kennke
This fixes BasicTextUI so that the colors in the textfield demo are correctly set when enabling/disabling. 2005-11-08 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTextUI.java (installDefaults): Initialize background field correctly. /Roman Index: javax/swing

Re: [cp-patches] FYI: Component invalidate() fix

2005-11-08 Thread Roman Kennke
Am Dienstag, den 08.11.2005, 10:46 -0500 schrieb Anthony Balkissoon: On Tue, 2005-11-08 at 11:53 +, Roman Kennke wrote: Hi again, Yesterday I checked in a change to java.awt.Component. Today I wrote a testcase for that (bad me, I should really do that before starting to code

Re: [cp-patches] Patch: SwingUtilities.replaceUIActionMap fixed

2005-11-08 Thread Roman Kennke
Am Dienstag, den 08.11.2005, 15:39 -0500 schrieb Anthony Balkissoon: As I reported in bug 24742: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24742 SwingUtilities.replaceUIActionMap wasn't working properly. This patch fixes it and also fixes BasicListUI, BasicTableUI, and BasicTreeUI to use

[cp-patches] FYI: BasicTextUI fixlet

2005-11-09 Thread Roman Kennke
I committed this little fixlet for the BasicTextUI. This should solve the problem with textfields where the text is slightly off when displaying right-aligned. 2005-11-09 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTextUI.java (getVisibleEditorRect): Correctly

[cp-patches] FYI: JComponent fixlet

2005-11-09 Thread Roman Kennke
I committed the attached fix that moves the getComponentGraphics() fetch from paintComponent() to paint(). Some simple tests show that this is the right thing and it also fixes a problem with an app I have here. 2005-11-09 Roman Kennke [EMAIL PROTECTED] * javax/swing/JComponent.java

Re: [cp-patches] Patch: implemented InvocationEvent.getThrowable

2005-11-09 Thread Roman Kennke
Hi there, Am Mittwoch, den 09.11.2005, 10:40 -0500 schrieb Anthony Balkissoon: On Tue, 2005-11-08 at 18:30 -0700, Tom Tromey wrote: Tony == Anthony Balkissoon [EMAIL PROTECTED] writes: Tony Thanks for the advice Mark, I fixed this up and committed it. Tony 2005-11-08 Anthony

[cp-patches] FYI: InputStreamReader fixlet

2005-11-09 Thread Roman Kennke
Hi, The jIRCii app passes a CharseetDecoder to InputStreamReader that returns null for charset() (its named NoConversion). This must be catched in the InputStreamReader constructor. 2005-11-09 Roman Kennke [EMAIL PROTECTED] * java/io/InputStreamReader.java (InputStreamReader

Re: [cp-patches] RFC: small PrintWriter improvement

2005-11-09 Thread Roman Kennke
Am Mittwoch, den 26.10.2005, 10:39 +0200 schrieb Roman Kennke: Hi, here comes another fix from Friedjof Siebert that ensures that the field line_separator is not null (in the unlikely but not impossible case that the system property is not set). 2005-10-26 Roman Kennke [EMAIL PROTECTED

Re: [cp-patches] RFC: WeakHashMap improvement

2005-11-09 Thread Roman Kennke
Hi, Am Mittwoch, den 26.10.2005, 10:37 +0200 schrieb Roman Kennke: Hi, Friedjof Siebert did some improvements on java.util.WeakHashMap that I'd like to check in. They are meant to improve reliability of this class by enabling the prove of a cast and the absence of a null-pointer. 2005-10

[cp-patches] FYI: ComboBox fix

2005-11-10 Thread Roman Kennke
Hi, I fixed the BasicComboBoxUI so that the box is closed when the ComboBox (or its list) loses the focus. 2005-10-10 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicComboBoxUI.java (installListeners): Also install focusListener on the listBox

[cp-patches] FYI: BasicListUI

2005-11-10 Thread Roman Kennke
. I'll implement a similar optimization for JTable, JTree and the text components soon. 2005-11-10 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicListUI.java (valueChanged): Repaint list when selection changed. (updateLayoutState): Reworked to correctly respect

[cp-patches] FYI: Fixed JProgressBar UIs

2005-11-14 Thread Roman Kennke
vertical text without Java2D support? I don't know... 2005-11-14 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicProgressBarUI.java (boxRect): New protected field. (PropertyChangeHandler.propertyChange): Fixed typo in 'indeterminate'. Only start animation

[cp-patches] FYI: New ProgressBar demo

2005-11-14 Thread Roman Kennke
Hi, I added a little new demo to our Swing Activity Board. It demonstrates the JProgressBar in some different settings. 2005-11-14 Roman Kennke [EMAIL PROTECTED] * examples/gnu/classpath/examples/swing/Demo.java (static_initializer): Set the LF and theme explicitly

[cp-patches] FYI: AbstractButton fixlet

2005-11-14 Thread Roman Kennke
/jdk1.5.0/api/java/awt/doc-files/FocusSpec.html 2005-11-14 Roman Kennke [EMAIL PROTECTED] * javax/swing/AbstractButton.java (setEnabled): Also set focusable flag on the button when the enabled property changes. Cheers, Roman Index: javax/swing/AbstractButton.java

[cp-patches] FYI: BoxView optimization

2005-11-14 Thread Roman Kennke
I optimized the BoxView (a basic view for all kinds of styled text components) a little so that it only paints a given child view if the child view's allocation is inside the current clip. 2005-11-14 Roman Kennke [EMAIL PROTECTED] * javax/swing/text/BoxView.java (paint): Only

[cp-patches] FYI: BasicTextUI fixes

2005-11-14 Thread Roman Kennke
Hi, I fixed 2 little issues in BasicTextUI that came up when testing jIRCii. 2005-11-14 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTextUI.java (uninstallListeners): Uninstall the document listener here. (getVisibleEditorRect): Fetch the textComponent

[cp-patches] FYI: BasicTextUI fixlet

2005-11-14 Thread Roman Kennke
not update the textfield colors correctly. 2005-11-14 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTextFieldUI.java (propertyChange): Get new value from the PropertyChangeEvent and not from the component itself (since when it receives the event

[cp-patches] FYI: BasicLookAndFeel fix

2005-11-14 Thread Roman Kennke
This patch really belongs to my previous ProgressBar UI patch, but slipped through. This fixes some UI defaults for the BasicProgressBarUI. 2005-11-14 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicLookAndFeel.java (initComponentDefaults): Fixed some UI defaults

[cp-patches] FYI: BasicInternalFrameTitlePane fixlet

2005-11-14 Thread Roman Kennke
I added some null pointer checks to BasicInternalFrameTitlePane so that subclasses that don't use the fields of this class won't break the setButtonIcons method. 2005-11-14 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicInternalFrameTitlePane.java (setButtonIcons

[cp-patches] FYI: BasicComboPopup fix

2005-11-14 Thread Roman Kennke
Hi, I fixed the BasicComboPopup a little so that it comes up with the correct size and borders. 2005-11-14 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicComboPopup.java (show): Instead of fiddling with the list size, set the preferredSize of the scroller

[cp-patches] FYI: RepaintManager fix

2005-11-14 Thread Roman Kennke
The RepaintManagers static access methods currentManager() and setCurrentManager() should manage the RepaintManager instances by the calling thread's ThreadGroup instead of using one global instance for everything. I implemented this in the following patch. 2005-11-14 Roman Kennke [EMAIL

[cp-patches] FYI: JLayeredPane fix

2005-11-14 Thread Roman Kennke
The JLayeredPane.paint() method should only clear the background of the JLayeredPane if it is opaque. Fixed with the attached patch. 2005-11-14 Roman Kennke [EMAIL PROTECTED] * javax/swing/JLayeredPane.java (paint): Only clear the background if the layeredPane is opaque

[cp-patches] FYI: PlatformHelper fix for Windows platforms

2005-11-14 Thread Roman Kennke
with the assumption that it would be easier to handle. In fact this is incorrect, while it may work for Windows file systems, it does not work for JAR files etc. Since I received no negative replies to that proposal, I'll commit this now. 2005-11-14 Roman Kennke [EMAIL PROTECTED] Reported by Ingo

Re: [cp-patches] FYI: New ProgressBar demo

2005-11-14 Thread Roman Kennke
Am Montag, den 14.11.2005, 15:26 +0100 schrieb Michael Koch: Hi Roman, Your patch looks really strange. :-) Yeah sorry. Too much bash history usage :-/ Attached you find the real patch. /Roman Index: examples/gnu/classpath/examples/swing/Demo.java

[cp-patches] FYI: BasicListUI fix

2005-11-15 Thread Roman Kennke
My last 'fix' for BasicListUI introduced some new misbehaviour in JList rendering. This should be fixed by this patch. 2005-11-15 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicListUI.java Fixed API docs all over to better explain the changed (but correct

Re: [cp-patches] FYI: Prevent multiple lines in JTextField

2005-11-15 Thread Roman Kennke
Am Dienstag, den 15.11.2005, 11:27 +0100 schrieb Meskauskas Audrius: JTextField is always a single line component. In GNU Classpath, it is possible to make it multi line by setting or pasting the line with line feeds. While this is highly impressive, the Sun's implementation never does

Re: [cp-patches] FYI: Prevent multiple lines in JTextField

2005-11-15 Thread Roman Kennke
by default). I checked in the attached patch to fix this. This should also solve your problem and there is no need to check in your patch. 2005-11-15 Roman Kennke [EMAIL PROTECTED] * javax/swing/JTextField.java (createDefaultModel): Set the filterNewlines property on the created

[cp-patches] FYI: MetalUtils fix for Graphics2D

2005-11-15 Thread Roman Kennke
I fixed the texture for the Graphics2D version of MetalUtils. The metal pattern should now be drawn using textures when in Graphics2D mode (I assume that this is faster than drawing the pattern 'manually'). 2005-11-15 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/metal

[cp-patches] FYI: JViewport system property

2005-11-15 Thread Roman Kennke
a very usable copyArea implementation atm. In such case simply add -Dgnu.javax.swing.JViewport.scrollMode=SIMPLE to avoid copyArea calls. 2005-11-15 Roman Kennke [EMAIL PROTECTED] * javax/swing/JViewport.java (JViewport): Recognize setting of a system property

[cp-patches] FYI: Basic LF cleanup

2005-11-15 Thread Roman Kennke
/fix this). I also took out some caching in BasicToolBarUI, that caused problems with the jIRCii app that I tried out. I will have to look into this issue in more detail later. 2005-11-15 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicBorders.java (getButtonBorder

[cp-patches] FYI: Metal LF cleanup

2005-11-15 Thread Roman Kennke
I also cleaned up the Metal LF, replacing all UIManager.getLookAndFeelDefaults().getXXX() calls with UIManager.getXXX(). I also removed some redundant init code from MetalTreeUI() which is now delegated to the superclass, which does exactly the same thing. 2005-11-15 Roman Kennke [EMAIL

[cp-patches] FYI: UIManager fix

2005-11-15 Thread Roman Kennke
UIManager.getLookAndFeelDefaults().getXXX() but instead UIManager.getXXX(), so that they can 'see' the user settings. 2005-11-15 Roman Kennke [EMAIL PROTECTED] * javax/swing/UIManager.java (userUIDefaults): New field. (get(Object)): Respect the user UI settings. (get(Object,Locale)): Respect

Re: [cp-patches] FYI: Releasing the first CORBA/Swing example ( two player network strategy game)

2005-11-15 Thread Roman Kennke
Hi, Am Dienstag, den 15.11.2005, 22:12 +0100 schrieb Meskauskas Audrius: This example should demonstrate the work of CORBA in the Swing based network game.The game was popular in my student times. After doing some web search I concluded that the game is called Five-in-a-row in

<    1   2   3   4   5   6   7   8   9   10   >