[cp-patches] FYI: BasicListUI API doc fixlet

2006-01-10 Thread Roman Kennke
I added a @since to BasicListUI.playSound. 2006-01-10 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicLookAndFeel.java (playSound): Added @since 1.4 to the API docs. /Roman Index: javax/swing/plaf/basic/BasicLookAndFeel.java

[cp-patches] FYI: ViewportLayout fix

2006-01-10 Thread Roman Kennke
Hi there, This ViewportLayout fix makes Scrollable view components always have the viewport size, when they return true on getScrollableTracksViewportHeight() and ...Width(), independent of their preferred size. 2006-01-10 Roman Kennke [EMAIL PROTECTED] * javax/swing

[cp-patches] FYI: RepaintManager fix

2006-01-10 Thread Roman Kennke
I fixed a condition in RepaintManager.validateInvalidComponents() to avoid an NPE. 2006-01-10 Roman Kennke [EMAIL PROTECTED] * javax/swing/RepaintManager.java (validateInvalidComponents): Fixed condition to avoid NPE. /Roman Index: javax/swing/RepaintManager.java

[cp-patches] FYI: Another ViewportLayout fix

2006-01-10 Thread Roman Kennke
I had to fix the condition in ViewportLayout.layoutContainer() again, in order to avoid a ClasscastException. 2006-01-10 Roman Kennke [EMAIL PROTECTED] * javax/swing/ViewportLayout.java (layoutContainer): Fixed condition, to avoid ClasscastException. /Roman Index: javax/swing

[cp-patches] FYI: Wrap over the ChangeLog

2006-01-10 Thread Roman Kennke
Hi there, I moved all the ChangeLog entries of 2005 into ChangeLog-2005, as was done the years before. /Roman ___ Classpath-patches mailing list Classpath-patches@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-patches

[cp-patches] FYI: ChangeLog-2005

2006-01-10 Thread Roman Kennke
I included the ChangeLog-2005 in the Makefile.am, so that it will be shipped in releases. 2006-01-10 Roman Kennke [EMAIL PROTECTED] * Makefile.am (EXTRA_DIST): Added ChangeLog-2004. * ChangeLog-2005: New File. /Roman Index: Makefile.am

[cp-patches] RFC: Hashtable cleanup

2006-01-10 Thread Roman Kennke
includes a small improvement in the rehash() method. See the ChangeLog and the code for details. So, should I check this in? 2006-01-10 Roman Kennke [EMAIL PROTECTED] Reported by: Fridjof Siebert [EMAIL PROTECTED] * java/util/Hashtable.java (KEYS): Removed unneeded field

Re: [cp-patches] RFC: Hashtable cleanup

2006-01-11 Thread Roman Kennke
Hi Tom, Am Mittwoch, den 11.01.2006, 11:19 -0700 schrieb Tom Tromey: Roman == Roman Kennke [EMAIL PROTECTED] writes: Roman So, should I check this in? Yes, but... Roman + if (idx = 0) /* added this test to avoid Roman + * ArrayIndexOutOfBounds when Hashtable

Re: [cp-patches] RFC: Hashtable cleanup

2006-01-11 Thread Roman Kennke
Hi Tom, I applied your suggested changes and committed the attached patch. I am going to commit the mentioned mauve test now. 2006-01-11 Roman Kennke [EMAIL PROTECTED] Reported by: Fridjof Siebert [EMAIL PROTECTED] * java/util/Hashtable.java (KEYS): Removed unneeded

[cp-patches] FYI: Hashtable fixes

2006-01-12 Thread Roman Kennke
Now that was interesting. My last patch for Hashtable contained a fix for the (new) EnumerateAndModify mauve test and some rewrite for the parameterized class. Obviously the latter made the former fail again. I had to add some null checks in order to make the tests fully PASS. 2006-01-12 Roman

[cp-patches] FYI: Component event handling fix

2006-01-13 Thread Roman Kennke
Hi, this is the first patch that I commit to make our AWT more compatible with the 1.0-style event handling. It moves some code from dispatchEventImpl to dispatchEvent and fixes translateEvent() to also be usable for MenuComponent events. 2006-01-13 Roman Kennke [EMAIL PROTECTED

[cp-patches] FYI: Old style event fixes, part 2

2006-01-13 Thread Roman Kennke
the event this way. 2006-01-13 Roman Kennke [EMAIL PROTECTED] * java/awt/MenuBar.java (frame): New field. (removeNotify): Clear frame field when beeing removed from the frame. * java/awt/Frame.java (setMenuBar): Store a reference of the frame

[cp-patches] FYI: fix MenuBar warnings

2006-01-13 Thread Roman Kennke
This fixes some warnings that were pointed out by Eclipse in java.awt.MenuBar. 2006-01-13 Roman Kennke [EMAIL PROTECTED] * java/awt/MenuBar.java (accessibleContext): Removed unnecessary field. This is already defined in MenuComponent. (setHelpMenu): Renamed

[cp-patches] FYI: MenuBar reformatting

2006-01-13 Thread Roman Kennke
I reformatted the java.awt.MenuBar to better match our coding style. 2006-01-13 Roman Kennke [EMAIL PROTECTED] * java/awt/MenuBar.java: Reformatted to better match our coding style. /Roman Index: java/awt/MenuBar.java

[cp-patches] FYI: reformatted Frame

2006-01-13 Thread Roman Kennke
I also reformatted java.awt.Frame to match our coding style. 2006-01-13 Roman Kennke [EMAIL PROTECTED] * java/awt/Frame.java: Reformatted to better match our coding style. /Roman Index: java/awt/Frame.java === RCS

[cp-patches] FYI: Swing based AWT peers.

2006-01-13 Thread Roman Kennke
hints for implementing a real toolkit on top of those widgets. Cheers, Roman 2006-01-13 Roman Kennke [EMAIL PROTECTED] * gnu/java/awt/peer/swing/SwingButtonPeer.java, * gnu/java/awt/peer/swing/SwingCanvasPeer.java, * gnu/java/awt/peer/swing/SwingComponent.java

[cp-patches] FYI: MinGW layer

2006-01-16 Thread Roman Kennke
-01-16 Roman Kennke [EMAIL PROTECTED] * native/target/MinGW/target_native.h, * native/target/MinGW/target_native_file.h, * native/target/MinGW/target_native_io.h, * native/target/MinGW/target_native_math.h, * native/target/MinGW/target_native_memory.h

[cp-patches] FYI: embOS target native layer

2006-01-16 Thread Roman Kennke
This is the target native layer implementation for the embOS platform. Again, this is pretty straightforward. 2006-01-16 Roman Kennke [EMAIL PROTECTED] * native/target/embOS/target_native.h, * native/target/embOS/target_native_file.h, * native/target/embOS

[cp-patches] FYI: target_native_math

2006-01-16 Thread Roman Kennke
I want to start my work on the TARGET_NATIVE layer with some small adjustments. Here I stack together the code from target_native_math_int.h and target_native_math_float.h into one new target_native_math.h. 2006-01-16 Roman Kennke [EMAIL PROTECTED] * native/target/generic

[cp-patches] FYI: Fixed typo in generic target

2006-01-16 Thread Roman Kennke
... And on we go with the first fix for the generic target. A little typo has slipped in which is fixed by this patch. 2006-01-16 Roman Kennke [EMAIL PROTECTED] * native/target/generic/target_generic_network.c: Fixed typo. * native/target/generic/target_generic_network.h: Fixed

[cp-patches] FYI: RTEMS impl for the target native layer

2006-01-16 Thread Roman Kennke
Hi, here comes the last patch for the target native layer (for now), which implements the layer for RTEMS platform. 2006-01-16 Roman Kennke [EMAIL PROTECTED] * native/target/RTEMS/target_native.h, * native/target/RTEMS/target_native_file.h, * native/target/RTEMS

[cp-patches] FYI: SunOS target native layer

2006-01-16 Thread Roman Kennke
Here comes the target native layer implementation for the SunOS platform. Again, since this is pretty close to Posix, this is nothing serious. Some stuff in math and network and that's it. 2006-01-16 Roman Kennke [EMAIL PROTECTED] * native/target/SunOS/target_native.h, * native

[cp-patches] RFC: Build fixes for new target native layers

2006-01-16 Thread Roman Kennke
that. Anybody there who can help me with this? I committed the attached patch anyway so that the build is fixed. 2006-01-16 Roman Kennke [EMAIL PROTECTED] * native/target/Makefile.am: Adjusted SUBDIRS and DIST_SUBDIRS to include the new targets. * native/target/posix/Makefile.am

[cp-patches] FYI: Some fixes for the generic layer

2006-01-16 Thread Roman Kennke
This patch fixes several typos and includes in the target generic implementation. 2006-01-16 Roman Kennke [EMAIL PROTECTED] * native/target/generic/target_generic_file.h: Added missing include. * native/target/generic/target_generic_network.c: Fixed several

[cp-patches] FYI: another build fix

2006-01-16 Thread Roman Kennke
The attached patch is also needed in order to correctly build the new target native code. 2006-01-16 Roman Kennke [EMAIL PROTECTED] * configure.ac: Include new target native directories in build. /Roman Index: configure.ac

[cp-patches] FYI: Makefiles for new targets

2006-01-16 Thread Roman Kennke
The attached patch includes the new targets in the Makefile.am's so they are included in the distributions. 2006-01-16 Roman Kennke [EMAIL PROTECTED] * native/target/Makefile.am: Include new targets. * native/target/Linux/Makefile.am: Include new memory layer. * native

Re: [cp-patches] Re: JamVM stopped working today

2006-01-17 Thread Roman Kennke
Hi folks, Am Montag, den 16.01.2006, 20:45 +0100 schrieb Mark Wielaard: Hi David, On Mon, 2006-01-16 at 18:22 +, David Gilbert wrote: Hi All, JamVM stopped working for me today - I get this error when I try to run the SimpleTestHarness in Mauve: $ jamvm -classpath .

[cp-patches] FYI: Build fixes for new target native stuff

2006-01-17 Thread Roman Kennke
exit somehow). 2006-01-17 Roman Kennke [EMAIL PROTECTED] * native/jni/classpath/jcl.c: Added missing imports. (JCL_realloc): Fixed signature to include oldsize. This is needed for some targets. Make this function use the MEMORY_REALLOC macro for portability

Re: [cp-patches] Re: JamVM stopped working today

2006-01-17 Thread Roman Kennke
Hi, Am Dienstag, den 17.01.2006, 13:42 + schrieb David Gilbert: Roman Kennke wrote: I fixed this in CVS. I really should always --enable-Werror when doing such changes. Sorry for any inconveniences. Cheers, /Roman You're such a liability! ;-) Regards, Dave P.S

[cp-patches] FYI: target_generic_network.c fixlet

2006-01-17 Thread Roman Kennke
I fixed two functions in target_generic_network.c so that their signatures match the declarations in the corresponding .h file. 2006-01-17 Roman Kennke [EMAIL PROTECTED] * native/target/generic/target_generic_network.c: (targetGenericNetwork_receive): Fixed signature to match

[cp-patches] FYI: malloc and free targetizized

2006-01-17 Thread Roman Kennke
I replaced calls to malloc() and free() in jcl.c and native_state.c with the corresponding target macros for improved portability. 2006-01-17 Roman Kennke [EMAIL PROTECTED] * native/jni/classpath/jcl.c: (JCL_malloc): Replaced calls to malloc with the corresponding

[cp-patches] FYI: FileChannelImpl.c fixes

2006-01-17 Thread Roman Kennke
the corresponding target native macros. 2006-01-17 Roman Kennke [EMAIL PROTECTED] * native/jni/java-nio/gnu_java_nio_channels_FileChannelImpl.c: (Java_gnu_java_nio_channels_FileChannelImpl_init): Improved exception messages a little

[cp-patches] FYI: javanet.c fixes and improvements

2006-01-17 Thread Roman Kennke
macros for improved portability. 2006-01-17 Roman Kennke [EMAIL PROTECTED] * native/jni/java-net/javanet.c: (_javanet_connect): Changed type of some local variables to jint. Fixed error handling to throw a SocketTimeoutException if the connection attempt times out

Re: [cp-patches] FYI: malloc and free targetizized

2006-01-17 Thread Roman Kennke
Hi Tromey, Am 17.1.2006 schrieb Tom Tromey [EMAIL PROTECTED]: Roman == Roman Kennke [EMAIL PROTECTED] writes: Roman I replaced calls to malloc() and free() in jcl.c and Roman native_state.c with the corresponding target macros for Roman improved portability. Roman - void *mem = malloc

[cp-patches] FYI: java-util adjustments for target/native

2006-01-18 Thread Roman Kennke
I checked in this adjustment for VMTimeZone.c to make use of the target native portability layer. 2006-01-18 Roman Kennke [EMAIL PROTECTED] * native/jni/java-util/java_util_VMTimeZone.c: (Java_java_util_VMTimeZone_getSystemTimeZoneId): Rewritten to use target native

[cp-patches] FYI: java-nio adjustments for target/native

2006-01-18 Thread Roman Kennke
consider this as a work in progress... 2006-01-18 Roman Kennke [EMAIL PROTECTED] * native/jni/java-nio/gnu_java_nio_VMPipe.c: Removed unnecessary include. * native/jni/java-nio/gnu_java_nio_VMSelector.c: Reorganized includes to only include sys/* headers when available

Re: [cp-patches] FYI: Remove (bogus) asserts in java-net.

2006-01-18 Thread Roman Kennke
Hi Mark, Am Donnerstag, den 12.01.2006, 10:36 +0100 schrieb Mark Wielaard: Hi, The crashes we were seeing with the net code in Mauve were caused by the following bogus asserts in VMPlainDatagramSocketImpl_nativeReceive(): assert((*env)-GetArrayLength(env, receivedFromAddress) 4);

[cp-patches] FYI: Fixlet for VMInetAddress.c

2006-01-18 Thread Roman Kennke
Here comes a small patchlet that lets the VMInetAddress.c use the target native macro for INADDR_ANY. 2006-01-18 Roman Kennke [EMAIL PROTECTED] * native/jni/java-net/java_net_VMInetAddress.c (Java_java_net_VMInetAddress_lookupInaddrAny): Use target native macro

[cp-patches] Re: [commit-cp] classpath ChangeLog configure.ac

2006-01-19 Thread Roman Kennke
Hi Mark, Am Donnerstag, den 19.01.2006, 01:59 +0100 schrieb Mark Wielaard: Hi Roman, On Wed, 2006-01-18 at 11:31 +, Roman Kennke wrote: CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Roman Kennke [EMAIL PROTECTED]06/01/18 11:31:14

Re: [cp-patches] FYI: java-util adjustments for target/native

2006-01-19 Thread Roman Kennke
Hi Mark, Am Donnerstag, den 19.01.2006, 02:02 +0100 schrieb Mark Wielaard: Hi Roman, On Wed, 2006-01-18 at 10:19 +, Roman Kennke wrote: I checked in this adjustment for VMTimeZone.c to make use of the target native portability layer. 2006-01-18 Roman Kennke [EMAIL PROTECTED

[cp-patches] FYI: Fixlet for target Makefile.am

2006-01-19 Thread Roman Kennke
In my last commit I made a little mistake. I added a conditional to the native/target/Makefile.am but didn't actually use it when putting together the SUBDIRS. This resulted in posix beeing build unconditionally which of course is wrong. This is fixed by the attached patch. 2006-01-19 Roman

Re: [cp-patches] FYI: Remove (bogus) asserts in java-net.

2006-01-19 Thread Roman Kennke
Hi Mark, Am Donnerstag, den 19.01.2006, 02:12 +0100 schrieb Mark Wielaard: Hi Roman, On Wed, 2006-01-18 at 12:20 +0100, Roman Kennke wrote: Am Donnerstag, den 12.01.2006, 10:36 +0100 schrieb Mark Wielaard: Hi, The crashes we were seeing with the net code in Mauve were caused

[cp-patches] FYI: Bugfix for target layer

2006-01-19 Thread Roman Kennke
Hi, I added the missing function targetGenericMisc_formatString() that somehow got lost. 2006-01-19 Roman Kennke [EMAIL PROTECTED] * native/target/generic/target_generic_misc.c: (targetGenericMisc_formatString): Added missing method. /Roman Index: native/target/generic

[cp-patches] FYI: SwingFramePeer fix

2006-01-19 Thread Roman Kennke
Roman Kennke [EMAIL PROTECTED] * gnu/java/awt/peer/swing/SwingFramePeer.java (handleMouseEvent): Fixed handling of mouse events. (handleMouseMotionEvent): Fixed handling of mouse events. /Roman Index: gnu/java/awt/peer/swing/SwingFramePeer.java

[cp-patches] FYI: JOptionPane fixlet

2006-01-19 Thread Roman Kennke
In my last commit I forgot to adjust the JOptionPane to the new SwingUtilities.getOwnerFrame() signature. This is done by this patch. 2006-01-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/JOptionPane.java Added cast to Frame for JDialog constructor. /Roman Index: javax/swing

[cp-patches] FYI: JWindow API docs

2006-01-19 Thread Roman Kennke
I added some API docs to the JWindow constructors. 2006-01-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/JWindow.java: Added API docs to the constructors. /Roman Index: javax/swing/JWindow.java === RCS file: /cvsroot

[cp-patches] FYI: Some swing fixes

2006-01-19 Thread Roman Kennke
, which is now also going in. This is to call pack() in the showXXXDialog() methods. I feel that this will break the JFileChooser a little, but I already know how to fix it (I only must find time to do it - basically we need a special subclass of JList that displays the files) 2006-01-19 Roman Kennke

[cp-patches] FYI: more JWindow constructor fixes

2006-01-19 Thread Roman Kennke
I fixed the remaining JWindow constructors to also accept null owner arguments. This involved modifying the SwingUtilities.getOwnerFrame() signature once more, and adding casts to the statements that call this method. 2006-01-19 Roman Kennke [EMAIL PROTECTED] * javax/swing/JWindow.java

[cp-patches] FYI: DefaultFormatter fixlet

2006-01-20 Thread Roman Kennke
This fixes the DefaultFormatter constructor which shouldn't set a value class (according to a mauve test that I also committed). 2006-01-20 Roman Kennke [EMAIL PROTECTED] * javax/swing/text/DefaultFormatter.java (DefaultFormatter): Don't set a value class. /Roman Index: javax

[cp-patches] FYI: PopupFactory improvement

2006-01-21 Thread Roman Kennke
to that). 2006-01-21 Roman Kennke [EMAIL PROTECTED] * javax/swing/PopupFactory.java (getPopup): If there is no Swing root found in any way, use a heavyweight popup. This is useful for mixed Swing/AWT GUIs, or for the Swing AWT peers. /Roman Roman Kennke aicas GmbH http

[cp-patches] FYI: JSplitPane fixes

2006-01-21 Thread Roman Kennke
- wrong border set on divider - general layout problems in the layout manager - performance problems when dragging These should be somewhat solved. However, the JSplitPane is still shaky and needs some love. 2006-01-21 Roman Kennke [EMAIL PROTECTED] PR classpath/25843: * javax

[cp-patches] FYI: MetalSplitPaneDivider fixlet

2006-01-21 Thread Roman Kennke
The MetalSplitPaneDivider wasn't painting its border, this is fixed by this patch. 2006-01-21 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/metal/MetalSplitPaneDivider.java (paint): Added painting of border if one is installed. /Roman -- Roman Kennke aicas GmbH http

Re: [cp-patches] Patch to make Classpath HEAD build work again with Darwin

2006-01-22 Thread Roman Kennke
Hi Chris, Am Freitag, den 20.01.2006, 21:32 + schrieb Chris Burdess: The attached patch allows the build to complete on Darwin. I'd very much appreciate any comments as I'm really not an expert on the new target-native stuff. This patch looks very good. Please check it in. /Roman

Re: [cp-patches] FYI: FileChannelImpl.c fixes

2006-01-23 Thread Roman Kennke
Hi Mark, Am Montag, den 23.01.2006, 15:13 +0100 schrieb Mark Wielaard: Hi Roman, On Tue, 2006-01-17 at 16:36 +, Roman Kennke wrote: Here come some fixes for FileChannelImpl.c. Mainly this provides alternative implementations of the methods for systems that don't have a filesystems

Re: [cp-patches] FYI: FileChannelImpl.c fixes

2006-01-23 Thread Roman Kennke
Hi Mark, Am Montag, den 23.01.2006, 17:25 +0100 schrieb Mark Wielaard: Hi Roman, On Mon, 2006-01-23 at 15:21 +0100, Roman Kennke wrote: This broke File locking. In particular the mauve test gnu.testlet.java.nio.channels.FileChannel.lock and the eclipse osgi locking. How did you test

[cp-patches] FYI: SplitPane fixlets

2006-01-25 Thread Roman Kennke
Hi there, I removed some layout() and repaint() calls in JSplitPane and BasicSplitPaneUI. These caused a NPE when starting the SwingDemo and seem to be useless anyway. There are still problems though with the SplitPane. I'll look at these soon. 2006-01-25 Roman Kennke [EMAIL PROTECTED

[cp-patches] FYI: FormView

2006-01-25 Thread Roman Kennke
I did a partial implementation of javax.swing.text.html.FormView and added FIXMEs for the things to do. 2006-01-25 Roman Kennke [EMAIL PROTECTED] * javax/swing/text/html/FormView.java: New file. /Roman Index: javax/swing/text/html/FormView.java

[cp-patches] FYI: Component fixlet

2006-01-27 Thread Roman Kennke
Roman Kennke [EMAIL PROTECTED] * java/awt/Component.java (coalescePaintEvent): Don't try to optimize coalescing. This hurts more than it helps. Cheers, Roman Index: java/awt/Component.java === RCS file

[cp-patches] FYI: removed debug statement in SwingFramePeer

2006-01-27 Thread Roman Kennke
I removed a debug statement in SwingFramePeer. 2006-01-27 Roman Kennke [EMAIL PROTECTED] * gnu/java/awt/peer/swing/SwingComponentPeer.java (handleEvent): Removed debug statement. /Roman Index: gnu/java/awt/peer/swing/SwingComponentPeer.java

[cp-patches] FYI: Some more API fixlets for Swing

2006-01-27 Thread Roman Kennke
Some more API fixes for Swing. 2006-01-27 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java (installDefaults): Removed requestFocusInWindow() call. * javax/swing/JComponent.java (requestFocusInWindow(boolean)): Made method protected

[cp-patches] FYI: Even more Swing API fixes

2006-01-27 Thread Roman Kennke
2006-01-27 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicInternalFrameUI.java (InternalFramePropertyChangeListener): Don't implement VetoableChangeListener. (InternalFramePropertyChangeListener.vetoableChange): Removed

[cp-patches] FYI: Popup fixes

2006-01-27 Thread Roman Kennke
The attached fixes improve the working of Popup and JPopupMenu in non-Swing toplevel containers. 2006-01-27 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicPopupMenuUI.java (PopupMenuHandler.popupMenuWillBecomeInvisible): Fixed to also handle non-Swing

[cp-patches] FYI: MetalFileChooserUI fixlet

2006-01-27 Thread Roman Kennke
, when I find some time. 2006-01-27 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/metal/MetalFileChooserUI.java (createList): Don't set scrollbar policy. /Roman Index: javax/swing/plaf/metal/MetalFileChooserUI.java

[cp-patches] FYI: JLayeredPane fixes

2006-01-27 Thread Roman Kennke
. 2006-01-27 Roman Kennke [EMAIL PROTECTED] * javax/swing/JLayeredPane.java (FRAME_CONTENT_LAYER): Made field final. (componentToLayer): Made field private. (rectCache): Removed field. (layers): Removed field. (JLayeredPane()): Removed initialization

[cp-patches] FYI: JLayeredPane fixlet

2006-01-27 Thread Roman Kennke
I made a small mistake in my JLayeredPane patch. The components were added to the layeredpane in exactly the wrong order for layers to be rendered correctly. This patch fixes this. 2006-01-27 Roman Kennke [EMAIL PROTECTED] * javax/swing/JLayeredPane.java (inserIndexForLayer

[cp-patches] FYI: Swing demo optimization

2006-01-27 Thread Roman Kennke
time of the Demo. 2006-01-27 Roman Kennke [EMAIL PROTECTED] * examples/gnu/classpath/examples/swing/ButtonDemo.java (createContent): Only create new content if we don't have one already. * examples/gnu/classpath/examples/swing/ComboBoxDemo.java

[cp-patches] FYI: MiniDemo for Swing

2006-01-27 Thread Roman Kennke
javax.swing.plaf.metal.MetalLookAndFeel; + +/** + * A Swing demo suitable for embedded environments (e.g. small display, + * b/w graphics etc). + * + * @author Roman Kennke ([EMAIL PROTECTED]) + */ +public class MiniDemo extends JFrame +{ + + /** + * Creates a new MiniDemo instance. + */ + MiniDemo

[cp-patches] FYI: BasicListUI fix

2006-01-28 Thread Roman Kennke
This patch corrects the calculation of the cell width for VERTICAL layoutOrientation in JLists and greatly improves performance of JList painting by saving most updateLayoutState() calls from within paint(). 2006-01-28 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic

[cp-patches] FYI: Another BasicListUI fixlet

2006-01-28 Thread Roman Kennke
I removed some statements that are no longer needed since my last patch. 2006-01-28 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicListUI.java (updateLayoutState): Removed unneeded special case for VERTICAL /Roman Index: javax/swing/plaf/basic/BasicListUI.java

Re: [cp-patches] RFC:Changing the javax/swing/ViewportLayout.java algorithm.

2006-01-28 Thread Roman Kennke
Hi Audrius, Am Samstag, den 28.01.2006, 22:09 +0100 schrieb Audrius Meskauskas: There was a strange (but documented) rule in the javax/swing/ViewportLayout.java: If the port is larger than the view's minimum size, put the port at view position (0,0). For the view port in the scroll pane

Re: [cp-patches] The latest two patches on javax/swing/plaf/basic/BasicListUI.java break the List World demo: One line should be reverted

2006-01-30 Thread Roman Kennke
Hi Audrius, Am Montag, den 30.01.2006, 09:33 +0100 schrieb Audrius Meskauskas: The new JList component does not appear because maybeUpdateLayoutState does not update the layout state if the list.isValid() returns false. I would suggest avoid applying patches, breaking some already existing

[cp-patches] FYI: JLayeredPane fixlet

2006-01-30 Thread Roman Kennke
Hi there, I committed this small fix to make the Mauve test PASS that I committed a couple of minutes ago. 2006-01-30 Roman Kennke [EMAIL PROTECTED] * javax/swing/JLayeredPane.java (insertIndexForLayer): Fixed algorithm to correctly insert components within same layer

[cp-patches] FYI: another JLayeredPane fixlet

2006-01-30 Thread Roman Kennke
My last patch broke the JLayeredPane a little because of a slight logical mistake. I added a Mauve test for this and fixed it with this patch. 2006-01-30 Roman Kennke [EMAIL PROTECTED] * javax/swing/JLayeredPane.java (insertIndexForLayer): Fixed algorithm to correctly insert

Re: [cp-patches] The latest two patches on javax/swing/plaf/basic/BasicListUI.java break the List World demo: One line should be reverted

2006-01-30 Thread Roman Kennke
Hi Audrius, Am Montag, den 30.01.2006, 09:33 +0100 schrieb Audrius Meskauskas: The new JList component does not appear because maybeUpdateLayoutState does not update the layout state if the list.isValid() returns false. I would suggest avoid applying patches, breaking some already existing

Re: [cp-patches] FYI: JProgressBar 'illegal' orientation

2006-01-30 Thread Roman Kennke
Hi Mark, Testing this it seems that (at least in JDK1.5) the orientation value is indeed restricted to 0 and 1 (the constants that are defined for the orientation). JDK1.5 throws IllegalArgumentExceptions for all other values. I would suggest to follow the JDK there. /Roman Got an application

[cp-patches] FYI: RootLayout fix

2006-01-30 Thread Roman Kennke
? Caching layout info is ok and actually makes sense, but caching preferredSize can easily lead to incorrect layout, except when the caching is done in a way that the valid state of the container is also considered. 2006-01-30 Roman Kennke [EMAIL PROTECTED] * javax/swing/JRootPane.java

Re: [cp-patches] FYI: Swing Demos / minor fixes

2006-01-31 Thread Roman Kennke
Hi David, Am Montag, den 30.01.2006, 23:24 + schrieb David Gilbert: This patch (committed) removes one of the 'Close' buttons from the demo panels when they are launched from the main Swing demo: 2006-01-30 David Gilbert [EMAIL PROTECTED] *

[cp-patches] FYI: BasicTextUI fixlet

2006-01-31 Thread Roman Kennke
for now to make my application working: 2006-01-31 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTextUI.java (createKeymap): Don't store KeyBindings[] as focusInputMap in UIManager. Added FIXME regarding the implementation of this method. /Roman Index: javax

[cp-patches] FYI: Plain text fixes

2006-01-31 Thread Roman Kennke
I have an application here that implements a subclass of PlainView and seems to expect the drawLine method to be feeded with the coordinates of the text baseline instead of the upper left corner of the text. I adjusted the affected methods and added documentation for this. 2006-01-31 Roman

[cp-patches] FYI: BasicRootPaneUI fixlet

2006-01-31 Thread Roman Kennke
A mauve test that I committed just now points out that the BasicRootPaneUI should not install a background color on JRootPanes. This is fixed by this patch. 2006-01-31 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicRootPaneUI.java (installDefaults): Don't install

[cp-patches] FYI: JLayeredPane fix

2006-02-01 Thread Roman Kennke
I fixed one more JLayeredPane algorithm mistake, this makes the corresponding Mauve test pass. 2006-01-31 Roman Kennke [EMAIL PROTECTED] * javax/swing/JLayeredPane.java (insertIndexForLayer): Fixed algorithm to correctly determine inser index for positions = 0

[cp-patches] FYI: DefaultTableCellRenderer fixes

2006-02-01 Thread Roman Kennke
not be handled different than others. This must be a programming mistake, nobody would want a JTextField as _value_ in a table. Editing of table cells should be left to a TableCellEditor instance. 2006-01-31 Roman Kennke [EMAIL PROTECTED] * javax/swing/table/DefaultTableCellRenderer.java

[cp-patches] FYI: JTextField fixlet

2006-02-01 Thread Roman Kennke
In JTextField.getPreferredSize() we must include the textfield's insets, otherwise we might get strange layouts. 2006-01-31 Roman Kennke [EMAIL PROTECTED] * javax/swing/JTextField.java (getPreferredSize): Also include textfield's insets in width calculation. /Roman

[cp-patches] FYI: PasswordView fix

2006-02-01 Thread Roman Kennke
this to drawEchoCharacter() for subclasses to override. Doing so also magically fixes the regression :-) 2006-01-31 Roman Kennke [EMAIL PROTECTED] * javax/swing/text/PasswordView.java (drawSelectedText): Use drawEchoCharacter() method to draw echo character. (drawUnselectedText): Use

[cp-patches] FYI: RepaintManager optimization

2006-02-02 Thread Roman Kennke
job and wrapped it up in a try{} finally{} clause to make sure it cleans up when something in between fails. 2006-02-02 Roman Kennke [EMAIL PROTECTED] * javax/swing/RepaintManager.java Made fields private. (RepaintWorker.run): Enclosed work stuff in try finally block

Re: [cp-patches] FYI: SwingPropertyChangeSupport fixlet

2006-02-03 Thread Roman Kennke
Hi Mark, Am Freitag, den 03.02.2006, 12:19 +0100 schrieb Mark Wielaard: Hi, This should get rid of the last regression that builder is complaining about (technically it isn't a regression, the test got changed to not expect a NullPointerException). It simply changes the Hashtable that

Re: [cp-patches] Patch: DefaultStyledDocument.ElementBuffer final fix

2006-02-04 Thread Roman Kennke
Hi Lillian, Am Freitag, den 03.02.2006, 11:25 -0500 schrieb Lillian Angel: All the structures in the mauve tests are now correct. There are some regressions with ElementBuffer still. Mark, can you please change these to Failures instead. They test that the leaves of the document are

[cp-patches] FYI: JLayeredPane fixes / new Container methods

2006-02-04 Thread Roman Kennke
there is a layout manager installed on the JLayeredPane (which is discouraged but not forbidden). 2006-02-04 Roman Kennke [EMAIL PROTECTED] * java/awt/Container.java (getComponentZOrder): New method. (setComponentZOrder): New method. * javax/swing

Re: [cp-patches] RFC: DefaultListCellRenderer.getListCellRendererComponent() null values fix

2006-02-05 Thread Roman Kennke
Hi Mark, Am Sonntag, den 05.02.2006, 11:38 +0100 schrieb Mark Wielaard: Hi, The following fixes a bug with Jmol startup as reported by Egon. 2006-02-04 Mark Wielaard [EMAIL PROTECTED] Fixes bug #26101 reported by Egon Willighagen [EMAIL PROTECTED] *

Re: [cp-patches] FYI: SwingPropertyChangeSupport fixlet

2006-02-06 Thread Roman Kennke
Hi there again, Am Freitag, den 03.02.2006, 14:36 +0100 schrieb Roman Kennke: Hi Mark, Am Freitag, den 03.02.2006, 12:19 +0100 schrieb Mark Wielaard: Hi, This should get rid of the last regression that builder is complaining about (technically it isn't a regression, the test got

[cp-patches] FYI: SwingPropertyChangeSupport

2006-02-06 Thread Roman Kennke
Hi there, It seems that Sun has removed everything except the constructor from javax.swing.event.SwingPropertyChangeSupport. See http://java.sun.com/j2se/1.5.0/docs/guide/swing/1.5/index.html#swingMisc for details. 2006-02-06 Roman Kennke [EMAIL PROTECTED] * javax/swing/event

Re: [cp-patches] FYI: SwingPropertyChangeSupport fixlet

2006-02-06 Thread Roman Kennke
Hi Mark again, But maybe it can be made a little more efficient by not using the old Vector and Hashtable classes all the time which seem to double the synchronization in that class, but use an List and Map for that and only synchronize on those when really needed. Thinking about it, I am

[cp-patches] FYI: New java.awt.Component methods

2006-02-06 Thread Roman Kennke
I added a couple of JDK1.5 methods to java.awt.Component that are related to my last 2 property related Swing patches. This adds the firePropertyChange overloads that have been in javax.swing.JComponent before JDK1.5. 2006-02-06 Roman Kennke [EMAIL PROTECTED] * java/awt/Component.java

Re: [cp-patches] FYI: SwingPropertyChangeSupport fixlet

2006-02-06 Thread Roman Kennke
Hi Mark, Am Montag, den 06.02.2006, 14:21 +0100 schrieb Mark Wielaard: Hi Roman, On Mon, 2006-02-06 at 12:09 +0100, Roman Kennke wrote: I guess the java.beans.PropertyChangeSupport is now made more efficient (and not thread safe) so that the SwingPropertyChangeSupport is not needed

[cp-patches] FYI: Container fix

2006-02-06 Thread Roman Kennke
I remove one more duplication of the PropertyChangeSupport thingy in java.awt.Container. From the specs it is not immediately clear to me why addPropertyChangeListener is overridden in java.awt.Container. So I let it call super for now. 2006-02-06 Roman Kennke [EMAIL PROTECTED] * java

[cp-patches] FYI: javax.swing.text fixes

2006-02-06 Thread Roman Kennke
The attached patch makes the BeanShell JConsole work quite well (ok, slow and ugly, but anyway ;-) ). Thanks to Lillian and Anthony for making this possible with their work on DefaultStyledDocument. 2006-02-06 Roman Kennke [EMAIL PROTECTED] * javax/swing/text/GlyphView.java

[cp-patches] FYI: Component fixes

2006-02-07 Thread Roman Kennke
Yesterday I added a couple of JDK1.5 firePropertyChange methods to java.awt.Component. I made them protected (copy+paste) but they should be public according to the specs. Why this is so is beyond me though... fixed by the attached patch. 2006-02-06 Roman Kennke [EMAIL PROTECTED

[cp-patches] FYI: JTextPane fixlet

2006-02-07 Thread Roman Kennke
This fixes a small issue in JTextPane which makes the BeanShell JConsole look a little nicer. 2006-02-07 Roman Kennke [EMAIL PROTECTED] * javax/swing/JTextPane.java (setCharacterAttributes): Replace input attributes when replace==true. /Roman Index: javax/swing

[cp-patches] FYI: BasicTextUI cleanup

2006-02-07 Thread Roman Kennke
This cleans up the BasicTextUI a little (remove ECJ warnings, etc). 2006-02-07 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTextUI.java (RootView.preferenceChange): Changed view parameter to view so that it doesn't hide a field of that class

[cp-patches] FYI: DefaultStyledDocument.ElementBuffer fixlet

2006-02-07 Thread Roman Kennke
I adjusted the ElementBuffer.insert method so that it only registers an element change if that element has actually changed. It is required that DocumentEvent.getChange(Element) returns null for a not-changed element instead of an empty ElementChange. 2006-02-07 Roman Kennke [EMAIL PROTECTED

<    3   4   5   6   7   8   9   10   11   12   >