Re: [cp-patches] Patch: view in JScrollPane

2005-06-20 Thread Lillian Angel
Can I get approval to commit this patch? Thank you! On Fri, 2005-06-17 at 11:17 -0400, Lillian Angel wrote: I fixed the Patch in this attachment to not include the ChangeLog. Sorry about that. 2005-06-17 Lillian Angel [EMAIL PROTECTED] * javax/swing/JScrollPane.java

Re: [cp-patches] Patch: view in JScrollPane

2005-06-20 Thread Roman Kennke
Lillian Angel wrote: Can I get approval to commit this patch? Please do. Sorry, I forgot this. /Roman ___ Classpath-patches mailing list Classpath-patches@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-patches

[cp-patches] FYI: Reformatted Swing classes

2005-06-20 Thread Roman Kennke
I reformatted a bunch of classes in javax.swing. 2005-06-20 Roman Kennke [EMAIL PROTECTED] * javax/swing/AbstractButton.java: * javax/swing/AbstractCellEditor.java: * javax/swing/Action.java: * javax/swing/BorderFactory.java: * javax/swing/ButtonGroup.java: *

[cp-patches] FYI: preferredSize in JComponent

2005-06-20 Thread Roman Kennke
We already had two fixes in the last weeks about this issue. The problem was that preferredSize must not be less than minimumSize. The solution so far has been to adjust preferredSize when minimumSize is set. This has the sideeffect that getPreferredSize() is called too early or (after Marks

[cp-patches] Patch: Bug #13420 JInternalFrame default close operation

2005-06-20 Thread Anthony Balkissoon
Permission to commit the following patch? Or will a maintainer please commit? This patches fixes bug #13420, allows invalid close operations to be specified for JInternalFrame and JFrame without throwing an Error. If the specified close operation is invalid, the components default close

[cp-patches] FYI: removing 'a.diff'

2005-06-20 Thread Tom Tromey
I'm deleting the mistakenly added 'a.diff'. I'm not writing a ChangeLog entry for this since it is just a mistake and has no bearing on the real history of the sources. But, I thought I'd send email here in case somebody sees the commit and is curious. Tom

Re: [cp-patches] [RFA/JDWP] IdManager

2005-06-20 Thread Keith Seitz
On Mon, 2005-06-20 at 10:22 -0500, Archie Cobbs wrote: Keith Seitz wrote: + /* Mapping of class (Class) to IDs (ReferenceTypeId) for reference + types. Unlike other types, reference id types are NEVER released. */ + private Hashtable _classTable; Another question born from my own

Re: [cp-patches] Patch: #13419 JOptionPane.showInputDialog multi-line

2005-06-20 Thread Tom Tromey
Tony == Anthony Balkissoon [EMAIL PROTECTED] writes: Tony 2005-06-17 Anthony Balkissoon [EMAIL PROTECTED] Tony * javax/swing/SwingUtilities.java: Tony (layoutCompoundLabel): Added check for multi-line text. Just a minor nit... Tony +fromIndex=text.indexOf('\n', fromIndex)+1;

Re: [cp-patches] [RFA/JDWP] IdManager

2005-06-20 Thread Archie Cobbs
Keith Seitz wrote: + /* Mapping of class (Class) to IDs (ReferenceTypeId) for reference + types. Unlike other types, reference id types are NEVER released. */ + private Hashtable _classTable; What if a class(loader)s are garbage collected? Would this hash table then become a memory

Re: [cp-patches] Patch: Bug #13420 JInternalFrame default close operation

2005-06-20 Thread Roman Kennke
Am Montag, den 20.06.2005, 11:35 -0400 schrieb Anthony Balkissoon: Permission to commit the following patch? Or will a maintainer please commit? This patches fixes bug #13420, allows invalid close operations to be specified for JInternalFrame and JFrame without throwing an Error. If the

Re: [cp-patches] Patch: adding to top-level containers

2005-06-20 Thread Roman Kennke
Am Montag, den 20.06.2005, 12:06 -0600 schrieb Tom Tromey: Roman == Roman Kennke [EMAIL PROTECTED] writes: Roman this is cool, thank you. Generally I would prefer to go for 1.4 Roman compatibility and completeness first, and add 1.5 stuff later Any particular reason? I think it makes

Re: [cp-patches] Patch: Null check after dereference ingnu.xml.aelfred2.XmlParser

2005-06-20 Thread Meskauskas Audrius
Impressive! - Original Message - From: Lillian Angel [EMAIL PROTECTED] To: classpath-patches@gnu.org Sent: Monday, June 20, 2005 10:24 PM Subject: [cp-patches] Patch: Null check after dereference ingnu.xml.aelfred2.XmlParser fixes bug #13458 2005-06-20 Lillian Angel [EMAIL

[cp-patches] FYI: Null check after dereference in javax.swing.DefaultDesktopManager

2005-06-20 Thread Lillian Angel
ChangeLog explains it all. Avoids NullPointerException 2005-06-20 Lillian Angel [EMAIL PROTECTED] * javax/swing/DefaultDesktopManager (getBoundsForIconOf): No reason to check if desktopPane is null after dereferencing desktopPane in code. Fixes bug #13461. Committed!

Re: [cp-patches] Patch: Null check after dereference ingnu.xml.aelfred2.XmlParser

2005-06-20 Thread Lillian Angel
took me all day ;) just kidding! On Mon, 2005-06-20 at 22:56 +0200, Meskauskas Audrius wrote: Impressive! - Original Message - From: Lillian Angel [EMAIL PROTECTED] To: classpath-patches@gnu.org Sent: Monday, June 20, 2005 10:24 PM Subject: [cp-patches] Patch: Null check after

[cp-patches] FYI: Adding public parameterless constructor form HTML.Tag.

2005-06-20 Thread Meskauskas Audrius
Adding public parameterless constructor form HTML.Tag. This constructor appeared since 1.3. It may be very strange to see toString() method returning null, but the Suns implementation does exactly the same. 2005-06-07 Audrius Meskauskas [EMAIL PROTECTED] * javax/swing/text/html/HTML.java

Re: [cp-patches] Patch for logging

2005-06-20 Thread Mark Wielaard
Hi Chris, On Sat, 2005-06-18 at 13:31 +0100, Chris Burdess wrote: This patch sets the root logger's level to INFO. The root logger's behaviour is inherited by all loggers by default, so this specifies the default level. This means that by default, loggers will actually log something.