Re: [cp-patches] FYI: ParserDelegator compatibility fix.

2005-07-12 Thread Meskauskas Audrius
Maybe. 2005-07-12 Audrius Meskauskas [EMAIL PROTECTED] * javax/swing/text/html/parser/ParserDelegator.java (gnuParser.getDTD): Added comment about 'super'. Robert Schuster wrote: could you please add a small comment that this is a workaround for 1.3's javac to make sure no one removes

[cp-patches] FYI: JTextComponent.CaretBlinkTimer fixlet

2005-07-12 Thread Mark Wielaard
Hi, From time to time the JTextComponent.CaretBlinkTimer would fire while the caret was null. Resulting in nasty exceptions. This patch guards all uses of caret in the Timer with a check to make sure the caret actually exists. 2005-07-12 Mark Wielaard [EMAIL PROTECTED] *

[cp-patches] FYI: Make MediaTRacker handle Images that didn't properly load

2005-07-12 Thread Mark Wielaard
Hi, In MediaTracker we didn't correctly handle Images that were already loaded, but that actually failed to load correctly. In such a case prepareImage() will return false immediately, but the ImageObserver will never be called. So we need an extra call to checkImage() to explicitly grab the

[cp-patches] Re: String class: hack for ORP 1.0.9

2005-07-12 Thread David P Grove
So, I'm having a hard time seeing how this optimization actually makes the code faster under any reasonable assumptions of what an optimizing JIT is going to do. It seems mostly harmless to have it (although it makes the method larger, and thus a slightly less attractive candidate for

[cp-patches] FYI: fixlet for JApplet, JDialog, JFrame, JWindow

2005-07-12 Thread Anthony Balkissoon
This is the same as Roman's JInternalFrame addImpl fixlet from yesterday. Add to the top level container itself if we're in the initialization stage, otherwise add to its content pane. Patch attached. 2005-07-12 Anthony Balkissoon [EMAIL PROTECTED] * javax/swing/JApplet.java,

[cp-patches] Patch: JTree demo

2005-07-12 Thread Lillian Angel
2005-07-11 Lillian Angel [EMAIL PROTECTED] * examples/gnu/classpath/examples/swing/Demo.java (mkTreeWorld): Implemented (mkTabbedPane): added in tab for TreeWorld * javax/swing/plaf/basic/BasicLookAndFeel.java Changed default color of text non selection

[cp-patches] FYI: fixlet for BasicLookAndFeel

2005-07-12 Thread Roman Kennke
This corrects the color values for Basic buttons. 2005-07-12 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicLookAndFeel.java (initComponentDefaults): Corrected color values for BasicLF buttons. /Roman Index: javax/swing/plaf/basic/BasicLookAndFeel.java

[cp-patches] FYI: Fixed JInternalFrame's title bar

2005-07-12 Thread Roman Kennke
Hi, I have hacked JInternalFrame's title bar in the Basic LF, so that it matches the Basic LF of the JDK more, and also fixed some behavioural aspects. For example, we had some candidates for paint/layout loops in the title bar's LayoutManager that I removed. 2005-07-12 Roman Kennke

[cp-patches] FYI: JMenu fix closes bug 13683

2005-07-12 Thread Anthony Balkissoon
Committed this patch that paints the background of a disabled JMenu properly when it is selected. This, in addition to the JMenu patches I committed yesterday, should close bug 13683. Patch is attached. 2005-07-12 Anthony Balkissoon [EMAIL PROTECTED] * javax/swing/JMenu.java: (isSelected):

[cp-patches] FYI: Cleaned up BasicInternalFrameTitlePane

2005-07-12 Thread Roman Kennke
Hi, I removed some cruft from BasicInternalFrame and fixed handling of property changes from the enclosing JInternalFrame. 2005-07-12 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicInternalFrameTitlePane.java Removed ad-hoc icons. Replaced them by

[cp-patches] [RFA/JDWP] VirtualMachineCommandSet.java

2005-07-12 Thread Aaron Luchko
Ok this is a touch more complicated but not too bad, there's also a couple possibly minor issues. This implements the VirtualMachine CommandSet http://java.sun.com/j2se/1.5.0/docs/guide/jpda/jdwp/jdwp-protocol.html#JDWP_VirtualMachine The VERSION command is the first one that is a bit of an

[cp-patches] Re: [RFA/JDWP} ObjectReferenceCommandSet.java

2005-07-12 Thread Aaron Luchko
On Tue, 2005-07-12 at 14:15 -0400, Bryce McKinlay wrote: Aaron Luchko wrote: Here's the implementation for the ObjectReference CommandSet http://java.sun.com/j2se/1.5.0/docs/guide/jpda/jdwp/jdwp-protocol.html#JDWP_ObjectReference ChangeLog 2005-07-08 Aaron Luchko [EMAIL PROTECTED]

[cp-patches] FYI: some more cleanup in JInternalFrame stuff

2005-07-12 Thread Roman Kennke
I did some more cleanup in JInternalFrame. 2005-07-12 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicInternalFrameUI.java (installDefaults): Create border based on defaults in current LookAndFeel. * javax/swing/plaf/basic/BasicLookAndFeel.java

[cp-patches] FYI: Fixed formatting of BasicTreeUI

2005-07-12 Thread Roman Kennke
This little fix spans to commits. Sorry for that. 2005-07-12 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java I accidentally introduced revalidate calls for repaint calls. Reverted. 2005-07-12 Roman Kennke [EMAIL PROTECTED] *

[cp-patches] Re: [RFA/JDWP] VirtualMachineCommandSet.java

2005-07-12 Thread Bryce McKinlay
Aaron Luchko wrote: Ok this is a touch more complicated but not too bad, there's also a couple possibly minor issues. This implements the VirtualMachine CommandSet http://java.sun.com/j2se/1.5.0/docs/guide/jpda/jdwp/jdwp-protocol.html#JDWP_VirtualMachine The VERSION command is the first one

[cp-patches] [FYI/JDWP] shutting down in PacketProcessor

2005-07-12 Thread Aaron Luchko
I've committed this patch to the trunk. This makes a minor improvement in the shutdown sequence for jdwp by having the Jdwp object itself handle the shutdown from the top level instead of PacketProcessor telling the collection (and possibly the whole VM) to exit itself. Aaron ChangeLog

[cp-patches] Patch: formatting of copyrights

2005-07-12 Thread Lillian Angel
2005-07-12 Lillian Angel [EMAIL PROTECTED] * javax/swing/JTree.java: Formatting copyright * javax/swing/tree/DefaultTreeCellRenderer.java: Formatting copyright * javax/swing/tree/DefaultTreeSelectionModel.java: Formatting copyright

[cp-patches] Patch: selection for JTree with icon

2005-07-12 Thread Lillian Angel
2005-07-12 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java (paintLeaf): fixed size of selection background to depend on if icon exists (paintNonLeaf): fixed size of selection background to depend on if icon exists Index:

[cp-patches] FYI: Patch for DefaultButtonModel relating to JToggleButtons

2005-07-12 Thread Anthony Balkissoon
This patch fixes the problem discussed in the additional comments to bug 13683: ==additional comment #1== I have discovered another bug in this testcase. If you open a menu, you can see in the taskbar that a new window with the name . has been opened. And also, on the sun vm if you

[cp-patches] Patch: Demo fix

2005-07-12 Thread Lillian Angel
2005-07-12 Lillian Angel [EMAIL PROTECTED] * examples/gnu/classpath/examples/swing/Demo.java (mkTree): no need to make root visible, it is by default (mkTreeWorld): no need to make root visible, it is by default ___

[cp-patches] FYI: buttons paramString fixes

2005-07-12 Thread Robert Schuster
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, this fixes the part of Bug #13695 (https://savannah.gnu.org/bugs/?func=detailitemitem_id=13695) which complains about the paramString() method. 2005-07-13 Robert Schuster [EMAIL PROTECTED] * javax/swing/JToggleButton.java:

[cp-patches] buttons paramString fixes #2

2005-07-12 Thread Robert Schuster
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, please forget about the first patch. This one is the same but fixes JRadioButton, too. 2005-07-13 Robert Schuster [EMAIL PROTECTED] * javax/swing/JToggleButton.java: (paramString): Returns value of same method in superclass now. *