Re: [cp-patches] Fwd: Patch for parse() of DecimalFormat and SimpleDateFormat

2010-12-06 Thread Pekka Enberg
[ Sorry for the delay. ] On Sat, 27 Nov 2010, Ivan Maidanski wrote: Sorry for the provided test below - it doesn't test the things that are fixed by the attached patch. In fact, the test is for a bug that has been already fixed since Classpath v0.93 (by not relying on setMaximumIntegerDigits

Re: [cp-patches] Minor refactoring of PrintStream

2010-12-06 Thread Pekka Enberg
Hi all, I added the following PrintStream constructor API tests to Malva: https://github.com/penberg/malva/commit/b5020c862656c491fc81b2f4f3cee39a6444709a Some of the tests fail with GNU Classpath but Ivan's patch from June cures most of the issues:

Re: [cp-patches] Fwd: Patch for parse() of Deci malFormat and SimpleDateFormat

2010-12-06 Thread Ivan Maidanski
Hi Pekka, Mon, 6 Dec 2010 10:54:09 +0200 (EET) Pekka Enberg penb...@kernel.org: [ Sorry for the delay. ] On Sat, 27 Nov 2010, Ivan Maidanski wrote: Sorry for the provided test below - it doesn't test the things that are fixed by the attached patch. In fact, the test is for a bug that has

Re: [cp-patches] Minor refactoring of PrintStre am

2010-12-06 Thread Ivan Maidanski
Hello Pekka, Mon, 6 Dec 2010 11:36:06 +0200 Pekka Enberg penb...@kernel.org: Hi all, I added the following PrintStream constructor API tests to Malva: https://github.com/penberg/malva/commit/b5020c862656c491fc81b2f4f3cee39a6444709a Some of the tests fail with GNU Classpath but Ivan's

Re: [cp-patches] Merged some of your patches to my GNU Classpath git tree

2010-12-06 Thread Ivan Maidanski
Hi, Mon, 6 Dec 2010 11:40:24 +0200 (EET) Pekka Enberg penb...@kernel.org: Hi Ivan, On Wed, 24 Nov 2010, Ivan Maidanski wrote: Thank you merging these patches. I've attached the rest of my pending patches (33) - I posted them this Summer to classpath-bugs mailing list. (Of course, I don't

Re: [cp-patches] Fwd: Patch for parse() of DecimalFormat and SimpleDateFormat

2010-12-06 Thread Pekka Enberg
Hi Ivan, 2010/12/6 Ivan Maidanski iv...@mail.ru: Sorry for the provided test below - it doesn't test the things that are fixed by the attached patch. In fact, the test is for a bug that has been already fixed since Classpath v0.93 (by not relying on setMaximumIntegerDigits implementation).

Re: [cp-patches] Fwd: Patch for parse() of Deci malFormat and SimpleDateFormat

2010-12-06 Thread Ivan Maidanski
Hello Pekka, Mon, 6 Dec 2010 22:36:18 +0200 Pekka Enberg penb...@kernel.org: Hi Ivan, 2010/12/6 Ivan Maidanski iv...@mail.ru: Sorry for the provided test below - it doesn't test the things that are fixed by the attached patch. In fact, the test is for a bug that has been already

Re: [cp-patches] Fwd: Patch for parse() of DecimalFormat and SimpleDateFormat

2010-12-06 Thread Pekka Enberg
2010/12/6 Ivan Maidanski iv...@mail.ru: I'm bit surprised, though, that we'd want behavior that doesn't match Sun JRE. To me, any API behavior (even if it's a bug) that has lived long enough in Sun JRE is what Classpath ought to aim at. Compatibility is not just following the specification

Re: [cp-patches] Fwd: Patch for parse() of Deci malFormat and SimpleDateFormat

2010-12-06 Thread Ivan Maidanski
Hi, Mon, 6 Dec 2010 23:19:56 +0200 Pekka Enberg penb...@kernel.org: 2010/12/6 Ivan Maidanski iv...@mail.ru: I'm bit surprised, though, that we'd want behavior that doesn't match Sun JRE. To me, any API behavior (even if it's a bug) that has lived long enough in Sun JRE is what

Re: [cp-patches] Fwd: Patch for parse() of DecimalFormat and SimpleDateFormat

2010-12-06 Thread Pekka Enberg
2010/12/6 Ivan Maidanski iv...@mail.ru: Googling around doesn't seem to bring anything on the topic which makes me think this is an old bug that nobody really cares about but there can be applications out there that rely on the current behavior that would be broken under GNU Classpath. Not