Re: [cp-patches] [PATCH] Fix PrintStream constructor API differences for null

2011-01-23 Thread Pekka Enberg
On Sun, 2011-01-23 at 00:36 +, Dr Andrew John Hughes wrote: public PrintStream (OutputStream out, boolean auto_flush, String encoding) throws UnsupportedEncodingException { super (out); +if (out == null || encoding == null) + throw new NullPointerException();

Re: [cp-patches] [PATCH] Fix PrintStream constructor API differences for null

2011-01-23 Thread Pekka Enberg
On Sun, 2011-01-23 at 00:36 +, Dr Andrew John Hughes wrote: What is the current behaviour? Does it eventually throw an NPE but just performs a lot of additional computation first? Or does it throw some other error? Or return a bad value? The NPEs should have some message as to what

Re: [cp-patches] [PATCH] Fix PrintStream constructor API differences for null

2011-01-23 Thread Dr Andrew John Hughes
On 23 January 2011 12:41, Pekka Enberg penb...@kernel.org wrote: On Sun, 2011-01-23 at 00:36 +, Dr Andrew John Hughes wrote: What is the current behaviour?  Does it eventually throw an NPE but just performs a lot of additional computation first?  Or does it throw some other error?  Or