Re: [cp-patches] [PATCH] Implement Pattern.quote() API method

2011-01-27 Thread Ivan Maidanski
Hi Pekka, Thanks. 1. private TestHarness harness; is not needed. 2. I hope (when you were composing this test case) that you produced the result value for abc\\E123\E manually by reading the spec, not by executing quote() and copy-pasting its result to this test case code ;) Regards. Wed,

Re: [cp-patches] [PATCH] Implement Pattern.quote() API method

2011-01-27 Thread Ivan Maidanski
Hi, Ok, since even if OpenJDK quote() is buggy, nonetheless we should reproduce its behavior in the Classpath. ;) Regards. Thu, 27 Jan 2011 23:58:18 +0200 Pekka Enberg penb...@cs.helsinki.fi: On Thu, 2011-01-27 at 23:28 +0300, Ivan Maidanski wrote: 2. I hope (when you were composing this

Re: [cp-patches] [PATCH] Implement Pattern.quote() API method

2011-01-27 Thread Dr Andrew John Hughes
On 01:13 Fri 28 Jan , Ivan Maidanski wrote: Hi, Ok, since even if OpenJDK quote() is buggy, nonetheless we should reproduce its behavior in the Classpath. ;) Sadly, this is usually true, though obviously the specification should also be checked for agreement. Regards. Thu, 27

Re: [cp-patches] [PATCH] Implement Pattern.quote() API method

2011-01-27 Thread Pekka Enberg
On Fri, 2011-01-28 at 00:31 +, Dr Andrew John Hughes wrote: On 01:13 Fri 28 Jan , Ivan Maidanski wrote: Hi, Ok, since even if OpenJDK quote() is buggy, nonetheless we should reproduce its behavior in the Classpath. ;) Sadly, this is usually true, though obviously the