[cp-patches] don't include gtk peer and xmlj classes in glibj.zip if disabled

2005-05-12 Thread Christian Thalinger
As discussed with tromey on #classpath today, here is a patch which excludes the classes. lib/standard.omit should be removed from cvs. Index: configure.ac === RCS file: /cvsroot/classpath/classpath/configure.ac,v retrieving

[cp-patches] native/jni/java-nio/gnu_java_nio_VMSelector.c strerror ifdef's

2005-05-13 Thread Christian Thalinger
Check which strerror we have or even if we have any. Index: native/jni/java-nio/gnu_java_nio_VMSelector.c === RCS file: /ahome/cacao/cacaocvs/cacao/src/classpath/native/jni/java-nio/gnu_java_nio_VMSelector.c,v retrieving revision

[cp-patches] unified pointer size checks in jni (java-nio, xmlj)

2005-05-13 Thread Christian Thalinger
2005-05-13 Christian Thalinger [EMAIL PROTECTED] * native/jni/java-nio/gnu_java_nio_charset_iconv_IconvDecoder.c (createRawData): Use SIZEOF_VOID_P instead of POINTERS_ARE_64BIT. * native/jni/java-nio/gnu_java_nio_charset_iconv_IconvEncoder.c

[cp-patches] native/fdlibm/mprec.c: -Wall warning fixes

2005-05-20 Thread Christian Thalinger
Hi! We compile CACAO and thus classpath with -Wall to get rid of all warnings. mprec.c had some problems here. TWISTI 2005-05-20 Christian Thalinger [EMAIL PROTECTED] * native/fdlibm/mprec.c: Fixes to compile with -Wall without warnings (mostly parentheses in arithmetic

[cp-patches] finite() for fdlibm

2005-06-29 Thread Christian Thalinger
Hi! Since there are some finite() calls in classpath's native code, we should also provide a implementation. This one is taken and adapted from the current file available from http://www.netlib.org/fdlibm/. TWISTI 2005-07-29 Christian Thalinger [EMAIL PROTECTED] * native/fdlibm

Re: [cp-patches] javanet.c compile fix for IRIX

2005-07-26 Thread Christian Thalinger
On Tue, 2005-07-26 at 11:12 +0200, Mark Wielaard wrote: Hi, On Tue, 2005-07-26 at 10:20 +0200, Christian Thalinger wrote: There is an include missing (for timeval struct). #ifndef TARGET_NATIVE_NETWORK_SOCKET_SET_OPTION_SO_TIMEOUT + #include sys/time.h #include sys/types.h

[cp-patches] jcl.c 64-bit fix

2005-09-14 Thread Christian Thalinger
Hi! Yesterday, after a long debugging session with fitzsim, i've found this bug. TWISTI 2005-09-14 Christian Thalinger [EMAIL PROTECTED] * native/jni/classpath/jcl.c: Replaced undefined POINTERS_ARE_64BIT with SIZEOF_VOID_P == 8. Index: native/jni/classpath/jcl.c

[cp-patches] __attribute__ patch (Was: Re: RFC: __attribute__ handling)

2005-10-04 Thread Christian Thalinger
On Tue, 2005-10-04 at 10:01 -0600, Tom Tromey wrote: Twisti == Christian Thalinger [EMAIL PROTECTED] writes: Why only if !__cplusplus? Twisti Hmm, that seems to be a copy-paste bug. AFAIK a C++ compiler Twisti always has the `inline' keyword. It should be removed and Twisti simply

Re: [cp-patches] __attribute__ patch (Was: Re: RFC: __attribute__ handling)

2005-10-06 Thread Christian Thalinger
On Wed, 2005-10-05 at 13:12 -0600, Tom Tromey wrote: Twisti == Christian Thalinger [EMAIL PROTECTED] writes: Twisti Here is the actual patch. Tested on IRIX with MIPSPro compiler. I'm checking this in. FWIW a patch like this is easier to apply if you use 'cvs diff -N' to get the new

[cp-patches] Re: build failure - problems detecting freetype2 headers

2005-10-19 Thread Christian Thalinger
On Tue, Oct 18, 2005 at 10:41:11AM -0600, Tom Tromey wrote: The updated patch looks good to me. Write a ChangeLog entry and email it and the patch to me, I'll check it in. 2005-10-19 Christian Thalinger [EMAIL PROTECTED] * configure.ac: Also check for pangoft2 without cairo

Re: [cp-patches] Re: build failure - problems detecting freetype2 headers

2005-10-21 Thread Christian Thalinger
On Wed, 2005-10-19 at 14:57 +0200, Christian Thalinger wrote: On Tue, Oct 18, 2005 at 10:41:11AM -0600, Tom Tromey wrote: The updated patch looks good to me. Write a ChangeLog entry and email it and the patch to me, I'll check it in. While preparing the patch on my local system to commit, i

[cp-patches] RFC: VMThread.sleep mauve fix

2005-10-24 Thread Christian Thalinger
Hi! Just noticed that the default implementation in GNU classpath has problems with gnu.testlet.java.lang.Thread.sleep. This patch should fix the issue, without breaking anything. TWISTI 2005-10-25 Christian Thalinger [EMAIL PROTECTED] * vm/reference/java/lang/VMThread.java (sleep

Re: [cp-patches] RFC: VMThread.sleep mauve fix

2005-11-01 Thread Christian Thalinger
On Tue, 2005-11-01 at 18:31 +0100, Mark Wielaard wrote: The round up probably comes from join() which uses a similar way to wait. And according to the bug pointed to in the comment apparently some VMs mishandle a zero ms argument (we also had that bug in the past). It seems that sun also does

Re: [cp-patches] Patch: use StringBuilder for reading/writing property files

2005-11-01 Thread Christian Thalinger
On Tue, 2005-11-01 at 21:00 +0100, Christian Thalinger wrote: On Sun, 2005-10-30 at 12:28 +0100, Mark Wielaard wrote: position. Opinions? Volunteers? Anyone want to test against other runtimes? Or another test set? Hmm, just tested the patch with cacao. It finished in 1.48user

[cp-patches] RFC: StringIndexOutOfBoundsException fixes in String contructors

2005-11-01 Thread Christian Thalinger
is talking about better exception message, adds the index to the message. Ok? TWISTI 2005-11-01 Christian Thalinger [EMAIL PROTECTED] * java/lang/String.java (String): Added StringIndexOutOfBoundsException check and a message to the exception. Index: java/lang

Re: [cp-patches] RFC: StringIndexOutOfBoundsException fixes in String contructors

2005-11-02 Thread Christian Thalinger
: + offset + count); Ok? Yes thanks. Ok, here is the patch i'll commit. Fixes also some additional comments. TWISTI 2005-11-02 Christian Thalinger [EMAIL PROTECTED] * java/lang/String.java (String): Added StringIndexOutOfBoundsException check

Re: [cp-patches] RFC: StringIndexOutOfBoundsException fixes inString contructors

2005-11-02 Thread Christian Thalinger
On Wed, Nov 02, 2005 at 10:33:30AM -0500, Anthony Balkissoon wrote: Uhm, I think that offset and count probably wouldn't have been checked to be non-negative, otherwise why would they check that offset + count 0 ? That check is for overflow. But i'll make a patch for jeroen's suggestion.

Re: [cp-patches] FYI: NEWS, AUTHORS

2005-11-02 Thread Christian Thalinger
On Wed, 2005-11-02 at 17:04 +0100, Mark Wielaard wrote: have kept it up to date when I added new developers (bad mjw!). But it probably is a good idea to have new developers add themselves as their first commit action. Ok. TWISTI 2005-11-02 Christian Thalinger [EMAIL PROTECTED

[cp-patches] FYI: Was: gnu_java_awt_peer_gtk_GdkFontPeer.c (initStaticState): missing NewGlobalRef?

2005-11-09 Thread Christian Thalinger
Hi! As discussed on classpath, this one is commited. Maybe more to come... TWISTI 2005-11-09 Christian Thalinger [EMAIL PROTECTED] * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkFontPeer.c (initStaticState): Register global variable glyphVector_class as global

[cp-patches] FYI: Was: Re: gnu_java_awt_peer_gtk_GdkFontPeer.c (initStaticState): missing NewGlobalRef?

2005-11-15 Thread Christian Thalinger
Ooops! Almost forgot to commit this. TWISTI 2005-11-15 Christian Thalinger [EMAIL PROTECTED] * native/jni/java-lang/java_lang_VMDouble.c (initIDs): Register clsDouble as global ref. * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkToolkit.c (gtkInit

Re: [cp-patches] FYI: gnu_java_awt_peer_gtk_GtkClipboard.c 64-bit fix

2005-11-15 Thread Christian Thalinger
On Mon, 2005-11-07 at 21:36 +0100, Christian Thalinger wrote: On Mon, 2005-11-07 at 14:15 -0700, Tom Tromey wrote: Twisti == Christian Thalinger [EMAIL PROTECTED] writes: Twisti +#if SIZEOF_VOID_P == 8 Twisti +static long current_selection = 0; Twisti +#else Twisti static int

[cp-patches] RFC: some missing DeleteLocalRef patches

2005-11-21 Thread Christian Thalinger
Hi! These are some patches for missing DeleteLocalRef calls i've found with CACAO. Are they ok? It seems so to me. Should i search for more stuff like that? TWISTI Index: native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphicsEnvironment.c

Re: [cp-patches] RFC: some missing DeleteLocalRef patches

2005-11-22 Thread Christian Thalinger
This one i found with jaha (http://www.cs.helsinki.fi/u/abrax/HACK/JAVA/JAHA.html). TWISTI Index: native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c === RCS file:

Re: [cp-patches] RFC: some missing DeleteLocalRef patches

2005-11-22 Thread Christian Thalinger
Ok, next time i'll send immediately a changelog. These are commited. TWISTI 2005-11-22 Christian Thalinger [EMAIL PROTECTED] * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphicsEnvironment.c (nativeGetFontFamilies): Added missing DeleteLocalRef calls. * native/jni

Re: [cp-patches] RFC: some missing DeleteLocalRef patches

2005-11-24 Thread Christian Thalinger
Hi! Found this one with statcvs, ok? TWISTI 2005-11-24 Christian Thalinger [EMAIL PROTECTED] * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c (save_to_stream): Added missing DeleteLocalRef call. Index: native/jni/gtk-peer

Re: [cp-patches] FYI: GdkGraphics fix

2005-11-25 Thread Christian Thalinger
On Tue, 2005-11-22 at 14:07 -0500, Lillian Angel wrote: I added the code to filter out non-printing characters in native, like Mark suggested. It is a lot more efficient. I'm compiling my local classpath (on x86_64) with --enable-Werror and this patch broke it. This patched fix it. Is const

Re: [cp-patches] RFC: some missing DeleteLocalRef patches

2005-11-25 Thread Christian Thalinger
On Thu, 2005-11-24 at 17:31 +0100, Mark Wielaard wrote: Yes, please. Commited. TWISTI ___ Classpath-patches mailing list Classpath-patches@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-patches

[cp-patches] Re: FYI: GtkSelection.c LocalRef cleanup

2005-11-26 Thread Christian Thalinger
On Fri, 2005-11-25 at 21:17 +0100, Mark Wielaard wrote: Christian, together with the patch that I committed today for this file this should now compile warning free and actually work, even on 64bit machines. Could you check? Yes, builds. TWISTI

[cp-patches] Re: FYI: GtkSelection.c LocalRef cleanup

2005-11-26 Thread Christian Thalinger
=Variable clipboard is not available. ) at gnu_java_awt_peer_gtk_GtkSelection.c:106 But i don't know where it actually leaks the refs. Maybe someone else? TWISTI 2005-11-26 Christian Thalinger [EMAIL PROTECTED] * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkClipboard.c

[cp-patches] RFC: XMLFormatter duplicate getMillis() call

2005-11-27 Thread Christian Thalinger
Hi! While hunting a CACAO bug, i stumbled over this duplicate getMillis() call. Should not really give a big speedup, but... :-) TWISTI 2005-11-27 Christian Thalinger [EMAIL PROTECTED] * java/util/logging/XMLFormatter.java (format): Don't call getMillis() twice. Index

Re: [cp-patches] [generics] RFC : implementation of jjava.lang.instrument package

2005-12-03 Thread Christian Thalinger
On Fri, 2005-12-02 at 12:22 +0100, Nicolas Geoffray wrote: gnu/java/lang/instrument. Would you like InstrumentationImpl to be in vm/reference/java/lang/InsutrumentationImpl? This sounds weird. We could also make the callTransformers method public. I think it's very helpful for vm implementors

Re: [cp-patches] Patch: Opening RandomAccessFiles requires excessive permission

2005-12-06 Thread Christian Thalinger
On Mon, 2005-12-05 at 14:42 +, Gary Benson wrote: public void write (int oneByte) throws IOException { +if (out == null) + throw new IOException(Bad file descriptor); + out.write(oneByte); I don't know if this is performance critical code or is used very often, but

Re: [cp-patches] Patch: Opening RandomAccessFiles requires excessive permission

2005-12-06 Thread Christian Thalinger
On Tue, 2005-12-06 at 10:00 -0600, Archie Cobbs wrote: That's getting into the micro-optimzation realm, which is fraught with danger and mistaken assumptions :-) E.g., on some machines the time overhead of setting up a try/catch in a method that wouldn't otherwise have one is higher than the

RE: [cp-patches] RFC: StringIndexOutOfBoundsException fixes inString contructors

2005-12-06 Thread Christian Thalinger
On Wed, 2005-11-02 at 12:50 +0100, Jeroen Frijters wrote: Christian Thalinger wrote: +if (offset + count 0 || offset + count ascii.length) You can write this more efficiently as: if (ascii.length - offset count) (This assumes that offset and count have previously been

Re: [cp-patches] Patch: Opening RandomAccessFiles requires excessive permission

2005-12-06 Thread Christian Thalinger
On Tue, 2005-12-06 at 13:32 -0600, Archie Cobbs wrote: You say the generated code is smaller but that depends on who generates the code (if you mean the generated Java bytecode, I'd guess you're wrong there too because of the extra exception table required). And that depends on which VM you're

[cp-patches] RFC: java.net.InetAddress.toString() returns wrong address

2005-12-29 Thread Christian Thalinger
. Is this correct? TWISTI 2005-12-29 Christian Thalinger [EMAIL PROTECTED] * java/net/InetAddress.java (toString): Return 0.0.0.0 for null hostname. Index: java/net/InetAddress.java === RCS file: /cvsroot/classpath

[cp-patches] RFC: checking for socklen_t

2006-01-01 Thread Christian Thalinger
it to `int' if not found (Andrew Pinski will surely complain here ;-) TWISTI 2006-01-01 Christian Thalinger [EMAIL PROTECTED] * configure.ac: Added TYPE_SOCKLEN_T call. * m4/type_socklen_t: Added. Index: configure.ac

Re: [cp-patches] RFC: checking for socklen_t

2006-01-01 Thread Christian Thalinger
On Sun, 2006-01-01 at 15:24 -0700, Tom Tromey wrote: Twisti + if test $ac_cv_type_socklen_t != yes; then Twisti +AC_DEFINE(socklen_t, int, [Substitute for socklen_t]) Twisti + fi Kind of a bogus approach (better to use a real typedef), but whatever. That's true, yes. I'll commit it

Re: [cp-patches] FYI: Replaced use of JvAssert by assert and removed java-assert.h

2006-01-09 Thread Christian Thalinger
On Mon, 2006-01-09 at 09:58 -0700, Tom Tromey wrote: The buffer size workaround I applied to mprec isn't completely safe -- it just works in more cases. This is why we need the newer dynamically-allocating mprec. Ok, someone has to take care of that. I'll do it, if you tell me where to get

Re: [cp-patches] RFC: java.net.InetAddress.toString() returns wrong address

2006-01-09 Thread Christian Thalinger
On Mon, 2006-01-09 at 15:30 +0100, Mark Wielaard wrote: So what do you think of the following patch? 2006-01-08 Mark Wielaard [EMAIL PROTECTED] * java/net/InetAddress.java (getInaddrAny): Explicitly set hostName. It fixes the mauve test for me. Ooops, sorry. I nearly forgot this

Re: [cp-patches] installing logging.properties

2006-01-10 Thread Christian Thalinger
On Tue, Jan 10, 2006 at 04:47:41PM +0100, Mark Wielaard wrote: * liIf the system property codejava.util.logging.config.file/code * is not set, however, the contents of the URL * {gnu.classpath.home.url}/logging.properties are passed to * [EMAIL PROTECTED]

Re: [cp-patches] installing logging.properties

2006-01-10 Thread Christian Thalinger
On Tue, 2006-01-10 at 18:28 +0100, Mark Wielaard wrote: libgcj installs it as: propdir = $(libdir) $(INSTALL_DATA) $(srcdir)/java/util/logging/logging.properties $(DESTDIR)$(propdir)/logging.properties That seems a better place. But it looks like we have to update LogManager in that

Re: [cp-patches] FYI: Define isnan explicitly in fdlibm

2006-01-10 Thread Christian Thalinger
On Sat, 2005-12-17 at 21:43 +0100, Guilhem Lavaux wrote: Hi, Here is a patch to define isnan explicitly as a macro if it is not already defined. At the same it removes the symbol renaming in namespace.h. Hi! As i merged the changes into CACAO, i noticed that this patch breaks some stuff on

Re: [cp-patches] FYI: Define isnan explicitly in fdlibm

2006-01-12 Thread Christian Thalinger
On Thu, 2006-01-12 at 21:37 +0100, Guilhem Lavaux wrote: To define isnan in any cases. Looking at IRC logs it looks like that we met some trouble on darwin5. Here is a new patch which should make everyone happy. Tell me if it's ok for you. Yeah, that one makes me happy. Commit! TWISTI

Re: [cp-patches] RFC: installing logging.properties

2006-01-12 Thread Christian Thalinger
) can be something different. Commit? TWISTI 2005-01-12 Christian Thalinger [EMAIL PROTECTED] * resource/Makefile.am: Install logging.properties into $(prefix)/lib. * resource/Makefile.am (securitydir): Changed to $(prefix)/lib/security. Index: resource

Re: [cp-patches] Re: JamVM stopped working today

2006-01-17 Thread Christian Thalinger
On Mon, 2006-01-16 at 20:45 +0100, Mark Wielaard wrote: Seems something is completely broken in the new native layer, I cannot even get it to compile (Roman, did you try the --enable-Werror configure flag?). And since the macros are such a pain to debug I have not been able to really

Re: [cp-patches] Re: JamVM stopped working today

2006-01-17 Thread Christian Thalinger
On Tue, 2006-01-17 at 12:43 +0100, Mark Wielaard wrote: The old target layer didn't define any symbols itself so it didn't need to be linked into any other (jni) libraries. We might want to handle it like we do with jcl (native/jni/classpath) for now. But I haven't yet looked at the new target

Re: [cp-patches] Re: JamVM stopped working today

2006-01-17 Thread Christian Thalinger
, hint...) Yeah, sorry, i was a bit overeager :-) Here the corrected patch _with_ changelog entry. TWISTI 2006-01-17 Christian Thalinger [EMAIL PROTECTED] * configure.ac: Set TARGET. * native/Makefile.am, native/jni/classpath/Makefile.am, native/jni/gtk-peer/Makefile.am

Re: [cp-patches] Re: JamVM stopped working today

2006-01-17 Thread Christian Thalinger
On Tue, 2006-01-17 at 12:39 -0700, Tom Tromey wrote: Twisti --- native/jni/classpath/Makefile.am 24 Oct 2005 22:16:10 - 1.6 [...] Twisti AM_LDFLAGS = @CLASSPATH_MODULE@ This setting causes libclasspath to be built as a loadable module. I don't think that is what we want. I

Re: [cp-patches] FYI: javanet.c fixes and improvements

2006-01-19 Thread Christian Thalinger
Hi! Not sure if it's related to this commit, but mips-irix does not work anymore: cc-1020 cc: ERROR File = javanet.c, Line = 1062 The identifier MSG_NOSIGNAL is undefined. TARGET_NATIVE_NETWORK_SOCKET_SEND (fd, p + offset, len, bytes_sent); ^ cc-1020 cc: ERROR File =

Re: [cp-patches] RFC: arm doubleToLongBits fix

2006-01-26 Thread Christian Thalinger
On Thu, Jan 26, 2006 at 08:17:53AM -0600, Archie Cobbs wrote: Could instead you just have a configure test for byte order? Not sure if __IEEE_BYTES_LITTLE_ENDIAN is going to cover all possible cases. Of course, since you've got a patch and I don't feel free to ignore me :-) Originally the

Re: [cp-patches] FYI: Remove freetype2 configure checks

2006-02-13 Thread Christian Thalinger
On Mon, 2005-11-07 at 14:31 +0100, Mark Wielaard wrote: Hi, As discussed on the main list the checks for freetype2 are not necessary and might break on (really) old gtk+ installations. This patch removes them. 2005-11-07 Mark Wielaard [EMAIL PROTECTED] * configure.ac: Don't

Re: [cp-patches] FYI: Remove freetype2 configure checks

2006-02-13 Thread Christian Thalinger
On Mon, 2006-02-13 at 21:40 +0100, Christian Thalinger wrote: Haven't recompiled the classpath for a long time on darwin, but this check is really necessary for darwin. What was the exact reason to remove this? As Mark suggested on irc, here is the linking error message: ld: .libs

Re: [cp-patches] FYI: Remove freetype2 configure checks

2006-02-17 Thread Christian Thalinger
On Fri, 2006-02-17 at 11:30 +0100, Mark Wielaard wrote: It was removed by this patch: http://lists.gnu.org/archive/html/classpath/2005-11/msg00065.html For which you said it worked for you: http://lists.gnu.org/archive/html/classpath/2005-11/msg00066.html That was my fault, as i only tested

[cp-patches] Re: FYI: HTTPConnection.Pool fixlet

2006-03-06 Thread Christian Thalinger
On Sat, 2006-03-04 at 21:53 +0100, Mark Wielaard wrote: This should solve the issue Christian was seeing. Yes, looks good. Thanks! TWISTI

Re: [cp-patches] FYI: Remove freetype2 configure checks

2006-03-06 Thread Christian Thalinger
also be applied to the release branch (if not too late). Commited. TWISTI 2006-03-06 Christian Thalinger [EMAIL PROTECTED] * configure.ac: Check for FREETYPE2. This is a reverted patch and is required on Darwin. * native/jni/gtk-peer/Makefile.am (AM_LDFLAGS): Added

Re: [cp-patches] FYI: Swing Demo - show VM infos

2006-03-07 Thread Christian Thalinger
On Mon, 2006-03-06 at 16:44 +0100, Robert Schuster wrote: Hi, I wanted to be able to know the VM I am running the Swing Demo on. Here is a small patch that makes that possible. Wanted to try that coool feature :-), but unfortunately: java.lang.IllegalArgumentException: position: 2,

Re: [cp-patches] RFC: defaultLocale changes

2006-03-14 Thread Christian Thalinger
On Fri, Mar 10, 2006 at 03:38:02PM +0100, Christian Thalinger wrote: Hi! We had a problem with a mauve testlet which turned out to be related to the default locale. CACAO sets the user.country property instead of the user.region per default. Some websearch (http://www.kaffe.org/pipermail

Re: [cp-patches] RFC: defaultLocale changes

2006-03-22 Thread Christian Thalinger
On Tue, 2006-03-14 at 16:56 +0100, Michael Koch wrote: Together with a mauve testcase that proves this I'm fine with it. :-) (as I told you on IRC) Ok, I'm unable to write a mauve testcase for that. The problem is: $ cat test.java import java.util.*; public class test { public static

Re: [cp-patches] Re: RFC: gnu.regexp: miscellaneous fixes

2006-03-28 Thread Christian Thalinger
On Sat, 2006-03-25 at 01:05 +0900, Ito Kazumitsu wrote: ChangeLog: 2006-03-24 Ito Kazumitsu [EMAIL PROTECTED] * gnu/regexp/CharIndexed.java(setLastMatch, getLastMatch, getAnchor): New methods. * gnu/regexp/CharIndexedCharArray.java(setLastMatch, getLastMatch,

Re: [cp-patches] FYI: Merging reflection stuff from generics branch

2006-04-04 Thread Christian Thalinger
On Tue, 2006-04-04 at 10:53 +0200, Christian Thalinger wrote: On Mon, 2006-04-03 at 21:05 +0100, Andrew John Hughes wrote: * vm/reference/java/lang/VMClass.java: (isAnonymousClass(Class?)): New native method. (isLocalClass(Class?)): New native method. (isMemberClass(Class

Re: [cp-patches] FYI: Manifest re-factoring

2006-04-10 Thread Christian Thalinger
On Thu, 2006-04-06 at 21:05 +0200, Mark Wielaard wrote: My apologies. This seems to have been some strange issue with my local setup. Everything works fine now again. Cacao is great! :-) TWISTI

Re: [cp-patches] FYI: Merging reflection stuff from generics branch

2006-04-10 Thread Christian Thalinger
On Tue, 2006-04-04 at 11:37 -0600, Tom Tromey wrote: Actually I've been curious to know why these don't simply use getModifiers (or whatever the equivalent is on VMClass). I was meaning to make that change... Tom, are you working on that or...? TWISTI

Re: [cp-patches] RFC: defaultLocale changes

2006-04-11 Thread Christian Thalinger
On Wed, Mar 22, 2006 at 11:23:50AM +0100, Christian Thalinger wrote: On Tue, 2006-03-14 at 16:56 +0100, Michael Koch wrote: Together with a mauve testcase that proves this I'm fine with it. :-) (as I told you on IRC) Ok, I'm unable to write a mauve testcase for that. The problem

[cp-patches] FYI: added CACAO to list of VMs

2006-05-14 Thread Christian Thalinger
Hi! Edwin mentioned that CACAO isn't listed in the README. So, here it goes. @mark: maybe you can backport this to the release branch. TWISTI 2006-05-15 Christian Thalinger [EMAIL PROTECTED] * README: Added CACAO to list of VMs. Index: README

Re: [cp-patches] FYI: Handle thread state

2006-06-29 Thread Christian Thalinger
On Thu, 2006-06-29 at 10:35 +0100, Andrew John Hughes wrote: Based on your comments, it seems you agree with my original intuition of making this a native VM call (by default) in the majority of cases, but efficiency would seem to be fairly VM specific. I suppose I was aiming on

[cp-patches] PR22800 fix (arm float parsing)

2006-09-12 Thread Christian Thalinger
Hi! I really think we should include that patch and revert my old one. I've tested it and it works. Ok to commit? - twisti 2006-10-12 Christian Thalinger [EMAIL PROTECTED] Fixes PR22800 * native/fdlibm/mprec.h (Storeinc): Define correctly for LE architectures (like

Re: [cp-patches] PATCH: (mprec.c) Fix _Jv_ulp for 64-bit __Long

2006-09-14 Thread Christian Thalinger
On Thu, Sep 14, 2006 at 09:47:37AM +0200, Mark Wielaard wrote: Hi Andrew and Christian, By now you two probably know mprec.c better than others. Could you take a look at this patch suggestion? Might this be related to the recent miscompilation observed by Andrew? Do we have testcases for

Re: [cp-patches] PR22800 fix (arm float parsing)

2006-09-14 Thread Christian Thalinger
On Wed, Sep 13, 2006 at 11:34:16AM +0200, Mark Wielaard wrote: Hi Christian, On Tue, 2006-09-12 at 16:57 +0200, Christian Thalinger wrote: I really think we should include that patch and revert my old one. I've tested it and it works. Ok to commit? 2006-10-12 Christian Thalinger

Re: [cp-patches] updated: IO, net, and NIO

2006-09-14 Thread Christian Thalinger
On Thu, Sep 14, 2006 at 11:18:34AM -0700, Casey Marshall wrote: Does cacao support GetDirectBufferAddress properly? There may be a bug there. Hmm, it unlikely, because OpenGL stuff works and that uses directu buffers a lot. But I'll try the patch. - twisti

Re: [cp-patches] updated: IO, net, and NIO

2006-09-14 Thread Christian Thalinger
On Fri, Sep 15, 2006 at 12:20:33AM +0200, Christian Thalinger wrote: On Thu, Sep 14, 2006 at 11:18:34AM -0700, Casey Marshall wrote: Does cacao support GetDirectBufferAddress properly? There may be a bug there. Hmm, it unlikely, because OpenGL stuff works and that uses directu buffers

[cp-patches] [generics] FYI: removed check in Formatter.basicIntegralConversion

2006-09-20 Thread Christian Thalinger
This patch removes the ZERO !LEFT_JUSTIFY check, as it's ok to print leading zeros with right justification. - twisti 2006-09-20 Christian Thalinger [EMAIL PROTECTED] * java/util/Formatter.java (basicIntegralConversion): Removed check for ZERO !LEFT_JUSTIFY. Index: java

[cp-patches] darwin build fix

2006-09-29 Thread Christian Thalinger
Hi! Current head did not build on darwin. This patch fixes it. I'll commit it later, when I'm in linux. - twisti 2006-09-29 Christian Thalinger [EMAIL PROTECTED] * native/jni/java-net/gnu_java_net_VMPlainSocketImpl.c (config-int.h): Added. * native/jni/java-nio

[cp-patches] Re: problem with extern inline function in javanio.c

2006-10-04 Thread Christian Thalinger
-04 Christian Thalinger [EMAIL PROTECTED] * native/jni/java-nio/javanio.c (cpnio_read, cpnio_readv) (cpnio_write, cpnio_writev, cpnio_socket, cpnio_connect) (cpnio_accept, cpnio_sendto, cpnio_recvfrom, cpnio_fcntl) (cpnio_select): Use CPNIO_EXPORT. * native

[cp-patches] Re: Build failure on Mac OS X

2006-10-22 Thread Christian Thalinger
On Sat, Oct 21, 2006 at 09:01:01AM +0200, Christian Thalinger wrote: On Sat, 2006-10-21 at 00:45 +0100, Robert Lougher wrote: Hi, I tried building the lastest distcheck on Mac OS X last night (first time in a while). The build trivially failed in two files: native/jni/java-net

[cp-patches] [RFC] check for all 2.6x autoconf versions

2006-12-15 Thread Christian Thalinger
+++ ChangeLog 15 Dec 2006 14:53:13 - @@ -1,3 +1,7 @@ +2006-12-15 Christian Thalinger [EMAIL PROTECTED] + + * autogen.sh: Check for all 2.6x autoconf versions. + 2006-12-14 David Daney [EMAIL PROTECTED] * gnu/java/net/protocol/http/HTTPURLConnection.java: Clean Index: autogen.sh

Re: [cp-patches] [RFC] check for all 2.6x autoconf versions

2006-12-15 Thread Christian Thalinger
On Fri, Dec 15, 2006 at 11:18:40AM -0700, Tom Tromey wrote: Twisti == Christian Thalinger [EMAIL PROTECTED] writes: Twisti Ok to commit? I guess so... Yes, thanks. Commited. - twisti

[cp-patches] [FYI] added support for Sun's javac

2006-12-15 Thread Christian Thalinger
--- ChangeLog 15 Dec 2006 21:48:39 - 1.8991 +++ ChangeLog 15 Dec 2006 22:05:37 - @@ -1,3 +1,14 @@ +2006-12-15 Christian Thalinger [EMAIL PROTECTED] + + * m4/acinclude.m4 (CLASSPATH_FIND_JAVAC): Added support for Sun's + javac. + (CLASSPATH_WITH_JAVAC): Added

Re: [cp-patches] FYI: Fix for PR26852

2007-02-16 Thread Christian Thalinger
On Thu, 2007-02-15 at 23:46 +, Andrew John Hughes wrote: I'm committing Edwin's patch for PR28652. According to Mark, this is minor enough not to warrant an assignment just yet. Changelog: 2006-10-14 Edwin Steiner [EMAIL PROTECTED] PR classpath/28652: *

Re: [cp-patches] FYI: Make VMChannel.open thread-safe

2007-03-28 Thread Christian Thalinger
On Wed, 2007-03-28 at 11:48 +0200, Mark Wielaard wrote: Hi, Andrew and Christian pointed out that the way we fiddle with umask is 1) not-thread-safe and 2) unnecessary. So this patch fixes that up. It also removes the linking against libclasspathnative for the nio library since it doesn't

[cp-patches] RFC: iconv -Werror compilation fix

2007-03-29 Thread Christian Thalinger
Hi! This patch fixes -Werror compilation with !HAVE_ICONV. Daney pointed me to the (void)-solution. I'm not sure if that is the best solution, but it works. Comments? - twisti --- Index: native/jni/java-nio/gnu_java_nio_charset_iconv_IconvDecoder.c

Re: [cp-patches] RFC: iconv -Werror compilation fix

2007-03-29 Thread Christian Thalinger
On Thu, 2007-03-29 at 16:35 -0600, Tom Tromey wrote: We discussed on irc but I thought the answer should be in the list archives too. Annotation the argument with UNUSED. This is defined in config.h. We already use this all over; gcc's __attribute__ ((unused)) really means might or might

Re: [cp-patches] RFC: iconv -Werror compilation fix

2007-04-04 Thread Christian Thalinger
On Fri, 2007-03-30 at 01:36 +0200, Christian Thalinger wrote: On Thu, 2007-03-29 at 16:35 -0600, Tom Tromey wrote: We discussed on irc but I thought the answer should be in the list archives too. Annotation the argument with UNUSED. This is defined in config.h. We already use this all

[cp-patches] Re: FYI: Some Image icon cleanups

2007-04-04 Thread Christian Thalinger
On Thu, 2007-04-05 at 00:57 +0200, Mark Wielaard wrote: Christian, this hopefully solves the issue you reported on irc with MegaMek. Could you test? Yes, this fixed the problem. - twisti

Re: [cp-patches] RFC: iconv -Werror compilation fix

2007-04-05 Thread Christian Thalinger
On Wed, 2007-04-04 at 13:36 +0200, Christian Thalinger wrote: Yeah, tomorrow :-) Anyways, here it is. Commit? Commited as follows. 2007-04-05 Christian Thalinger [EMAIL PROTECTED] * native/jni/java-nio/gnu_java_nio_charset_iconv_IconvDecoder.c, native/jni/java-nio

FYI: VMNetworkInterface -Werror fix [Was: Re: [cp-patches] RFC: iconv -Werror compilation fix]

2007-04-05 Thread Christian Thalinger
On Thu, 2007-04-05 at 14:21 +0200, Christian Thalinger wrote: On Wed, 2007-04-04 at 13:36 +0200, Christian Thalinger wrote: Yeah, tomorrow :-) Anyways, here it is. Commit? Commited as follows. Had another one of this type pending. Commited. - twisti --- 2007-04-05 Christian Thalinger

[cp-patches] FYI: PR 22800 fixed

2007-04-05 Thread Christian Thalinger
Hi! I reverted the reverted patch because it's required. See also: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22800. This should finally fix all double-arm problems. - twisti --- 2007-04-05 Christian Thalinger [EMAIL PROTECTED] PR classpath/22800: * native/jni/java-lang

Re: [cp-patches] Little XML patch

2007-04-07 Thread Christian Thalinger
On Tue, 2007-02-06 at 10:13 +, Chris Burdess wrote: I committed this patch which does two things: fixes a problem whereby Xerces did not support an asynchronous DOM LS parser, and works around a problem with the URLs specified in XML system IDs. Note, this is only a workaround and

Re: [cp-patches] Little XML patch

2007-04-09 Thread Christian Thalinger
On Sat, 2007-04-07 at 19:14 +0200, Mark Wielaard wrote: Hi Christian, On Sat, 2007-04-07 at 17:03 +0200, Christian Thalinger wrote: This patch broke SPECjbb2005 (http://developer.classpath.org/pipermail/classpath/2007-March/001917.html). Could you provide us with the input

Re: [cp-patches] Little XML patch

2007-04-09 Thread Christian Thalinger
On Mon, 2007-04-09 at 19:17 +0200, Christian Thalinger wrote: Ok, here we go: input.systemId=file:/home/twisti/cacao/spec/jbb2005/xml/template-document.xml ids.systemId=jbb-document.dtd url=jbb-document.dtd This is the output before Chris' patch: input.systemId=file:/home/twisti/cacao/spec

[cp-patches] RFC: old DeleteLocalRef patch

2007-04-11 Thread Christian Thalinger
Hi! I just found this one in my local working copy. Should I commit it? - twisti --- Index: native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkClipboard.c === RCS file:

[cp-patches] FYI: added AC_C_INLINE check

2007-04-11 Thread Christian Thalinger
Hi! I added the AC_C_INLINE check in configure.ac, since some compilers don't understand the inline keyword. This one is commited and should go on the release branch. - twisti --- 2007-04-11 Christian Thalinger [EMAIL PROTECTED] * configure.ac: Added AC_C_INLINE. Index

[cp-patches] FYI: fixed compiler warning in native/jni/native-lib/cpproc.c

2007-04-11 Thread Christian Thalinger
Hi! MIPSpro warned about that. Commited. - twisti --- 2007-04-11 Christian Thalinger [EMAIL PROTECTED] * native/jni/native-lib/cpproc.c (cpproc_forkAndExec): Fixed warning on some compilers, e.g. MIPSpro. Index: native/jni/native-lib/cpproc.c

[cp-patches] FYI: fixed fcntl.h include in native/jni/java-nio/javanio.c

2007-04-11 Thread Christian Thalinger
Hi! IRIX had a problem with including sys/fcntl.h directly. Commited. - twisti --- 2007-04-11 Christian Thalinger [EMAIL PROTECTED] * native/jni/java-nio/javanio.c: Include fcntl.h instead of sys/fcntl.h. Index: native/jni/java-nio/javanio.c

[cp-patches] RFC: check for gethostbyname_r argument number

2007-04-11 Thread Christian Thalinger
Hi! This patch checks for the number of arguments of the gethostbyname_r library call. The six- and five-argument case is implemented, the three-argument case is missing, but I added an #error. Ok to commit? - twisti --- 2007-04-11 Christian Thalinger [EMAIL PROTECTED] * LICENSE

Re: [cp-patches] RFC: old DeleteLocalRef patch

2007-04-12 Thread Christian Thalinger
:-) Could you please write a changelog entry and fix this little nitpick? Commited as follows. - twisti --- 2007-04-12 Christian Thalinger [EMAIL PROTECTED] * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkClipboard.c (clipboard_get_func): Call DeleteLocalRef. * native/jni/gtk

Re: [cp-patches] Little XML patch

2007-04-16 Thread Christian Thalinger
On Mon, 2007-04-09 at 21:11 +0200, Christian Thalinger wrote: On Mon, 2007-04-09 at 19:17 +0200, Christian Thalinger wrote: Ok, here we go: input.systemId=file:/home/twisti/cacao/spec/jbb2005/xml/template-document.xml ids.systemId=jbb-document.dtd url=jbb-document.dtd

Re: [cp-patches] Little XML patch

2007-04-16 Thread Christian Thalinger
On Mon, 2007-04-16 at 14:16 +0200, Mark Wielaard wrote: Christian, can you retest against cvs HEAD and let us know whether or not this solves your regressions? Yes, works. - twisti

Re: [cp-patches] RFC: Options to javac

2007-05-10 Thread Christian Thalinger
On Thu, 2007-05-10 at 17:00 +0200, Mario Torre wrote: Il giorno gio, 10/05/2007 alle 13.39 +0100, Chris Burdess ha scritto: Will the switches just be ignored by 1.4 and earlier versions of javac, or will they cause an error? I don't think they are ignored. Is there configury in any

[cp-patches] RFC: jni.h changes to be openjdk compatible

2007-06-21 Thread Christian Thalinger
Hi! While doing the cacao port to use openjdk's libraries, I noticed the function prototypes in sun's jni.h are a bit different than ours. And also the JNINativeInterface and JNIInvokeInterface struct names. As cacao does not have it's own jni.h, we'd need these changes. Any objections? -

  1   2   >