[cp-patches] Patch: Scroll pane containing a JList with a preferred size.

2005-06-16 Thread Lillian Angel
because the JList is about the same size as the JScrollPane. Funny, but the JScrollPane is 3 pixels smaller because of the border, and thats the reason the scrollbar appears. 2005-06-15 Lillian Angel [EMAIL PROTECTED] * javax/swing/JViewport.java Fixed Bug #17360 and 17362

[cp-patches] Patch: NullPointerException in ToolTipManger #11538

2005-06-16 Thread Lillian Angel
This simple patch fixes the NullPointerException in the function mousePressed in ToolTipManager. Attached is the patch. 2005-06-15 Lillian Angel [EMAIL PROTECTED] * javax/swing/ToolTipManager.java Fixed Bug #11538. (mousePressed): check if currentComponent is null

Re: [cp-patches] Patch: Scroll pane containing a JList with a preferred size.

2005-06-17 Thread Lillian Angel
On Fri, 2005-06-17 at 08:17 -0600, Tom Tromey wrote: Lillian == Lillian Angel [EMAIL PROTECTED] writes: A small formatting nit ... Lillian +if (p instanceof JScrollPane !vd.equals( new Dimension() )) Lillian +( (JScrollPane) p ).setPreferredSize( vd

[cp-patches] view in JScrollPane

2005-06-17 Thread Lillian Angel
With the new changes to JScrollPane, the view would not appear because the viewport view was never initialized. I fixed this. 2005-06-17 Lillian Angel [EMAIL PROTECTED] * javax/swing/JScrollPane.java (JScrollPane): Viewport was not being set when the view was null

[cp-patches] Patch: view in JScrollPane

2005-06-17 Thread Lillian Angel
I fixed the Patch in this attachment to not include the ChangeLog. Sorry about that. 2005-06-17 Lillian Angel [EMAIL PROTECTED] * javax/swing/JScrollPane.java (JScrollPane): Viewport was not being set when the view was null. Whenever a view would be added to container

Re: [cp-patches] Patch: view in JScrollPane

2005-06-20 Thread Lillian Angel
Can I get approval to commit this patch? Thank you! On Fri, 2005-06-17 at 11:17 -0400, Lillian Angel wrote: I fixed the Patch in this attachment to not include the ChangeLog. Sorry about that. 2005-06-17 Lillian Angel [EMAIL PROTECTED] * javax/swing/JScrollPane.java

[cp-patches] FYI: Null check after dereference in javax.swing.DefaultDesktopManager

2005-06-20 Thread Lillian Angel
ChangeLog explains it all. Avoids NullPointerException 2005-06-20 Lillian Angel [EMAIL PROTECTED] * javax/swing/DefaultDesktopManager (getBoundsForIconOf): No reason to check if desktopPane is null after dereferencing desktopPane in code. Fixes bug #13461. Committed

Re: [cp-patches] Patch: Null check after dereference ingnu.xml.aelfred2.XmlParser

2005-06-20 Thread Lillian Angel
took me all day ;) just kidding! On Mon, 2005-06-20 at 22:56 +0200, Meskauskas Audrius wrote: Impressive! - Original Message - From: Lillian Angel [EMAIL PROTECTED] To: classpath-patches@gnu.org Sent: Monday, June 20, 2005 10:24 PM Subject: [cp-patches] Patch: Null check after

[cp-patches] FYI: Null check after dereference in gnu.xml.aelfred2.XmlParser

2005-06-21 Thread Lillian Angel
Damage Prevention. Prevents a NullPointerException 2005-06-21 Lillian Angel [EMAIL PROTECTED] * gnu/xml/aelfred2/XmlParser (parseAttribute): if (type.equals(CDATA) || type == null) this would always throw a NullPointerException if type is null. fixes bug #13458 Committed

[cp-patches] FYI: #13460 Incorrect logic in java.util.logging.Logger

2005-06-21 Thread Lillian Angel
Incorrect Logic. committed 2005-06-21 Lillian Angel [EMAIL PROTECTED] * java/util/loggin.Logger (setParent): No lines after throwing an exception are executed and there is no point to check if the parent is null, because a NullPointerException would have been thrown

Re: [cp-patches]: Patch: JTree related class' implementations

2005-06-28 Thread Lillian Angel
Ok, no problem. Thanks for the feedback. I will change these things as soon as possible. I will be working on it more today. About the copyright question, that was a copy/paste mistake. grrr! Lillian. On Tue, 2005-06-28 at 14:47 +0200, Mark Wielaard wrote: Hi, On Tue, 2005-06-28 at 12:35

[cp-patches] Approval Needed: Patch: JTree related class' implementations

2005-06-29 Thread Lillian Angel
(isPathSelected): took out unneeded lines (getTreeSelectionListeners): made more logical to call getListeners (fireValueChanged): fixed loop to be more logical -- Lillian Angel Red Hat Canada, Ltd. (416) 482-2661 x239 [EMAIL PROTECTED] Index: javax/swing/JTree.java

[cp-patches] Need Approval: Patch: JTree selection

2005-07-04 Thread Lillian Angel
Same as the previous patch, just a slight change in a comment for getCellBounds On Thu, 2005-06-30 at 16:21 -0400, Lillian Angel wrote: Now when you click on a node in the JTree it actually highlights it. patch attached, approval needed. 2005-06-30 Lillian Angel [EMAIL PROTECTED

[cp-patches] Patch: expand/collapse for JTree

2005-07-06 Thread Lillian Angel
in the BasicLookAndFeel class. For selection, I still need to implement the CONTIGUOUS_TREE_SELECTION option. There are some other functions/features that I still need to implement. 2005-07-06 Lillian Angel [EMAIL PROTECTED] * javax/swing/JTree.java Initialized

[cp-patches] FYI: expand/collapse for JTree

2005-07-06 Thread Lillian Angel
I committed a minor fix for my last patch. 2005-07-06 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java (getNextVisibleNode): Implemented (getPathForRow): Fixed so the next node retrieved is visible. On Wed, 2005-07-06 at 13:53 -0400, Lillian

[cp-patches] FYI: JTree expand/collapse Implementation

2005-07-06 Thread Lillian Angel
Another fix.. last one, I hope. 2005-07-06 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java (getPathForRow): took out redundant code. ___ Classpath-patches mailing list Classpath-patches@gnu.org http

[cp-patches] Patch: Demo tree

2005-07-11 Thread Lillian Angel
2005-07-11 Lillian Angel [EMAIL PROTECTED] * examples/gnu/classpath/examples/swing/Demo.java (mkTree): fixed so the JTree appears properly. Index: examples/gnu/classpath/examples/swing/Demo.java === RCS file

[cp-patches] Patch: JTree demo

2005-07-12 Thread Lillian Angel
2005-07-11 Lillian Angel [EMAIL PROTECTED] * examples/gnu/classpath/examples/swing/Demo.java (mkTreeWorld): Implemented (mkTabbedPane): added in tab for TreeWorld * javax/swing/plaf/basic/BasicLookAndFeel.java Changed default color of text non selection

[cp-patches] Patch: formatting of copyrights

2005-07-12 Thread Lillian Angel
2005-07-12 Lillian Angel [EMAIL PROTECTED] * javax/swing/JTree.java: Formatting copyright * javax/swing/tree/DefaultTreeCellRenderer.java: Formatting copyright * javax/swing/tree/DefaultTreeSelectionModel.java: Formatting copyright

[cp-patches] Patch: selection for JTree with icon

2005-07-12 Thread Lillian Angel
2005-07-12 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java (paintLeaf): fixed size of selection background to depend on if icon exists (paintNonLeaf): fixed size of selection background to depend on if icon exists Index: javax

[cp-patches] Patch: Demo fix

2005-07-12 Thread Lillian Angel
2005-07-12 Lillian Angel [EMAIL PROTECTED] * examples/gnu/classpath/examples/swing/Demo.java (mkTree): no need to make root visible, it is by default (mkTreeWorld): no need to make root visible, it is by default ___ Classpath

[cp-patches]: Patch: painting icons

2005-07-13 Thread Lillian Angel
This paints the icons when using a look and feel other than 'basic'. I still need to make the control icons work for MetalLF. Also, clicking still needs to be fixed so it works the same as Sun's. 2005-07-13 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicLookAndFeel.java

[cp-patches] Patch: JTree defaults

2005-07-13 Thread Lillian Angel
2005-07-13 Lillian Angel [EMAIL PROTECTED]i * javax/swing/plaf/basic/BasicLookAndFeel.java: Changed font to match jdk. * javax/swing/plaf/basic/BasicTreeUI.java: took out unneeded import statement * javax/swing/plaf/metal/MetalLookAndFeel.java: Changed

[cp-patches] FYI: added to defaults

2005-07-13 Thread Lillian Angel
Slight Change to last patch. Forgot to change a default in BasicLookAndFeel.java ___ Classpath-patches mailing list Classpath-patches@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-patches

[cp-patches] Patch: BasicTreeUI getPathBounds

2005-07-15 Thread Lillian Angel
2005-07-15 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java (mouseClicked): changed to use getPathBounds. (getPathBounds): Implemented Index: javax/swing/plaf/basic/BasicTreeUI.java

[cp-patches] Patch: bug fixing for BasicTreeUI

2005-07-18 Thread Lillian Angel
There appears to be some bugs when adding in custom icons. This still does not work perfectly, but soon. 2005-17-18 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/BasicTreeUI (getPathBounds): checked if path was null initially (paint): no need to check for control

[cp-patches] Patch: BasicTreeUI, clicking cells

2005-07-19 Thread Lillian Angel
2005-17-19 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/BasicTreeUI (setModel): changed to call JTree's setModel (setRootVisible): Likewise (isRootVisible): Likewise (getClosestPathForLocation): Implemented (paint): took out translate

Re: [cp-patches]: Patch: JTree clicking

2005-07-20 Thread Lillian Angel
I fixed this already. This was a temporary patch to get things working at the time. It works really well now, without the constants. On Wed, 2005-07-20 at 14:08 -0400, Thomas Fitzsimmons wrote: Hi, On Fri, 2005-07-15 at 13:35 -0400, Lillian Angel wrote: + Rectangle bounds

[cp-patches]: Patch: keyHandling for JTree

2005-07-20 Thread Lillian Angel
Still a few more to be implemented. Most are done. 2005-07-20 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java (keyPressed): Implemented some more VK_XXX and VK_KP_XXX events. Index: javax/swing/plaf/basic/BasicTreeUI.java

Re: [cp-patches] Patch: BasicTreeUI, preferredsize and double clicking

2005-07-21 Thread Lillian Angel
I apologize, I attached the wrong patch before. Here is the updated version. On Thu, 2005-07-21 at 10:33 -0400, Lillian Angel wrote: 2005-07-21 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java (getPreferredSize): Changed to depend on visible nodes

[cp-patches]: Patch: JTree painting

2005-07-25 Thread Lillian Angel
A fix for the case where there are no icons. 2005-07-25 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java (paint): moved code to paintNode (getCellBounds): width increased, slightly short before (paintNode): changed to paint node

Re: [cp-patches]: Patch: JTree painting

2005-07-25 Thread Lillian Angel
Done it again! heres the correct patch. On Mon, 2005-07-25 at 13:39 -0400, Lillian Angel wrote: A fix for the case where there are no icons. 2005-07-25 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java (paint): moved code to paintNode

[cp-patches] Patch: various bug fixes

2005-07-28 Thread Lillian Angel
These are many bugs I ran into when running several applications. There are more I have found and will fix soon! 2005-07-28 Lillian Angel [EMAIL PROTECTED] * java/awt/GridBagLayout.java (distributeSizeAndWeight): added in check, because OutOfBounds exception was being

[cp-patches]: bug fixes for exceptions

2005-07-29 Thread Lillian Angel
This patch fixes some unnecessary ArrayOutOfBoundsException and NullPointerExceptions. 2005-07-29 Lillian Angel [EMAIL PROTECTED] * javax/swing/JTextField.java (insertString): Added in check for null to resolve a NPE. * javax/swing/text/GapContent.java

[cp-patches]: Patch: fixes for NullPointerExceptions

2005-07-29 Thread Lillian Angel
I was getting NPEs with some menu applications. This fixes it. 2005-07-29 Lillian Angel [EMAIL PROTECTED] * javax/swing/MenuSelectionManager.java (isComponentPartOfCurrentMenu): Fixed to prevent NPE. * javax/swing/plaf/basic/BasicMenuUI.java (popupVisible

[cp-patches] Patch: GapContent fix

2005-08-02 Thread Lillian Angel
2005-08-02 Lillian Angel [EMAIL PROTECTED] * javax/swing/text/GapContent.java (shiftGap): Added in if statement to check if indexes are negative. Does not work properly if they are. Index: javax/swing/text/GapContent.java

[cp-patches]: Patch: Formatting GapContent

2005-08-02 Thread Lillian Angel
2005-08-02 Lillian Angel [EMAIL PROTECTED] * javax/swing/text/GapContent.java: Formatting code. Index: javax/swing/text/GapContent.java === RCS file: /cvsroot/classpath/classpath/javax/swing/text/GapContent.java,v

Re: FYI: [cp-patches]: Patch: Formatting GapContent

2005-08-02 Thread Lillian Angel
Fixed to use only 2-space indents. Re-committed. On Tue, 2005-08-02 at 10:22 -0400, Lillian Angel wrote: 2005-08-02 Lillian Angel [EMAIL PROTECTED] * javax/swing/text/GapContent.java: Formatting code. ___ Classpath-patches

Re: FYI: [cp-patches] Patch: GapContent fix

2005-08-02 Thread Lillian Angel
Small bug fixed. 2005-08-02 Lillian Angel [EMAIL PROTECTED] * javax/swing/text/GapContent.java (shiftGap): Changed to used ''. both indexes should be greater than 0. On Tue, 2005-08-02 at 10:23 -0400, Lillian Angel wrote: 2005-08-02 Lillian Angel [EMAIL PROTECTED

Re: [cp-patches] FYI: RadioButton and CheckBox icon cleanup

2005-08-02 Thread Lillian Angel
* javax/swing/plaf/basic/BasicIconFactory.java (CheckBoxIcon): An new Icon implementation used for CheckBoxes in the Basic LF. (RadioButtonIcon): An new Icon implementation used for RadioButtons in the Basic LF. (getCheckBoxIcon): Now returns

[cp-patches] Patch: checkbox in the menu

2005-08-03 Thread Lillian Angel
Now a check mark is drawn next to the menu item when it is clicked on and selected. 2005-08-03 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicIconFactory.java: (getMenuItemCheckIcon): Implemented so a check mark is drawn when the item is selected

Re: [cp-patches] FYI: checkbox in the menu

2005-08-03 Thread Lillian Angel
Accidently changed the fonts in BasicLF. Changed them back. 2005-08-03 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicLookAndFeel.java: Changed the fonts from Helvetica to Dialog. On Wed, 2005-08-03 at 14:11 -0400, Lillian Angel wrote: Now a check mark is drawn

[cp-patches] Patch: set checkbox menu items to visible

2005-08-03 Thread Lillian Angel
2005-08-03 Lillian Angel [EMAIL PROTECTED] * javax/swing/JCheckBoxMenuItem.java (installUI): set the items visible. Fixes exceptions that are thrown because item is not explicitly set visible. Index: javax/swing/JCheckBoxMenuItem.java

[cp-patches] Patch: JCheckBox icon initialization for basic and metal LF

2005-08-04 Thread Lillian Angel
Fixed because swingDemo was not working properly for checkboxes. It was using the checkIcon for both the icon and selectedIcon before. Now works well! 2005-08-04 Lillian Angel [EMAIL PROTECTED] * javax/swing/JCheckBox.java (init): Initialized icons. Was not working otherwise

[cp-patches] Patch: Border around checkBox

2005-08-04 Thread Lillian Angel
Border around checkBox is now drawn for MetalLF 2005-08-04 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicMenuItemUI.java (paintIcon): Added in border painting code for MenuItem * javax/swing/plaf/metal/MetalLookAndFeel.java: Added in default

[cp-patches] Patch: JMenu size

2005-08-04 Thread Lillian Angel
2005-08-04 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicMenuItemUI.java (getPreferredSize): Multiplied defaultTextIconGap by 2, so there is equal space around the MenuItem I accidently committed my changes before making a patch, basically here

Re: [cp-patches] FYI: JMenu size

2005-08-05 Thread Lillian Angel
I changed this patch since this one is slightly more intuitive. 2005-08-05 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicGraphicsUtils.java (getPreferredButtonSize): Added horizontalAdjustment to width to create gap at end of label text. * javax

[cp-patches] Patch: GridBagLayout

2005-08-05 Thread Lillian Angel
2005-08-05 Lillian Angel [EMAIL PROTECTED] * java/awt/GridBagLayout.java (setConstraints): Removed checks in if statements because if the height or width is less than 0, it should be updated to a positive number in all cases. Index: java/awt/GridBagLayout.java

[cp-patches] Patch: BasicTreeUI using TreeNode

2005-08-05 Thread Lillian Angel
2005-08-05 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java: (getPathBounds): Changed to use TreeNode and not DefaultMutableTreeNode. (getPathForRow): Likewise. (getRowCount): Likewise. (getPreferredSize

[cp-patches] Patch: bug #23252 fix

2005-08-08 Thread Lillian Angel
2005-08-08 Lillian Angel [EMAIL PROTECTED] Fixes bug #23252 * javax/swing/JTree.java (setModel): Changed to allow model to be null. * javax/swing/plaf/basic/BasicTreeUI.java (setModel): Changed to depend on JTree functions (getPathBounds): Fixed

[cp-patches] Patch: fix for bug #23255

2005-08-09 Thread Lillian Angel
2005-08-09 Lillian Angel [EMAIL PROTECTED] Fixes Bug #23255 * javax/swing/plaf/basic/BasicTreeUI.java: Fixed entire class to use Objects as opposed to TreeNodes. (getPathBounds): Changed root to Object (getPathForRow): Likewise. (getRowCount

[cp-patches]: Patch: Formatting for DefaultTreeModel.

2005-08-09 Thread Lillian Angel
2005-08-09 Lillian Angel [EMAIL PROTECTED] * javax/swing/tree/DefaultTreeModel.java: Fixed formatting of class. ___ Classpath-patches mailing list Classpath-patches@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-patches

[cp-patches] Patch: Icon fixes

2005-08-09 Thread Lillian Angel
2005-08-09 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicLabelUI.java (paint): Added in code to paint background rect according to API. Also, formatting changes. * javax/swing/plaf/basic/BasicTreeUI.java (setCellRenderer): Fixed to changed

[cp-patches] Patch: Label and icon fixes for tree nodes.

2005-08-09 Thread Lillian Angel
2005-08-09 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicLabelUI.java (paint): Added in painting code for label border. * javax/swing/plaf/basic/BasicTreeUI.java (paintControlIcons): Fixed location for control icons. * javax/swing/plaf

[cp-patches]: JTable setRowHeight

2005-08-09 Thread Lillian Angel
2005-08-09 Lillian Angel [EMAIL PROTECTED] * javax/swing/JTable.java (setRowHeight): Fixed condition on when to throw exception. (setRowHeight): Parameters were mixed up. ? .ChangeLog.swp ? examples/gnu/classpath/examples/swing/Demo$1.class ? examples/gnu/classpath

[cp-patches] Patch: BasicTreeUI, fireTreeWillCollapse/Expand

2005-08-10 Thread Lillian Angel
2005-08-10 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java (mouseClicked): Called fireTreeWillExpand and fireTreeWillCollapse when appropriate. (keyPressed): Likewise. Index: javax/swing/plaf/basic/BasicTreeUI.java

[cp-patches] Patch: JTree

2005-08-10 Thread Lillian Angel
2005-08-10 Lillian Angel [EMAIL PROTECTED] * javax/swing/JTree.java (doExpandParents): Took out call to checkExpandParents. (checkExpandParents): Helper method not needed. Caused problems since fireTreeWillExpand was being called too many times

Re: [cp-patches] FYI: Fix BasicViewportUI

2005-08-11 Thread Lillian Angel
Here is a patch that fixes the viewport painting problem. Viewport is no longer being cutoff at the top or bottom. 2005-08-11 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicViewportUI.java (paintSimple): Changed to paint the portBounds from (0,0). On Thu, 2005

[cp-patches] Patch: JTable NullPointerExceptions

2005-08-11 Thread Lillian Angel
2005-08-11 Lillian Angel [EMAIL PROTECTED] * javax/swing/JTable (rowAtPoint): Added in a check for null. Was getting NPE. (columnAtPoint): Likewise. Index: javax/swing/JTable.java === RCS file: /cvsroot

[cp-patches] Patch: JSplitPane divider

2005-08-12 Thread Lillian Angel
2005-08-12 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicSplitPaneUI.java * (getMinimumDividerLocation): Fixed to work similar to getMaximumDividerLocation. Was not able to move divider in both directions before. Index: javax/swing/plaf/basic

[cp-patches] Patch: BasicTreeUI NPE checks

2005-08-12 Thread Lillian Angel
2005-08-12 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java (getCellLocation): Added in a check to make sure the node has children. Fixed loop to use post-increment. (paintRecursive): Fixed loop to use post-increment

[cp-patches]: Patch: JPasswordField

2005-08-15 Thread Lillian Angel
2005-08-15 Lillian Angel [EMAIL PROTECTED] * javax/swing/JPasswordField.java (echoCharIsSet): Fixed this to work according to API. (getText): Implemented (getText): Implemented (getPassword): Implemented (paramString): Implemented Index: javax

[cp-patches] FYI: JPasswordField

2005-08-15 Thread Lillian Angel
2005-08-15 Lillian Angel [EMAIL PROTECTED] * javax/swing/JPasswordField.java (getText): Fixed the length of the string to retrieve. On Mon, 2005-08-15 at 15:45 -0400, Lillian Angel wrote: 2005-08-15 Lillian Angel [EMAIL PROTECTED] * javax/swing

[cp-patches] Patch: PasswordView

2005-08-16 Thread Lillian Angel
2005-08-16 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicLookAndFeel.java: Changed font for PasswordField because textbox was being drawn at an awkward height. * javax/swing/text/PasswordView.java (getPreferredSpan): Implemented

[cp-patches] Patch: PasswordView fix

2005-08-16 Thread Lillian Angel
2005-08-16 Lillian Angel [EMAIL PROTECTED] * javax/swing/text/PasswordView.java (drawUnselectedText): Fixed so the password is drawn correctly in the text box and no * characters are drawn before anything was typed. Index: javax/swing/text/PasswordView.java

[cp-patches]: Patch: painting fix.

2005-08-17 Thread Lillian Angel
2005-08-17 Lillian Angel [EMAIL PROTECTED] * java/awt/FontMetrics.java (charWidth): Reversed Roman's patch, was not compiling. * javax/swing/tree/DefaultTreeCellRenderer.java (getTreeCellRendererComponent): Set Opaque to true for painting reasons Index

[cp-patches] Patch: painting of tree cell.

2005-08-17 Thread Lillian Angel
2005-08-17 Lillian Angel [EMAIL PROTECTED] * javax/swing/tree/DefaultTreeCellRenderer.java (paint): paints the background and border of cell. Index: javax/swing/tree/DefaultTreeCellRenderer.java === RCS file

[cp-patches]: Patch: Tree editing

2005-08-18 Thread Lillian Angel
I have started the JTree editing. There is _alot_ to implement, this is just the beginning. :) 2005-08-18 Lillian Angel [EMAIL PROTECTED] * javax/swing/DefaultCellEditor.java (getTreeCellEditorComponent): Implemented. * javax/swing/plaf/basic/BasicTreeUI.java

[cp-patches]: Patch: DefaultTreeModel implementation

2005-08-19 Thread Lillian Angel
2005-08-19 Lillian Angel [EMAIL PROTECTED] * javax/swing/tree/DefaultTreeModel.java (setAsksAllowsChildren): Removed comment, unneeded. (setRoot): Formatting. (getIndexOfChild): Formatting. (reload): Added API documentation. (reload): Likewise

[cp-patches] Patch: DefaultTreeCellEditor

2005-08-19 Thread Lillian Angel
Still working on implementing this class. I implemented some of the functions, but alot of them still need to be done. I will continue to implement them to get editing working for JTree's. 2005-08-19 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java

[cp-patches] Patch: NPE fix

2005-08-23 Thread Lillian Angel
2005-08-23 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java (BasicTreeUI): Moved these lines to installUI because they were causing NullPointerExceptions. (installUI): Added code from constructor. * javax/swing/plaf/metal

Re: [cp-patches]: Patch: JPasswordField

2005-08-24 Thread Lillian Angel
Are you sure you want to return the empty string if there is a BadLocationException thrown from the underlying code? It looks like that might hide problems with the Document (sub) class implementation. Better would be to chain it in a InternalError() and throw that since it seems that

Re: [cp-patches]: FYI: JTree editing.

2005-08-24 Thread Lillian Angel
Accidently committed the change to DefaultCellEditor. I committed the change. 2005-08-24 Lillian Angel [EMAIL PROTECTED] * javax/swing/DefaultCellEditor.java (isCellEditable): Reversed last changes. On Wed, 2005-08-24 at 16:36 -0400, Lillian Angel wrote: Still working

[cp-patches]: Patch: JTree editing.

2005-08-24 Thread Lillian Angel
Still working on JTree editing. You will not be able to test this yet, but ATM it is almost working :) 2005-08-24 Lillian Angel [EMAIL PROTECTED] * javax/swing/DefaultCellEditor.java (isCellEditable): If the event is null, the cell is still editable. * javax

Re: [cp-patches]: FYI: JPasswordField

2005-08-25 Thread Lillian Angel
I changed this to raise an AssertionError. 2005-08-25 Lillian Angel [EMAIL PROTECTED] * javax/swing/JPasswordField.java (setText): Changed to raise an AssertionError when a BadLocationException is caught. Index: javax/swing/JPasswordField.java

[cp-patches] Patch: JTree Editing

2005-08-29 Thread Lillian Angel
to do this. It is about half done. Also, I added in a change for JPasswordField that was requested by Mark and Roman. The patch is rather cumbersome, keep in mind not everything is completed... so things will probably change slightly. 2005-08-29 Lillian Angel [EMAIL PROTECTED] * javax

[cp-patches]: Patch: BasicTreeUI, caret update

2005-08-30 Thread Lillian Angel
2005-08-30 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java: Added a timer field for repainting the editing component. (EditorUpdateTimer): Inner class added and implemented. Updates the caret and text box. Still need to fix typing in text

[cp-patches] Patch: JTree editing

2005-09-01 Thread Lillian Angel
when 'ENTER' is pressed. But, I have tested that it does work so far. 2005-09-01 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java: Added new field to keep track of contents in newly edited cell. (isEditing): Made more intuitive. (stopEditing

Re: [cp-patches]: FYI: JTree editing fix

2005-09-02 Thread Lillian Angel
2005-09-02 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java (mousepressed): Fixed, so that clicking on control icon will not start editing. On Fri, 2005-09-02 at 14:00 -0400, Lillian Angel wrote: JTree editing is complete and key handling

[cp-patches]: JScrollBar fix

2005-09-06 Thread Lillian Angel
2005-09-06 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicScrollBarUI: Fixes Bug PR23529. (installUI): Changed delay for Timer. Was set too long and actionPerformed was not being called fast enough when the user clicks on the scroll bar

[cp-patches]: Patch: JMenuBar fix

2005-09-06 Thread Lillian Angel
2005-09-06 Lillian Angel [EMAIL PROTECTED] Fixes Bug #PR20015 * javax/swing/JMenuBar.java (getUIClassID): Fixed API documentation. * javax/swing/plaf/basic/BasicMenuBarUI.java: Added a private field for the mouse listener. (BasicMenuBarUI

[cp-patches]: Patch: BasicFileChooserUI formatting.

2005-09-06 Thread Lillian Angel
2005-09-06 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicFileChooserUI.java: Formatted entire class. Index: javax/swing/plaf/basic/BasicFileChooserUI.java === RCS file: /cvsroot/classpath/classpath

Re: [cp-patches]: FYI: GapContent fix

2005-09-07 Thread Lillian Angel
Silly mistake! 2005-09-07 Lillian Angel [EMAIL PROTECTED] * javax/swing/text/GapContent.java: Fixes Bug #PR22966 (getOffset): Fixed check, was redundant. On Wed, 2005-09-07 at 11:57 -0600, Tom Tromey wrote: Lillian == Lillian Angel [EMAIL PROTECTED] writes

[cp-patches]: Patch: SpringLayout fix

2005-09-07 Thread Lillian Angel
2005-09-07 Lillian Angel [EMAIL PROTECTED] * javax/swing/SpringLayout.java: Fixes Bug #PR23003 (getConstraints): Width and height should always be reset, even if constraints is not null. Constraints deal with the location of the component. Index: javax

[cp-patches]: Patch: JPopupMenu fix

2005-09-08 Thread Lillian Angel
2005-09-08 Lillian Angel [EMAIL PROTECTED] * javax/swing/JPopupMenu.java: Fixes Bug #PR23533 (setVisible): Adjusted popup menu's location depending on the size of the screen. Index: javax/swing/JPopupMenu.java

Re: [cp-patches]: Patch: JPopupMenu fix and BasicTreeUI fix

2005-09-09 Thread Lillian Angel
patch attached On Fri, 2005-09-09 at 10:45 -0400, Lillian Angel wrote: 2005-09-09 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java (installDefaults): Fixed method signature. (uninstallDefaults): Likewise. (uninstallUI): Fixed call

[cp-patches]: JTree editing

2005-09-12 Thread Lillian Angel
I added this fix because it appeared that double-clicking on a node would start editing. This was because the timer would still fire if there was no pause between clicks. 2005-09-12 Lillian Angel [EMAIL PROTECTED] * javax/swing/tree/DefaultTreeCellEditor.java (isCellEditable

[cp-patches]: Patch: JTree missing functions-

2005-09-13 Thread Lillian Angel
Added methods in JTree that were missing. 2005-09-13 Lillian Angel [EMAIL PROTECTED] * javax/swing/JTree.java (AccessibleJTree): Added new Inner class. (AccessibleJTree.addAccessibleSelection): New method. (AccessibleJTree.clearAccessibleSelection): New method

[cp-patches]: Patch: MetalTreeUI implementation, BasicTreeUI implementation updated.

2005-09-14 Thread Lillian Angel
2005-09-14 Lillian Angel [EMAIL PROTECTED] Fixes Bug #23795 * javax/swing/plaf/basic/BasicTreeUI.java: Made private fields package private. (setCellRenderer): Took out code that updateRenderer takes care of. (getPathBounds): Fixed to use treeModel

[cp-patches]: Patch: JProgressBar Fix

2005-09-14 Thread Lillian Angel
2005-09-14 Lillian Angel [EMAIL PROTECTED] * javax/swing/JProgressBar.java (JProgressBar): Fixed to use setOrientation function. * javax/swing/plaf/metal/MetalProgressBarUI.java (createUI): Was using the same instance of the UI for each new JProgressBar

[cp-patches]: Patch: JOptionPane fix

2005-09-15 Thread Lillian Angel
2005-09-15 Lillian Angel [EMAIL PROTECTED] Fixes #23873 * javax/swing/plaf/basic/BasicOptionPaneUI.java (createMessageArea): Changed orientation of message from EAST to CENTER. Also, fixed empty border values to make message more centered

Re: [cp-patches]: Patch: JOptionPane fix

2005-09-15 Thread Lillian Angel
Oops! That is just in my patch, i never committed that file. attached is the proper patch. On Thu, 2005-09-15 at 16:40 +0200, Mark Wielaard wrote: Hi Lillian, On Thu, 2005-09-15 at 10:04 -0400, Lillian Angel wrote: --- java/awt/BorderLayout.java 4 Aug 2005 18:10:44 - 1.18

[cp-patches]: Patch: JFileChooser fix

2005-09-15 Thread Lillian Angel
2005-09-15 Lillian Angel [EMAIL PROTECTED] Fixes Bug #23678 * javax/swing/plaf/basic/BasicFileChooserUI.java (CBLabelRenderer): Removed. Not in API, and it is really redundant to have. (installComponents): Changed the renderer set for the combo box

[cp-patches]: Patch: Container fix

2005-09-16 Thread Lillian Angel
2005-09-16 Lillian Angel [EMAIL PROTECTED] Fixes Bug #22610 * java/awt/Container.java (remove): Removed component listeners from the component being removed. This was a problem if that same component that was removed was added to a new component. Index

[cp-patches]: Patch: JTree accessibility

2005-09-16 Thread Lillian Angel
A couple functions are still not implemented. I will probably finish this up on monday- as well as more testing. 2005-09-16 Lillian Angel [EMAIL PROTECTED] * javax/swing/JTree.java (AccessibleJTreeNode): Fixed documentation. (addAccessibleSelection): Likewise, still

[cp-patches]: Patch: ToolTip fix

2005-09-20 Thread Lillian Angel
2005-09-20 Lillian Angel [EMAIL PROTECTED] * javax/swing/ToolTipManager.java (mouseMoved): Removed unneeded code. If the mouse moves into another component, then mouseEntered would do the same thing. Otherwise, it is not needed. (showTip): Fixed so

Re: [cp-patches]: Patch: ToolTip fix

2005-09-20 Thread Lillian Angel
I forgot to mention that tooltips are still acting up when on HeavyWeightPopup's. I am going to fix this soon. On Tue, 2005-09-20 at 17:11 -0400, Lillian Angel wrote: 2005-09-20 Lillian Angel [EMAIL PROTECTED] * javax/swing/ToolTipManager.java (mouseMoved): Removed unneeded

[cp-patches]: Patch: ToolTip fix for HeavyWeightPopups

2005-09-20 Thread Lillian Angel
2005-09-20 Lillian Angel [EMAIL PROTECTED] * javax/swing/JPopupMenu.java (setVisible): If HeavyWeightPopup, setLightWeightPopupEnabled is false. * javax/swing/ToolTipManager.java (showTip): Change so toolTips on lightWeightPopups are added

Re: [cp-patches]: FYI: ToolTip fix

2005-09-21 Thread Lillian Angel
I fixed this so the Tool Tips are painted in a better location. 2005-09-21 Lillian Angel [EMAIL PROTECTED] * javax/swing/ToolTipManager.java (showTip): Added code to move currentPoint to a new place. (getGoodPoint): Removed, not needed. On Tue, 2005-09-20 at 18:00

[cp-patches]: Patch: JOptionPane fix

2005-09-21 Thread Lillian Angel
2005-09-21 Lillian Angel [EMAIL PROTECTED] Fixes Bug #23937 * javax/swing/plaf/basic/BasicOptionPaneUI.java (propertyChange): When WANTS_INPUT_PROPERTY is changed, the buttons should be updated. (getButtons): Applied patch in bug report. Sets default

  1   2   3   4   5   >