[cp-patches] Fix for Class.getSimpleName()

2008-04-15 Thread Sebastian Mancke
Hi, attached is a fix for the method Class.getSimpleName(), together with a small testcase. The old implementation failed on usual class names, as well as on inner classes. Please comment/commit. This is my first direct classpath contribution. Do I need to sign any copyright assignment?

Re: [cp-patches] Fix for Class.getSimpleName()

2008-04-16 Thread Sebastian Mancke
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Christian Thalinger schrieb: On Tue, 2008-04-15 at 23:28 +0200, Sebastian Mancke wrote: Hi, attached is a fix for the method Class.getSimpleName(), together with a small testcase. The old implementation failed on usual class names, as well

Re: [cp-patches] Fix for Class.getSimpleName()

2008-04-16 Thread Sebastian Mancke
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Christian Thalinger schrieb: On Wed, 2008-04-16 at 10:58 +0200, Sebastian Mancke wrote: I saw this patch and think it broke the behaviour, because of the wrong usage of fullName.lastIndexOf(., pos): The pos argument, counted from left makes

Re: [cp-patches] Fix for Class.getSimpleName()

2008-04-16 Thread Sebastian Mancke
Sebastian Mancke schrieb: Christian Thalinger schrieb: On Wed, 2008-04-16 at 10:58 +0200, Sebastian Mancke wrote: I saw this patch and think it broke the behaviour, because of the wrong usage of fullName.lastIndexOf(., pos): The pos argument, counted from left makes no sense

Re: [cp-patches] Fix for Class.getSimpleName()

2008-04-17 Thread Sebastian Mancke
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mark Wielaard schrieb: Hi, On Thu, 2008-04-17 at 00:50 +0100, Andrew John Hughes wrote: As to your contribution, the Classpath part (i.e. the java.lang.Class changes, Mauve has different contribution rules) looks minor enough to not require

Re: [cp-patches] Fix for Class.getSimpleName()

2008-04-19 Thread Sebastian Mancke
Hi. Now, the method getSimpleName() is merged with the one of glibgcj. (Not changing behaviour, but avoiding recursion) The Testcase has additional checks for array types and is converted to mauve, now. I could not find regression due to my changes --Sebastian Sebastian Mancke schrieb