[cp-patches] [RFC/PATCH] Fix NPE in HashMap.put()

2011-10-24 Thread Pekka Enberg
Stefan Ring reports that commit f154af6 (Fix HashMap.put() to check for hashCode equality before equals()) breaks running the CACAO test suite for me. It looks like this: LD_LIBRARY_PATH=../../../src/cacao/.libs ../../../src/cacao/cacao

Re: [cp-patches] [RFC/PATCH] Fix NPE in HashMap.put()

2011-10-24 Thread Mark Wielaard
On Mon, 2011-10-24 at 10:11 +0300, Pekka Enberg wrote: Looking at the code, it's obviously broken for HashMap.put() with a null key. Urgh yes. @@ -345,7 +345,10 @@ public class HashMapK, V extends AbstractMapK, V while (e != null) { -if ((key.hashCode() ==

Re: [cp-patches] [RFC/PATCH] Fix NPE in HashMap.put()

2011-10-24 Thread Mark Wielaard
On Mon, 2011-10-24 at 10:24 +0200, Mark Wielaard wrote: On Mon, 2011-10-24 at 10:11 +0300, Pekka Enberg wrote: Looking at the code, it's obviously broken for HashMap.put() with a null key. Urgh yes. @@ -345,7 +345,10 @@ public class HashMapK, V extends AbstractMapK, V while

Re: [cp-patches] [RFC/PATCH] Fix NPE in HashMap.put()

2011-10-24 Thread Pekka Enberg
On Mon, Oct 24, 2011 at 11:24 AM, Mark Wielaard m...@klomp.org wrote: On Mon, 2011-10-24 at 10:11 +0300, Pekka Enberg wrote: Looking at the code, it's obviously broken for HashMap.put() with a null key. Urgh yes. @@ -345,7 +345,10 @@ public class HashMapK, V extends AbstractMapK, V      

Re: [cp-patches] [RFC/PATCH] Fix NPE in HashMap.put()

2011-10-24 Thread Mark Wielaard
On Mon, 2011-10-24 at 10:34 +0200, Mark Wielaard wrote: On Mon, 2011-10-24 at 10:24 +0200, Mark Wielaard wrote: On Mon, 2011-10-24 at 10:11 +0300, Pekka Enberg wrote: @@ -345,7 +345,10 @@ public class HashMapK, V extends AbstractMapK, V while (e != null) { -