Re: String.equals optimisation

2005-07-12 Thread Stephen Crawley
I stand corrected. -- Steve ___ Classpath mailing list Classpath@gnu.org http://lists.gnu.org/mailman/listinfo/classpath

Re: String.equals optimisation

2005-07-12 Thread Per Bothner
Stephen Crawley wrote: [EMAIL PROTECTED] said: I'd be interested to hear of other reasons for Java's requirement to intern all literal strings and constants. Backwards compatibility. At this point we can only conjecture as to why Java was originally defined this way. My guess is that

RE: String.equals optimisation

2005-07-12 Thread Jeroen Frijters
Archie Cobbs wrote: Simon Kitching wrote:. * Class.getName returns strings that have been interned. I don't think this is explicitly required by the java specs but is certainly true for Sun's JVM and seems likely to be done by any sensible JVM. I.e., is there something special

Re: String class: hack for ORP 1.0.9

2005-07-12 Thread Mark Wielaard
On Tue, 2005-07-12 at 13:02 +1200, Simon Kitching wrote: I just wondered if it was time to remove this hack... Wow, that is a very old workaround. And indeed a nice optimization to have. A quick startup of eclipse (with just a little project) shows 4642 hits of String.toCharArray() of which 4200

Re: String class: hack for ORP 1.0.9

2005-07-12 Thread David P Grove
So, I'm having a hard time seeing how this optimization actually makes the code faster under any reasonable assumptions of what an optimizing JIT is going to do. It seems mostly harmless to have it (although it makes the method larger, and thus a slightly less attractive candidate for

Re: String.equals optimisation

2005-07-12 Thread Archie Cobbs
Simon Kitching wrote: * Class.getName returns strings that have been interned. I don't think this is explicitly required by the java specs but is certainly true for Sun's JVM and seems likely to be done by any sensible JVM. You definitely make some good arguments, but this one is not

Re: String class: hack for ORP 1.0.9

2005-07-12 Thread David P Grove
Guess I'm showing my bias ;-) It is very easy to get the right thing to happen in Jikes RVM... In general, you are right about native methods being a barrier to JIT optimization (btw there was an interesting paper in VEE'05 last month by Stepanian et al on a system that can inline native

Re: String class: hack for ORP 1.0.9

2005-07-12 Thread Archie Cobbs
David P Grove wrote: So, I'm having a hard time seeing how this optimization actually makes the code faster under any reasonable assumptions of what an optimizing JIT is going to do. It seems mostly harmless to have it (although it makes the method larger, and thus a slightly less attractive

Re: String.equals optimisation

2005-07-12 Thread Robert Lougher
Hi, On 7/12/05, Archie Cobbs [EMAIL PROTECTED] wrote: Simon Kitching wrote: * Class.getName returns strings that have been interned. I don't think this is explicitly required by the java specs but is certainly true for Sun's JVM and seems likely to be done by any sensible JVM. You

Problem with JDNI (under IKVM)

2005-07-12 Thread Le.Wang
Hi, my task is to use the Joram JMS (Java Messaging Service, provider JORAM) inmy .Net(C#) application, at first I used "jbimp" from .Net, but jbimp couldnever find the classpaths which I set, today I found the tool IKVM which uses GNU Classpath, I feel the IKVM is much better, but I

Re: [cp-patches] Patch: formatting of copyrights

2005-07-12 Thread Robert Schuster
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, the patch is missing. Not that I want to peer review it, but IMHO kaffe gcj need it. cu Robert Lillian Angel wrote: 2005-07-12 Lillian Angel [EMAIL PROTECTED] * javax/swing/JTree.java: Formatting copyright *

Re: [cp-patches] FYI: ParserDelegator compatibility fix.

2005-07-12 Thread Meskauskas Audrius
Maybe. 2005-07-12 Audrius Meskauskas [EMAIL PROTECTED] * javax/swing/text/html/parser/ParserDelegator.java (gnuParser.getDTD): Added comment about 'super'. Robert Schuster wrote: could you please add a small comment that this is a workaround for 1.3's javac to make sure no one removes

[cp-patches] FYI: JTextComponent.CaretBlinkTimer fixlet

2005-07-12 Thread Mark Wielaard
Hi, From time to time the JTextComponent.CaretBlinkTimer would fire while the caret was null. Resulting in nasty exceptions. This patch guards all uses of caret in the Timer with a check to make sure the caret actually exists. 2005-07-12 Mark Wielaard [EMAIL PROTECTED] *

[cp-patches] FYI: Make MediaTRacker handle Images that didn't properly load

2005-07-12 Thread Mark Wielaard
Hi, In MediaTracker we didn't correctly handle Images that were already loaded, but that actually failed to load correctly. In such a case prepareImage() will return false immediately, but the ImageObserver will never be called. So we need an extra call to checkImage() to explicitly grab the

[cp-patches] Re: String class: hack for ORP 1.0.9

2005-07-12 Thread David P Grove
So, I'm having a hard time seeing how this optimization actually makes the code faster under any reasonable assumptions of what an optimizing JIT is going to do. It seems mostly harmless to have it (although it makes the method larger, and thus a slightly less attractive candidate for

[cp-patches] FYI: fixlet for JApplet, JDialog, JFrame, JWindow

2005-07-12 Thread Anthony Balkissoon
This is the same as Roman's JInternalFrame addImpl fixlet from yesterday. Add to the top level container itself if we're in the initialization stage, otherwise add to its content pane. Patch attached. 2005-07-12 Anthony Balkissoon [EMAIL PROTECTED] * javax/swing/JApplet.java,

[cp-patches] Patch: JTree demo

2005-07-12 Thread Lillian Angel
2005-07-11 Lillian Angel [EMAIL PROTECTED] * examples/gnu/classpath/examples/swing/Demo.java (mkTreeWorld): Implemented (mkTabbedPane): added in tab for TreeWorld * javax/swing/plaf/basic/BasicLookAndFeel.java Changed default color of text non selection

[cp-patches] FYI: fixlet for BasicLookAndFeel

2005-07-12 Thread Roman Kennke
This corrects the color values for Basic buttons. 2005-07-12 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicLookAndFeel.java (initComponentDefaults): Corrected color values for BasicLF buttons. /Roman Index: javax/swing/plaf/basic/BasicLookAndFeel.java

[cp-patches] FYI: Fixed JInternalFrame's title bar

2005-07-12 Thread Roman Kennke
Hi, I have hacked JInternalFrame's title bar in the Basic LF, so that it matches the Basic LF of the JDK more, and also fixed some behavioural aspects. For example, we had some candidates for paint/layout loops in the title bar's LayoutManager that I removed. 2005-07-12 Roman Kennke

[cp-patches] FYI: JMenu fix closes bug 13683

2005-07-12 Thread Anthony Balkissoon
Committed this patch that paints the background of a disabled JMenu properly when it is selected. This, in addition to the JMenu patches I committed yesterday, should close bug 13683. Patch is attached. 2005-07-12 Anthony Balkissoon [EMAIL PROTECTED] * javax/swing/JMenu.java: (isSelected):

[cp-patches] FYI: Cleaned up BasicInternalFrameTitlePane

2005-07-12 Thread Roman Kennke
Hi, I removed some cruft from BasicInternalFrame and fixed handling of property changes from the enclosing JInternalFrame. 2005-07-12 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicInternalFrameTitlePane.java Removed ad-hoc icons. Replaced them by

[cp-patches] [RFA/JDWP] VirtualMachineCommandSet.java

2005-07-12 Thread Aaron Luchko
Ok this is a touch more complicated but not too bad, there's also a couple possibly minor issues. This implements the VirtualMachine CommandSet http://java.sun.com/j2se/1.5.0/docs/guide/jpda/jdwp/jdwp-protocol.html#JDWP_VirtualMachine The VERSION command is the first one that is a bit of an

[cp-patches] Re: [RFA/JDWP} ObjectReferenceCommandSet.java

2005-07-12 Thread Aaron Luchko
On Tue, 2005-07-12 at 14:15 -0400, Bryce McKinlay wrote: Aaron Luchko wrote: Here's the implementation for the ObjectReference CommandSet http://java.sun.com/j2se/1.5.0/docs/guide/jpda/jdwp/jdwp-protocol.html#JDWP_ObjectReference ChangeLog 2005-07-08 Aaron Luchko [EMAIL PROTECTED]

[cp-patches] FYI: some more cleanup in JInternalFrame stuff

2005-07-12 Thread Roman Kennke
I did some more cleanup in JInternalFrame. 2005-07-12 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicInternalFrameUI.java (installDefaults): Create border based on defaults in current LookAndFeel. * javax/swing/plaf/basic/BasicLookAndFeel.java

[cp-patches] FYI: Fixed formatting of BasicTreeUI

2005-07-12 Thread Roman Kennke
This little fix spans to commits. Sorry for that. 2005-07-12 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java I accidentally introduced revalidate calls for repaint calls. Reverted. 2005-07-12 Roman Kennke [EMAIL PROTECTED] *

[cp-patches] Re: [RFA/JDWP] VirtualMachineCommandSet.java

2005-07-12 Thread Bryce McKinlay
Aaron Luchko wrote: Ok this is a touch more complicated but not too bad, there's also a couple possibly minor issues. This implements the VirtualMachine CommandSet http://java.sun.com/j2se/1.5.0/docs/guide/jpda/jdwp/jdwp-protocol.html#JDWP_VirtualMachine The VERSION command is the first one

[cp-patches] [FYI/JDWP] shutting down in PacketProcessor

2005-07-12 Thread Aaron Luchko
I've committed this patch to the trunk. This makes a minor improvement in the shutdown sequence for jdwp by having the Jdwp object itself handle the shutdown from the top level instead of PacketProcessor telling the collection (and possibly the whole VM) to exit itself. Aaron ChangeLog

[cp-patches] Patch: formatting of copyrights

2005-07-12 Thread Lillian Angel
2005-07-12 Lillian Angel [EMAIL PROTECTED] * javax/swing/JTree.java: Formatting copyright * javax/swing/tree/DefaultTreeCellRenderer.java: Formatting copyright * javax/swing/tree/DefaultTreeSelectionModel.java: Formatting copyright

[cp-patches] Patch: selection for JTree with icon

2005-07-12 Thread Lillian Angel
2005-07-12 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java (paintLeaf): fixed size of selection background to depend on if icon exists (paintNonLeaf): fixed size of selection background to depend on if icon exists Index:

[cp-patches] FYI: Patch for DefaultButtonModel relating to JToggleButtons

2005-07-12 Thread Anthony Balkissoon
This patch fixes the problem discussed in the additional comments to bug 13683: ==additional comment #1== I have discovered another bug in this testcase. If you open a menu, you can see in the taskbar that a new window with the name . has been opened. And also, on the sun vm if you

[cp-patches] Patch: Demo fix

2005-07-12 Thread Lillian Angel
2005-07-12 Lillian Angel [EMAIL PROTECTED] * examples/gnu/classpath/examples/swing/Demo.java (mkTree): no need to make root visible, it is by default (mkTreeWorld): no need to make root visible, it is by default ___

[cp-patches] FYI: buttons paramString fixes

2005-07-12 Thread Robert Schuster
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, this fixes the part of Bug #13695 (https://savannah.gnu.org/bugs/?func=detailitemitem_id=13695) which complains about the paramString() method. 2005-07-13 Robert Schuster [EMAIL PROTECTED] * javax/swing/JToggleButton.java:

[cp-patches] buttons paramString fixes #2

2005-07-12 Thread Robert Schuster
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, please forget about the first patch. This one is the same but fixes JRadioButton, too. 2005-07-13 Robert Schuster [EMAIL PROTECTED] * javax/swing/JToggleButton.java: (paramString): Returns value of same method in superclass now. *

[commit-cp] classpath ./ChangeLog javax/swing/text/html/par...

2005-07-12 Thread Audrius Me�kauskas
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Audrius Meškauskas [EMAIL PROTECTED] 05/07/12 07:15:41 Modified files: . : ChangeLog javax/swing/text/html/parser: ParserDelegator.java Log message: 2005-07-12

[commit-cp] classpath ./ChangeLog java/lang/String.java

2005-07-12 Thread Mark Wielaard
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Mark Wielaard [EMAIL PROTECTED] 05/07/12 08:53:44 Modified files: . : ChangeLog java/lang : String.java Log message: Reported by Simon Kitching [EMAIL

[commit-cp] classpath ./ChangeLog java/awt/MediaTracker.java

2005-07-12 Thread Mark Wielaard
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Mark Wielaard [EMAIL PROTECTED] 05/07/12 09:16:05 Modified files: . : ChangeLog java/awt : MediaTracker.java Log message: * java/awt/MediaTracker.java

[commit-cp] classpath ./ChangeLog javax/swing/JApplet.java ...

2005-07-12 Thread Anthony Balkissoon
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Anthony Balkissoon [EMAIL PROTECTED] 05/07/12 13:48:35 Modified files: . : ChangeLog javax/swing: JApplet.java JDialog.java JFrame.java

[commit-cp] classpath ./ChangeLog examples/gnu/classpath/ex...

2005-07-12 Thread Lillian Angel
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Lillian Angel [EMAIL PROTECTED] 05/07/12 15:23:11 Modified files: . : ChangeLog examples/gnu/classpath/examples/swing: Demo.java javax/swing/plaf/basic:

[commit-cp] classpath ./ChangeLog javax/swing/plaf/basic/Ba...

2005-07-12 Thread Roman Kennke
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Roman Kennke [EMAIL PROTECTED]05/07/12 16:57:03 Modified files: . : ChangeLog javax/swing/plaf/basic: BasicInternalFrameTitlePane.java Log message:

[commit-cp] classpath ./ChangeLog gnu/classpath/jdwp/proces...

2005-07-12 Thread Aaron Luchko
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Aaron Luchko [EMAIL PROTECTED]05/07/12 18:22:02 Modified files: . : ChangeLog Added files: gnu/classpath/jdwp/processor: ObjectReferenceCommandSet.java Log

[commit-cp] classpath ./ChangeLog javax/swing/plaf/basic/Ba...

2005-07-12 Thread Lillian Angel
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Lillian Angel [EMAIL PROTECTED] 05/07/12 18:58:01 Modified files: . : ChangeLog javax/swing/plaf/basic: BasicTreeUI.java BasicLookAndFeel.java

[commit-cp] classpath ./ChangeLog javax/swing/JTree.java ja...

2005-07-12 Thread Lillian Angel
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Lillian Angel [EMAIL PROTECTED] 05/07/12 19:26:41 Modified files: . : ChangeLog javax/swing: JTree.java javax/swing/tree: DefaultTreeCellRenderer.java

[commit-cp] classpath ./ChangeLog javax/swing/plaf/metal/Me...

2005-07-12 Thread Roman Kennke
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Roman Kennke [EMAIL PROTECTED]05/07/12 19:24:49 Modified files: . : ChangeLog javax/swing/plaf/metal: MetalTreeUI.java Log message: 2005-07-12 Roman

[commit-cp] classpath ./ChangeLog javax/swing/plaf/basic/Ba...

2005-07-12 Thread Roman Kennke
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Roman Kennke [EMAIL PROTECTED]05/07/12 19:18:51 Modified files: . : ChangeLog javax/swing/plaf/basic: BasicTreeUI.java Log message: 2005-07-12 Roman

[commit-cp] classpath ./ChangeLog gnu/classpath/jdwp/proces...

2005-07-12 Thread Aaron Luchko
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Aaron Luchko [EMAIL PROTECTED]05/07/12 19:29:46 Modified files: . : ChangeLog gnu/classpath/jdwp/processor: PacketProcessor.java Log message: *

[commit-cp] classpath ./ChangeLog javax/swing/DefaultButton...

2005-07-12 Thread Anthony Balkissoon
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Anthony Balkissoon [EMAIL PROTECTED] 05/07/12 20:19:08 Modified files: . : ChangeLog javax/swing: DefaultButtonModel.java Log message: 2005-07-12 Anthony

[commit-cp] classpath ./ChangeLog javax/swing/plaf/basic/Ba...

2005-07-12 Thread Anthony Balkissoon
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Anthony Balkissoon [EMAIL PROTECTED] 05/07/12 20:59:57 Modified files: . : ChangeLog javax/swing/plaf/basic: BasicMenuItemUI.java Log message: 2005-07-12 Anthony

[commit-cp] classpath ./ChangeLog examples/gnu/classpath/ex...

2005-07-12 Thread Lillian Angel
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Lillian Angel [EMAIL PROTECTED] 05/07/12 20:57:23 Modified files: . : ChangeLog examples/gnu/classpath/examples/swing: Demo.java Log message: 2005-07-12

[commit-cp] classpath ./ChangeLog gnu/classpath/jdwp/proces...

2005-07-12 Thread Aaron Luchko
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Aaron Luchko [EMAIL PROTECTED]05/07/12 23:40:31 Modified files: . : ChangeLog Added files: gnu/classpath/jdwp/processor: FieldCommandSet.java

[commit-cp] classpath ./ChangeLog javax/swing/JButton.java ...

2005-07-12 Thread Robert Schuster
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Robert Schuster [EMAIL PROTECTED] 05/07/13 00:34:54 Modified files: . : ChangeLog javax/swing: JButton.java JCheckBox.java JRadioButton.java