Re: Feedback on datafy/nav project

2020-01-31 Thread Derek Troy-West
Hi Dimitris. I think your library is an excellent idea. Like the other replies I'd prefer if it used Datafiable. Would you consider adopting an explicit options map instead of the jdt/now! varags destructuring? I'm not sure if that style is adopted throughout, but in general I prefer maps to

Re: Feedback on datafy/nav project

2020-01-31 Thread dimitris
Sean, I've already done that ;) I will publish to clojars either this weekend or the next - I just want to add some more tests... On 31/01/2020 21:34, Sean Corfield wrote: Dimitris, As a follow-up to Alex’s comments: if you change your lib to extend the clojure.datafy version, I’ll

RE: Feedback on datafy/nav project

2020-01-31 Thread Sean Corfield
Dimitris, As a follow-up to Alex’s comments: if you change your lib to extend the clojure.datafy version, I’ll almost certainly use your library  Sean Corfield -- (904) 302-SEAN An Architect's View -- http://corfield.org/ "If you're not annoying somebody, you're not really alive." --

Re: Feedback on datafy/nav project

2020-01-31 Thread dimitris
Ok, thanks a million Alex On 31/01/2020 21:13, Alex Miller wrote: Datafiable is not special, the guidelines (recently refreshed with Rich's input at https://clojure.org/reference/protocols#_guidelines_for_extension) still make sense, but are still just guidelines for your thinking not Laws

Re: Recursively convert Java Map to Clojure Map

2020-01-31 Thread Jason Ross
Thanks for the reply. I do need to convert to java hashmaps and arraylists because I'm trying to duplicate the testing of a clojure workflow being run on a server thats pushing pure java context through it. So in my tests I define a clojure map but want to javafy it to force errors to happen

Re: Recursively convert Java Map to Clojure Map

2020-01-31 Thread Alex Miller
You don't need that - Clojure maps *are* Java maps (they implement java.util.Map) and you can pass them into most Java APIs as is (with the caveat that they are made for reading, not for writing). If you did really want to convert them to hash-maps or whatever, it's pretty easy to do so with a

Re: Feedback on datafy/nav project

2020-01-31 Thread Alex Miller
Datafiable is not special, the guidelines (recently refreshed with Rich's input at https://clojure.org/reference/protocols#_guidelines_for_extension) still make sense, but are still just guidelines for your thinking not Laws whose breakage will land you in Clojure Jail. If you want to make

Re: Recursively convert Java Map to Clojure Map

2020-01-31 Thread Jason Ross
Hey I know this is super old post but what would the reverse look like, eg. recursively convert Clojure to java map On Saturday, October 15, 2011 at 4:10:32 AM UTC-5, Baishampayan Ghose wrote: > > > I have a Java Map contains Map of Maps/List (JSON like map) and have > > to convert to Clojure

Re: Feedback on datafy/nav project

2020-01-31 Thread dimitris
I tend to agree with you in where the benefit is - it's just that the way the protocol docs are phrased, and some of the language used in that mailing discussion from 10 years ago (from authoritative sources like Rich and Stuart), implies that /no library is to extend clojure.core protocols to