Re: [Cloud-init-dev] [Merge] ~goneri/cloud-init:freebsd_nocloud into cloud-init:master

it might be useful to have some test cases that cover the linux way using blkid and having a case that covers the FreeBSD way so future addition/changes to the data source don't break things up again without noticing. apart from that - looking at the code diff without really testing it - the

Re: [Cloud-init-dev] [Merge] ~goneri/cloud-init:build-on-freebsd into cloud-init:master

i wonder if tools/build-on-freebsd could not be dropped completely as there is an official freshport in the meanwhile: https://www.freshports.org/net/cloud-init/ the port is version 18.3 and includes just some FreeBSD specific patches out of which i know some are 100% obsolete in the

Re: [Cloud-init-dev] [Merge] ~liaoishere/cloud-init:sysconfig-bond-options into cloud-init:master

Thanks for looking at extending these options. Could you look at the existing unittests for sysconfig bond rendering in tests/unittests/test_net.py and extend that with some of the additional values. -- https://code.launchpad.net/~liaoishere/cloud-init/+git/cloud-init/+merge/366377 Your

Re: [Cloud-init-dev] [Merge] ~goneri/cloud-init:build-on-freebsd into cloud-init:master

I use the following script to prepare my FreeBSD images, my freebsd branch comes with all the patches from my different branches: https://github.com/virt-lightning/freebsd-cloud-images Python3 is on my TODO list, with a lower priority. If you open a bug, you can affect it to me. --

Re: [Cloud-init-dev] [Merge] ~goneri/cloud-init:build-on-freebsd into cloud-init:master

This looks like a reasonable set of changes to me; is there any good way for me to test it? (Perhaps in a container/public cloud?) Also, do we need to open a bug for converting this script to Python 3 in preparation for dropping Python 2 support from cloud-init[0]? [0]

Re: [Cloud-init-dev] [Merge] ~rjschwei/cloud-init:triggerudev into cloud-init:master

Diff comments: > diff --git a/cloudinit/net/sysconfig.py b/cloudinit/net/sysconfig.py > index 0998392..5f6f2d8 100644 > --- a/cloudinit/net/sysconfig.py > +++ b/cloudinit/net/sysconfig.py > @@ -696,6 +696,14 @@ class Renderer(renderer.Renderer): > if nm_conf_content: >

Re: [Cloud-init-dev] [Merge] ~rjschwei/cloud-init:triggerudev into cloud-init:master

Diff comments: > diff --git a/cloudinit/net/sysconfig.py b/cloudinit/net/sysconfig.py > index 0998392..5f6f2d8 100644 > --- a/cloudinit/net/sysconfig.py > +++ b/cloudinit/net/sysconfig.py > @@ -696,6 +696,14 @@ class Renderer(renderer.Renderer): > if nm_conf_content: >

[Cloud-init-dev] [Merge] ~liaoishere/cloud-init:sysconfig-bond-options into cloud-init:master

Liao Penghui has proposed merging ~liaoishere/cloud-init:sysconfig-bond-options into cloud-init:master. Commit message: Support more bonding options for sysconfig system. Currently, only a few bonding parameters can be configured on sysconfig systems. This patch aims to support more parameters