Re: Review Request: fix bug CLOUDSTACK-1531: vmware create volume from snapshot will missing data for master

2013-03-16 Thread Hongtu Zang
applied in master This addresses bug CLOUDSTACK-1531. Diffs - plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java e11dd53 Diff: https://reviews.apache.org/r/9989/diff/ Testing --- Thanks, Hongtu Zang

Review Request:

2013-03-15 Thread Hongtu Zang
e11dd53 Diff: https://reviews.apache.org/r/9989/diff/ Testing --- Thanks, Hongtu Zang

Re: Review Request: fix bug CLOUDSTACK-1531: vmware create volume from snapshot will missing data

2013-03-15 Thread Hongtu Zang
files 4. take another snapshot s2, and detach v0 5. create volume v1 from s1 and then create volume v2 from s2 Success. v1 and v2 has different data. v1 doesn't contains partition and v2 has files I touched. Thanks, Hongtu Zang

Re: Review Request: fix bug CLOUDSTACK-1531: vmware create volume from snapshot will missing data

2013-03-14 Thread Hongtu Zang
another snapshot s2, and detach v0 5. create volume v1 from s1 and then create volume v2 from s2 Success. v1 and v2 has different data. v1 doesn't contains partition and v2 has files I touched. Thanks, Hongtu Zang

Review Request: fix CLOUDSTACK-1649

2013-03-12 Thread Hongtu Zang
Diff: https://reviews.apache.org/r/9879/diff/ Testing --- Upload a redhat 5.1 iso start a vm with it. check the os type in vsphere client, the os type is red hat not the other 64. Thanks, Hongtu Zang

[jira] [Resolved] (CLOUDSTACK-1334) vmware.root.disk.controller doesn't work.

2013-02-21 Thread Hongtu Zang (JIRA)
[ https://issues.apache.org/jira/browse/CLOUDSTACK-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongtu Zang resolved CLOUDSTACK-1334. - Resolution: Fixed commit f7b600b43921ee2324e049432c9cf18906fc6772

[jira] [Created] (CLOUDSTACK-1334) vmware.root.disk.controller doesn't work.

2013-02-19 Thread Hongtu Zang (JIRA)
Hongtu Zang created CLOUDSTACK-1334: --- Summary: vmware.root.disk.controller doesn't work. Key: CLOUDSTACK-1334 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1334 Project: CloudStack

Review Request: fix CLOUDSTACK-1334:vmware.root.disk.controller doesn't work

2013-02-19 Thread Hongtu Zang
/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java e6d5742 Diff: https://reviews.apache.org/r/9519/diff/ Testing --- try to modify the vmware.root.disk.controller value. it works after the vm stopped and start again. Thanks, Hongtu Zang

[jira] [Commented] (CLOUDSTACK-1334) vmware.root.disk.controller doesn't work.

2013-02-19 Thread Hongtu Zang (JIRA)
[ https://issues.apache.org/jira/browse/CLOUDSTACK-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13581875#comment-13581875 ] Hongtu Zang commented on CLOUDSTACK-1334: - I tried to fix it. https

[jira] [Commented] (CLOUDSTACK-1240) Unable to registerTemplate : Cannot find template adapter for XenServer

2013-02-13 Thread Hongtu Zang (JIRA)
[ https://issues.apache.org/jira/browse/CLOUDSTACK-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577430#comment-13577430 ] Hongtu Zang commented on CLOUDSTACK-1240: - I fixed this bug

Re: Review Request: fix bug 1237 and 1240 : Register Template fails with Cannot find template adapter for XenServer

2013-02-13 Thread Hongtu Zang
the patch. - Hongtu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9420/#review16509 --- On Feb. 13, 2013, 5:07 a.m., Hongtu Zang wrote

Re: Review Request: fix bug 1237 and 1240 : Register Template fails with Cannot find template adapter for XenServer

2013-02-13 Thread Hongtu Zang
://reviews.apache.org/r/9420/diff/ Testing --- register a template and start a vm. success. Thanks, Hongtu Zang

Review Request: fix bug 1237 and 1240 : Register Template fails with Cannot find template adapter for XenServer

2013-02-12 Thread Hongtu Zang
-1237 and CLOUDSTACK-1240. Diffs - server/src/com/cloud/template/TemplateAdapter.java 19cfef0 Diff: https://reviews.apache.org/r/9420/diff/ Testing --- register a template and start a vm. success. Thanks, Hongtu Zang

[jira] [Commented] (CLOUDSTACK-1237) Register Template fails with Cannot find template adapter for XenServer

2013-02-12 Thread Hongtu Zang (JIRA)
[ https://issues.apache.org/jira/browse/CLOUDSTACK-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577338#comment-13577338 ] Hongtu Zang commented on CLOUDSTACK-1237: - I fixed this bug

[jira] [Commented] (CLOUDSTACK-1239) Unable to registerISO :unhandled exception executing api command: registerIso

2013-02-12 Thread Hongtu Zang (JIRA)
[ https://issues.apache.org/jira/browse/CLOUDSTACK-1239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577340#comment-13577340 ] Hongtu Zang commented on CLOUDSTACK-1239: - I think it's duplicate with issue

[jira] [Commented] (CLOUDSTACK-449) Disk I/O polling for instances

2013-02-08 Thread Hongtu Zang (JIRA)
[ https://issues.apache.org/jira/browse/CLOUDSTACK-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13574655#comment-13574655 ] Hongtu Zang commented on CLOUDSTACK-449: It's long time no updated. Do we

Re: Review Request: CLOUDSTACK-644 add vmware resizeVolume support

2013-02-06 Thread Hongtu Zang
, the vsphere will throw an exception, I add a check in the code before resize volume. If the newSize is smaller, it will return false. Thanks, Hongtu Zang

Re: Review Request: CLOUDSTACK-644 add vmware resizeVolume support

2013-02-05 Thread Hongtu Zang
is changed. If we try to shrink the volume, the vsphere will throw an exception, I add a check in the code before resize volume. If the newSize is smaller, it will return false. Thanks, Hongtu Zang

Re: Review Request: CLOUDSTACK-644 add vmware resizeVolume support

2013-02-05 Thread Hongtu Zang
, 2013, 1:57 a.m., Hongtu Zang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9241/ --- (Updated Feb. 6, 2013, 1:57 a.m

Re: Review Request: add ui for resize volume

2013-02-04 Thread Hongtu Zang
Diff: https://reviews.apache.org/r/9298/diff/ Testing --- Input newSize and newOfferingId. The api will be sent and returns correct. NewSize should be GB and newOfferingId find in database, not the uuid. Thanks, Hongtu Zang

[jira] [Commented] (CLOUDSTACK-644) Resize volumes feature

2013-02-01 Thread Hongtu Zang (JIRA)
[ https://issues.apache.org/jira/browse/CLOUDSTACK-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568571#comment-13568571 ] Hongtu Zang commented on CLOUDSTACK-644: I can add resizeVolume support

[jira] [Commented] (CLOUDSTACK-644) Resize volumes feature

2013-02-01 Thread Hongtu Zang (JIRA)
[ https://issues.apache.org/jira/browse/CLOUDSTACK-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568590#comment-13568590 ] Hongtu Zang commented on CLOUDSTACK-644: https://reviews.apache.org/r/9241

Review Request: CLOUDSTACK-644 add vmware resizeVolume support

2013-02-01 Thread Hongtu Zang
, it will return false. Thanks, Hongtu Zang

Re: Review Request: CLOUDSTACK-644 add vmware resizeVolume support

2013-02-01 Thread Hongtu Zang
will throw an exception, I add a check in the code before resize volume. If the newSize is smaller, it will return false. Thanks, Hongtu Zang

Re: Review Request: CLOUDSTACK-644 add vmware resizeVolume support

2013-02-01 Thread Hongtu Zang
it. - Hongtu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9241/#review16009 --- On Feb. 1, 2013, 9:23 a.m., Hongtu Zang wrote

Re: Review Request: CLOUDSTACK-644 add vmware resizeVolume support

2013-02-01 Thread Hongtu Zang
. Reboot the vm and use fdisk to check the disk size, we found the size is changed. If we try to shrink the volume, the vsphere will throw an exception, I add a check in the code before resize volume. If the newSize is smaller, it will return false. Thanks, Hongtu Zang

Re: Review Request: CLOUDSTACK-644 add vmware resizeVolume support

2013-02-01 Thread Hongtu Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9241/#review15998 --- On Feb. 2, 2013, 12:59 a.m., Hongtu Zang wrote