Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a template is created from a snapshot

2013-03-11 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8900/ --- (Updated March 11, 2013, 10:43 a.m.) Review request for cloudstack, Devdeep

Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a template is created from a snapshot

2013-03-11 Thread Nitin Mehta
Pushed with commit 75261eb317a763114a6054664f4adf3f7a2c2709 Please build and run it at your end From: Saksham Srivastava saksham.srivast...@citrix.commailto:saksham.srivast...@citrix.com Reply-To: Saksham Srivastava saksham.srivast...@citrix.commailto:saksham.srivast...@citrix.com To: Nitin

Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a template is created from a snapshot

2013-03-05 Thread Nitin Mehta
Hi Animesh, Saksham is supposed to send a rebased request to me. Below is what he wrote to me. The code has changed a lot after the storage refactoring. I will submit a new patch after resolving the conflicts. Saksham On Thursday 28 February 2013 12:03 PM, Nitin Mehta wrote:

RE: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a template is created from a snapshot

2013-03-05 Thread Animesh Chaturvedi
Ok thanks for following up Animesh -Original Message- From: Nitin Mehta Sent: Tuesday, March 05, 2013 12:00 AM To: Animesh Chaturvedi; cloudstack-dev@incubator.apache.org; Saksham Srivastava; Devdeep Singh; Abhinandan Prateek Subject: Re: Review Request: CLOUDSTACK-924:

RE: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a template is created from a snapshot

2013-02-28 Thread Animesh Chaturvedi
Nitin This has been pending your review since couple of days. Please attend to this review and close it Animesh -Original Message- From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] Sent: Wednesday, February 13, 2013 7:34 PM To: Saksham Srivastava; Nitin Mehta; Devdeep

RE: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a template is created from a snapshot

2013-02-13 Thread Animesh Chaturvedi
Nitin Please review the updates patch and commit if satisfied -Original Message- From: Saksham Srivastava [mailto:nore...@reviews.apache.org] On Behalf Of Saksham Srivastava Sent: Monday, February 11, 2013 3:38 AM To: Nitin Mehta; Devdeep Singh Cc: Saksham Srivastava; cloudstack

Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a template is created from a snapshot

2013-02-11 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8900/ --- (Updated Feb. 11, 2013, 11:35 a.m.) Review request for cloudstack and Devdeep

Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a template is created from a snapshot

2013-02-11 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8900/ --- (Updated Feb. 11, 2013, 11:37 a.m.) Review request for cloudstack, Devdeep

Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a template is created from a snapshot

2013-02-06 Thread Nitin Mehta
On Jan. 9, 2013, 8:43 a.m., Nitin Mehta wrote: You need to take care of migration as well. Any thoughts on that ? Saksham Srivastava wrote: The fix is only for the new volumes which are created from snapshots which were themselves created from volumes which have a non-null template

Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a template is created from a snapshot

2013-01-09 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8900/#review15181 --- You need to take care of migration as well. Any thoughts on that ?

Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a template is created from a snapshot

2013-01-09 Thread saksham srivastava
On Jan. 9, 2013, 8:43 a.m., Nitin Mehta wrote: You need to take care of migration as well. Any thoughts on that ? The fix is only for the new volumes which are created from snapshots which were themselves created from volumes which have a non-null template id. In case of parent volume

Re: Review Request: CLOUDSTACK-924: source_template_id set to NULL when a template is created from a snapshot

2013-01-09 Thread Nitin Mehta
Exactly, so this is not a full fledged fix. Do you have a plan in mind to take care of volumes already facing this issue ? Remember that the volumes created from ISO will also have template_id as null so I understand that this is a bit tricky. From: Saksham Srivastava