Re: Review Request: CloudStack-965: When a detailview action is prohibited, the operation dialog box should not show up in the mean time

2013-01-26 Thread Pranav Saxena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8992/#review15734 --- Ship it! Isaac , Thanks for the updated patch . Now , the code

Re: Review Request: CloudStack-965: When a detailview action is prohibited, the operation dialog box should not show up in the mean time

2013-01-26 Thread Pranav Saxena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8992/#review15735 --- Patch merged with asf/master - Commit -

Re: Review Request: CloudStack-965: When a detailview action is prohibited, the operation dialog box should not show up in the mean time

2013-01-25 Thread Isaac Chiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8992/ --- (Updated Jan. 25, 2013, 9:33 a.m.) Review request for cloudstack and Pranav

Re: Review Request: CloudStack-965: When a detailview action is prohibited, the operation dialog box should not show up in the mean time

2013-01-24 Thread Pranav Saxena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8992/#review15638 --- Hey Isaac, I reviewed your patch but it seems there is some

Re: Review Request: CloudStack-965: When a detailview action is prohibited, the operation dialog box should not show up in the mean time

2013-01-24 Thread Isaac Chiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8992/ --- (Updated Jan. 24, 2013, 1:58 p.m.) Review request for cloudstack and Pranav

Re: Review Request: CloudStack-965: When a detailview action is prohibited, the operation dialog box should not show up in the mean time

2013-01-24 Thread Pranav Saxena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8992/#review15643 --- Hey Isaac , Thanks for the updated patch . It seems to be working

Re: Review Request: CloudStack-965: When a detailview action is prohibited, the operation dialog box should not show up in the mean time

2013-01-24 Thread Isaac Chiang
On Jan. 24, 2013, 3 p.m., Pranav Saxena wrote: Hey Isaac , Thanks for the updated patch . It seems to be working fine and applies cleanly . However I have one minor concern before I apply it - The overlay div while clicking on any button which would create a form like Register

Re: Review Request: CloudStack-965: When a detailview action is prohibited, the operation dialog box should not show up in the mean time

2013-01-21 Thread Isaac Chiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8992/ --- (Updated Jan. 21, 2013, 12:04 p.m.) Review request for cloudstack and Pranav

RE: Review Request: CloudStack-965: When a detailview action is prohibited, the operation dialog box should not show up in the mean time

2013-01-18 Thread Pranav Saxena
Isaac, I really appreciate for all your efforts . Your patch looks good just that the refactoring of the code seemed to be a point of concern . I tested your patch and it seemed to be working fine . Perhaps you could send an updated patch by removing the whitespace errors and I can push it to

Re: Review Request: CloudStack-965: When a detailview action is prohibited, the operation dialog box should not show up in the mean time

2013-01-17 Thread Pranav Saxena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8992/#review15452 --- Your code changes look good . However , I have few concerns - 1)