On March 14, 2013, 3:59 a.m., Hiroaki Kawai wrote:
server/src/com/cloud/network/NetworkManagerImpl.java, line 1773
https://reviews.apache.org/r/9898/diff/1/?file=270127#file270127line1773
NetworkElement should be always called after NetworkGuru, isn't it?
Dave Cahill wrote:
On March 14, 2013, 3:59 a.m., Hiroaki Kawai wrote:
server/src/com/cloud/network/NetworkManagerImpl.java, line 1773
https://reviews.apache.org/r/9898/diff/1/?file=270127#file270127line1773
NetworkElement should be always called after NetworkGuru, isn't it?
Dave Cahill wrote:
On March 14, 2013, 3:59 a.m., Hiroaki Kawai wrote:
The patch set is so big that it is hard to review. It would be nice to
separate it into management-server, plugin, agent plugin and UI.
Thanks for the review Kawai-san!
With regard to the patch size, we followed the example of the Big
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9898/#review17865
---
deps/install-non-oss.sh
On March 14, 2013, 8:15 a.m., Hugo Trippaers wrote:
Hi Hugo, thanks for the quick review reply.
On March 14, 2013, 8:15 a.m., Hugo Trippaers wrote:
deps/install-non-oss.sh, line 19
https://reviews.apache.org/r/9898/diff/1/?file=270113#file270113line19
I'm not really thrilled
On March 14, 2013, 8:15 a.m., Hugo Trippaers wrote:
deps/install-non-oss.sh, line 19
https://reviews.apache.org/r/9898/diff/1/?file=270113#file270113line19
I'm not really thrilled by adding components to the non-oss build.
What are the possibilities of making the the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9898/#review17849
---
The patch set is so big that it is hard to review. It would be nice
