Re: Review Request: (CLOUDSTACK-1088) EnableStaticNat error will clear the data in database

2013-02-13 Thread Prasanna Santhanam
On Tue, Feb 12, 2013 at 02:12:21AM -0500, Animesh Chaturvedi wrote: Prasanna Can you review the updated patch and if it looks good apply it to master and close the item Pushed to reqd branches. Let's use the practice however to enforce that whoever marks ship it ideally commits the patch

RE: Review Request: (CLOUDSTACK-1088) EnableStaticNat error will clear the data in database

2013-02-12 Thread Animesh Chaturvedi
Prasanna any updates? -Original Message- From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] Sent: Monday, February 11, 2013 11:12 PM To: Wei Zhou; cloudstack-dev@incubator.apache.org; Prasanna Santhanam Subject: RE: Review Request: (CLOUDSTACK-1088) EnableStaticNat error

Re: Review Request: (CLOUDSTACK-1088) EnableStaticNat error will clear the data in database

2013-02-11 Thread Wei Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9254/ --- (Updated Feb. 11, 2013, 10:10 a.m.) Review request for cloudstack, Prasanna

RE: Review Request: (CLOUDSTACK-1088) EnableStaticNat error will clear the data in database

2013-02-11 Thread Animesh Chaturvedi
Prasanna Can you review the updated patch and if it looks good apply it to master and close the item Thanks Animesh -Original Message- From: Wei Zhou [mailto:nore...@reviews.apache.org] On Behalf Of Wei Zhou Sent: Monday, February 11, 2013 2:10 AM To: Prasanna Santhanam; Jessica

Re: Review Request: (CLOUDSTACK-1088) EnableStaticNat error will clear the data in database

2013-02-09 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9254/#review16387 --- The patch applies on 4.0 but not on master. Also could you use git

Re: Review Request: (CLOUDSTACK-1088) EnableStaticNat error will clear the data in database

2013-02-08 Thread Wei Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9254/ --- (Updated Feb. 8, 2013, 9:18 a.m.) Review request for cloudstack, Prasanna

Re: Review Request: (CLOUDSTACK-1088) EnableStaticNat error will clear the data in database

2013-02-05 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9254/#review16105 --- Wei, thanks for the patch. But can you prevent addition of a boolean

Re: Review Request: (CLOUDSTACK-1088) EnableStaticNat error will clear the data in database

2013-02-05 Thread Wei Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9254/ --- (Updated Feb. 5, 2013, 4 p.m.) Review request for cloudstack, Prasanna

Re: Review Request: (CLOUDSTACK-1088) EnableStaticNat error will clear the data in database

2013-02-05 Thread Wei Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9254/ --- (Updated Feb. 5, 2013, 4:02 p.m.) Review request for cloudstack, Prasanna

Re: Review Request: (CLOUDSTACK-1088) EnableStaticNat error will clear the data in database

2013-02-05 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9254/#review16152 --- Ship it! Ship It! - Chiradeep Vittal On Feb. 5, 2013, 4:02 p.m.,

Review Request: (CLOUDSTACK-1088) EnableStaticNat error will clear the data in database

2013-02-01 Thread Wei ZHOU
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9254/ --- Review request for cloudstack, Prasanna Santhanam, Jessica Wang, and Alena

Re: Review Request: (CLOUDSTACK-1088) EnableStaticNat error will clear the data in database

2013-02-01 Thread Wei ZHOU
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9254/ --- (Updated Feb. 1, 2013, 2:36 p.m.) Review request for cloudstack, Prasanna