---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9165/
---
(Updated March 15, 2013, 10:54 a.m.)
Review request for cloudstack, Sateesh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9165/
---
(Updated March 15, 2013, 1:20 p.m.)
Review request for cloudstack, Sateesh
On March 14, 2013, 3:12 p.m., Vijay Venkatachalam wrote:
Ship It!
Thanks Vijay for the comments
- Rajesh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9165/#review17874
On March 12, 2013, 1:59 p.m., Vijay Venkatachalam wrote:
server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java, line 773
https://reviews.apache.org/r/9165/diff/5/?file=269507#file269507line773
In AWS, health checks are collected for every LBrule. In upgrade case
the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9165/
---
(Updated March 14, 2013, 12:36 p.m.)
Review request for cloudstack and Vijay
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9165/#review17874
---
Ship it!
Ship It!
- Vijay Venkatachalam
On March 14, 2013, 12:36
: Review Request: AWS Style HealthCheck feature BugID : 664
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9165/#review17874
---
Ship
On March 12, 2013, 1:59 p.m., Vijay Venkatachalam wrote:
server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java, line 780
https://reviews.apache.org/r/9165/diff/5/?file=269507#file269507line780
Are you using provider?
Not using it. unused one
- Rajesh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9165/
---
(Updated March 13, 2013, 9:49 a.m.)
Review request for cloudstack and Vijay
On March 6, 2013, 12:40 p.m., Vijay Venkatachalam wrote:
server/src/com/cloud/network/dao/LBHealthCheckPolicyDaoImpl.java, line 62
https://reviews.apache.org/r/9165/diff/4/?file=266232#file266232line62
Looks like an unused public function
Am using this method LBRulesManagerImpl.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9165/
---
(Updated March 12, 2013, 7:42 a.m.)
Review request for cloudstack and Vijay
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9165/#review17734
---
server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9165/#review17454
---
On March 1, 2013, 4:06 p.m., Vijay Venkatachalam wrote:
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java,
line 481
https://reviews.apache.org/r/9165/diff/3/?file=263578#file263578line481
Monitor name required to be passed here.
monitor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9165/
---
(Updated March 5, 2013, 6:56 p.m.)
Review request for cloudstack and Vijay
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9165/
---
(Updated March 1, 2013, 9:07 a.m.)
Review request for cloudstack and Vijay
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9165/#review17237
---
api/src/com/cloud/network/lb/LoadBalancingRule.java
To: Vijay Venkatachalam
Cc: Rajesh Battala; cloudstack
Subject: Re: Review Request: AWS Style HealthCheck feature BugID : 664
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9165/#review17237
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9165/#review17241
---
api/src/com/cloud/agent/api/to/LoadBalancerTO.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9165/
---
(Updated Feb. 28, 2013, 11 a.m.)
Review request for cloudstack.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9165/
---
(Updated Feb. 27, 2013, 12:26 p.m.)
Review request for cloudstack.
Changes
On Jan. 30, 2013, 11:24 p.m., Chiradeep Vittal wrote:
Can you
a. ensure there are no tabs
b. ensure that you do not use printStackTrace() any where
c. Document the service interface
d. avoid putting code into NetworkManagerImpl.java
e. Remove unneeded imports
f. fix indentations
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9165/
---
Review request for cloudstack.
Description
---
Code Review for AWS Style
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9165/#review15898
---
Can you
a. ensure there are no tabs
b. ensure that you do not use
24 matches
Mail list logo
