Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-09-06 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6473/#review11086 --- Ship it! I committed this to master. I did not see JmDns in the

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-09-06 Thread Chip Childers
Hey all, Can I ask a favor, which is to not edit the NOTICE and LICENSE files directly? I'm trying to keep things structured within the tools/whisker/descriptor.xml file, so that the LICENSE and NOTICE are generated from that structured data. I'll take a look at the change in the commit, and

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-09-06 Thread Chip Childers
On Thu, Sep 6, 2012 at 12:54 PM, Chiradeep Vittal chiradeep.vit...@citrix.com wrote: Sorry about that. I should have been more careful. No worries! It's fixed in master. On 9/6/12 8:37 AM, Chip Childers chip.child...@sungard.com wrote: And actually, after looking at the commit, the licensing

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-09-05 Thread Jamshid Afshar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6473/ --- (Updated Sept. 6, 2012, 12:07 a.m.) Review request for cloudstack. Changes

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-09-04 Thread Jamshid Afshar
On Aug. 15, 2012, 6:56 p.m., Chiradeep Vittal wrote: Jamshid, the jar files download as zero bytes. Can you put them up somewhere where I can download them from? David Nalley wrote: Please DO NOT add more binary jars to the source repo. That is a backwards step in our efforts to

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-09-04 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6473/#review11037 --- Jamshid, could you re-submit patches against latest master? I am

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-09-04 Thread Jamshid Afshar
On Sept. 4, 2012, 10:11 p.m., Chiradeep Vittal wrote: Jamshid, could you re-submit patches against latest master? I am also looking for the build file (pom.xml) changes. I believe adding this to pom.xml is all that is needed, though CAStorSDK doesn't seem to have sync'd to the central

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-09-04 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6473/#review11040 --- I think that since Rajesh removed the Hibernate dependency, the

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-09-04 Thread Jamshid Afshar
On Sept. 4, 2012, 10:26 p.m., Chiradeep Vittal wrote: I think that since Rajesh removed the Hibernate dependency, the patch does not merge clean any more. Hence I am requesting a clean patch. Okay, I'll try again... - Jamshid ---

RE: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-08-23 Thread Sudha Ponnaganti
support for Caringo's CAStor object storage as the S3 backend. --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6473/ --- (Updated Aug. 23, 2012

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-08-15 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6473/#review10349 --- Ship it! Ship It! - Chiradeep Vittal On Aug. 15, 2012, 2:29

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-08-15 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6473/#review10358 --- Jamshid, the jar files download as zero bytes. Can you put them up

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-08-15 Thread David Nalley
On Aug. 15, 2012, 6:56 p.m., Chiradeep Vittal wrote: Jamshid, the jar files download as zero bytes. Can you put them up somewhere where I can download them from? Please DO NOT add more binary jars to the source repo. That is a backwards step in our efforts to clean up the source repo.

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-08-14 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6473/#review10312 --- awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-08-14 Thread Jamshid Afshar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6473/ --- (Updated Aug. 15, 2012, 2:29 a.m.) Review request for cloudstack. Changes

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-08-14 Thread Jamshid Afshar
On Aug. 14, 2012, 10:18 p.m., Chiradeep Vittal wrote: awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java, line 72 https://reviews.apache.org/r/6473/diff/2/?file=135872#file135872line72 This logic seems suspect: if the port is not specified or if only the port is specified.

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-08-10 Thread Ewan Mellor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6473/#review10157 --- Jamshid, what is the license on CAStorSDK.jar and jmdns-2.1.jar? I

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-08-10 Thread Ewan Mellor
On Aug. 10, 2012, 10:52 p.m., Ewan Mellor wrote: Jamshid, what is the license on CAStorSDK.jar and jmdns-2.1.jar? I presume CAStorSDK is one that you own -- what about the other one? The license on dependent libraries affects whether we can build the code as part of the default

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-08-10 Thread Jamshid Afshar
On Aug. 10, 2012, 10:52 p.m., Ewan Mellor wrote: Jamshid, what is the license on CAStorSDK.jar and jmdns-2.1.jar? I presume CAStorSDK is one that you own -- what about the other one? The license on dependent libraries affects whether we can build the code as part of the default

Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-08-08 Thread Jamshid Afshar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6473/ --- Review request for cloudstack. Description --- Below is the commit

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-08-08 Thread David Nalley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6473/#review10028 --- First, thanks for the patch. I haven't looked deeply in this, but

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-08-08 Thread Jamshid Afshar
On Aug. 8, 2012, 6:36 p.m., David Nalley wrote: First, thanks for the patch. I haven't looked deeply in this, but noticed the license header in one of the files needs some work, see the below for more information: http://www.apache.org/legal/src-headers.html If you have questions,

RE: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-08-08 Thread Edison Su
-Original Message- From: Jamshid Afshar [mailto:nore...@reviews.apache.org] On Behalf Of Jamshid Afshar Sent: Wednesday, August 08, 2012 12:29 PM To: cloudstack; David Nalley; Jamshid Afshar Subject: Re: Review Request: Add initial support for Caringo's CAStor object storage