Re: Review Request: Add the ability to specify different VIF drivers per traffic type in KVM

2013-03-04 Thread Hugo Trippaers
On March 2, 2013, 1:10 a.m., edison su wrote: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java, line 802 https://reviews.apache.org/r/9604/diff/1/?file=262223#file262223line802 Wondering, what's the purpose of network.bridge.type used

Re: Review Request: Add the ability to specify different VIF drivers per traffic type in KVM

2013-03-04 Thread Hugo Trippaers
On March 1, 2013, 7:36 p.m., Hugo Trippaers wrote: Dave, looks good. Couple of questions though, there is some bridge specific code in LibvirtComputingResource that checks existence of interfaces and such. Shouldn't that code also be modified to support multiple drivers per nic?

Re: Review Request: Add the ability to specify different VIF drivers per traffic type in KVM

2013-03-04 Thread edison su
On March 2, 2013, 1:10 a.m., edison su wrote: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java, line 802 https://reviews.apache.org/r/9604/diff/1/?file=262223#file262223line802 Wondering, what's the purpose of network.bridge.type used

Re: Review Request: Add the ability to specify different VIF drivers per traffic type in KVM

2013-03-04 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9604/#review17353 --- Ship it! Ship It! - Hugo Trippaers On March 1, 2013, 7:46 a.m.,

Re: Review Request: Add the ability to specify different VIF drivers per traffic type in KVM

2013-03-04 Thread Hugo Trippaers
On March 4, 2013, 7:53 p.m., Hugo Trippaers wrote: Ship It! commit in master: ff099fa651e8476220332d7e1cc4b24746802cfe Dave, can you update the documentation in docs for the bits you changed? - Hugo --- This is an automatically

Re: Review Request: Add the ability to specify different VIF drivers per traffic type in KVM

2013-03-04 Thread Dave Cahill
On March 4, 2013, 7:53 p.m., Hugo Trippaers wrote: Ship It! Hugo Trippaers wrote: commit in master: ff099fa651e8476220332d7e1cc4b24746802cfe Dave, can you update the documentation in docs for the bits you changed? Sure - I've left CLOUDSTACK-1311 open for now; I'll make

Re: Review Request: Add the ability to specify different VIF drivers per traffic type in KVM

2013-03-01 Thread Wido den Hollander
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9604/#review17231 --- Ship it! Looks good to me. Hugo did the most work in this corner,

Re: Review Request: Add the ability to specify different VIF drivers per traffic type in KVM

2013-03-01 Thread edison su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9604/#review17293 ---

Re: Review Request: Add the ability to specify different VIF drivers per traffic type in KVM

2013-03-01 Thread Dave Cahill
On March 1, 2013, 7:36 p.m., Hugo Trippaers wrote: Dave, looks good. Couple of questions though, there is some bridge specific code in LibvirtComputingResource that checks existence of interfaces and such. Shouldn't that code also be modified to support multiple drivers per nic?

Re: Review Request: Add the ability to specify different VIF drivers per traffic type in KVM

2013-03-01 Thread Dave Cahill
On March 2, 2013, 1:10 a.m., edison su wrote: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java, line 802 https://reviews.apache.org/r/9604/diff/1/?file=262223#file262223line802 Wondering, what's the purpose of network.bridge.type used

Re: Review Request: Add the ability to specify different VIF drivers per traffic type in KVM

2013-02-28 Thread Dave Cahill
Hi, This patch was submitted 3 days ago, so sending a gentle reminder email as per ReviewBoard guidelines. :) [1] If there are any questions or issues, just let me know. Thanks, Dave. [1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines On Tue, Feb 26, 2013 at

Re: Review Request: Add the ability to specify different VIF drivers per traffic type in KVM

2013-02-28 Thread Dave Cahill
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9604/ --- (Updated March 1, 2013, 7:46 a.m.) Review request for cloudstack, Hugo

Review Request: Add the ability to specify different VIF drivers per traffic type in KVM

2013-02-26 Thread Dave Cahill
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9604/ --- Review request for cloudstack and Hugo Trippaers. Description --- Feature