Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM

2013-02-25 Thread deepti dohare
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7660/ --- (Updated Feb. 25, 2013, 8:55 a.m.) Review request for cloudstack and Min Chen.

Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM

2013-02-25 Thread Nitin Mehta
Code committed with 4d573ddd1bcd4ab27edfb91791a830308236521b From: Deepti Dohare deepti.doh...@citrix.commailto:deepti.doh...@citrix.com Reply-To: Deepti Dohare deepti.doh...@citrix.commailto:deepti.doh...@citrix.com To: Min Chen min.c...@citrix.commailto:min.c...@citrix.com Cc: Nitin Mehta

Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM

2013-02-24 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7660/#review17017 --- Ship it! Great work. Thanks for all the detailed information. -

Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM

2013-02-24 Thread Nitin Mehta
Your patch doesn't apply Nitins-MacBook-Air:incubator-cloudstack nitinmehta$ git apply --whitespace=fix ../0001-CS-357-ISO-cannot-be-detached-when-it-is-deleted-fro.patch error: patch failed: server/src/com/cloud/storage/download/DownloadMonitorImpl.java:78 error:

Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM

2013-02-21 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7660/#review16837 --- Thanks Deepti for the work. Really appreciate the hard work. Can you

Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM

2013-02-21 Thread deepti dohare
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7660/ --- (Updated Feb. 21, 2013, 10:01 a.m.) Review request for cloudstack and Min Chen.

Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM

2013-02-19 Thread deepti dohare
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7660/ --- (Updated Feb. 19, 2013, 5:21 p.m.) Review request for cloudstack and Min Chen.

Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM

2013-02-18 Thread deepti dohare
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7660/ --- (Updated Feb. 18, 2013, 1:59 p.m.) Review request for cloudstack and Min Chen.

Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM

2013-02-18 Thread deepti dohare
On Feb. 15, 2013, 8:10 a.m., Nitin Mehta wrote: This gives the ability to the user to affect other user vms as well, which is not desirable. I would suggest you to do the following. When you delete iso, mark it removed in DB so that its not available for further use. In the storage

Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM

2013-02-18 Thread Nitin Mehta
Deepti – Unfortunately, that’s not the right fix as I have already said below because as a user you shouldn't be allowed to detach iso from other user's vm. That would be a big security hole. I also said you should keep a note of the two things below. Your bug is all about #1 so fix that

Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM

2013-02-15 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7660/#review16634 --- This gives the ability to the user to affect other user vms as well,

Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM

2013-02-15 Thread Wei Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7660/#review16639 --- I just see this issue. I had some test about DetachISO at the beginn

Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM

2013-02-15 Thread Wei Zhou
On Feb. 15, 2013, 9:51 a.m., Wei Zhou wrote: I just see this issue. I had some test about DetachISO at the beginn of this year. I did not add a jira ticket because I think it is not the bug of CloudStack. I was using Ubuntu 12.04, and the qemu version is 1.0+noroms-0ubuntu14.3.

Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM

2013-02-15 Thread Wei Zhou
On Feb. 15, 2013, 9:51 a.m., Wei Zhou wrote: I just see this issue. I had some test about DetachISO at the beginn of this year. I did not add a jira ticket because I think it is not the bug of CloudStack. I was using Ubuntu 12.04, and the qemu version is 1.0+noroms-0ubuntu14.3.

Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM

2013-02-15 Thread deepti dohare
On Feb. 15, 2013, 8:10 a.m., Nitin Mehta wrote: This gives the ability to the user to affect other user vms as well, which is not desirable. I would suggest you to do the following. When you delete iso, mark it removed in DB so that its not available for further use. In the storage

Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM

2013-02-15 Thread Nitin Mehta
Great thanks Deepti. Two things to note #1 You might want to be careful about is that when mark the iso removed…the detach operation should still work on the vm. #2 Template sync might come up and delete this iso from sec. storage. You need to be careful for ISOs in that logic. -Nitin From:

Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM

2013-02-14 Thread deepti dohare
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7660/ --- (Updated Feb. 15, 2013, 5:02 a.m.) Review request for cloudstack. Changes

Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM

2013-02-14 Thread Sateesh Chodapuneedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7660/#review16627 ---

Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM

2013-02-13 Thread Min Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7660/#review16518 --- This patch looks good, but I cannot apply this to latest master,

Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM

2013-01-31 Thread deepti dohare
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7660/ --- (Updated Feb. 1, 2013, 7:37 a.m.) Review request for cloudstack. Changes

RE: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM

2012-10-22 Thread Deepti Dohare
A gentle reminder! - Thanks, Deepti From: deepti dohare [mailto:nore...@reviews.apache.org] On Behalf Of deepti dohare Sent: Friday, October 19, 2012 12:56 PM To: cloudstack; Deepti Dohare Subject: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM,

Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM

2012-10-19 Thread deepti dohare
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7660/ --- Review request for cloudstack. Description --- Currently no warning or